[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #125: Sling 10931

2022-01-14 Thread GitBox
sonarcloud[bot] removed a comment on pull request #125: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/125#issuecomment-1013634451 Kudos, SonarCloud Quality Gate passed! ![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #125: Sling 10931

2022-01-14 Thread GitBox
sonarcloud[bot] commented on pull request #125: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/125#issuecomment-1013636454 Kudos, SonarCloud Quality Gate passed! ![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #125: Sling 10931

2022-01-14 Thread GitBox
sonarcloud[bot] removed a comment on pull request #125: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/125#issuecomment-1013632118 Kudos, SonarCloud Quality Gate passed! ![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #125: Sling 10931

2022-01-14 Thread GitBox
sonarcloud[bot] commented on pull request #125: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/125#issuecomment-1013634451 Kudos, SonarCloud Quality Gate passed! ![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #125: Sling 10931

2022-01-14 Thread GitBox
sonarcloud[bot] removed a comment on pull request #125: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/125#issuecomment-1013630967 SonarCloud Quality Gate failed. ![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #125: Sling 10931

2022-01-14 Thread GitBox
sonarcloud[bot] commented on pull request #125: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/125#issuecomment-1013632118 Kudos, SonarCloud Quality Gate passed! ![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #125: Sling 10931

2022-01-14 Thread GitBox
sonarcloud[bot] removed a comment on pull request #125: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/125#issuecomment-101362 SonarCloud Quality Gate failed. ![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #125: Sling 10931

2022-01-14 Thread GitBox
sonarcloud[bot] commented on pull request #125: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/125#issuecomment-1013630967 SonarCloud Quality Gate failed. ![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #125: Sling 10931

2022-01-14 Thread GitBox
sonarcloud[bot] commented on pull request #125: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/125#issuecomment-101362 SonarCloud Quality Gate failed. ![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #125: Sling 10931

2022-01-14 Thread GitBox
sonarcloud[bot] removed a comment on pull request #125: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/125#issuecomment-1013628727 SonarCloud Quality Gate failed. ![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #125: Sling 10931

2022-01-14 Thread GitBox
sonarcloud[bot] commented on pull request #125: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/125#issuecomment-1013628727 SonarCloud Quality Gate failed. ![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #125: Sling 10931

2022-01-14 Thread GitBox
sonarcloud[bot] removed a comment on pull request #125: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/125#issuecomment-1013623900 Kudos, SonarCloud Quality Gate passed! ![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #125: Sling 10931

2022-01-14 Thread GitBox
sonarcloud[bot] removed a comment on pull request #125: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/125#issuecomment-1013622312 Kudos, SonarCloud Quality Gate passed! ![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #125: Sling 10931

2022-01-14 Thread GitBox
sonarcloud[bot] commented on pull request #125: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/125#issuecomment-1013623900 Kudos, SonarCloud Quality Gate passed! ![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #125: Sling 10931

2022-01-14 Thread GitBox
sonarcloud[bot] commented on pull request #125: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/125#issuecomment-1013622312 Kudos, SonarCloud Quality Gate passed! ![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #125: Sling 10931

2022-01-14 Thread GitBox
sonarcloud[bot] removed a comment on pull request #125: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/125#issuecomment-1013621673 Kudos, SonarCloud Quality Gate passed! ![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #125: Sling 10931

2022-01-14 Thread GitBox
sonarcloud[bot] removed a comment on pull request #125: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/125#issuecomment-1013620224 Kudos, SonarCloud Quality Gate passed! ![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #125: Sling 10931

2022-01-14 Thread GitBox
sonarcloud[bot] commented on pull request #125: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/125#issuecomment-1013621673 Kudos, SonarCloud Quality Gate passed! ![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #125: Sling 10931

2022-01-14 Thread GitBox
sonarcloud[bot] commented on pull request #125: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/125#issuecomment-1013620224 Kudos, SonarCloud Quality Gate passed! ![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #125: Sling 10931

2022-01-14 Thread GitBox
sonarcloud[bot] removed a comment on pull request #125: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/125#issuecomment-1013611730 Kudos, SonarCloud Quality Gate passed! ![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #125: Sling 10931

2022-01-14 Thread GitBox
sonarcloud[bot] removed a comment on pull request #125: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/125#issuecomment-1013611484 Kudos, SonarCloud Quality Gate passed! ![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #125: Sling 10931

2022-01-14 Thread GitBox
sonarcloud[bot] commented on pull request #125: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/125#issuecomment-1013611730 Kudos, SonarCloud Quality Gate passed! ![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #125: Sling 10931

2022-01-14 Thread GitBox
sonarcloud[bot] commented on pull request #125: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/125#issuecomment-1013611484 Kudos, SonarCloud Quality Gate passed! ![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #125: Sling 10931

2022-01-14 Thread GitBox
sonarcloud[bot] removed a comment on pull request #125: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/125#issuecomment-1013608936 Kudos, SonarCloud Quality Gate passed! ![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #125: Sling 10931

2022-01-14 Thread GitBox
sonarcloud[bot] removed a comment on pull request #125: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/125#issuecomment-1013209890 Kudos, SonarCloud Quality Gate passed! ![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #125: Sling 10931

2022-01-14 Thread GitBox
sonarcloud[bot] commented on pull request #125: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/125#issuecomment-1013608936 Kudos, SonarCloud Quality Gate passed! ![Quality Gate

[GitHub] [sling-org-apache-sling-jcr-resource] kwin commented on a change in pull request #19: SLING-11061 URIProvider for resources backed by JCR BinaryDownload

2022-01-14 Thread GitBox
kwin commented on a change in pull request #19: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/19#discussion_r785062268 ## File path: src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/BinaryDownloadUriProvider.java ## @@ -0,0 +1,141 @@

[GitHub] [sling-org-apache-sling-jcr-resource] kwin commented on a change in pull request #19: SLING-11061 URIProvider for resources backed by JCR BinaryDownload

2022-01-14 Thread GitBox
kwin commented on a change in pull request #19: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/19#discussion_r785061389 ## File path: src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrNodeResource.java ## @@ -181,34 +185,15 @@

[GitHub] [sling-org-apache-sling-jcr-resource] ieb commented on a change in pull request #19: SLING-11061 URIProvider for resources backed by JCR BinaryDownload

2022-01-14 Thread GitBox
ieb commented on a change in pull request #19: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/19#discussion_r785050340 ## File path: src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrNodeResource.java ## @@ -227,6 +212,31 @@ private

[GitHub] [sling-org-apache-sling-jcr-resource] ieb commented on a change in pull request #19: SLING-11061 URIProvider for resources backed by JCR BinaryDownload

2022-01-14 Thread GitBox
ieb commented on a change in pull request #19: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/19#discussion_r785049773 ## File path: src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrNodeResource.java ## @@ -181,34 +185,15 @@ private

[GitHub] [sling-org-apache-sling-feature-cpconverter] anchela commented on a change in pull request #125: Sling 10931

2022-01-14 Thread GitBox
anchela commented on a change in pull request #125: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/125#discussion_r785043228 ## File path: src/test/resources/org/apache/sling/feature/cpconverter/handlers/i18n-jsonfile-xml-descriptor-test/en.json

[GitHub] [sling-org-apache-sling-jcr-resource] ieb commented on a change in pull request #19: SLING-11061 URIProvider for resources backed by JCR BinaryDownload

2022-01-14 Thread GitBox
ieb commented on a change in pull request #19: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/19#discussion_r785042879 ## File path: src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/BinaryDownloadUriProvider.java ## @@ -0,0 +1,141 @@

[GitHub] [sling-org-apache-sling-jcr-resource] kwin commented on a change in pull request #19: SLING-11061 URIProvider for resources backed by JCR BinaryDownload

2022-01-14 Thread GitBox
kwin commented on a change in pull request #19: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/19#discussion_r785023193 ## File path: src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/BinaryDownloadUriProvider.java ## @@ -0,0 +1,142 @@

[GitHub] [sling-org-apache-sling-jcr-resource] kwin commented on a change in pull request #19: SLING-11061 URIProvider for resources backed by JCR BinaryDownload

2022-01-14 Thread GitBox
kwin commented on a change in pull request #19: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/19#discussion_r785023193 ## File path: src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/BinaryDownloadUriProvider.java ## @@ -0,0 +1,142 @@

[GitHub] [sling-org-apache-sling-jcr-resource] kwin commented on a change in pull request #19: SLING-11061 URIProvider for resources backed by JCR BinaryDownload

2022-01-14 Thread GitBox
kwin commented on a change in pull request #19: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/19#discussion_r785018707 ## File path: src/test/java/org/apache/sling/jcr/resource/internal/JcrResourceListenerTest.java ## @@ -269,7 +269,7 @@ public

[GitHub] [sling-org-apache-sling-jcr-resource] kwin commented on a change in pull request #19: SLING-11061 URIProvider for resources backed by JCR BinaryDownload

2022-01-14 Thread GitBox
kwin commented on a change in pull request #19: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/19#discussion_r785018707 ## File path: src/test/java/org/apache/sling/jcr/resource/internal/JcrResourceListenerTest.java ## @@ -269,7 +269,7 @@ public

[GitHub] [sling-org-apache-sling-jcr-resource] cziegeler commented on a change in pull request #19: SLING-11061 URIProvider for resources backed by JCR BinaryDownload

2022-01-14 Thread GitBox
cziegeler commented on a change in pull request #19: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/19#discussion_r785003391 ## File path: src/test/java/org/apache/sling/jcr/resource/internal/JcrResourceListenerTest.java ## @@ -269,7 +269,7 @@ public

Pushing Sling Starter snapshot Docker images to DockerHub

2022-01-14 Thread Robert Munteanu
Hi, During my work on the Docker Images for the Starter I found out that building only for tags makes it very hard to test out Docker builds. I have forked the repository and built it using my Docker Hub account, but that unfortunately requires a paid Docker account, and I think we should not

[GitHub] [sling-org-apache-sling-jcr-resource] sonarcloud[bot] commented on pull request #19: SLING-11061 URIProvider for resources backed by JCR BinaryDownload

2022-01-14 Thread GitBox
sonarcloud[bot] commented on pull request #19: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/19#issuecomment-1013282700 SonarCloud Quality Gate failed. ![Quality Gate

[GitHub] [sling-org-apache-sling-starter] rombert merged pull request #45: Update to o.a.s.xss 2.2.18

2022-01-14 Thread GitBox
rombert merged pull request #45: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [sling-org-apache-sling-starter] sonarcloud[bot] commented on pull request #45: Update to o.a.s.xss 2.2.18

2022-01-14 Thread GitBox
sonarcloud[bot] commented on pull request #45: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/45#issuecomment-1013280292 Kudos, SonarCloud Quality Gate passed! ![Quality Gate

[jira] [Resolved] (SLING-11065) Update to Bnd 6.1

2022-01-14 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-11065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-11065. - Resolution: Fixed Fixed in

[jira] [Created] (SLING-11065) Update to Bnd 6.1

2022-01-14 Thread Konrad Windszus (Jira)
Konrad Windszus created SLING-11065: --- Summary: Update to Bnd 6.1 Key: SLING-11065 URL: https://issues.apache.org/jira/browse/SLING-11065 Project: Sling Issue Type: Improvement Affects

[jira] [Resolved] (SLING-11064) Update Maven plugins

2022-01-14 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-11064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-11064. - Resolution: Fixed Fixed in

[GitHub] [sling-org-apache-sling-jcr-resource] rombert commented on pull request #19: SLING-11061 URIProvider for resources backed by JCR BinaryDownload

2022-01-14 Thread GitBox
rombert commented on pull request #19: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/19#issuecomment-1013269019 @kwin - looks like a problem with Java 8. The PR works for me with Java 11, but fails with ``` Apache Maven 3.8.1 (SUSE 3.8.1-3.3) Maven

[jira] [Created] (SLING-11064) Update Maven plugins

2022-01-14 Thread Konrad Windszus (Jira)
Konrad Windszus created SLING-11064: --- Summary: Update Maven plugins Key: SLING-11064 URL: https://issues.apache.org/jira/browse/SLING-11064 Project: Sling Issue Type: Improvement

[jira] [Commented] (SLING-10289) Sling Dynamic Include 3.2.0 configuration of arrays broken

2022-01-14 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-10289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17476248#comment-17476248 ] Robert Munteanu commented on SLING-10289: - [~banerjee-ronit] - the 3.3.0 release is out and

[jira] [Closed] (SLING-10096) Allow the SlingHttpServletRequest in the IncludeGenerator or Sling dynamic includes

2022-01-14 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-10096. --- > Allow the SlingHttpServletRequest in the IncludeGenerator or Sling dynamic > includes >

[jira] [Closed] (SLING-10289) Sling Dynamic Include 3.2.0 configuration of arrays broken

2022-01-14 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-10289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-10289. --- > Sling Dynamic Include 3.2.0 configuration of arrays broken >

[RESULT] [VOTE] Release Apache Sling Dynamic Include 3.3.0

2022-01-14 Thread Robert Munteanu
Hi, The vote has passed with the following result: +1 (binding): Nicolas Peltier, Carsten Ziegeler, Radu Cotescu +1 (non-binding): none I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Regards, Robert Munteanu

[GitHub] [sling-org-apache-sling-jcr-resource] kwin commented on a change in pull request #19: SLING-11061 URIProvider for resources backed by JCR BinaryDownload

2022-01-14 Thread GitBox
kwin commented on a change in pull request #19: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/19#discussion_r784966830 ## File path: src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/BinaryDownloadUriProvider.java ## @@ -0,0 +1,142 @@

[jira] [Closed] (SLING-10953) Update dependency Antisamy version from 1.5.10 to 1.6.4

2022-01-14 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-10953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-10953. --- > Update dependency Antisamy version from 1.5.10 to 1.6.4 >

[GitHub] [sling-org-apache-sling-jcr-resource] kwin commented on pull request #19: SLING-11061 URIProvider for resources backed by JCR BinaryDownload

2022-01-14 Thread GitBox
kwin commented on pull request #19: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/19#issuecomment-1013250788 @rombert Any idea why this build fails on Jenkins? To me it looks like not all dependencies are downloaded... -- This is an automated message from the

[RESULT] [VOTE] Release Apache Sling XSS Protection API 2.2.18

2022-01-14 Thread Robert Munteanu
Hi, The vote has passed with the following result: +1 (binding): Nicolas Peltier, Karl Pauls, Carsten Ziegeler, Radu Cotescu +1 (non-binding): none I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Regards, Robert Munteanu

[jira] [Updated] (SLING-11063) JcrResourceListenerTest.testMultiplePaths fails after updating to Oak 1.10.0

2022-01-14 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-11063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-11063: Description: For me the test at {{JcrResourceListenerTest.testMultiplePaths()}} fails

[jira] [Created] (SLING-11063) JcrResourceListenerTest.testMultiplePaths fails on Mac OS

2022-01-14 Thread Konrad Windszus (Jira)
Konrad Windszus created SLING-11063: --- Summary: JcrResourceListenerTest.testMultiplePaths fails on Mac OS Key: SLING-11063 URL: https://issues.apache.org/jira/browse/SLING-11063 Project: Sling

[jira] [Updated] (SLING-11063) JcrResourceListenerTest.testMultiplePaths fails after updating to Oak 1.10.0

2022-01-14 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-11063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-11063: Description: For me the test at {{JcrResourceListenerTest.testMultiplePaths()}} fails

[jira] [Updated] (SLING-11063) JcrResourceListenerTest.testMultiplePaths fails after updating to Oak 1.10.0

2022-01-14 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-11063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-11063: Summary: JcrResourceListenerTest.testMultiplePaths fails after updating to Oak 1.10.0

[GitHub] [sling-org-apache-sling-jcr-resource] kwin commented on a change in pull request #19: SLING-11061 URIProvider for resources backed by JCR BinaryDownload

2022-01-14 Thread GitBox
kwin commented on a change in pull request #19: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/19#discussion_r784934453 ## File path: src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrNodeResource.java ## @@ -181,34 +185,15 @@

[GitHub] [sling-org-apache-sling-jcr-resource] kwin commented on a change in pull request #19: SLING-11061 URIProvider for resources backed by JCR BinaryDownload

2022-01-14 Thread GitBox
kwin commented on a change in pull request #19: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/19#discussion_r784933480 ## File path: src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrNodeResource.java ## @@ -227,6 +212,31 @@ private

[GitHub] [sling-org-apache-sling-jcr-resource] kwin commented on a change in pull request #19: SLING-11061 URIProvider for resources backed by JCR BinaryDownload

2022-01-14 Thread GitBox
kwin commented on a change in pull request #19: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/19#discussion_r784933096 ## File path: src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/BinaryDownloadUriProvider.java ## @@ -0,0 +1,142 @@

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #125: Sling 10931

2022-01-14 Thread GitBox
sonarcloud[bot] commented on pull request #125: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/125#issuecomment-1013209890 Kudos, SonarCloud Quality Gate passed! ![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #125: Sling 10931

2022-01-14 Thread GitBox
sonarcloud[bot] removed a comment on pull request #125: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/125#issuecomment-1013197266 Kudos, SonarCloud Quality Gate passed! ![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #125: Sling 10931

2022-01-14 Thread GitBox
sonarcloud[bot] commented on pull request #125: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/125#issuecomment-1013197266 Kudos, SonarCloud Quality Gate passed! ![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #125: Sling 10931

2022-01-14 Thread GitBox
sonarcloud[bot] removed a comment on pull request #125: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/125#issuecomment-1013184779 Kudos, SonarCloud Quality Gate passed! ![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #125: Sling 10931

2022-01-14 Thread GitBox
sonarcloud[bot] removed a comment on pull request #125: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/125#issuecomment-1013176685 SonarCloud Quality Gate failed. ![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #125: Sling 10931

2022-01-14 Thread GitBox
sonarcloud[bot] commented on pull request #125: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/125#issuecomment-1013184779 Kudos, SonarCloud Quality Gate passed! ![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #125: Sling 10931

2022-01-14 Thread GitBox
sonarcloud[bot] removed a comment on pull request #125: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/125#issuecomment-1013153966 SonarCloud Quality Gate failed. ![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #125: Sling 10931

2022-01-14 Thread GitBox
sonarcloud[bot] commented on pull request #125: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/125#issuecomment-1013176685 SonarCloud Quality Gate failed. ![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #125: Sling 10931

2022-01-14 Thread GitBox
sonarcloud[bot] removed a comment on pull request #125: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/125#issuecomment-1011946095 SonarCloud Quality Gate failed. ![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #125: Sling 10931

2022-01-14 Thread GitBox
sonarcloud[bot] commented on pull request #125: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/125#issuecomment-1013153966 SonarCloud Quality Gate failed. ![Quality Gate

[GitHub] [sling-org-apache-sling-jcr-resource] ieb commented on a change in pull request #19: SLING-11061 URIProvider for resources backed by JCR BinaryDownload

2022-01-14 Thread GitBox
ieb commented on a change in pull request #19: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/19#discussion_r784854708 ## File path: src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/BinaryDownloadUriProvider.java ## @@ -0,0 +1,142 @@

Re: [VOTE] Release Apache Sling Resource Resolver 1.8.2

2022-01-14 Thread Carsten Ziegeler
+1 Carsten Am 14.01.2022 um 10:58 schrieb Jörg Hoh: Hi, We solved 2 issues in this release:https://issues.apache.org/jira/projects/SLING/versions/12350919 Staging repository:https://repository.apache.org/content/repositories/orgapachesling-2584/ You can use this UNIX script to download the

Re: [VOTE] Release Apache Sling Resource Resolver 1.8.2

2022-01-14 Thread Radu Cotescu
+1 > On 14 Jan 2022, at 10:58, Jörg Hoh wrote: > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours.

Re: [VOTE] Release Apache Sling Security 1.1.22

2022-01-14 Thread Radu Cotescu
+1 > On 12 Jan 2022, at 16:02, Carsten Ziegeler wrote: > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours.

Re: [VOTE] Release Apache Sling Commons Log 5.4.0

2022-01-14 Thread Radu Cotescu
+1 > On 11 Jan 2022, at 16:36, Carsten Ziegeler wrote: > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours.

Re: [VOTE] Release Apache Sling Dynamic Include 3.3.0

2022-01-14 Thread Radu Cotescu
+1 > On 11 Jan 2022, at 14:44, Robert Munteanu wrote: > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours.

Re: [VOTE] Release Apache Sling XSS Protection API 2.2.18

2022-01-14 Thread Radu Cotescu
+1 > On 11 Jan 2022, at 14:07, Robert Munteanu wrote: > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ...

[GitHub] [sling-org-apache-sling-jcr-resource] kwin opened a new pull request #19: SLING-11061 URIProvider for resources backed by JCR BinaryDownload

2022-01-14 Thread GitBox
kwin opened a new pull request #19: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/19 properties -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Created] (SLING-11062) javadoc errors when releasing the bundle

2022-01-14 Thread Joerg Hoh (Jira)
Joerg Hoh created SLING-11062: - Summary: javadoc errors when releasing the bundle Key: SLING-11062 URL: https://issues.apache.org/jira/browse/SLING-11062 Project: Sling Issue Type: Bug

[VOTE] Release Apache Sling Resource Resolver 1.8.2

2022-01-14 Thread Jörg Hoh
Hi, We solved 2 issues in this release:https://issues.apache.org/jira/projects/SLING/versions/12350919 Staging repository:https://repository.apache.org/content/repositories/orgapachesling-2584/ You can use this UNIX script to download the release and verify the

Extension of URIProvider to use Optional

2022-01-14 Thread Konrad Windszus
Hi, currently URIProvider is not allowed to return null according to https://github.com/apache/sling-org-apache-sling-api/blob/333fa20f07a1d42897c9e0b6253bec5dcedb3e0b/src/main/java/org/apache/sling/api/resource/external/URIProvider.java#L48. This forces every URIProvider to throw an exception

[jira] [Updated] (SLING-11061) Create URIProvider for Jackrabbit API BinaryDownload

2022-01-14 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-11061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-11061: Description: There should be one implementation shipped for the URIProvider API added

[jira] [Updated] (SLING-11061) Create URIProvider for Jackrabbit API BinaryDownload

2022-01-14 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-11061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-11061: Description: There should be one implementation shipped for the URIProvider API added

[jira] [Created] (SLING-11061) Create URIProvider for Jackrabbit API BinaryDownload

2022-01-14 Thread Konrad Windszus (Jira)
Konrad Windszus created SLING-11061: --- Summary: Create URIProvider for Jackrabbit API BinaryDownload Key: SLING-11061 URL: https://issues.apache.org/jira/browse/SLING-11061 Project: Sling