Thanks for the feedback!
If others already use "good-first-fix" let's do it the same way and replace
"easyfix" and "newbie" with it. I will update the website accordingly and
also update the existing tickets.
have a nice weekend,
Jörg
Am Fr., 21. Jan. 2022 um 17:24 Uhr schrieb Robert Munteanu <
+1 i remember bugging Carsten asking what issue i could look at, so i
confirm this is a service that would be useful
Le ven. 21 janv. 2022 à 17:24, Robert Munteanu a
écrit :
> On Thu, 2022-01-20 at 12:05 +0100, Bertrand Delacretaz wrote:
> > On Thu, Jan 20, 2022 at 10:11 AM Dirk Rudolph
> >
sonarcloud[bot] commented on pull request #56:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/56#issuecomment-1018691105
SonarCloud Quality Gate failed. ![Quality Gate
sonarcloud[bot] removed a comment on pull request #56:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/56#issuecomment-1018682831
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
sonarcloud[bot] removed a comment on pull request #56:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/56#issuecomment-1018672747
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
sonarcloud[bot] commented on pull request #56:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/56#issuecomment-1018682831
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
sonarcloud[bot] commented on pull request #56:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/56#issuecomment-1018672747
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
sonarcloud[bot] removed a comment on pull request #56:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/56#issuecomment-1018666704
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
sonarcloud[bot] removed a comment on pull request #56:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/56#issuecomment-1018658795
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
sonarcloud[bot] commented on pull request #56:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/56#issuecomment-1018666704
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
On Thu, 2022-01-20 at 12:05 +0100, Bertrand Delacretaz wrote:
> On Thu, Jan 20, 2022 at 10:11 AM Dirk Rudolph
> wrote:
> > ...Regarding the naming, we may want to adapt the naming
> > Github uses for that: "good-first-issue"..
>
> +1
>
+1. Once we start using that it would be good to a) align
sonarcloud[bot] removed a comment on pull request #56:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/56#issuecomment-1018650042
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
sonarcloud[bot] commented on pull request #56:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/56#issuecomment-1018658795
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
sonarcloud[bot] commented on pull request #56:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/56#issuecomment-1018650042
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
sonarcloud[bot] removed a comment on pull request #56:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/56#issuecomment-1018639642
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
sonarcloud[bot] commented on pull request #56:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/56#issuecomment-1018639642
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
sonarcloud[bot] removed a comment on pull request #56:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/56#issuecomment-1018630776
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
sonarcloud[bot] commented on pull request #56:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/56#issuecomment-1018630776
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
reschke removed a comment on pull request #55:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/55#issuecomment-1018318165
So Sonarcloud complains about missing test coverage; but then, the code
where I added the logging doesn't seem to have test coverage at
klcodanr merged pull request #16:
URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
anchela commented on pull request #16:
URL:
https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/16#issuecomment-1018502274
@klcodanr , lgtm. thanks a lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
klcodanr commented on pull request #16:
URL:
https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/16#issuecomment-1018500235
Thanks @anchela! I agree and thanks for spotting. I believe I've addressed
all of the points you raised.
--
This is an automated message from
sonarcloud[bot] removed a comment on pull request #16:
URL:
https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/16#issuecomment-1017878764
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
sonarcloud[bot] commented on pull request #16:
URL:
https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/16#issuecomment-1018499261
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
Please see
https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-launchpad-testing/job/master/872/
for details.
No further emails will be sent until the status of the build is changed.
[
https://issues.apache.org/jira/browse/SLING-11081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved SLING-11081.
--
Resolution: Fixed
Fixed in
Carsten Ziegeler created SLING-11081:
Summary: Feature is not marked changed if config is removed
Key: SLING-11081
URL: https://issues.apache.org/jira/browse/SLING-11081
Project: Sling
reschke commented on pull request #55:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/55#issuecomment-1018318165
So Sonarcloud complains about missing test coverage; but then, the code
where I added the logging doesn't seem to have test coverage at all...
--
anchela commented on a change in pull request #16:
URL:
https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/16#discussion_r789437145
##
File path:
src/test/java/org/apache/sling/repoinit/parser/operations/AsRepoInitTest.java
##
@@ -59,6 +62,21 @@ private
29 matches
Mail list logo
