[GitHub] [sling-org-apache-sling-hc-support] sonarcloud[bot] commented on pull request #1: SLING-11141 update to o.a.felix.healthcheck.generalchecks 3.x

2022-06-21 Thread GitBox
sonarcloud[bot] commented on PR #1: URL: https://github.com/apache/sling-org-apache-sling-hc-support/pull/1#issuecomment-1162482275 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-hc-support] sonarcloud[bot] commented on pull request #1: SLING-11141 update to o.a.felix.healthcheck.generalchecks 3.x

2022-06-21 Thread GitBox
sonarcloud[bot] commented on PR #1: URL: https://github.com/apache/sling-org-apache-sling-hc-support/pull/1#issuecomment-1162477645 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-hc-support] sonarcloud[bot] commented on pull request #1: SLING-11141 update to o.a.felix.healthcheck.generalchecks 3.x

2022-06-21 Thread GitBox
sonarcloud[bot] commented on PR #1: URL: https://github.com/apache/sling-org-apache-sling-hc-support/pull/1#issuecomment-1162456221 SonarCloud Quality Gate failed. [![Quality Gate

[GitHub] [sling-org-apache-sling-hc-support] sonarcloud[bot] commented on pull request #1: SLING-11141 update to o.a.felix.healthcheck.generalchecks 3.x

2022-06-21 Thread GitBox
sonarcloud[bot] commented on PR #1: URL: https://github.com/apache/sling-org-apache-sling-hc-support/pull/1#issuecomment-1162452915 SonarCloud Quality Gate failed. [![Quality Gate

[jira] [Commented] (SLING-11398) handle serviceloader ScriptEngineFactory defined in a fragment bundle

2022-06-21 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17557148#comment-17557148 ] Oliver Lietz commented on SLING-11398: -- No, not at all. Go on. > handle serviceloader

[jira] [Commented] (SLING-11141) Make compatible with org.apache.felix.healthcheck.generalchecks version 3.x

2022-06-21 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-11141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17557146#comment-17557146 ] Eric Norman commented on SLING-11141: - [~olli]  {quote}There is a bug in 

[GitHub] [sling-org-apache-sling-scripting-core] sonarcloud[bot] commented on pull request #18: SLING-11398 handle ScriptEngineFactory defined in a fragment

2022-06-21 Thread GitBox
sonarcloud[bot] commented on PR #18: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/18#issuecomment-1162408226 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[jira] [Commented] (SLING-11398) handle serviceloader ScriptEngineFactory defined in a fragment bundle

2022-06-21 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17557143#comment-17557143 ] Eric Norman commented on SLING-11398: - [~olli] Updated the comment at:

[jira] [Commented] (SLING-11141) Make compatible with org.apache.felix.healthcheck.generalchecks version 3.x

2022-06-21 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-11141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17557134#comment-17557134 ] Oliver Lietz commented on SLING-11141: -- [~enorman], There is a bug in {{ScriptedHealthCheck}},

[jira] [Commented] (SLING-11398) handle serviceloader ScriptEngineFactory defined in a fragment bundle

2022-06-21 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17557124#comment-17557124 ] Oliver Lietz commented on SLING-11398: -- {quote}What is unclear about the comments in that test

[jira] [Comment Edited] (SLING-11398) handle serviceloader ScriptEngineFactory defined in a fragment bundle

2022-06-21 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17557109#comment-17557109 ] Eric Norman edited comment on SLING-11398 at 6/21/22 8:46 PM: -- [~olli] 

[jira] [Comment Edited] (SLING-11398) handle serviceloader ScriptEngineFactory defined in a fragment bundle

2022-06-21 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17557109#comment-17557109 ] Eric Norman edited comment on SLING-11398 at 6/21/22 8:37 PM: -- [~olli] 

[jira] [Commented] (SLING-11398) handle serviceloader ScriptEngineFactory defined in a fragment bundle

2022-06-21 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17557109#comment-17557109 ] Eric Norman commented on SLING-11398: - [~olli]  {quote}You mentioned above HCs as your primary

[jira] [Commented] (SLING-11398) handle serviceloader ScriptEngineFactory defined in a fragment bundle

2022-06-21 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17557103#comment-17557103 ] Eric Norman commented on SLING-11398: - [~olli]  {quote}Sure, but it's not obvious to everyone that

[jira] [Commented] (SLING-11398) handle serviceloader ScriptEngineFactory defined in a fragment bundle

2022-06-21 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17557102#comment-17557102 ] Oliver Lietz commented on SLING-11398: -- [~enorman], You mentioned above HCs as your primary

[jira] [Comment Edited] (SLING-11398) handle serviceloader ScriptEngineFactory defined in a fragment bundle

2022-06-21 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17557092#comment-17557092 ] Eric Norman edited comment on SLING-11398 at 6/21/22 8:18 PM: -- [~olli] 

[jira] [Commented] (SLING-11398) handle serviceloader ScriptEngineFactory defined in a fragment bundle

2022-06-21 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17557099#comment-17557099 ] Oliver Lietz commented on SLING-11398: -- {quote}Well, the test is specifically for testing a factory

[jira] [Comment Edited] (SLING-11398) handle serviceloader ScriptEngineFactory defined in a fragment bundle

2022-06-21 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17557089#comment-17557089 ] Eric Norman edited comment on SLING-11398 at 6/21/22 8:15 PM: -- [~olli] 

[jira] [Comment Edited] (SLING-11398) handle serviceloader ScriptEngineFactory defined in a fragment bundle

2022-06-21 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17557089#comment-17557089 ] Eric Norman edited comment on SLING-11398 at 6/21/22 8:12 PM: -- [~olli] 

[jira] [Commented] (SLING-11398) handle serviceloader ScriptEngineFactory defined in a fragment bundle

2022-06-21 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17557092#comment-17557092 ] Eric Norman commented on SLING-11398: - [~olli]  {quote}The IT breaks when using Groovy 3.0.1. So you

Re: [VOTE] Release Apache Sling Whiteboard JMX Exporter 0.2.0

2022-06-21 Thread Jörg Hoh
Hi Robert, Robert Munteanu schrieb am Di. 21. Juni 2022 um 12:53: > Hi Joerg, > > On Mon, 2022-06-20 at 13:47 +0200, Jörg Hoh wrote: > > I want to release a first 0.2.0 version of the JMX Exporter which I > > am > > currently working on in the Sling Whiteboard. The scope of this > > bundle > >

[jira] [Commented] (SLING-11398) handle serviceloader ScriptEngineFactory defined in a fragment bundle

2022-06-21 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17557089#comment-17557089 ] Eric Norman commented on SLING-11398: - [~olli]  {quote}bq. Felix HC comes with its own 

[jira] [Commented] (SLING-11398) handle serviceloader ScriptEngineFactory defined in a fragment bundle

2022-06-21 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17557088#comment-17557088 ] Oliver Lietz commented on SLING-11398: -- [~enorman], The IT breaks when using Groovy 3.0.1. So you

[jira] [Commented] (SLING-11398) handle serviceloader ScriptEngineFactory defined in a fragment bundle

2022-06-21 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17557083#comment-17557083 ] Oliver Lietz commented on SLING-11398: -- [~enorman], Felix HC comes with its own

[GitHub] [sling-org-apache-sling-hc-support] sonarcloud[bot] commented on pull request #1: SLING-11141 update to o.a.felix.healthcheck.generalchecks 3.x

2022-06-21 Thread GitBox
sonarcloud[bot] commented on PR #1: URL: https://github.com/apache/sling-org-apache-sling-hc-support/pull/1#issuecomment-1162227652 SonarCloud Quality Gate failed. [![Quality Gate

[GitHub] [sling-org-apache-sling-jcr-repoinit] sonarcloud[bot] commented on pull request #27: SLING-10740 implemention for create path with properties

2022-06-21 Thread GitBox
sonarcloud[bot] commented on PR #27: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/27#issuecomment-1162215916 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-repoinit-parser] sonarcloud[bot] commented on pull request #23: SLING-11402 Update to Sling Bundle Parent 48

2022-06-21 Thread GitBox
sonarcloud[bot] commented on PR #23: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/23#issuecomment-1162190096 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[jira] [Commented] (SLING-11402) Update to Sling Bundle Parent 48

2022-06-21 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-11402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17557060#comment-17557060 ] Eric Norman commented on SLING-11402: - Created PR #23 for review and feedback > Update to Sling

[GitHub] [sling-org-apache-sling-repoinit-parser] enapps-enorman opened a new pull request, #23: SLING-11402 Update to Sling Bundle Parent 48

2022-06-21 Thread GitBox
enapps-enorman opened a new pull request, #23: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/23 Update to the latest parent pom NOTE: The latest bnd revealed the following problem during the build due to (not exported) private classes being referenced

[GitHub] [sling-org-apache-sling-repoinit-parser] enapps-enorman merged pull request #22: SLING-10740 Bump the org.apache.sling.repoinit.language version number

2022-06-21 Thread GitBox
enapps-enorman merged PR #22: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/22 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [sling-org-apache-sling-repoinit-parser] enapps-enorman opened a new pull request, #22: SLING-10740 Bump the org.apache.sling.repoinit.language version number

2022-06-21 Thread GitBox
enapps-enorman opened a new pull request, #22: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/22 Changes to the parser should declare a new version of the language to avoid out-of-sync version of the jcr.repoinit bundle -- This is an automated message from the

[jira] [Created] (SLING-11402) Update to Sling Bundle Parent 48

2022-06-21 Thread Eric Norman (Jira)
Eric Norman created SLING-11402: --- Summary: Update to Sling Bundle Parent 48 Key: SLING-11402 URL: https://issues.apache.org/jira/browse/SLING-11402 Project: Sling Issue Type: Improvement

[GitHub] [sling-org-apache-sling-scripting-core] sonarcloud[bot] commented on pull request #18: SLING-11398 handle ScriptEngineFactory defined in a fragment

2022-06-21 Thread GitBox
sonarcloud[bot] commented on PR #18: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/18#issuecomment-1161980990 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[jira] [Commented] (SLING-10740) Repoinit create path statement fails for node types with a mandatory property

2022-06-21 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-10740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17556998#comment-17556998 ] Eric Norman commented on SLING-10740: - Merged PR #19 at:  

[GitHub] [sling-org-apache-sling-repoinit-parser] sonarcloud[bot] commented on pull request #19: SLING-10740 update create path grammar

2022-06-21 Thread GitBox
sonarcloud[bot] commented on PR #19: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/19#issuecomment-1161976573 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-repoinit-parser] enapps-enorman merged pull request #19: SLING-10740 update create path grammar

2022-06-21 Thread GitBox
enapps-enorman merged PR #19: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/19 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [sling-org-apache-sling-scripting-core] dependabot[bot] merged pull request #16: Bump jsoup from 1.11.3 to 1.14.2

2022-06-21 Thread GitBox
dependabot[bot] merged PR #16: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/16 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [sling-org-apache-sling-scripting-core] enapps-enorman commented on pull request #16: Bump jsoup from 1.11.3 to 1.14.2

2022-06-21 Thread GitBox
enapps-enorman commented on PR #16: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/16#issuecomment-1161963444 @dependabot squash and merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [sling-org-apache-sling-repoinit-parser] sonarcloud[bot] commented on pull request #19: SLING-10740 update create path grammar

2022-06-21 Thread GitBox
sonarcloud[bot] commented on PR #19: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/19#issuecomment-1161961465 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-scripting-core] sonarcloud[bot] commented on pull request #18: SLING-11398 handle ScriptEngineFactory defined in a fragment

2022-06-21 Thread GitBox
sonarcloud[bot] commented on PR #18: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/18#issuecomment-1161955872 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-scripting-core] sonarcloud[bot] commented on pull request #16: Bump jsoup from 1.11.3 to 1.14.2

2022-06-21 Thread GitBox
sonarcloud[bot] commented on PR #16: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/16#issuecomment-1161947343 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

Re: [VOTE] Release Apache Sling Whiteboard JMX Exporter 0.2.0

2022-06-21 Thread Robert Munteanu
Hi Joerg, On Mon, 2022-06-20 at 13:47 +0200, Jörg Hoh wrote: > I want to release a first 0.2.0 version of the JMX Exporter which I > am > currently working on in the Sling Whiteboard. The scope of this > bundle > is quite tight, but I want to give a first shot. I can't find the Sling repository

[GitHub] [sling-tooling-jenkins] kwin commented on a diff in pull request #10: SLING-11401 properly isolate workspace directories

2022-06-21 Thread GitBox
kwin commented on code in PR #10: URL: https://github.com/apache/sling-tooling-jenkins/pull/10#discussion_r902306152 ## vars/slingOsgiBundleBuild.groovy: ## @@ -178,24 +178,27 @@ def defineStage(def globalConfig, def jobConfig, def jdkVersion, boolean isRefer def

Re: [VOTE] Release Apache Sling Whiteboard JMX Exporter 0.2.0

2022-06-21 Thread Christian Schneider
+1 Christian Am Mo., 20. Juni 2022 um 13:47 Uhr schrieb Jörg Hoh : > Hi, > > I want to release a first 0.2.0 version of the JMX Exporter which I am > currently working on in the Sling Whiteboard. The scope of this bundle > is quite tight, but I want to give a first shot. > > Also, this gives me

[GitHub] [sling-tooling-jenkins] kwin commented on a diff in pull request #10: SLING-11401 properly isolate workspace directories

2022-06-21 Thread GitBox
kwin commented on code in PR #10: URL: https://github.com/apache/sling-tooling-jenkins/pull/10#discussion_r902258462 ## vars/slingOsgiBundleBuild.groovy: ## @@ -178,24 +178,27 @@ def defineStage(def globalConfig, def jobConfig, def jdkVersion, boolean isRefer def

[GitHub] [sling-org-apache-sling-graphql-core] tyge68 commented on pull request #28: SLING-11248 QueryParser.fromRequest(...) calls possible exceptions sh…

2022-06-21 Thread GitBox
tyge68 commented on PR #28: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/28#issuecomment-1161371588 @raducotescu @bdelacretaz could you check this one, eventually take ownership on it to speed up the resolution ? -- This is an automated message from the

[GitHub] [sling-org-apache-sling-repoinit-parser] anchela commented on pull request #21: SLING-11384 - fix case of create path /(jcr:primaryType)

2022-06-21 Thread GitBox
anchela commented on PR #21: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/21#issuecomment-1161367755 @niekraaijmakers , done :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [sling-org-apache-sling-repoinit-parser] anchela merged pull request #21: SLING-11384 - fix case of create path /(jcr:primaryType)

2022-06-21 Thread GitBox
anchela merged PR #21: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [sling-org-apache-sling-repoinit-parser] niekraaijmakers commented on pull request #21: SLING-11384 - fix case of create path /(jcr:primaryType)

2022-06-21 Thread GitBox
niekraaijmakers commented on PR #21: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/21#issuecomment-1161363657 @anchela who can merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Created] (SLING-11401) Jenkins: Properly isolate workspace directories for parallel stages

2022-06-21 Thread Konrad Windszus (Jira)
Konrad Windszus created SLING-11401: --- Summary: Jenkins: Properly isolate workspace directories for parallel stages Key: SLING-11401 URL: https://issues.apache.org/jira/browse/SLING-11401 Project:

[jira] [Resolved] (SLING-11400) Jacoco coverage was missing on PR

2022-06-21 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-11400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-11400. - Resolution: Fixed Fixed in

[GitHub] [sling-tooling-jenkins] kwin merged pull request #9: SLING-11400 enable jacoco with the main Maven build

2022-06-21 Thread GitBox
kwin merged PR #9: URL: https://github.com/apache/sling-tooling-jenkins/pull/9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: