klcodanr commented on code in PR #30:
URL:
https://github.com/apache/sling-org-apache-sling-event/pull/30#discussion_r1244188308
##
src/main/java/org/apache/sling/event/impl/jobs/stats/GaugeSupport.java:
##
@@ -150,9 +154,10 @@ private void registerWithSuffix(String suffix,
pat-lego opened a new pull request, #30:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/30
Removing infinite loop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Hi Radu,
In general I agree, that it is too easy to leak implementation details
here. Maybe I can use these mixins in the first way to write a lot of WARN
messages in such a case, plus the option not to serialize them (by default
turned off, so serializing them nevertheless).
But my priority is
Could you do something like [1] and [2] and just write out JSON null or
some other value that makes sense? That would avoid trying to serialize the
ResourceResolver (and potentially Resource as well), at the expense of a
remaining null. There also may be other features of the StdSerializer [3]
sonarcloud[bot] commented on PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/45#issuecomment-1609924130
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
Hi Jörg,
I think you would have the same problem with that model given the other
property, namely that list of resources.
Unfortunately I don’t see an easy way out other than documenting this
aspect and advising developers to avoid exposing implementation details.
Whatever you’d change in the
kwin opened a new pull request, #45:
URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/45
This is available if compiled accordingly (with javac flag -parameters,
https://docs.oracle.com/en/java/javase/17/docs/specs/man/javac.html#option-parameters)
--
This is an
Hm, I think that Jackson Mixins [1] could work here.
[1] https://github.com/FasterXML/jackson-docs/wiki/JacksonMixInAnnotations
Am Di., 27. Juni 2023 um 13:28 Uhr schrieb Jörg Hoh :
> Hi,
>
> Assuming this Sling Model (using Lombok's @Getter annotation)
>
> @Getter
> @Model(
>
HI Stefan,
I agree, but:
I don't have control over the code, which causes the ResourceResolver to be
serialized. Also I cannot enforce, that such code is NOT written and
deployed (there are too many ways to make it wrong). Also because it
currently works, I would have to counter the "but it
Konrad Windszus created SLING-11917:
---
Summary: Sling Models: Support parameter name evaluation in
constructor injection
Key: SLING-11917
URL: https://issues.apache.org/jira/browse/SLING-11917
kwin opened a new pull request, #112:
URL: https://github.com/apache/sling-site/pull/112
Document injection specific annotations. Clarify that @Inject on constructor
is mandatory.
Add chapters for field, method and constructor injection
--
This is an automated message from the Apache
[
https://issues.apache.org/jira/browse/SLING-11916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737635#comment-17737635
]
Robert Munteanu commented on SLING-11916:
-
My hunch was incorrect -
rombert commented on PR #28:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/28#issuecomment-1609414244
Failed again, does not seem like the missing synchronisation is the problem
```
laeubi commented on PR #19:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/19#issuecomment-1609410394
Yes I think this is now obsolete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
sonarcloud[bot] commented on PR #28:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/28#issuecomment-1609409586
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
rombert closed pull request #19: SLING-11231 - Support setting a version for
MockBundles
URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
[
https://issues.apache.org/jira/browse/SLING-11231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu resolved SLING-11231.
-
Resolution: Duplicate
I just implemented this in SLING-11913 without noticing that we
rombert commented on PR #19:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/19#issuecomment-1609408966
@laeubi - I implemented this in #27, did not notice that you already have a
PR open. Do the changes I applied work for you?
--
This is an automated
sonarcloud[bot] commented on PR #28:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/28#issuecomment-1609398126
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
rombert opened a new pull request, #28:
URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/28
Make DummyEventHandler thread-safe. The EventHandler is potentially invoked
from multiple threads, and improper synchronisation can lead to missing events.
--
This is
[
https://issues.apache.org/jira/browse/SLING-11913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu resolved SLING-11913.
-
Resolution: Fixed
> Implement MockBundle.getVersion
> ---
>
rombert merged PR #27:
URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/27
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
+1
stefan
Hi,
We solved 1 issues in this release:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353254=Text
Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2757/
You can use this UNIX script to download the release and verify the
sonarcloud[bot] commented on PR #27:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/27#issuecomment-1609351199
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
Robert Munteanu created SLING-11916:
---
Summary: MockEventAdminTest.testPostEvents times out on
Jenkins/Windows
Key: SLING-11916
URL: https://issues.apache.org/jira/browse/SLING-11916
Project: Sling
rombert commented on PR #27:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/27#issuecomment-1609350352
Created SLING-11916 . On a related note, does the `DummyEventHandler` need
to be thread-safe?
--
This is an automated message from the Apache Git Service.
stefanseifert commented on PR #27:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/27#issuecomment-1609343811
ah, ok - then best to create a separate issue for that
--
This is an automated message from the Apache Git Service.
To respond to the message, please
[
https://issues.apache.org/jira/browse/SLING-11915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert resolved SLING-11915.
Resolution: Fixed
stefanseifert merged PR #4:
URL:
https://github.com/apache/sling-org-apache-sling-testing-caconfig-mock-plugin/pull/4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
rombert commented on PR #27:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/27#issuecomment-1609338871
I asked since the last 5 executions failed
sonarcloud[bot] commented on PR #4:
URL:
https://github.com/apache/sling-org-apache-sling-testing-caconfig-mock-plugin/pull/4#issuecomment-1609337836
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
stefanseifert opened a new pull request, #4:
URL:
https://github.com/apache/sling-org-apache-sling-testing-caconfig-mock-plugin/pull/4
https://issues.apache.org/jira/browse/SLING-11915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
stefanseifert commented on PR #27:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/27#issuecomment-1609329046
did you try to re-run the test? in rare occasions i see such timeouts in
this test case, but usually it goes away when re-running.
--
This is an
well, using lombok with such a result is a bad idea. there should not be a
getResolver() method, this is an implementation detail and no getter should be
provided for it.
so to put it another way: good that the serialization fails, so you can fix the
calls to not add a getResolver() method!
rombert commented on PR #27:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/27#issuecomment-1609324758
@stefanseifert - do you have any idea about the Windows testing failures?
```
[ERROR]
Stefan Seifert created SLING-11915:
--
Summary: caconfig-mock-plugin: Order of collection items may be
lost in writeConfigurationCollection
Key: SLING-11915
URL: https://issues.apache.org/jira/browse/SLING-11915
Hi,
Assuming this Sling Model (using Lombok's @Getter annotation)
@Getter
@Model(
adaptables = { SlingHttpServletRequest.class },
adapters = { MyModel.class, ComponentExporter.class },
resourceType = MyModel.RESOURCE_TYPE)
@Exporter(
name =
Some things magically work even without ITs.
And no, by someone I really meant some committer.
> On 27. Jun 2023, at 11:36, Bertrand Delacretaz wrote:
>
> On Tue, Jun 27, 2023 at 9:05 AM Konrad Windszus wrote:
>> ...If someone can confirm that both levels are supported for constructor
>>
On Tue, Jun 27, 2023 at 9:05 AM Konrad Windszus wrote:
> ...If someone can confirm that both levels are supported for constructor
> injection
> I am gonna adjust our documentation...
Well, "someone" should be "automated tests", right? Otherwise it
didn't happen ;-)
-Bertrand
rombert opened a new pull request, #27:
URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/27
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
[
https://issues.apache.org/jira/browse/SLING-11913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-11913:
Description:
{{MockBundle.getVersion()}} is not implemented and always throws an
Christian Schneider created SLING-11914:
---
Summary: Accept initial offset via PingMessage
Key: SLING-11914
URL: https://issues.apache.org/jira/browse/SLING-11914
Project: Sling
Issue
[
https://issues.apache.org/jira/browse/SLING-11913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-11913:
Description:
{{MockBundle.getVersion()}} is not implemented and always throws an
Robert Munteanu created SLING-11913:
---
Summary: Implement Bundle.getVersion
Key: SLING-11913
URL: https://issues.apache.org/jira/browse/SLING-11913
Project: Sling
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/SLING-11913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-11913:
Summary: Implement MockBundle.getVersion (was: Implement Bundle.getVersion)
> Implement
[
https://issues.apache.org/jira/browse/SLING-2?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-2:
Summary: Regression in content loader : Different behaviour when initial
content is
Hi,
Currently our documentation at [1] only outlines using the annotations on
method level for constructor injection:
@Inject public MyModel(@Named("propertyName") String propertyName) { //
constructor code }
However as we recommend using injector-specific annotation now, I am wondering
if
48 matches
Mail list logo
