Re: Question about org.apache.sling.models.spi.DisposalCallbackRegistry & related

2023-07-26 Thread Carsten Ziegeler
Hi, I think at some point the servlet engine was actually reusing request objects and we ran into trouble with an async cleanup based on request objects and their attributes. Switching to the listener solved the issue. I'm not sure whether this is still the same or not. But I think getting

Re: Question about org.apache.sling.models.spi.DisposalCallbackRegistry & related

2023-07-26 Thread Paul Bjorkstrand
That was very helpful, thank you. Since requests would be (eventually) garbage collected by the JVM, I feel that a reference/queue-only approach could be sufficient for all types of cleanup. Sure, the servlet listener method could improve the timing of when the cleanup executes, but I imagine it

[GitHub] [sling-site] bfoster-discovery opened a new pull request, #114: Add example of file upload through cURL to documentation

2023-07-26 Thread via GitHub
bfoster-discovery opened a new pull request, #114: URL: https://github.com/apache/sling-site/pull/114 Had trouble coming up with how to upload a file through a cURL command, so I thought I would add a simple example to help others. -- This is an automated message from the Apache Git

[GitHub] [sling-site] bfoster-discovery opened a new pull request, #113: fix typo

2023-07-26 Thread via GitHub
bfoster-discovery opened a new pull request, #113: URL: https://github.com/apache/sling-site/pull/113 /content/pages should be /content/folder in that example -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: Question about org.apache.sling.models.spi.DisposalCallbackRegistry & related

2023-07-26 Thread Carsten Ziegeler
A while back we had a similar discussion. Now I think this distinction between real and fake requests could be completely removed, simplifying the models impl a lot - if we enhance the contract for servlet listeners being also called by Sling Engine for internal requests (which often use those

Re: Question about org.apache.sling.models.spi.DisposalCallbackRegistry & related

2023-07-26 Thread Dirk Rudolph
Hey Paul, afaik the marker attribute it used to distinguish between real and synthetic request objects. The ServletRequestListner implementation of the ModelAdapterFactory is only called for requests created by the servlet container. There are use cases that do not have access to a request

[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #934 is FIXED

2023-07-26 Thread Apache Jenkins Server
Please see https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-starter/job/master/934/ for details. No further emails will be sent until the status of the build is changed.

[GitHub] [sling-org-apache-sling-api] JesseOosterwijk commented on pull request #49: SLING-11546: Edited calendar toString method so it explicitly adds th…

2023-07-26 Thread via GitHub
JesseOosterwijk commented on PR #49: URL: https://github.com/apache/sling-org-apache-sling-api/pull/49#issuecomment-1651418982 Hi is there an ETA for this merge? This is still an issue in the project atm. -- This is an automated message from the Apache Git Service. To respond to the

[RESULT] [VOTE] Release Apache Sling GraphQL Core 0.0.22

2023-07-26 Thread Andreas Schaefer
Hi, I finishing the release of GraphQL that Radu created for me as my travel computer cannot sign a release. The vote has passed with the following result : +1 (binding): Robert Munteanu, Casten Ziegler, Joerg Hoh, Daniel Klco +1 (non binding): Andreas Schaefer Can a PMC push this release to