jsedding merged PR #45:
URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
James Raynor created SLING-12138:
Summary: Node Browser page keeps popping up login window
Key: SLING-12138
URL: https://issues.apache.org/jira/browse/SLING-12138
Project: Sling
Issue Type:
jsedding commented on PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#issuecomment-1805221195
@anchela in order to clear your "changes request" status from the PR, I
clicked the "re-request review" icon. Should have done that yesterday, before
you
jsedding commented on code in PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#discussion_r1389007296
##
src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java:
##
@@ -174,9 +173,26 @@ private static void setAcl(Session session, List
[
https://issues.apache.org/jira/browse/SLING-12026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784682#comment-17784682
]
Carsten Ziegeler commented on SLING-12026:
--
I wasn't thinking of anything particular. maybe a
rombert commented on code in PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#discussion_r1388291023
##
src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java:
##
@@ -174,9 +173,26 @@ private static void setAcl(Session session, List
jsedding commented on PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#issuecomment-1804022381
Thank you for your reviews, @anchela! Addressing the points you raised
forced me to look at all the details again, and I believe the result is an
improvement
jsedding commented on code in PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#discussion_r1388150998
##
src/test/java/org/apache/sling/jcr/repoinit/GeneralAclTest.java:
##
@@ -270,9 +270,9 @@ private void verifyRegisterNamespace(String
[
https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784482#comment-17784482
]
Rob McDougall commented on SLING-12131:
---
OK, will do. Thanks for the pointers.
> Update
rombert commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-testing-hamcrest/pull/2#issuecomment-1803933132
All good, thanks for the contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
rmcdouga commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-testing-hamcrest/pull/2#issuecomment-1803926586
Thank you for doing that and walking me through the process. I will
structure my commit comments like that in the future.
--
This is an automated message
sonarcloud[bot] commented on PR #40:
URL:
https://github.com/apache/sling-org-apache-sling-xss/pull/40#issuecomment-1803869680
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
rombert commented on PR #40:
URL:
https://github.com/apache/sling-org-apache-sling-xss/pull/40#issuecomment-1803866476
Manual checks for the generated jar
```
$ jar tf target/org.apache.sling.xss-2.3.11-SNAPSHOT.jar | grep -E -c
'owasp/html/.*.class'
117
$ jar tf
[
https://issues.apache.org/jira/browse/SLING-12137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-12137:
Priority: Critical (was: Major)
> XSS API bundle no longer embeds the needed
rombert opened a new pull request, #40:
URL: https://github.com/apache/sling-org-apache-sling-xss/pull/40
…ml classes
Mark org.owasp.html as a private-package so that it is included in the jar
file. Use 'merge-first' since we provide classes in our own project. We don't
overwrite
anchela commented on code in PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#discussion_r1388024166
##
src/test/java/org/apache/sling/jcr/repoinit/GeneralAclTest.java:
##
@@ -270,9 +270,9 @@ private void verifyRegisterNamespace(String
sonarcloud[bot] commented on PR #39:
URL:
https://github.com/apache/sling-org-apache-sling-xss/pull/39#issuecomment-1803855483
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
anchela commented on code in PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#discussion_r1388016165
##
src/main/java/org/apache/sling/jcr/repoinit/impl/DoNothingVisitor.java:
##
@@ -66,7 +66,7 @@ protected DoNothingVisitor(Session s) {
anchela commented on code in PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#discussion_r1388015841
##
src/main/java/org/apache/sling/jcr/repoinit/impl/AclVisitor.java:
##
Review Comment:
@jsedding , those are all valid points... it's
Robert Munteanu created SLING-12137:
---
Summary: XSS API bundle no longer embeds the needed org.owasp.html
classes
Key: SLING-12137
URL: https://issues.apache.org/jira/browse/SLING-12137
Project:
anchela commented on code in PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#discussion_r1388010901
##
src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java:
##
@@ -420,7 +419,7 @@ private static boolean isValidPath(@NotNull Session
anchela commented on code in PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#discussion_r1388009498
##
src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java:
##
@@ -152,7 +154,9 @@ private static void setAcl(Session session, List
anchela commented on code in PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#discussion_r1388008517
##
src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java:
##
@@ -156,8 +156,11 @@ private static void setAcl(Session session, List
[
https://issues.apache.org/jira/browse/SLING-12026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784456#comment-17784456
]
Konrad Windszus commented on SLING-12026:
-
Are you referring to a specific Maven plugin where
Please see
https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-starter/job/master/1119/
for details.
No further emails will be sent until the status of the build is changed.
[
https://issues.apache.org/jira/browse/SLING-12136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu resolved SLING-12136.
-
Resolution: Fixed
Fix applied, thanks [~RobMcDougall]!
> MapUtil.toMap infinite loop
[
https://issues.apache.org/jira/browse/SLING-12130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu resolved SLING-12130.
-
Resolution: Fixed
Fixed applied, thanks [~RobMcDougall]!
> Update Apache Sling
rombert merged PR #2:
URL: https://github.com/apache/sling-org-apache-sling-testing-hamcrest/pull/2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/SLING-12123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu reassigned SLING-12123:
---
Assignee: Robert Munteanu
> Unexpected new requirements for the XSS bundle
>
sonarcloud[bot] commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-testing-hamcrest/pull/2#issuecomment-1803763338
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
[
https://issues.apache.org/jira/browse/SLING-12136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-12136:
Description: MapUtil.toLoop causes an infinite loop in case an object that
implements
Robert Munteanu created SLING-12136:
---
Summary: MapUtil.toMap infinite loop for Dictionary arguments
Key: SLING-12136
URL: https://issues.apache.org/jira/browse/SLING-12136
Project: Sling
[
https://issues.apache.org/jira/browse/SLING-12130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu reassigned SLING-12130:
---
Assignee: Rob McDougall
> Update Apache Sling Hamcrest Matchers to use latest
[
https://issues.apache.org/jira/browse/SLING-12026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784410#comment-17784410
]
Carsten Ziegeler edited comment on SLING-12026 at 11/9/23 12:16 PM:
sonarcloud[bot] commented on PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#issuecomment-1803721129
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
Please see
https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-starter/job/master/1120/
for details.
No further emails will be sent until the status of the build is changed.
Build log follows below:
[...truncated 28903 lines...]
@media (min-width: 48em) {
[
https://issues.apache.org/jira/browse/SLING-12026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784410#comment-17784410
]
Carsten Ziegeler commented on SLING-12026:
--
I don't have a good idea; I have the feeling that
[
https://issues.apache.org/jira/browse/SLING-12135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784385#comment-17784385
]
Konrad Windszus commented on SLING-12135:
-
Just FTR:
Each line in {{provider-types.txt}}
[
https://issues.apache.org/jira/browse/SLING-12084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved SLING-12084.
-
Resolution: Won't Fix
[~cziegeler] Thanks, that should work fine as well for
[
https://issues.apache.org/jira/browse/SLING-12084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784373#comment-17784373
]
Carsten Ziegeler commented on SLING-12084:
--
I've added a similar functionality which adds the
[
https://issues.apache.org/jira/browse/SLING-12084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler reassigned SLING-12084:
Assignee: (was: Carsten Ziegeler)
> Expose provider types in feature model
>
[
https://issues.apache.org/jira/browse/SLING-12135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler updated SLING-12135:
-
Description: In order to be able to check whether provider type interfaces
of an API
[
https://issues.apache.org/jira/browse/SLING-12135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784371#comment-17784371
]
Carsten Ziegeler commented on SLING-12135:
--
The list of provider types is added to the apis jar
Carsten Ziegeler created SLING-12135:
Summary: Expose provider types in apis jar
Key: SLING-12135
URL: https://issues.apache.org/jira/browse/SLING-12135
Project: Sling
Issue Type:
[
https://issues.apache.org/jira/browse/SLING-12084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler updated SLING-12084:
-
Fix Version/s: (was: OSGi Feature Maven Plugin 1.8.0)
> Expose provider types in
[
https://issues.apache.org/jira/browse/SLING-12135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler updated SLING-12135:
-
Fix Version/s: OSGi Feature Maven Plugin 1.8.0
> Expose provider types in apis jar
>
[
https://issues.apache.org/jira/browse/SLING-12084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler updated SLING-12084:
-
Fix Version/s: OSGi Feature Maven Plugin 1.7.6
> Expose provider types in feature model
[
https://issues.apache.org/jira/browse/SLING-12084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler updated SLING-12084:
-
Component/s: Maven Plugins and Archetypes
> Expose provider types in feature model
>
cziegeler commented on code in PR #40:
URL:
https://github.com/apache/sling-org-apache-sling-engine/pull/40#discussion_r1387629421
##
src/main/java/org/apache/sling/engine/impl/request/RequestData.java:
##
@@ -507,7 +507,12 @@ public static void service(SlingHttpServletRequest
49 matches
Mail list logo
