Re: [PR] SLING-12318 apply spotless formatting [sling-org-apache-sling-engine]

sonarcloud[bot] commented on PR #44: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/44#issuecomment-2113699160 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] SLING-12317 - Make Sling Engine build with Java 21 [sling-org-apache-sling-engine]

sonarcloud[bot] commented on PR #45: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/45#issuecomment-2113698925 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[jira] [Commented] (SLING-12279) Move Sling Model cache holder for Resource and ResourceResolver adaptables into the resource resolver property map

[ https://issues.apache.org/jira/browse/SLING-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846767#comment-17846767 ] Paul Bjorkstrand commented on SLING-12279: -- [~pakira], you are correct that this does not fix

[jira] [Comment Edited] (SLING-12279) Move Sling Model cache holder for Resource and ResourceResolver adaptables into the resource resolver property map

[ https://issues.apache.org/jira/browse/SLING-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846765#comment-17846765 ] Sumanta Pakira edited comment on SLING-12279 at 5/15/24 10:29 PM: -- I

[jira] [Commented] (SLING-12279) Move Sling Model cache holder for Resource and ResourceResolver adaptables into the resource resolver property map

[ https://issues.apache.org/jira/browse/SLING-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846765#comment-17846765 ] Sumanta Pakira commented on SLING-12279: I think still the problem mentioned in SLING-12259 does

[jira] [Updated] (SLING-12279) Move Sling Model cache holder for Resource and ResourceResolver adaptables into the resource resolver property map

[ https://issues.apache.org/jira/browse/SLING-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sumanta Pakira updated SLING-12279: --- Attachment: cachesize.log > Move Sling Model cache holder for Resource and ResourceResolver

[jira] [Updated] (SLING-12279) Move Sling Model cache holder for Resource and ResourceResolver adaptables into the resource resolver property map

[ https://issues.apache.org/jira/browse/SLING-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sumanta Pakira updated SLING-12279: --- Attachment: cache-size.log > Move Sling Model cache holder for Resource and

Re: [PR] SLING-12318 apply spotless formatting [sling-org-apache-sling-engine]

joerghoh commented on PR #44: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/44#issuecomment-2113422171 @rombert When I tried to make the update of the parent pom and the test dependencies, the spotless plugin failed the build for me; and for that reason I wanted to

[jira] [Resolved] (SLING-12316) Servlet Name might be set incorrectly after an exception

[ https://issues.apache.org/jira/browse/SLING-12316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh resolved SLING-12316. --- Resolution: Fixed PR merged > Servlet Name might be set incorrectly after an exception >

[jira] [Updated] (SLING-12316) Servlet Name might be set incorrectly after an exception

[ https://issues.apache.org/jira/browse/SLING-12316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-12316: -- Fix Version/s: Engine 2.15.16 > Servlet Name might be set incorrectly after an exception >

Re: [PR] SLING-12316 servlet name should always be re-set properly [sling-org-apache-sling-engine]

joerghoh merged PR #43: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/43 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] SLING-12283 : changed the config Pid to separate factoryPID & PID wit… [sling-org-apache-sling-installer-factory-configuration]

sonarcloud[bot] commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/13#issuecomment-2113317468 ## [![Quality Gate

Re: [PR] SLING-12283 : changed the config Pid to separate factoryPID & PID wit… [sling-org-apache-sling-installer-factory-configuration]

sonarcloud[bot] commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/13#issuecomment-2113316059 ## [![Quality Gate

Re: [PR] SLING-12283 : changed the config Pid to separate factoryPID & PID wit… [sling-org-apache-sling-installer-factory-configuration]

sonarcloud[bot] commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/13#issuecomment-2113311666 ## [![Quality Gate

Re: [PR] SLING-12283 : changed the config Pid to separate factoryPID & PID wit… [sling-org-apache-sling-installer-factory-configuration]

sonarcloud[bot] commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/13#issuecomment-2113206440 ## [![Quality Gate

Re: [PR] SLING-12313 bump oak.version to 1.62.0 for compatibility [sling-org-apache-sling-jcr-oak-server]

reschke commented on PR #10: URL: https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/10#issuecomment-2112861725 FTR: 1. Yes, we want to completely remove even the shaded Guava variant, but it'll take time. 2. *Major* version updates of Guava happened ~ once

Re: [PR] SLING-12313 bump oak.version to 1.62.0 for compatibility [sling-org-apache-sling-jcr-oak-server]

rombert commented on PR #10: URL: https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/10#issuecomment-2112842362 Echoing a direct conversation I had with @reschke - it's hard for me to formulate an ask to the Oak project since we can pull in a lot of components (from

[jira] [Updated] (SLING-12317) Make Sling Engine build with Java 21

[ https://issues.apache.org/jira/browse/SLING-12317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-12317: Fix Version/s: Engine 2.15.16 > Make Sling Engine build with Java 21 >

[jira] [Updated] (SLING-12317) Make Sling Engine build with Java 21

[ https://issues.apache.org/jira/browse/SLING-12317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-12317: Description: {noformat}[ERROR]

Re: [PR] SLING-12317 - Make Sling Engine build with Java 21 [sling-org-apache-sling-engine]

sonarcloud[bot] commented on PR #45: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/45#issuecomment-2112761541 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] SLING-12318 apply spotless formatting [sling-org-apache-sling-engine]

rombert commented on PR #44: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/44#issuecomment-2112750535 @joerghoh - I think I already fixed the Java 21 build ... #45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[PR] SLING-12317 - Make Sling Engine build with Java 21 [sling-org-apache-sling-engine]

rombert opened a new pull request, #45: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/45 Update to the latest JMock and byte-buddy versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Assigned] (SLING-12317) Make Sling Engine build with Java 21

[ https://issues.apache.org/jira/browse/SLING-12317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-12317: --- Assignee: Robert Munteanu > Make Sling Engine build with Java 21 >

Re: [PR] SLING-12318 apply spotless formatting [sling-org-apache-sling-engine]

joerghoh commented on PR #44: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/44#issuecomment-2112724636 (failed for not building on Java 21, which I plan to fix asap) -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Created] (SLING-12318) Apply spotless formatting to Sling Engine

Joerg Hoh created SLING-12318: - Summary: Apply spotless formatting to Sling Engine Key: SLING-12318 URL: https://issues.apache.org/jira/browse/SLING-12318 Project: Sling Issue Type: Task

[jira] [Created] (SLING-12317) Make Sling Engine build with Java 21

Joerg Hoh created SLING-12317: - Summary: Make Sling Engine build with Java 21 Key: SLING-12317 URL: https://issues.apache.org/jira/browse/SLING-12317 Project: Sling Issue Type: Task

Re: [PR] SLING-12313 bump oak.version to 1.62.0 for compatibility [sling-org-apache-sling-jcr-oak-server]

reschke commented on PR #10: URL: https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/10#issuecomment-2112496633 It's not clear to me yet what makes those Oak objects special. Or are they really special? At the end of the day, each repostiory instance will end up with

Re: [PR] SLING-12283 : changed the config Pid to separate factoryPID & PID wit… [sling-org-apache-sling-installer-factory-configuration]

rombert commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/13#issuecomment-2112452359 @rishabhdaim - can you please merge with the latest master commit?

[jira] [Commented] (SLING-12313) bump oak.version to 1.62.0 for compatibility

[ https://issues.apache.org/jira/browse/SLING-12313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846598#comment-17846598 ] Julian Reschke commented on SLING-12313: Oak and Jackrabbit dependencies should be in sync. Like

Re: [PR] SLING-12283 : changed the config Pid to separate factoryPID & PID wit… [sling-org-apache-sling-installer-factory-configuration]

rombert commented on code in PR #13: URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/13#discussion_r1601372208 ## src/main/java/org/apache/sling/installer/factories/configuration/impl/ConfigUtil.java: ## @@ -336,4 +337,20 @@ public

Re: [PR] SLING-12315: avoid new registrations during deactivation [sling-org-apache-sling-i18n]

jsedding commented on code in PR #14: URL: https://github.com/apache/sling-org-apache-sling-i18n/pull/14#discussion_r1601048338 ## src/main/java/org/apache/sling/i18n/impl/JcrResourceBundleProvider.java: ## @@ -436,8 +439,10 @@ protected void deactivate() {