Re: [PR] SLING-12320 - Add support for retrieving a service resource resolver with impersonation without requiring extra configuration [sling-org-apache-sling-jcr-resource]

2024-05-17 Thread via GitHub
anchela commented on PR #43: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/43#issuecomment-2117930435 @raducotescu , as discussed... i am fine now but making the comment a bit clearer and maybe also explaining why the extra attribute on the credentials is set

Re: [PR] SLING-12320 - Add support for retrieving a service resource resolver with impersonation without requiring extra configuration [sling-org-apache-sling-jcr-resource]

2024-05-17 Thread via GitHub
anchela commented on code in PR #43: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/43#discussion_r1605249171 ## src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrProviderStateFactory.java: ## @@ -111,7 +111,20 @@ private static Bundle

Re: [PR] SLING-12320 - Add support for retrieving a service resource resolver with impersonation without requiring extra configuration [sling-org-apache-sling-jcr-resource]

2024-05-17 Thread via GitHub
anchela commented on code in PR #43: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/43#discussion_r1605245518 ## src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrProviderStateFactory.java: ## @@ -111,7 +111,20 @@ private static Bundle

Re: [PR] SLING-12320 - Add support for retrieving a service resource resolver with impersonation without requiring extra configuration [sling-org-apache-sling-jcr-resource]

2024-05-17 Thread via GitHub
raducotescu commented on code in PR #43: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/43#discussion_r1605242759 ## src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrProviderStateFactory.java: ## @@ -111,7 +111,20 @@ private static

Re: [PR] SLING-12320 - Add support for retrieving a service resource resolver with impersonation without requiring extra configuration [sling-org-apache-sling-jcr-resource]

2024-05-17 Thread via GitHub
raducotescu commented on code in PR #43: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/43#discussion_r1605239318 ## src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrProviderStateFactory.java: ## @@ -111,7 +111,20 @@ private static

Re: [PR] SLING-12320 - Add support for retrieving a service resource resolver with impersonation without requiring extra configuration [sling-org-apache-sling-jcr-resource]

2024-05-17 Thread via GitHub
anchela commented on code in PR #43: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/43#discussion_r1605209974 ## src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrProviderStateFactory.java: ## @@ -111,7 +111,20 @@ private static Bundle

Re: [PR] SLING-12320 - Add support for retrieving a service resource resolver with impersonation without requiring extra configuration [sling-org-apache-sling-jcr-resource]

2024-05-17 Thread via GitHub
sonarcloud[bot] commented on PR #43: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/43#issuecomment-2117858021 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] SLING-12320 - Add support for retrieving a service resource resolver with impersonation without requiring extra configuration [sling-org-apache-sling-jcr-resource]

2024-05-17 Thread via GitHub
raducotescu opened a new pull request, #43: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/43 * for service users that want to impersonate, simply call SlingRepository#impersonateFromService -- This is an automated message from the Apache Git Service. To respond

[jira] [Created] (SLING-12320) Add support for retrieving a service resource resolver with impersonation without requiring extra configuration

2024-05-17 Thread Radu Cotescu (Jira)
Radu Cotescu created SLING-12320: Summary: Add support for retrieving a service resource resolver with impersonation without requiring extra configuration Key: SLING-12320 URL:

Re: [PR] SLING-11716 ability to cache the results of a caconfig lookup [sling-org-apache-sling-caconfig-impl]

2024-05-17 Thread via GitHub
stefanseifert commented on PR #9: URL: https://github.com/apache/sling-org-apache-sling-caconfig-impl/pull/9#issuecomment-2116999103 lgtm in general, some remarks: * making it configurable with default switched off is not really helpful - either we consider this caching safe then we can