I'm in agreement with Justin and Bertrand that the developer (and not the
administrator) is the right person to author this information.
I'm on the fence regarding whether to put it in the file or use a
property. (If we do use a property, it should be inherited so it can be
put on entire
+1 (to showing deprecation in console)
On 20/08/2014 17:33, Carsten Ziegeler cziege...@apache.org wrote:
I think we don't - and for now it would be the factory implementation
doing
the stuff. It would be great to show something in the console. Maybe
through the annotations?
Carsten
2014-08-20
+1 (to deprecating adaptTo(URL), and to deprecation comments in the other
thread)
Cheers,
Jeff.
On 20/08/2014 17:29, Justin Edelson jus...@justinedelson.com wrote:
Hi,
I'm fine with this, although I'm see my other email about what it
means to deprecate an adapter factory.
Justin
On Wed, Aug
Hi Felix,
I think to reduce the unexpected you'd need filter.resourceType to match
on the resource's supertype hierarchy too.
Cheers,
Jeff.
On 18/08/2014 10:23, Felix Meschberger fmesc...@adobe.com wrote:
Hi all
I had various discussions around execution of Servlet API Filters in the
Sling
adaptTo() is currently commonly used as a test, similar to instanceof.
Throwing and catching to return null is a very poor implementation
(performance-wise) for this use.
Adding a hasAdapter() or canAdaptTo() might decrease the number of
implementations that think throwing is OK, but only if the
Hi Carsten,
Can you say more? (I'm not sure I understand what you're getting at)
Thanks,
Jeff.
On 01/07/2014 09:56, Carsten Ziegeler cziege...@apache.org wrote:
adaption and validation are different concerns
Carsten
2014-07-01 10:55 GMT+02:00 Jeff Young j...@adobe.com:
We could
+02:00 Jeff Young j...@adobe.com:
Hi Carsten,
Can you say more? (I'm not sure I understand what you're getting
at)
Thanks,
Jeff.
On 01/07/2014 09:56, Carsten Ziegeler cziege...@apache.org wrote:
adaption and validation are different concerns
Carsten
2014-07-01 10:55 GMT+02:00
:08 GMT+02:00 Jeff Young j...@adobe.com:
Hi Carsten,
Sure, but Konrad has a point in that I think sometimes the client *does*
care why the adaption failed. For instance, if it had to do with
something entirely different from whether or not adaption would normally
work.
Let's say that I
FWIW, there are lots of calls to resource.adaptTo(ValueMap) in rendering
code.
Cheers,
Jeff.
On 14/03/2014 10:19, Bertrand Delacretaz bdelacre...@apache.org wrote:
On Fri, Mar 14, 2014 at 11:03 AM, Carsten Ziegeler cziege...@apache.org
wrote:
...Just for rendering code, it is quiet handy to
Hi Alex,
Me thinks you didn't look hard enough. ;)
Adobe CQ's WCMDebugFilter has the following (commented-out) code:
/*
Currently disabled because misleading information, because the
script name is set after the filter chain.
SlingBindings bindings = (SlingBindings)
the debug info into the rendered html so that it
can be displayed client-side in the context of the portions of the page it
rendered. That's the highly-integrated part.
Cheers,
Jeff.
On 08/01/2014 10:47, Bertrand Delacretaz bdelacre...@apache.org wrote:
On Wed, Jan 8, 2014 at 11:42 AM, Jeff
Ping.
From: Jeff Young j...@adobe.commailto:j...@adobe.com
Date: Wednesday 13 November 2013 11:48
To: dev@sling.apache.orgmailto:dev@sling.apache.org
dev@sling.apache.orgmailto:dev@sling.apache.org
Cc: Jeff Young j...@adobe.commailto:j...@adobe.com
Subject: Should ValueMapDecorator implement
I assume yes, but it doesn't for dates.
In particular, org.apache.jackrabbit.value.DateValue converts to ISO8601 when
asked for a string, while ValueMapDecorator gives you the string format of the
Calendar object.
Is this a bug, or should I interpret the Value in ValueMapDecorator more
[
https://issues.apache.org/jira/browse/SLING-3028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13754518#comment-13754518
]
Jeff Young commented on SLING-3028:
---
+1 on keeping failed jobs forever.
As for keeping
[
https://issues.apache.org/jira/browse/SLING-3028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13753516#comment-13753516
]
Jeff Young commented on SLING-3028:
---
I think jobs that wrote to the log stream might
+1
That would be very nice.
Jeff.
-Original Message-
From: Bertrand Delacretaz [mailto:bdelacre...@apache.org]
Sent: 27 June 2013 08:26
To: dev@sling.apache.org
Subject: Re: Sling Posthandling - thougts about the current behavior
On Thu, Jun 27, 2013 at 12:52 AM, Ian Boston
I used to agree as well, but my opinion is now more nuanced. I've experienced
projects where a test keeps failing day after day, and after a while developers
stop looking at the test results with the same level of discipline.
Perhaps Sling is small enough (and the developers are pro-active
+1
-Original Message-
From: maret.timot...@gmail.com [mailto:maret.timot...@gmail.com] On Behalf Of
Timothée Maret
Sent: 13 May 2013 11:09
To: dev@sling.apache.org
Subject: Support allowed hosts patterns in ReferrerFilter
Hi,
The current allow.hosts setting of the
+1
(I was about to ask for a test for SLING-2844, but I see you already added one.)
Cheers,
Jeff.
-Original Message-
From: Carsten Ziegeler [mailto:cziege...@apache.org]
Sent: 30 April 2013 09:16
To: dev@sling.apache.org
Subject: [VOTE] Release API 2.4.2
Hi,
I just fixed two
+1
Jeff.
-Original Message-
From: Carsten Ziegeler [mailto:cziege...@apache.org]
Sent: 31 January 2013 16:48
To: dev@sling.apache.org
Subject: [VOTE] Drop Java 5 Support in General
Hi,
we see more and more problems with supporting Java 5 and we discussed
this several times
+1
Jeff.
-Original Message-
From: Felix Meschberger [mailto:fmesc...@adobe.com]
Sent: 10 January 2013 08:45
To: dev@sling.apache.org
Subject: Enhancing the RequestPathInfo
Hi all
The RequestPathInfo object (retrieved from
SlingHttpServletRequest.getRequestPathInfo()) allows
Jeff Young created SLING-2572:
-
Summary: Redirect validating service
Key: SLING-2572
URL: https://issues.apache.org/jira/browse/SLING-2572
Project: Sling
Issue Type: Improvement
This would be a nice feature.
There have been several times when I've written a POST servlet which pulls out
the :operation, handles one or more custom ones, and then forwards everything
else on to the default POST servlet.
Jeff.
-Original Message-
From: Bertrand Delacretaz
+0
I think this use case (for me) would be just over the line: the correct answer
would be to write a custom servlet (as you did). Making the sling POST servlet
more complicated doesn't seem worth it.
But I don't feel strongly (thus the +0).
Jeff.
-Original Message-
From:
Hi Carsten,
While I don't have any advice on how to proceed, I can tell you that I'd be
getting cold feet at about this point too. ;)
Jeff.
-Original Message-
From: Carsten Ziegeler [mailto:cziege...@apache.org]
Sent: 13 August 2012 10:48
To: dev@sling.apache.org
Subject: Re:
[
https://issues.apache.org/jira/browse/SLING-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13289232#comment-13289232
]
Jeff Young commented on SLING-2320:
---
The 12/Dec/11 patch still needs to be applied
[
https://issues.apache.org/jira/browse/SLING-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13272254#comment-13272254
]
Jeff Young commented on SLING-2467:
---
How about sling:Container?
Define
[
https://issues.apache.org/jira/browse/SLING-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13254061#comment-13254061
]
Jeff Young commented on SLING-2457:
---
Is the fail-over from Resource.isResourceType
29.03.2012 um 11:44 schrieb Antonio Sanso:
Hi Jeff,
in [0] you can find a kind of evidence for it.
Regards
Antonio
[0] https://issues.apache.org/jira/browse/SLING-2311
On Feb 24, 2012, at 1:48 PM, Jeff Young wrote:
Felix,
Have we done any profiling to confirm
[
https://issues.apache.org/jira/browse/SLING-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240489#comment-13240489
]
Jeff Young commented on SLING-2441:
---
If we stick with the old behaviour than someone
That's quite an improvement. Nice work, guys.
-Original Message-
From: Antonio Sanso (Commented) (JIRA) [mailto:j...@apache.org]
Sent: 26 March 2012 14:36
To: dev@sling.apache.org
Subject: [jira] [Commented] (SLING-2255) Improve
JcrResourceResolver#resolve performance when big
Type: Bug
Components: JCR
Reporter: Jeff Young
JCR supports the typehint {Decimal} for java.math.BigDecimal, but
JcrPropertyMap doesn't know about it so doing a map.get(propName,
BigDecimal.class) returns null.
--
This message is automatically generated by JIRA.
If you
I created an issue for this an uploaded a patch. I can't remember what comes
next. (Just this email?)
Jeff.
, Mar 23, 2012 at 9:20 AM, Jeff Young j...@adobe.com wrote:
I created an issue for this an uploaded a patch. I can't remember
what
comes next. (Just this email?)
Jeff.
is part of the API, i.e. it is exported by the
auth.core
bundle.
Justin
On Fri, Mar 23, 2012 at 9:58 AM, Jeff Young j...@adobe.com wrote:
Thanks Justin. (Although I don't remember an API change. Perhaps
you're
thinking of a different one?)
Jeff.
-Original Message
[
https://issues.apache.org/jira/browse/SLING-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13236621#comment-13236621
]
Jeff Young commented on SLING-2446:
---
Hi Justin,
Just to note that I'm working
[
https://issues.apache.org/jira/browse/SLING-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeff Young updated SLING-2446:
--
Attachment: BigDecimal_tests_.patch
Add support for BigDecimal JCR values
[
https://issues.apache.org/jira/browse/SLING-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13236664#comment-13236664
]
Jeff Young commented on SLING-2446:
---
Most of my changes were the same as Justin's, so I
Affects Versions: Auth Core 1.0.6
Reporter: Jeff Young
Historically the AUTH_TYPE of an AuthenitcationInfo had to be defined (ie:
non-null), but we're now using it for anonymous access as well, with a null
AUTH_TYPE. The put() method, however, throws if passed a null AUTH_TYPE
[
https://issues.apache.org/jira/browse/SLING-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeff Young updated SLING-2441:
--
Attachment: auth_info_put.patch
AuthenticationInfo.put() throws if method is null
to ignore it.
Jeff.
-Original Message-
From: Antonio Sanso [mailto:asa...@adobe.com]
Sent: 24 February 2012 13:28
To: dev@sling.apache.org
Subject: Re: [ResourceResolver] sling:alias support
Hi Jeff
On Feb 24, 2012, at 1:48 PM, Jeff Young wrote:
Felix,
Have we done any profiling
What is a whiteboard? (Is it equivalent to a sandbox?)
Thanks,
Jeff.
-Original Message-
From: Felix Meschberger [mailto:fmesc...@adobe.com]
Sent: 02 February 2012 13:42
To: dev@sling.apache.org
Subject: Re: The beast that is JcrResourceResolverFactoryImpl
Hi,
Am 02.02.2012 um 14:26
[
https://issues.apache.org/jira/browse/SLING-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13197723#comment-13197723
]
Jeff Young commented on SLING-2320:
---
My last patch (which contains all the good bug
[
https://issues.apache.org/jira/browse/SLING-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13190968#comment-13190968
]
Jeff Young commented on SLING-2236:
---
Imagine our poor developer trying to debug
[
https://issues.apache.org/jira/browse/SLING-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1319#comment-1319
]
Jeff Young commented on SLING-2236:
---
OK, one more attempt (and then I promise to shut up
[
https://issues.apache.org/jira/browse/SLING-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13191227#comment-13191227
]
Jeff Young commented on SLING-2236:
---
Hi Justin,
In my first example, if I use a -known
[
https://issues.apache.org/jira/browse/SLING-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13186296#comment-13186296
]
Jeff Young commented on SLING-2353:
---
sling:include with a null resource (whether
-1 to JSP taglib (see my comment in SLING-2353)
0 to the others (I'm not up-to-speed on them).
Cheers,
Jeff.
-Original Message-
From: justinedel...@gmail.com [mailto:justinedel...@gmail.com] On Behalf Of
Justin Edelson
Sent: 14 January 2012 16:29
To: dev@sling.apache.org
Subject: Re:
I was trying to look into the 4th test failure (the JsonRenderingTest), but I
can't get to svn.apache.org. Is it down, or is it just my machine?
Thanks,
Jeff.
-Original Message-
From: Apache Jenkins Server [mailto:jenk...@builds.apache.org]
Sent: 12 December 2011 10:22
To:
,
Jeff.
-Original Message-
From: Jeff Young [mailto:j...@adobe.com]
Sent: 12 December 2011 10:50
To: dev@sling.apache.org
Subject: RE: Jenkins build is unstable: sling-trunk-1.5 » Apache Sling
Launchpad Testing #1478
I was trying to look into the 4th test failure (the JsonRenderingTest
failure
Patch applied.
On Mon, Dec 12, 2011 at 3:58 AM, Jeff Young j...@adobe.com wrote:
Well, the server is still pretty glacial for me (when it responds at all),
but I've gotten enough out of it that I believe the test failure is a result
of the bug identified in SLING-2320 (comment 06/Dec/11
?
Thanks,
Jeff.
-Original Message-
From: Jeff Young [mailto:j...@adobe.com]
Sent: 12 December 2011 16:51
To: dev@sling.apache.org
Subject: RE: Jenkins test failure
Thanks, Justin.
Was svn.apache.org really slow for you, or is it just my connection?
Jeff.
-Original Message-
From
@sling.apache.org
Subject: Re: Jenkins test failure
Yep. I did the tests in the next revision.
Justin
On Mon, Dec 12, 2011 at 8:55 AM, Jeff Young j...@adobe.com wrote:
Hi Justin,
In revision 1213304, I only see the change to ResourceTraversor.java. I
think you might have applied the wrong patch
[
https://issues.apache.org/jira/browse/SLING-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeff Young updated SLING-2320:
--
Attachment: json_get_servlet_rewrite.patch
No worries, Justin. I've got one more anyway ;)
Hopefully
[
https://issues.apache.org/jira/browse/SLING-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13167650#comment-13167650
]
Jeff Young commented on SLING-2320:
---
BTW: final installment
Felix recently committed a change by Alex relating to the:
org.apache.sling.servlets.get.impl.RedirectServletTest
no longer returning absolute paths.
It would appear that the failing tests are the same issue, but from:
org.apache.sling.launchpad.webapp.integrationtest.VanityPathTest.
[
https://issues.apache.org/jira/browse/SLING-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeff Young updated SLING-2320:
--
Attachment: jsonRenderer.diff
Current DOS-prevention for infinity.json can prevent enumeration
[
https://issues.apache.org/jira/browse/SLING-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeff Young updated SLING-2320:
--
Attachment: servlet_tests.patch
Current DOS-prevention for infinity.json can prevent enumeration
We've got some Mock... classes in org.apache.sling.commons.testing.
Generally speaking, these mock the methods the original author needed, and
return null/false for all the rest.
However, there comes a time when someone else needs a Mock of the same class,
but with a few more of the methods
and decided to copy the code or create new
mocks. This reduces dependencies and ensures that the mock really
behaves as you expect.
In addition I prefer using jmock (or similar libs) to create mocks on the fly.
Regards
Carsten
2011/12/7 Jeff Young j...@adobe.com:
We've got some Mock... classes
[
https://issues.apache.org/jira/browse/SLING-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13163970#comment-13163970
]
Jeff Young commented on SLING-2320:
---
Felix, your change to the logic turns off the DOS
Issue Type: Bug
Components: Servlets
Affects Versions: Servlets Get 2.1.0
Reporter: Jeff Young
A request of resource.1.json should always succeed, as it's the primary method
for JSON introspection of the repository hierarchy. DOS protection should only
apply to deep
[
https://issues.apache.org/jira/browse/SLING-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeff Young updated SLING-2320:
--
Description:
A request of resource.1.json should always succeed, as it's the primary method
for JSON
[
https://issues.apache.org/jira/browse/SLING-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeff Young updated SLING-2320:
--
Attachment: jsonRenderer.diff
Ostensibly, this would just be a one-liner. However, I discovered
[
https://issues.apache.org/jira/browse/SLING-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13162978#comment-13162978
]
Jeff Young edited comment on SLING-2320 at 12/5/11 7:45 PM
[
https://issues.apache.org/jira/browse/SLING-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13162978#comment-13162978
]
Jeff Young commented on SLING-2320:
---
Note: the patch has SLING- in it because I
[
https://issues.apache.org/jira/browse/SLING-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13163073#comment-13163073
]
Jeff Young commented on SLING-2320:
---
Yeah, I was also somewhat concerned by the fact
[
https://issues.apache.org/jira/browse/SLING-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13163073#comment-13163073
]
Jeff Young edited comment on SLING-2320 at 12/5/11 9:45 PM
own the repository per
se.
Justin
On Thu, Dec 1, 2011 at 4:26 PM, Jeff Young j...@adobe.com wrote:
The intent behind the limitation seems sound, but the implementation has (to
my mind) a slight flaw.
A legitimate client which needs the information could presumably implement
its own
On Thu, Dec 1, 2011 at 4:26 PM, Jeff Young j...@adobe.com wrote:
The intent behind the limitation seems sound, but the implementation has
(to my mind) a slight flaw.
A legitimate client which needs the information could presumably implement
its own traversal to descend the tree. But this only
.
(PS: apologies if this gets sent out twice, but I think ezmlm ate the first
posting because I hadn't yet cofirmed my subscription so I'm re-sending.)
Jeff Young | Principal Scientist | Adobe Distinguished Inventor
Adobe Systems Software Ireland Ltd.
Registered Office: 4-6 Riverwalk, Citywest
Type: Bug
Components: Servlets
Reporter: Jeff Young
In sling/servlets/post/impl/SlingPostServlet.java's doPost() method, we look up
the operation (and report an unknown operation) before checking privileges.
I'd
like to propose that when the operation is not understood, we
72 matches
Mail list logo
