[jira] [Commented] (SLING-10840) Sling Servlet Helpers implements @ProviderType interfaces

2021-09-27 Thread Justin Edelson (Jira)
[ https://issues.apache.org/jira/browse/SLING-10840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17420975#comment-17420975 ] Justin Edelson commented on SLING-10840: bq. But still it is a very common use-case in real

[RESULT] [VOTE] Release Apache Sling Models Impl Version 1.4.14

2020-10-08 Thread Justin Edelson
Hi, The vote has passed with the following result : +1 (binding): Radu Cotescu, Karl Pauls, Carsten Ziegeler, Nicolas Peltier, Dan Klco I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository.

[VOTE] Release Apache Sling Models Impl Version 1.4.14

2020-10-05 Thread Justin Edelson
Hi, We solved 3 issues in this release: https://issues.apache.org/jira/projects/SLING/versions/12346492 There are still some outstanding issues: https://issues.apache.org/jira/browse/SLING/fixforversion/12349142 Staging repository:

[jira] [Updated] (SLING-9674) Allow SlingHttpServletRequest based adaptations for ChildResourceInjector

2020-10-05 Thread Justin Edelson (Jira)
[ https://issues.apache.org/jira/browse/SLING-9674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-9674: -- Fix Version/s: (was: Sling Models Impl 1.4.14) Sling Models Impl 1.4.16

[jira] [Updated] (SLING-8079) Returning false in a model PostConstruct causes an java.lang.IllegalStateException

2020-10-05 Thread Justin Edelson (Jira)
[ https://issues.apache.org/jira/browse/SLING-8079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-8079: -- Fix Version/s: (was: Sling Models Impl 1.4.14) Sling Models Impl 1.4.16

[jira] [Updated] (SLING-9478) Expose the full stack trace for PostConstruct exceptions

2020-10-05 Thread Justin Edelson (Jira)
[ https://issues.apache.org/jira/browse/SLING-9478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-9478: -- Fix Version/s: (was: Sling Models Impl 1.4.14) Sling Models Impl 1.4.16

[jira] [Updated] (SLING-8923) Jackson Sling Model Exporter for application/xml needs correct character encoding

2020-10-05 Thread Justin Edelson (Jira)
[ https://issues.apache.org/jira/browse/SLING-8923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-8923: -- Fix Version/s: (was: Sling Models Impl 1.4.14) Sling Models Impl 1.4.16

[jira] [Updated] (SLING-9036) Sling Models: SlingHttpServletRequestWrapper.adaptTo() unwraps before adapting

2020-10-05 Thread Justin Edelson (Jira)
[ https://issues.apache.org/jira/browse/SLING-9036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-9036: -- Fix Version/s: (was: Sling Models Impl 1.4.14) Sling Models Impl 1.4.16

[jira] [Resolved] (SLING-9781) [Sling Models] Caching doesn't work with Wrapped requests

2020-10-05 Thread Justin Edelson (Jira)
[ https://issues.apache.org/jira/browse/SLING-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-9781. --- Resolution: Fixed Fixed with 73cae5875cc47c76991d0a58e4fb2351595eb146 > [Sling Mod

[jira] [Commented] (SLING-8706) Injections for java.util.Optional<> should be automatic optional

2020-06-22 Thread Justin Edelson (Jira)
[ https://issues.apache.org/jira/browse/SLING-8706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142111#comment-17142111 ] Justin Edelson commented on SLING-8706: --- The question of how HTL interprets methods which return

Re: [Discuss] Thoughts about renaming the 'master' branches to 'main'?

2020-06-14 Thread Justin Edelson
+1 Regardless of the members@ discussion, we should do this. Although perhaps this should be done as a formal vote. I'm assuming this is something that can be relatively easily scripted, but if does require manual work, I'd be happy to help. On Sun, Jun 14, 2020 at 4:38 AM wrote: > Hi all, >

Re: Sonar complains about no assertion when using Awaitility

2020-03-30 Thread Justin Edelson
On Mon, Mar 30, 2020 at 5:58 AM Robert Munteanu wrote: > Hi Christian, > > On Mon, 2020-03-30 at 11:38 +0200, Christian Schneider wrote: > > In some of our tests we use Awaitility as the expected result will > > happen > > asynchronously. > > The code looks like: > > > >

[jira] [Commented] (SLING-8079) Returning false in a model PostConstruct causes an java.lang.IllegalStateException

2020-02-19 Thread Justin Edelson (Jira)
[ https://issues.apache.org/jira/browse/SLING-8079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17039980#comment-17039980 ] Justin Edelson commented on SLING-8079: --- [~kwin] What I would suggest is to have

Re: Why get rid of the rewriter?

2019-09-12 Thread Justin Edelson
+1 great summary. On Tue, Sep 10, 2019 at 12:37 PM Stefan Seifert wrote: > i try to write a first summary: > > - we have good use cases for a rewriter in general, but are unhappy with > the current implementation and it's way of configuration. the whole thing > is a bit "alien" to the other

Re: Why get rid of the rewriter?

2019-09-12 Thread Justin Edelson
... for urls, not for markup in general. On Tue, Sep 10, 2019 at 10:35 AM Konrad Windszus wrote: > The new url rewriter SPI will be perfectly supporting AOP. > Konrad > > > Am 10.09.2019 um 16:09 schrieb Justin Edelson >: > > > > I see that the same assumptions

Re: Why get rid of the rewriter?

2019-09-10 Thread Justin Edelson
I see that the same assumptions are being made here that were made a year ago when this was discussed. I would strongly caution against assuming that the "aspect developer" and the "script developer" are the same person or even work for the same organization. The value of AOP programming styles,

Re: [DISCUSS] Feature Files I/O long-therm proposal: improving the processing pipeline

2018-11-12 Thread Justin Edelson
Hi Simo, Take this with several grains of salt as I don't know the internals of the feature processing, but just looking at your email from a generic "how do I process a JSON file" it still seems inefficient. Ideally, IMO, the substitution would be done as a filter applied to the stream of parser

Re: Sling 12 themes

2018-10-24 Thread Justin Edelson
ng here (i.e. only do > it once in code instead of hundreds of times explicitly in HTL). > > Konrad > > > On 24. Oct 2018, at 15:16, Justin Edelson > wrote: > > > > As I was trying to say, this assumes that modifying the script (or the > > model or even the

Re: Sling 12 themes

2018-10-24 Thread Justin Edelson
upport > for streaming text based outputs so as long as we have that API in > between we have a bad solution. Building on top of something where we > know that its not a good thing, seems wrong to me as well. > > Carsten > > Am 24.10.2018 um 01:45 schrieb Justin Edel

Re: Sling 12 themes

2018-10-24 Thread Justin Edelson
utputs so as long as we have that API in > > between we have a bad solution. Building on top of something where we > > know that its not a good thing, seems wrong to me as well. > > > > Carsten > > > > Am 24.10.2018 um 01:45 schrieb Justin Edelson: > >> J

Re: Sling 12 themes

2018-10-23 Thread Justin Edelson
Just my 2cents as a fan of the rewriter. The problem with saying "just use HTL" (aside from what Jason said) is that it enables a separation of concerns. To say "just use HTL" implies that there is a single developer (or organization) who "owns" all the code responsible for generating HTML and

Re: [hackathon] health checks

2018-09-18 Thread Justin Edelson
hecks and servlets) > > and merge that functionality into Sling Health Checks and then move Sling > > Health Checks (or solid chunks of it) to Felix. > > This was the intention, but let’s wait for the feedback from Andrei and > Christian. > > -Georg > > Sent from my

Re: [hackathon] health checks

2018-09-18 Thread Justin Edelson
Hi, After reviewing the presentation, this seems like kind of a stretch to me. IIUC, the System Readyness Framework is (as its name would suggest) solely concerned with "readyness" and "liveness" (as seen in the example use cases on slide 3) and the API is explicitly designed for this purpose

Re: SLING-7613 - un-deprecating loginAdministrative

2018-07-27 Thread Justin Edelson
; > On Thu, Jul 19, 2018, at 5:25 AM, Bertrand Delacretaz wrote: > > Hi, > > > > On Tue, Jul 17, 2018 at 1:43 PM Justin Edelson > wrote: > > > ...Without the deprecation, how will a developer know that they need to > > > configure the whitelist? Whil

Re: SLING-7613 - un-deprecating loginAdministrative

2018-07-17 Thread Justin Edelson
> though? This also needs additional work to actually create the service user > and make a service mapping config for it. > Not that I am disagreeing with what you are saying because I think the > service user is also a bit too complex sometimes > > Greets > Roy > > > O

Re: SLING-7613 - un-deprecating loginAdministrative

2018-07-17 Thread Justin Edelson
+1 to the idea of removing the deprecation -0 on the PR Without the deprecation, how will a developer know that they need to configure the whitelist? While the deprecation wasn't perfect, at least it gave the developer the sense that they were doing something which should be avoided. It is

Re: Issue with Animal Snigger Maven Plugin

2018-07-10 Thread Justin Edelson
I don't know if this is necessarily related to the problem you are having, but FWIW, doing this will cause problems on case-insensitive filesystems -- depending on the compile sequencing (I assume it is the sequence in the file, but I'm not sure), the class file for Check will overwrite the class

Re: New "capabilities" module, feedback welcome

2018-06-27 Thread Justin Edelson
Hi Joerg, Even when a servlet is bound by resource type, it still assigned a resource entry. If you look at /system/console/status-jcrresolver (which is incorrectly named, but that's another story) on a running Sling instance with some servlets installed, you'll see entries for each servlet under

Re: New "capabilities" module, feedback welcome

2018-06-21 Thread Justin Edelson
One thing I noticed in the example is the (apparent) use of the class name as the namespace. While there doesn't appear to be anything in the API to encourage or require this (if anything the opposite), I'd suggest updating the example to use something that wasn't an implementation detail so that

[jira] [Commented] (SLING-7624) Add OSGi7 component property annotations for Servlet and Filter

2018-05-13 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473503#comment-16473503 ] Justin Edelson commented on SLING-7624: --- Sorry, didn't understand that restriction

[jira] [Commented] (SLING-7624) Add OSGi7 component property annotations for Servlet and Filter

2018-05-13 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473486#comment-16473486 ] Justin Edelson commented on SLING-7624: --- IMO, there is some unnecessary verbosity here. {code:java

[jira] [Updated] (SLING-7586) [Sling Models] Memory Leak in cached adapters

2018-04-17 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-7586: -- Description: There is a potential memory leak in the adapterCache in ModelAdapterFactory when

[jira] [Updated] (SLING-7586) [Sling Models] Memory Leak in cached adapters

2018-04-17 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-7586: -- Affects Version/s: Sling Models Impl 1.4.0 Sling Models Impl 1.4.2

[jira] [Created] (SLING-7586) [Sling Models] Memory Leak in cached adapters

2018-04-17 Thread Justin Edelson (JIRA)
Justin Edelson created SLING-7586: - Summary: [Sling Models] Memory Leak in cached adapters Key: SLING-7586 URL: https://issues.apache.org/jira/browse/SLING-7586 Project: Sling Issue Type

[jira] [Comment Edited] (SLING-7584) Only the last DisposalCallbackRegistry is disposed when multiple models are adapted in the same request

2018-04-16 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439818#comment-16439818 ] Justin Edelson edited comment on SLING-7584 at 4/16/18 6:22 PM: pull

[jira] [Commented] (SLING-7584) Only the last DisposalCallbackRegistry is disposed when multiple models are adapted in the same request

2018-04-16 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439818#comment-16439818 ] Justin Edelson commented on SLING-7584: --- pull request:  https://github.com/apache/sling-org-apache

[jira] [Created] (SLING-7584) Only the last DisposalCallbackRegistry is disposed when multiple models are adapted in the same request

2018-04-16 Thread Justin Edelson (JIRA)
Justin Edelson created SLING-7584: - Summary: Only the last DisposalCallbackRegistry is disposed when multiple models are adapted in the same request Key: SLING-7584 URL: https://issues.apache.org/jira/browse

Re: Bundle version for SNAPSHOTs generated by bnd-maven-plugin

2018-04-09 Thread Justin Edelson
tp://bnd.bndtools.org/macros/tstamp.html>), this could be a problem in > certain cases where you redeploy two builds within the same minute. > > > > On 9. Apr 2018, at 15:55, Justin Edelson <jus...@justinedelson.com> > wrote: > > > > I'm not sure this is problematic from

Re: Bundle version for SNAPSHOTs generated by bnd-maven-plugin

2018-04-09 Thread Justin Edelson
I'm not sure this is problematic from the perspective of the installer. The point of the different SNAPSHOT handling is to support the use case of updating a bundle with the *same* bundle version. However, if the bundle versions are including a timestamp, it isn't needed since the bundle versions

[jira] [Comment Edited] (SLING-7508) StackOverflowError adapting ServletResource to Sling Model with impl picker

2018-02-26 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377598#comment-16377598 ] Justin Edelson edited comment on SLING-7508 at 2/26/18 9:26 PM: sorry

[jira] [Resolved] (SLING-7508) StackOverflowError adapting ServletResource to Sling Model with impl picker

2018-02-26 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-7508. --- Resolution: Fixed > StackOverflowError adapting ServletResource to Sling Model with i

[jira] [Commented] (SLING-7508) StackOverflowError adapting ServletResource to Sling Model with impl picker

2018-02-26 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377598#comment-16377598 ] Justin Edelson commented on SLING-7508: --- sorry [~diru] was on vacation. the patch looks good to me

[jira] [Updated] (SLING-7508) StackOverflowError adapting ServletResource to Sling Model with impl picker

2018-02-26 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-7508: -- Fix Version/s: Sling Models Impl 1.4.8 > StackOverflowError adapting ServletResource to Sl

[jira] [Assigned] (SLING-7508) StackOverflowError adapting ServletResource to Sling Model with impl picker

2018-02-26 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson reassigned SLING-7508: - Assignee: Justin Edelson > StackOverflowError adapting ServletResource to Sling Mo

[jira] [Resolved] (SLING-7517) Memory Leak for "fake" Request objects in ModelAdapterFactory with interface-based models

2018-02-26 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-7517. --- Resolution: Fixed Fixed with b1ac26cfe2a6b4c6c20bbe30c5d2b3191e8bb5dc > Memory L

[jira] [Updated] (SLING-7517) Memory Leak for "fake" Request objects in ModelAdapterFactory with interface-based models

2018-02-26 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-7517: -- Summary: Memory Leak for "fake" Request objects in ModelAdapterFactory with inter

[jira] [Updated] (SLING-7517) CLONE - Memory Leak for "fake" Request objects in ModelAdapterFactory

2018-02-26 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-7517: -- Description: The functionality added in SLING-5668 to dispose of OSGi services (or anything

[jira] [Created] (SLING-7517) CLONE - Memory Leak for "fake" Request objects in ModelAdapterFactory

2018-02-26 Thread Justin Edelson (JIRA)
Justin Edelson created SLING-7517: - Summary: CLONE - Memory Leak for "fake" Request objects in ModelAdapterFactory Key: SLING-7517 URL: https://issues.apache.org/jira/browse/SLING-7517 Proj

[jira] [Commented] (SLING-7344) Jackson Sling Model Exporter needs correct character encoding

2018-02-12 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361002#comment-16361002 ] Justin Edelson commented on SLING-7344: --- {quote}FWIW, there is no "right" approach for

[jira] [Commented] (SLING-7344) Jackson Sling Model Exporter needs correct character encoding

2018-02-09 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16358605#comment-16358605 ] Justin Edelson commented on SLING-7344: --- Jetty does the right thing for the text/json content type

[jira] [Commented] (SLING-7344) Jackson Sling Model Exporter needs correct character encoding

2018-02-09 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16358369#comment-16358369 ] Justin Edelson commented on SLING-7344: --- [~reschke] the problem is that unless we set the charset

[jira] [Resolved] (SLING-7470) Memory Leak for "fake" Request objects in ModelAdapterFactory

2018-02-02 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-7470. --- Resolution: Fixed Fixed by  https://github.com/apache/sling-org-apache-sling-models-impl

[jira] [Created] (SLING-7470) Memory Leak for "fake" Request objects in ModelAdapterFactory

2018-02-02 Thread Justin Edelson (JIRA)
Justin Edelson created SLING-7470: - Summary: Memory Leak for "fake" Request objects in ModelAdapterFactory Key: SLING-7470 URL: https://issues.apache.org/jira/browse/SLING-7470 Proj

[jira] [Resolved] (SLING-7344) Jackson Sling Model Exporter needs correct character encoding

2018-01-30 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-7344. --- Resolution: Fixed Although I still think this is really a bug in Jetty, we have already

[jira] [Assigned] (SLING-7344) Jackson Sling Model Exporter needs correct character encoding

2018-01-30 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson reassigned SLING-7344: - Assignee: Justin Edelson Fix Version/s: Sling Models Impl 1.4.8 Component

[jira] [Resolved] (SLING-7321) ChildResourceViaProvider should be able to deal with SlingHttpServletRequest

2017-12-21 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-7321. --- Resolution: Fixed Assignee: Justin Edelson Pull request merged. Thanks a bunch

[jira] [Commented] (SLING-7321) ChildResourceViaProvider should be able to deal with SlingHttpServletRequest

2017-12-21 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300274#comment-16300274 ] Justin Edelson commented on SLING-7321: --- I have a few stylistic comments to make in GitHub

[jira] [Commented] (SLING-7307) Sling Model impl should not embed beanutils

2017-12-13 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289406#comment-16289406 ] Justin Edelson commented on SLING-7307: --- True, but for the worst possible reason. Fixed in https

[jira] [Resolved] (SLING-7307) Sling Model impl should not embed beanutils

2017-12-13 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-7307. --- Resolution: Fixed PR Merged > Sling Model impl should not embed beanut

[jira] [Commented] (SLING-7307) Sling Model impl should not embed beanutils

2017-12-12 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287787#comment-16287787 ] Justin Edelson commented on SLING-7307: --- Looking at where this is used, I think it is a trivial

[jira] [Updated] (SLING-7307) Sling Model impl should not embed beanutils

2017-12-12 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-7307: -- Fix Version/s: Sling Models Impl 1.4.8 > Sling Model impl should not embed beanut

[jira] [Assigned] (SLING-7307) Sling Model impl should not embed beanutils

2017-12-12 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson reassigned SLING-7307: - Assignee: Justin Edelson > Sling Model impl should not embed beanut

[jira] [Updated] (SLING-7307) Sling Model impl should not embed beanutils

2017-12-12 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-7307: -- Component/s: (was: General) Extensions > Sling Model impl should not em

[jira] [Closed] (SLING-7292) Only add model object to disposal registry if it is not empty

2017-12-12 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson closed SLING-7292. - > Only add model object to disposal registry if it is not em

[jira] [Closed] (SLING-7283) ModelPackageBundleListener: lower log level when registering servlets

2017-12-12 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson closed SLING-7283. - > ModelPackageBundleListener: lower log level when registering servl

[jira] [Closed] (SLING-7187) Use of Injector-specific annotation and @Optional results in required-value

2017-12-12 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson closed SLING-7187. - > Use of Injector-specific annotation and @Optional results in required-va

[jira] [Closed] (SLING-5668) Models: Leverage ServletRequestListener.requestDestroyed for calling DisposalCallback in case the model was created from a request

2017-12-12 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson closed SLING-5668. - > Models: Leverage ServletRequestListener.requestDestroyed for calling > DisposalCallback i

[jira] [Closed] (SLING-7124) Allow PostConstruct method to return false to indicate that a model object should not be returned

2017-12-12 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson closed SLING-7124. - > Allow PostConstruct method to return false to indicate that a model object >

[RESULT] [VOTE] Release Apache Sling Models Impl version 1.4.6

2017-12-12 Thread Justin Edelson
The vote has passed with 3 votes: +1: Stefan Seifert, Robert Munteanu, Justin Edelson On Fri, Dec 8, 2017 at 10:46 AM Justin Edelson <jus...@justinedelson.com> wrote: > Hi, > > We solved 6 issues in this release: > https://issues.apache.org/jira/projects/SLING/versions/12

Re: [VOTE] Release Apache Sling Models Impl version 1.4.6

2017-12-12 Thread Justin Edelson
+1 On Tue, Dec 12, 2017 at 10:17 AM Robert Munteanu <romb...@apache.org> wrote: > On Fri, 2017-12-08 at 15:46 +0000, Justin Edelson wrote: > > Please vote to approve this release: > > +1 > > Robert

Re: [VOTE] Release Apache Sling Models Impl version 1.4.6

2017-12-12 Thread Justin Edelson
Anyone else care to vote on this? Thanks. On Fri, Dec 8, 2017 at 11:07 AM Stefan Seifert wrote: > +1 >

[VOTE] Release Apache Sling Models Impl version 1.4.6

2017-12-08 Thread Justin Edelson
Hi, We solved 6 issues in this release: https://issues.apache.org/jira/projects/SLING/versions/12341409 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1831/ You can use this UNIX script to download the release and verify the signatures:

[jira] [Resolved] (SLING-7292) Only add model object to disposal registry if it is not empty

2017-12-08 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-7292. --- Resolution: Fixed Fixed with 56acddf62e55653283d750a938228aea3030b78b > Only add mo

[jira] [Created] (SLING-7292) Only add model object to disposal registry if it is not empty

2017-12-08 Thread Justin Edelson (JIRA)
Justin Edelson created SLING-7292: - Summary: Only add model object to disposal registry if it is not empty Key: SLING-7292 URL: https://issues.apache.org/jira/browse/SLING-7292 Project: Sling

[jira] [Resolved] (SLING-5668) Models: Leverage ServletRequestListener.requestDestroyed for calling DisposalCallback in case the model was created from a request

2017-12-08 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-5668. --- Resolution: Fixed Assignee: Justin Edelson > Models: Lever

[jira] [Updated] (SLING-5668) Models: Leverage ServletRequestListener.requestDestroyed for calling DisposalCallback in case the model was created from a request

2017-12-08 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-5668: -- Fix Version/s: Sling Models Impl 1.4.6 > Models: Lever

[jira] [Commented] (SLING-5668) Models: Leverage ServletRequestListener.requestDestroyed for calling DisposalCallback in case the model was created from a request

2017-12-07 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282289#comment-16282289 ] Justin Edelson commented on SLING-5668: --- [~kwin] do you want to review this pull request? I found

[jira] [Commented] (SLING-7257) Sling Models injector for resolving paths stored in the repo

2017-11-20 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16259561#comment-16259561 ] Justin Edelson commented on SLING-7257: --- Leaving aside the Tags-specific piece (which appears

Re: value level encryption

2017-11-03 Thread Justin Edelson
graphy, and then that would allow people who needed a higher level to > install their own providers. Is this something that Sling would be > interested in? Since I'm going to be writing this, if you're interested, > I'd rather write it with the intent of directly donating it. > > >

Re: value level encryption

2017-11-03 Thread Justin Edelson
We have this in our commercial product. At a high level, the way it works is that there is a PostProcessor which looks for an @Encrypted postfixed property and, if that is present, the corresponding property is stored in an encrypted fashion. Decryption is all done manually, although personally

Re: What to do with github.com/apache/sling (was [git] Migration to git repositories sort of complete)

2017-10-22 Thread Justin Edelson
+1 Great solution. On Sat, Oct 21, 2017 at 3:26 PM Robert Munteanu wrote: > On Fri, 2017-10-20 at 23:19 +0200, Robert Munteanu wrote: > > I guess the 'minimal damage' approach would be to switch the main > > branch and make that empty, with just a README.md . > > > > Would

[jira] [Commented] (SLING-7203) Sling Model Request-Scoped Caching Not Effective Across Script Include Boundaries

2017-10-17 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207730#comment-16207730 ] Justin Edelson commented on SLING-7203: --- One thing which could work would be to unwind the request

[jira] [Commented] (SLING-7203) Sling Model Request-Scoped Caching Not Effective Across Script Include Boundaries

2017-10-17 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207721#comment-16207721 ] Justin Edelson commented on SLING-7203: --- Thinking about this some more, unwinding the wrapping would

[jira] [Created] (SLING-7203) Sling Model Request-Scoped Caching Not Effective Across Script Include Boundaries

2017-10-17 Thread Justin Edelson (JIRA)
Justin Edelson created SLING-7203: - Summary: Sling Model Request-Scoped Caching Not Effective Across Script Include Boundaries Key: SLING-7203 URL: https://issues.apache.org/jira/browse/SLING-7203

Re: [git] Migration scheduled for 18 Oct, 22:00 CEST and final notes

2017-10-17 Thread Justin Edelson
On Tue, Oct 17, 2017 at 8:49 AM Robert Munteanu wrote: > > > Perhaps the people that actually work with these multi-project > extensions would like to comment? By a quick check we have: > > - models > > The models bundles can be released independently, i.e. I've done a number

Re: [NOTICE] Getting ready to start the SVN → Git migration

2017-10-12 Thread Justin Edelson
On Thu, Oct 12, 2017 at 4:42 PM Stefan Seifert wrote: > >BTW, not sure what the access rule for users@infra are, but you should > >be able to access https://lists.apache.org/list.html?users@infra.apache > >.org and then log in with your ASF credentials. I think it works

[jira] [Assigned] (SLING-7187) Use of Injector-specific annotation and @Optional results in required-value

2017-10-10 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson reassigned SLING-7187: - Assignee: Justin Edelson > Use of Injector-specific annotation and @Optional resu

[jira] [Commented] (SLING-7187) Use of Injector-specific annotation and @Optional results in required-value

2017-10-10 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199005#comment-16199005 ] Justin Edelson commented on SLING-7187: --- I did find one additional oddity. {code} @ValueMapValue

[jira] [Resolved] (SLING-7187) Use of Injector-specific annotation and @Optional results in required-value

2017-10-10 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-7187. --- Resolution: Fixed fixed in r1811741 > Use of Injector-specific annotation and @Optio

[jira] [Commented] (SLING-7187) Use of Injector-specific annotation and @Optional results in required-value

2017-10-10 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198999#comment-16198999 ] Justin Edelson commented on SLING-7187: --- bq. The patch in general looks fine but it would modify

[jira] [Comment Edited] (SLING-7187) Use of Injector-specific annotation and @Optional results in required-value

2017-10-10 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198835#comment-16198835 ] Justin Edelson edited comment on SLING-7187 at 10/10/17 5:16 PM: - patch

[jira] [Updated] (SLING-7187) Use of Injector-specific annotation and @Optional results in required-value

2017-10-10 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-7187: -- Attachment: SLING-7187.diff patch attached. [~kwindszus] can you take a look at this since I

[jira] [Created] (SLING-7187) Use of Injector-specific annotation and @Optional results in required-value

2017-10-10 Thread Justin Edelson (JIRA)
Justin Edelson created SLING-7187: - Summary: Use of Injector-specific annotation and @Optional results in required-value Key: SLING-7187 URL: https://issues.apache.org/jira/browse/SLING-7187 Project

[jira] [Commented] (SLING-7174) Using MockSlingHttpServletRequest for In-Sling Rendering fails when used with Export Servlet

2017-10-02 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188675#comment-16188675 ] Justin Edelson commented on SLING-7174: --- that's just me forgetting to commit a file. Should be fixed

[jira] [Resolved] (SLING-7174) Using MockSlingHttpServletRequest for In-Sling Rendering fails when used with Export Servlet

2017-10-02 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-7174. --- Resolution: Fixed > Using MockSlingHttpServletRequest for In-Sling Rendering fails when u

[jira] [Commented] (SLING-7174) Using MockSlingHttpServletRequest for In-Sling Rendering fails when used with Export Servlet

2017-10-02 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188487#comment-16188487 ] Justin Edelson commented on SLING-7174: --- Fixed in r1810562/r1810564 by properly implementing

[jira] [Updated] (SLING-7174) Using MockSlingHttpServletRequest for In-Sling Rendering fails when used with Export Servlet

2017-10-02 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-7174: -- Fix Version/s: Sling Models Impl 1.4.6 Servlet Helpers 1.1.2 > Us

[jira] [Commented] (SLING-7174) Using MockSlingHttpServletRequest for In-Sling Rendering fails when used with Export Servlet

2017-10-02 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188477#comment-16188477 ] Justin Edelson commented on SLING-7174: --- bq. If that Request / Response pair if for In-Sling

[jira] [Assigned] (SLING-7174) Using MockSlingHttpServletRequest for In-Sling Rendering fails when used with Export Servlet

2017-10-02 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson reassigned SLING-7174: - Assignee: Justin Edelson > Using MockSlingHttpServletRequest for In-Sling Render

[jira] [Commented] (SLING-7174) Using MockSlingHttpServletRequest for In-Sling Rendering fails when used with Export Servlet

2017-10-02 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188425#comment-16188425 ] Justin Edelson commented on SLING-7174: --- bq. In my opinion Sling should provide a Request / Response

  1   2   3   4   5   6   7   8   9   10   >