[GitHub] sling-site issue #2: Update manipulating-content-the-slingpostservlet-servle...

2017-10-06 Thread bdelacretaz
Github user bdelacretaz commented on the issue: https://github.com/apache/sling-site/pull/2 The proposed changes look good to me in principle, thank you very much! But do we have tests of those features? I don't remember the details off the top of my head and I'd like to make sure

[GitHub] sling-site pull request #1: TODO does commit to github work?

2017-09-29 Thread bdelacretaz
Github user bdelacretaz closed the pull request at: https://github.com/apache/sling-site/pull/1 ---

[GitHub] sling-site issue #1: TODO does commit to github work?

2017-09-29 Thread bdelacretaz
Github user bdelacretaz commented on the issue: https://github.com/apache/sling-site/pull/1 Looks like we need to move to gitbox to be able to merge PRs from github, will look at that. ---

[GitHub] sling-site pull request #1: TODO does commit to github work?

2017-09-29 Thread bdelacretaz
GitHub user bdelacretaz opened a pull request: https://github.com/apache/sling-site/pull/1 TODO does commit to github work? You can merge this pull request into a Git repository by running: $ git pull https://github.com/bdelacretaz/sling-site patch-1 Alternatively you can

[GitHub] sling pull request #242: SLING-6422: add to Nitin's patch a comparison that ...

2017-06-13 Thread bdelacretaz
GitHub user bdelacretaz opened a pull request: https://github.com/apache/sling/pull/242 SLING-6422: add to Nitin's patch a comparison that ignores ordering of restrictions You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] sling pull request #181: Issue/sling 5135

2016-10-11 Thread bdelacretaz
Github user bdelacretaz closed the pull request at: https://github.com/apache/sling/pull/181 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] sling pull request #181: Issue/sling 5135

2016-10-11 Thread bdelacretaz
GitHub user bdelacretaz opened a pull request: https://github.com/apache/sling/pull/181 Issue/sling 5135 Ready to commit this You can merge this pull request into a Git repository by running: $ git pull https://github.com/bdelacretaz/sling issue/SLING-5135 Alternatively you