[jira] [Commented] (SLING-12131) Update sling-parent pom.xml to include JUnit5 dependencies

2023-11-27 Thread Rob McDougall (Jira)
[ https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790081#comment-17790081 ] Rob McDougall commented on SLING-12131: --- PR Created Discretion being the better part of valour, I

[jira] [Commented] (SLING-12131) Update sling-parent pom.xml to include JUnit5 dependencies

2023-11-09 Thread Rob McDougall (Jira)
[ https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784482#comment-17784482 ] Rob McDougall commented on SLING-12131: --- OK, will do.  Thanks for the pointers. > Update

[jira] [Commented] (SLING-12131) Update sling-parent pom.xml to include JUnit5 dependencies

2023-11-08 Thread Julian Sedding (Jira)
[ https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784238#comment-17784238 ] Julian Sedding commented on SLING-12131: We have {{org.apache.sling.testing.osgi-mock}} and

[jira] [Commented] (SLING-12131) Update sling-parent pom.xml to include JUnit5 dependencies

2023-11-08 Thread Rob McDougall (Jira)
[ https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784231#comment-17784231 ] Rob McDougall commented on SLING-12131: --- {quote}So I think we're finding common ground :) I'm

[jira] [Commented] (SLING-12131) Update sling-parent pom.xml to include JUnit5 dependencies

2023-11-08 Thread Julian Sedding (Jira)
[ https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784213#comment-17784213 ] Julian Sedding commented on SLING-12131: bq. I've used this before and it works well, [...]

[jira] [Commented] (SLING-12131) Update sling-parent pom.xml to include JUnit5 dependencies

2023-11-08 Thread Rob McDougall (Jira)
[ https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784163#comment-17784163 ] Rob McDougall commented on SLING-12131: --- {quote}A quick google turned up that the OpenRewrite

[jira] [Commented] (SLING-12131) Update sling-parent pom.xml to include JUnit5 dependencies

2023-11-08 Thread Rob McDougall (Jira)
[ https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784161#comment-17784161 ] Rob McDougall commented on SLING-12131: --- So, at this point, I think no-one is arguing that the

[jira] [Commented] (SLING-12131) Update sling-parent pom.xml to include JUnit5 dependencies

2023-11-08 Thread Julian Sedding (Jira)
[ https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784146#comment-17784146 ] Julian Sedding commented on SLING-12131: If migration is the goal, then it may make sense to

[jira] [Commented] (SLING-12131) Update sling-parent pom.xml to include JUnit5 dependencies

2023-11-08 Thread Rob McDougall (Jira)
[ https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784113#comment-17784113 ] Rob McDougall commented on SLING-12131: --- > Testing dependencies are never transitive and therefore

[jira] [Commented] (SLING-12131) Update sling-parent pom.xml to include JUnit5 dependencies

2023-11-08 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784105#comment-17784105 ] Konrad Windszus commented on SLING-12131: - Testing dependencies are never transitive and

[jira] [Commented] (SLING-12131) Update sling-parent pom.xml to include JUnit5 dependencies

2023-11-08 Thread Rob McDougall (Jira)
[ https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784085#comment-17784085 ] Rob McDougall commented on SLING-12131: --- > Also, there is virtually no value in doing so, because

[jira] [Commented] (SLING-12131) Update sling-parent pom.xml to include JUnit5 dependencies

2023-11-08 Thread Julian Sedding (Jira)
[ https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784022#comment-17784022 ] Julian Sedding commented on SLING-12131: bq. Let us please just import the JUnit BOM [...] +1

[jira] [Commented] (SLING-12131) Update sling-parent pom.xml to include JUnit5 dependencies

2023-11-08 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784018#comment-17784018 ] Konrad Windszus commented on SLING-12131: - Let us please just import the JUnit BOM in the

[jira] [Commented] (SLING-12131) Update sling-parent pom.xml to include JUnit5 dependencies

2023-11-08 Thread Julian Sedding (Jira)
[ https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784016#comment-17784016 ] Julian Sedding commented on SLING-12131: AFAIK the latest maven-surefire-plugin automatically