[
https://issues.apache.org/jira/browse/SLING-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14552641#comment-14552641
]
Stefan Seifert commented on SLING-3709:
---
this is a big bunch of changes - i could
[
https://issues.apache.org/jira/browse/SLING-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14552413#comment-14552413
]
Konrad Windszus commented on SLING-3709:
I now rely again on the exception classes
[
https://issues.apache.org/jira/browse/SLING-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14338339#comment-14338339
]
Konrad Windszus commented on SLING-3709:
Basically this is working. But I do not
[
https://issues.apache.org/jira/browse/SLING-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14288387#comment-14288387
]
Stefan Seifert commented on SLING-3709:
---
[~kwin] is there any work left on this
[
https://issues.apache.org/jira/browse/SLING-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14241039#comment-14241039
]
Konrad Windszus commented on SLING-3709:
pushed a documentation update in rev.
[
https://issues.apache.org/jira/browse/SLING-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14209465#comment-14209465
]
ASF GitHub Bot commented on SLING-3709:
---
Github user kwin closed the pull request
[
https://issues.apache.org/jira/browse/SLING-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14156135#comment-14156135
]
Konrad Windszus commented on SLING-3709:
Hi [~justinedelson], thanks a lot for
[
https://issues.apache.org/jira/browse/SLING-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14155401#comment-14155401
]
Justin Edelson commented on SLING-3709:
---
In r1628824, I committed a version of this.
[
https://issues.apache.org/jira/browse/SLING-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14130551#comment-14130551
]
Konrad Windszus commented on SLING-3709:
[~justinedelson] Would you mind taking
[
https://issues.apache.org/jira/browse/SLING-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113779#comment-14113779
]
Stefan Seifert commented on SLING-3709:
---
in my example {{Models}} would be a helper
[
https://issues.apache.org/jira/browse/SLING-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113815#comment-14113815
]
Konrad Windszus commented on SLING-3709:
[~sseif...@pro-vision.de] I still don't
[
https://issues.apache.org/jira/browse/SLING-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113842#comment-14113842
]
Stefan Seifert commented on SLING-3709:
---
my example was not targeted at the sightly
[
https://issues.apache.org/jira/browse/SLING-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14109354#comment-14109354
]
Konrad Windszus commented on SLING-3709:
Thanks for the review. Regarding your
[
https://issues.apache.org/jira/browse/SLING-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092704#comment-14092704
]
Konrad Windszus commented on SLING-3709:
I enriched the PR to also use the same
[
https://issues.apache.org/jira/browse/SLING-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14087657#comment-14087657
]
ASF GitHub Bot commented on SLING-3709:
---
GitHub user kwin opened a pull request:
[
https://issues.apache.org/jira/browse/SLING-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14087663#comment-14087663
]
Konrad Windszus commented on SLING-3709:
[~justinedelson] The PR contains a first
[
https://issues.apache.org/jira/browse/SLING-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14086356#comment-14086356
]
Konrad Windszus commented on SLING-3709:
Since the discussion at
[
https://issues.apache.org/jira/browse/SLING-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14086993#comment-14086993
]
Justin Edelson commented on SLING-3709:
---
[~kwin] I'm not sure I understand what you
[
https://issues.apache.org/jira/browse/SLING-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14051269#comment-14051269
]
Konrad Windszus commented on SLING-3709:
It seems that throwing a RuntimeException
[
https://issues.apache.org/jira/browse/SLING-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14051365#comment-14051365
]
Justin Edelson commented on SLING-3709:
---
No. Such a change violates the contract of
[
https://issues.apache.org/jira/browse/SLING-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14047787#comment-14047787
]
Justin Edelson commented on SLING-3709:
---
I think this needs to be handled at the
[
https://issues.apache.org/jira/browse/SLING-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14047794#comment-14047794
]
Stefan Seifert commented on SLING-3709:
---
thinking about extending the adaptTo API
[
https://issues.apache.org/jira/browse/SLING-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14047980#comment-14047980
]
Justin Edelson commented on SLING-3709:
---
Created SLING-3714 for the generic concept
23 matches
Mail list logo
