Re: Thread Names for Sling Thread Support?

There were no objections to the latest proposed thread name format, so I committed the corresponding changes in https://svn.apache.org/r1718272. Regards Julian On Wed, Dec 2, 2015 at 4:04 PM, Bertrand Delacretaz wrote: > On Wed, Dec 2, 2015 at 2:22 PM, Julian Sedding

Re: Thread Names for Sling Thread Support?

On Wed, Dec 2, 2015 at 2:22 PM, Julian Sedding wrote: > ...If the pool name is "Job Thread Pool", a possible thread name would be > "sling-job-thread-pool-23" Works for me, dashes or underscores are fine. -Bertrand

Re: Thread Names for Sling Thread Support?

Maybe it's just nitpicking, but you're already using the dash as a seperator character. IMHO underscore or some other replacement character would be preferable. Regards Matthias 2015-12-02 14:22 GMT+01:00 Julian Sedding : > Ok, let's replace spaces with dashes. And

Re: Thread Names for Sling Thread Support?

On Tue, 2015-12-01 at 17:41 +0100, Bertrand Delacretaz wrote: > On Tue, Dec 1, 2015 at 2:58 PM, Carsten Ziegeler g> wrote: > > ...I would prefer a name without spaces. Makes > > parsing the log files easier... > > +1 > > Maybe just replace spaces in pool names with a dash.

Re: Thread Names for Sling Thread Support?

Ok, let's replace spaces with dashes. And lower-case the whole thing (for aesthetic reasons). I.e. sling--. If the pool name is "Job Thread Pool", a possible thread name would be "sling-job-thread-pool-23". Would that be fine? Regards Julian On Wed, Dec 2, 2015 at 2:00 PM, Robert Munteanu

Thread Names for Sling Thread Support?

Hi all Sling Thread Support (aka Commons Threads) uses an underlying java.util.concurrent.ThreadPoolExecutor. By default this leads to thread names like "pool-1-thread-5". I was wondering whether we should change the thread names so it is clear they are being managed by Sling Thread Support.

Re: Thread Names for Sling Thread Support?

I’m in favour for changing the thread names to the format "Apache Sling - -Thread #” Konrad > On 01 Dec 2015, at 10:15, Julian Sedding wrote: > > Hi all > > Sling Thread Support (aka Commons Threads) uses an underlying > java.util.concurrent.ThreadPoolExecutor. By default

Re: Thread Names for Sling Thread Support?

It would be better to keep it short as it get used in logs/stacktrace etc. So something like "sling--" Chetan Mehrotra On Tue, Dec 1, 2015 at 2:48 PM, Konrad Windszus wrote: > I’m in favour for changing the thread names to the format "Apache Sling - > -Thread #” > Konrad > >

Re: Thread Names for Sling Thread Support?

On Tue, Dec 1, 2015 at 10:35 AM, Chetan Mehrotra wrote: > ...It would be better to keep it short as it get used in logs/stacktrace > etc. So something like "sling--" ... +1 -Bertrand

Re: Thread Names for Sling Thread Support?

Are we "allowed" to abbreviate "Apache Sling" to "sling"? The pool name can be set by configuration or by a consuming bundle, e.g. "Apache Sling Job Thread Pool" is set by the EventingThreadPool implementation. Therefore I lean to a mixed-case format (despite the fact that I normally prefer all

Re: Thread Names for Sling Thread Support?

FYI, I created https://issues.apache.org/jira/browse/SLING-5343 with a proposed patch attached. Regards Julian On Tue, Dec 1, 2015 at 11:12 AM, Julian Sedding wrote: > Are we "allowed" to abbreviate "Apache Sling" to "sling"? > > The pool name can be set by configuration or

Re: Thread Names for Sling Thread Support?

On Tue, Dec 1, 2015 at 11:12 AM, Julian Sedding wrote: > ...Are we "allowed" to abbreviate "Apache Sling" to "sling"?... For technical names yes, of course...if you see "sling" in a system that's running Apache Sling there's no possible confusion ;-) -Bertrand

RE: Thread Names for Sling Thread Support?

>It would be better to keep it short as it get used in logs/stacktrace >etc. So something like "sling--" +1

RE: Thread Names for Sling Thread Support?

+1 On Dec 1, 2015 5:55 AM, "Stefan Seifert" wrote: > >It would be better to keep it short as it get used in logs/stacktrace > >etc. So something like "sling--" > > +1 >

Re: Thread Names for Sling Thread Support?

Hi Bertrand I just added more tests to also cover the refactored priority logic (https://svn.apache.org/r1717440). Regards Julian On Tue, Dec 1, 2015 at 2:43 PM, Bertrand Delacretaz wrote: > Hi, > > On Tue, Dec 1, 2015 at 2:38 PM, Bertrand Delacretaz >

Re: Thread Names for Sling Thread Support?

On Tue, Dec 1, 2015 at 2:20 PM, Julian Sedding wrote: > Thanks for your inputs. I went ahead and committed the change > (https://svn.apache.org/r1717425). That's https://svn.apache.org/r1717424 actually. -Bertrand

Re: Thread Names for Sling Thread Support?

Julian Sedding wrote > Thanks for your inputs. I went ahead and committed the change > (https://svn.apache.org/r1717425). > > The format is "Sling - #". If someone has a > strong preference for an alternative, please go ahead and change it. > It uses String#format(). > Maybe I'm the only one,

Re: Thread Names for Sling Thread Support?

Hi, On Tue, Dec 1, 2015 at 2:38 PM, Bertrand Delacretaz wrote: > ...That's https://svn.apache.org/r1717424 actually... That revision includes changes to the ExtendedThreadFactory.convertPriority method, is that on purpose? Looks unrelated to the thread name change.

Re: Thread Names for Sling Thread Support?

Thanks for your inputs. I went ahead and committed the change (https://svn.apache.org/r1717425). The format is "Sling - #". If someone has a strong preference for an alternative, please go ahead and change it. It uses String#format(). Regards Julian On Tue, Dec 1, 2015 at 11:57 AM, Daniel Klco

Re: Thread Names for Sling Thread Support?

Thanks for catching the revision error. The priority related changes don't change behaviour. In order to de-clutter the constructor I moved the switch statement to the new convertPriority method and slightly simplified it at the same time. Regards Julian On Tue, Dec 1, 2015 at 2:43 PM, Bertrand

Re: Thread Names for Sling Thread Support?

On Tue, Dec 1, 2015 at 2:58 PM, Carsten Ziegeler wrote: > Julian Sedding wrote >> Thanks for your inputs. I went ahead and committed the change >> (https://svn.apache.org/r1717425). >> >> The format is "Sling - #". If someone has a >> strong preference for an alternative,

Re: Thread Names for Sling Thread Support?

On Tue, Dec 1, 2015 at 2:58 PM, Carsten Ziegeler wrote: > ...I would prefer a name without spaces. Makes > parsing the log files easier... +1 Maybe just replace spaces in pool names with a dash. -Bertrand