Re: Metrics Web Console plugin always outputs Histograms as durations

[Chetan Mehrotra]

> duration (rather than the higher-level Timer type). It seems like there
> shouldn't be any manipulation of the values for Histograms and we shouldn't
> output a measurement unit. It would be nice if a metrics provider could
> associate a unit with a Histogram, but that does not seem possible with the

Makes sense. Going forward we would need to see how to augment such
meta info to metrics. So far seen 2 requirements

1. Metric Description - Some text to describe what the metric is all about
2. Unit - For Histograms

Chetan Mehrotra

[RESULT][VOTE] Release Apache Sling Parent version 31

[Konrad Windszus]

Hi, 
The vote has passed with the following result : 
+1 (binding): Robert, Carsten, Karl, Dan

I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.
Thanks for voting,
Konrad

[jira] [Created] (SLING-7036) Remove prerequisites from parent

[Konrad Windszus (JIRA)]

Konrad Windszus created SLING-7036:
--

 Summary: Remove prerequisites from parent
 Key: SLING-7036
 URL: https://issues.apache.org/jira/browse/SLING-7036
 Project: Sling
  Issue Type: Improvement
Affects Versions: Parent 31
Reporter: Konrad Windszus
Assignee: Konrad Windszus
 Fix For: Parent 32


The prerequisites section is still maintained in the sling parent. This was 
only intended for maven plugins (never for type "pom") with Maven 3 
(https://issues.apache.org/jira/browse/MNG-4840) and leads to warnings with 
Maven since 3.4.0 (https://issues.apache.org/jira/browse/MNG-6092). Therefore 
the section should be removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Closed] (SLING-6746) Remove and ban maven-scr-plugin

[Konrad Windszus (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus closed SLING-6746.
--

> Remove and ban maven-scr-plugin
> ---
>
> Key: SLING-6746
> URL: https://issues.apache.org/jira/browse/SLING-6746
> Project: Sling
>  Issue Type: Bug
>  Components: General
>Affects Versions: Parent 30
>Reporter: Konrad Windszus
>Assignee: Stefan Seifert
>Priority: Critical
> Fix For: Parent 31
>
>
> The additional execution of maven-bundle-plugin:manifest being added with 
> SLING-6572 is basically overwriting the service descriptors and metatype 
> resources which are written with maven-scr-plugin with empty files. Those 
> empty files finally end up in the bundle. This affects all modules still 
> leveraging the maven-scr-plugin for generating the service 
> descriptors/metatype resources.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Closed] (SLING-6678) Use maven-bundle-plugin 3.3.0

[Konrad Windszus (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus closed SLING-6678.
--

> Use maven-bundle-plugin 3.3.0
> -
>
> Key: SLING-6678
> URL: https://issues.apache.org/jira/browse/SLING-6678
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Affects Versions: Parent 30
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
> Fix For: Parent 31
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (SLING-7036) Remove prerequisites from parent

[Konrad Windszus (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus resolved SLING-7036.

Resolution: Fixed

Fixed in [r1804428|https://svn.apache.org/r1804428].

> Remove prerequisites from parent
> 
>
> Key: SLING-7036
> URL: https://issues.apache.org/jira/browse/SLING-7036
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: Parent 31
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
> Fix For: Parent 32
>
>
> The prerequisites section is still maintained in the sling parent. This was 
> only intended for maven plugins (never for type "pom") with Maven 3 
> (https://issues.apache.org/jira/browse/MNG-4840) and leads to warnings with 
> Maven since 3.4.0 (https://issues.apache.org/jira/browse/MNG-6092). Therefore 
> the section should be removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-7037) Scheduler does not retain provided name

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16118478#comment-16118478
 ] 

Carsten Ziegeler commented on SLING-7037:
-

Thanks for reporting and your tests [~mreutegg]

I've committed a potential solution in rev 1804434 together with your test case 
and some test cases.
The idea is:
- for whiteboard registered jobs: if a name is part of the properties, this 
name is used as is for the provided name; the name itself is still made unique 
using the service id.
- for whiteboard registered jobs: if no name is part of the properties, 
provided name is null and name will get a generated one (including the service 
id).
- for jobs registered using the api: if a name is provided, this is used as is 
for the provided name
- for jobs registered using the api: if no name is provided, a name is 
generated and provided name is null

> Scheduler does not retain provided name
> ---
>
> Key: SLING-7037
> URL: https://issues.apache.org/jira/browse/SLING-7037
> Project: Sling
>  Issue Type: Bug
>  Components: Commons
>Affects Versions: Commons Scheduler 2.6.0
>Reporter: Marcel Reutegger
>Assignee: Carsten Ziegeler
>Priority: Minor
> Fix For: Commons Scheduler 2.6.4
>
> Attachments: SLING-7037-test.patch
>
>
> The scheduler does not retain the provided name for the job as introduced in 
> SLING-5387.
> The value returned by the JobDataMap is a generated name that include the 
> service id.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Metrics Web Console plugin always outputs Histograms as durations

[Justin Edelson]

On Tue, Aug 8, 2017 at 4:42 AM Chetan Mehrotra 
wrote:

> > duration (rather than the higher-level Timer type). It seems like there
> > shouldn't be any manipulation of the values for Histograms and we
> shouldn't
> > output a measurement unit. It would be nice if a metrics provider could
> > associate a unit with a Histogram, but that does not seem possible with
> the
>
> Makes sense. Going forward we would need to see how to augment such
> meta info to metrics. So far seen 2 requirements
>
> 1. Metric Description - Some text to describe what the metric is all about
> 2. Unit - For Histograms
>

Do you have any thoughts on how this metric metadata can be managed? This
doesn't seem to be something natively supported, so I'm guessing we need to
do that in our wrapper.

Regards,
Justin


>
> Chetan Mehrotra
>

[jira] [Created] (SLING-7038) Update to commons-lang 3.5

[Carsten Ziegeler (JIRA)]

Carsten Ziegeler created SLING-7038:
---

 Summary: Update to commons-lang  3.5
 Key: SLING-7038
 URL: https://issues.apache.org/jira/browse/SLING-7038
 Project: Sling
  Issue Type: Improvement
  Components: JCR
Affects Versions: JCR Resource 3.0.4
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: JCR Resource 3.0.6


JCR Resource currently uses the outdated commons lang 2 library. We should 
update to the more recent 3.x version



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (SLING-7038) Update to commons-lang 3.5

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-7038.
-
Resolution: Fixed

Updated in rev 1804436
In addition removed unused dependencies from the pom

> Update to commons-lang  3.5
> ---
>
> Key: SLING-7038
> URL: https://issues.apache.org/jira/browse/SLING-7038
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Affects Versions: JCR Resource 3.0.4
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: JCR Resource 3.0.6
>
>
> JCR Resource currently uses the outdated commons lang 2 library. We should 
> update to the more recent 3.x version



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (SLING-7037) Scheduler does not retain provided name

[Marcel Reutegger (JIRA)]

Marcel Reutegger created SLING-7037:
---

 Summary: Scheduler does not retain provided name
 Key: SLING-7037
 URL: https://issues.apache.org/jira/browse/SLING-7037
 Project: Sling
  Issue Type: Bug
  Components: Commons
Affects Versions: Commons Scheduler 2.6.0
Reporter: Marcel Reutegger
Priority: Minor


The scheduler does not retain the provided name for the job as introduced in 
SLING-5387.

The value returned by the JobDataMap is a generated name that include the 
service id.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (SLING-7037) Scheduler does not retain provided name

[Marcel Reutegger (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcel Reutegger updated SLING-7037:

Attachment: SLING-7037-test.patch

Attached [^SLING-7037-test.patch] containing a test which shows the described 
behaviour.

> Scheduler does not retain provided name
> ---
>
> Key: SLING-7037
> URL: https://issues.apache.org/jira/browse/SLING-7037
> Project: Sling
>  Issue Type: Bug
>  Components: Commons
>Affects Versions: Commons Scheduler 2.6.0
>Reporter: Marcel Reutegger
>Assignee: Carsten Ziegeler
>Priority: Minor
> Fix For: Commons Scheduler 2.6.4
>
> Attachments: SLING-7037-test.patch
>
>
> The scheduler does not retain the provided name for the job as introduced in 
> SLING-5387.
> The value returned by the JobDataMap is a generated name that include the 
> service id.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (SLING-7037) Scheduler does not retain provided name

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-7037:

Fix Version/s: Commons Scheduler 2.6.4

> Scheduler does not retain provided name
> ---
>
> Key: SLING-7037
> URL: https://issues.apache.org/jira/browse/SLING-7037
> Project: Sling
>  Issue Type: Bug
>  Components: Commons
>Affects Versions: Commons Scheduler 2.6.0
>Reporter: Marcel Reutegger
>Assignee: Carsten Ziegeler
>Priority: Minor
> Fix For: Commons Scheduler 2.6.4
>
>
> The scheduler does not retain the provided name for the job as introduced in 
> SLING-5387.
> The value returned by the JobDataMap is a generated name that include the 
> service id.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (SLING-7037) Scheduler does not retain provided name

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler reassigned SLING-7037:
---

Assignee: Carsten Ziegeler

> Scheduler does not retain provided name
> ---
>
> Key: SLING-7037
> URL: https://issues.apache.org/jira/browse/SLING-7037
> Project: Sling
>  Issue Type: Bug
>  Components: Commons
>Affects Versions: Commons Scheduler 2.6.0
>Reporter: Marcel Reutegger
>Assignee: Carsten Ziegeler
>Priority: Minor
> Fix For: Commons Scheduler 2.6.4
>
>
> The scheduler does not retain the provided name for the job as introduced in 
> SLING-5387.
> The value returned by the JobDataMap is a generated name that include the 
> service id.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)