RE: [VOTE] Release Apache Sling Testing JCR Mock version 1.6.12

2023-12-19 Thread Stefan Seifert
+1 stefan

Re: [PR] Clarify dependency policy of Sling bundles [sling-site]

2023-12-19 Thread via GitHub
cziegeler commented on code in PR #149: URL: https://github.com/apache/sling-site/pull/149#discussion_r1431172707 ## src/main/jbake/content/documentation/development/dependency-management.md: ## @@ -15,22 +15,21 @@ Maven provides projects with a nice feature called dependency

Re: [PR] Clarify dependency policy of Sling bundles [sling-site]

2023-12-19 Thread via GitHub
cziegeler commented on code in PR #149: URL: https://github.com/apache/sling-site/pull/149#discussion_r1431173153 ## src/main/jbake/content/documentation/development/dependency-management.md: ## @@ -15,22 +15,21 @@ Maven provides projects with a nice feature called dependency

Re: [PR] Clarify dependency policy of Sling bundles [sling-site]

2023-12-19 Thread via GitHub
cziegeler commented on code in PR #149: URL: https://github.com/apache/sling-site/pull/149#discussion_r1431173638 ## src/main/jbake/content/documentation/development/dependency-management.md: ## @@ -39,28 +38,21 @@ The parent POM only does dependency management for build time

Re: [PR] Clarify dependency policy of Sling bundles [sling-site]

2023-12-19 Thread via GitHub
cziegeler commented on code in PR #149: URL: https://github.com/apache/sling-site/pull/149#discussion_r1431174010 ## src/main/jbake/content/documentation/development/dependency-management.md: ## @@ -39,28 +38,21 @@ The parent POM only does dependency management for build time

Re: [PR] Clarify dependency policy of Sling bundles [sling-site]

2023-12-19 Thread via GitHub
cziegeler commented on PR #149: URL: https://github.com/apache/sling-site/pull/149#issuecomment-1862457089 I think the changes mentioned are good as it does not explicitly say that we have a policy to not update for security fixes. But it clarifies the important aspect that nevertheless

Re: [PR] SLING-12198 - Extending sling.graphql.engine to allow passing custom graphql ParserOptions. [sling-org-apache-sling-graphql-core]

2023-12-19 Thread via GitHub
bdelacretaz commented on code in PR #39: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/39#discussion_r1431193880 ## src/main/java/org/apache/sling/graphql/core/engine/DefaultQueryExecutor.java: ## @@ -394,6 +417,24 @@ TypeDefinitionRegistry

Re: [PR] SLING-12198 - Extending sling.graphql.engine to allow passing custom graphql ParserOptions. [sling-org-apache-sling-graphql-core]

2023-12-19 Thread via GitHub
sonarcloud[bot] commented on PR #39: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/39#issuecomment-1862557425 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] SLING-12198 - Extending sling.graphql.engine to allow passing custom graphql ParserOptions. [sling-org-apache-sling-graphql-core]

2023-12-19 Thread via GitHub
bdelacretaz commented on code in PR #39: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/39#discussion_r1431268413 ## src/main/java/org/apache/sling/graphql/core/engine/DefaultQueryExecutor.java: ## @@ -394,6 +417,24 @@ TypeDefinitionRegistry

RE: [VOTE] Release Apache Sling JCR Jackrabbit User Manager version 2.2.30

2023-12-19 Thread Stefan Seifert
+1 stefan

Re: [PR] Clarify dependency policy of Sling bundles [sling-site]

2023-12-19 Thread via GitHub
cziegeler commented on code in PR #149: URL: https://github.com/apache/sling-site/pull/149#discussion_r1431176015 ## src/main/jbake/content/project-information/security.md: ## @@ -12,6 +12,10 @@ We strongly encourage folks to report such problems to our private security mail

Re: [PR] SLING-12198 - Extending sling.graphql.engine to allow passing custom graphql ParserOptions. [sling-org-apache-sling-graphql-core]

2023-12-19 Thread via GitHub
sonarcloud[bot] commented on PR #39: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/39#issuecomment-1862482633 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] SLING-12198 - Extending sling.graphql.engine to allow passing custom graphql ParserOptions. [sling-org-apache-sling-graphql-core]

2023-12-19 Thread via GitHub
bdelacretaz commented on PR #39: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/39#issuecomment-1862577214 I have converted this PR to a draft as I'd like @raducotescu to review when you're available. I haven't touched this module's code in a while so I'd prefer

[jira] [Created] (SLING-12204) ResourceResolver: refactor PagedQUeryIterator for re-use

2023-12-19 Thread Julian Reschke (Jira)
Julian Reschke created SLING-12204: -- Summary: ResourceResolver: refactor PagedQUeryIterator for re-use Key: SLING-12204 URL: https://issues.apache.org/jira/browse/SLING-12204 Project: Sling

Re: [PR] SLING-12198 - Extending sling.graphql.engine to allow passing custom graphql ParserOptions. [sling-org-apache-sling-graphql-core]

2023-12-19 Thread via GitHub
sonarcloud[bot] commented on PR #39: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/39#issuecomment-1862601635 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] SLING-12198 - Extending sling.graphql.engine to allow passing custom graphql ParserOptions. [sling-org-apache-sling-graphql-core]

2023-12-19 Thread via GitHub
sonarcloud[bot] commented on PR #39: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/39#issuecomment-1862606142 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] chore(deps): update dependency org.apache.sling:org.apache.sling.engine to v2.15.10 [sling-org-apache-sling-starter]

2023-12-19 Thread via GitHub
renovate-bot opened a new pull request, #290: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/290 [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age |

Re: [PR] SLING-12198 - Extending sling.graphql.engine to allow passing custom graphql ParserOptions. [sling-org-apache-sling-graphql-core]

2023-12-19 Thread via GitHub
sonarcloud[bot] commented on PR #39: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/39#issuecomment-1862608019 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate