[VOTE] Release Apache Sling Resource Resolver 1.1.8
Hi *, We solved 2 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12328780 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1152 You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 1152 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours.
Jenkins build became unstable: sling-trunk-1.8 » Apache Sling Event Support #473
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.event/473/
Jenkins build is still unstable: sling-trunk-1.8 » Apache Sling SlingRepository Integration Tests #473
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.jcr.repository.it-jackrabbit-oak/473/
Jenkins build is unstable: sling-trunk-1.8 #473
See https://builds.apache.org/job/sling-trunk-1.8/473/changes
Jenkins build is still unstable: sling-trunk-1.7 #1184
See https://builds.apache.org/job/sling-trunk-1.7/changes
Jenkins build is still unstable: sling-trunk-1.7 » Apache Sling Launchpad Testing #1184
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.launchpad.testing/1184/
Validation Documentation
There is currently no documentation at all on the Sling Validation stuff (https://issues.apache.org/jira/browse/SLING-2803 https://issues.apache.org/jira/browse/SLING-2803). Previously there was a readme.md describing the node structure of validation nodes at https://github.com/raducotescu/org.apache.sling.validation https://github.com/raducotescu/org.apache.sling.validation. Unfortunately that repo was removed (or is no longer publicly visible). Until we have something documented in http://sling.apache.org/documentation/bundles.html http://sling.apache.org/documentation/bundles.html would it be possible to restore the readme.md in Github? Thanks, Konrad
Jenkins build is unstable: sling-trunk-1.6 #2802
See https://builds.apache.org/job/sling-trunk-1.6/2802/changes
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Launchpad Testing #2802
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing/2802/
Old website content on Confluence, should we remove it?
Hi, https://cwiki.apache.org/confluence/display/SLINGxSITE/ was used to generate our website before switching to the Apache CMS. So it has an outdated version of our content that's useless AFAICS. Shall we delete that wiki space now? Or just leave a single page that points to sling.apache.org ? -Bertrand
Re: [Sightly] API vs. Implementation
Hi Radu Am 21.11.2014 um 18:39 schrieb Radu Cotescu r...@apache.org: Hi Felix, I pushed all the required changes to the forked repo. Things left to do: * check what we actually need to export for preventing class loading problems Excellent. I would prefer to really not export most of the RenderUnit stuff incl. BaseRenderUnit and RenderContext. At one point I had a change, where I actually had RenderContext as an interface with a subset of the API, basically just getWriter (does that need to be a StackedWriter after all ?) and a RenderContextImpl which had all the rest but was internal. * expand JavaDoc At this point I think that we can create a patch with our changes and apply it to trunk. We might want to continue on the fork to find the classes that we really want/need to export. Because this may cause further shuffling of packages etc. Thanks Felix Cheers, Radu On Thu, Nov 20, 2014 at 6:53 PM, Felix Meschberger fmesc...@adobe.com wrote: Hi Thanks for your reply. For those interested in following, Radu and I are cooperating on these changes in my GitHub fork at https://github.com/fmeschbe/sling Am 19.11.2014 um 22:53 schrieb Radu Cotescu r...@cotescu.com: Hi Felix, The API reorganisation looks good to me. On Wed, Nov 19, 2014 at 10:49 PM, Felix Meschberger fmesc...@adobe.com wrote: Apart from splitting the base .api package, this are further discussions: * Exceptions are forming a hierarchy with SightlyEngineException being the root and itself extending from SlingException Sure, it makes sense. Done in the fork. The „root“ exception for Sightly is not SightlyException (SightlyEngineException renamed to SightlyException). * I wonder, whether we should really drop the *Component abstract classes (RuntimeExtensionComponent and UseProviderComponent). I don’t think they provide real value at all but have an activate method, which they expect to be called and which they expect to be a DS component annotated with the Felix annotations. I think this is brittle. The abstract classes were written specifically for that activate method, in order to avoid writing those lines of code for every implementation. We are working on removing these abstract classes by leveraging service properties for * UseProvider ranking (service.ranking) * ExtensionProvider naming * UseProvider defines an ordering method and declares itself being Comparable. I think this is wrong. The UseProviders should be sorted using regular OSGi service ranking. If we make the service.ranking property configurable (metatype = true) I guess we could use the OSGi ranking. Theoretically the Use providers can be configured to be called in a pre-determined order, depending on how the Sightly projects from an instance make use of the Use-API (Java Use-API objects deployed in bundles / Java Use objects near the component script in the repo / JS Use-API, etc.). Having the Use providers called in the most favourable way can increase performance for Sightly applications. Yes, the service.ranking property can be added to metatype for configurable ranking. * I wonder, whether we really have to have all this API exported at all: Some API I don’t see implemented at all (e.g. BaseRenderUnit — or is that the base class for the Java classes generated from the Sightly templates ?) The BaseRenderUnit is indeed the base class for classes generated from Sightly scripts, which is why we need to export the other classes as well. In this regard Sightly is no different from the JSP engine. Ok. We’d have to test this more. But I suspect we don’t really need to export the BaseRenderUnit abstract class. IIRC the reason for exporting the base JSP servlet is that other classes in the same package must be exported. * Last but not least (actually most important of all): There is close to no JavaDoc. Before cutting a release of this bundle, JavaDoc must be provided for the API. For example I am not sure, what the Record or the ObjectModel interfaces are really used for. It's on my TODO list. Cool. Thanks. Regards Felix
[jira] [Commented] (SLING-2803) Create a Validation module capable of validating POST requests or Resources
[ https://issues.apache.org/jira/browse/SLING-2803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14222867#comment-14222867 ] Konrad Windszus commented on SLING-2803: I just pushed an initial documentation with rev 1641359. [~radu.cotescu] Can you please review at http://sling.staging.apache.org/documentation/bundles/validation.html? Create a Validation module capable of validating POST requests or Resources --- Key: SLING-2803 URL: https://issues.apache.org/jira/browse/SLING-2803 Project: Sling Issue Type: New Feature Components: Validation Reporter: Radu Cotescu Assignee: Bertrand Delacretaz Fix For: Validation 1.0.0 Attachments: org.apache.sling.validation.zip, org.apache.sling.validation.zip.sha1 Several Sling users have asked in the past [1] about a Validation mechanism in Sling that's able to validate data coming from the user. However, such a module is still missing. This issue is meant to track the work progress on such a module. Ideally the module should be able to validate both request parameters and Resources, by obtaining their properties via a ValueMap and provide feedback in case of a validation error. [1] - http://sling.markmail.org/search/?q=validation -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4187) Move validation and xss projects into contrib/extensions
[ https://issues.apache.org/jira/browse/SLING-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14222868#comment-14222868 ] Felix Meschberger commented on SLING-4187: -- [~rombert] Thanks alot :-) Move validation and xss projects into contrib/extensions Key: SLING-4187 URL: https://issues.apache.org/jira/browse/SLING-4187 Project: Sling Issue Type: Task Components: Extensions Reporter: Felix Meschberger Assignee: Felix Meschberger The Validation Framework and XSS bundle are currently directly in the contrib folder. These should be moved down into the extensions folder. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[website] don't expect control on the staging process/timing
Hi, On Mon, Nov 24, 2014 at 11:42 AM, Konrad Windszus (JIRA) j...@apache.org wrote: ...I just pushed an initial documentation with rev 1641359. [~radu.cotescu] Can you please review at http://sling.staging.apache.org/documentation/bundles/validation.html?... Note that you can't count on this staying in the staging area, as soon as someone publishes other site changes this will go live as well. If you're unsure about that content I'd suggest adding a work in progress note at the top of the page. -Bertrand
Re: [website] don't expect control on the staging process/timing
Thanks for that hint Betrand. I just added such a note and published my changes, so you can have a look at that http://sling.apache.org/documentation/bundles/validation.html http://sling.apache.org/documentation/bundles/validation.html. Konrad On 24 Nov 2014, at 11:46, Bertrand Delacretaz bdelacre...@apache.org wrote: Hi, On Mon, Nov 24, 2014 at 11:42 AM, Konrad Windszus (JIRA) j...@apache.org wrote: ...I just pushed an initial documentation with rev 1641359. [~radu.cotescu] Can you please review at http://sling.staging.apache.org/documentation/bundles/validation.html?... Note that you can't count on this staying in the staging area, as soon as someone publishes other site changes this will go live as well. If you're unsure about that content I'd suggest adding a work in progress note at the top of the page. -Bertrand
Re: Validation Documentation
I published an initial draft of the documentation to http://sling.apache.org/documentation/bundles/validation.html http://sling.apache.org/documentation/bundles/validation.html. It would be great if someone else could have a look at that. Thanks, Konrad On 24 Nov 2014, at 09:50, Konrad Windszus konra...@gmx.de wrote: There is currently no documentation at all on the Sling Validation stuff (https://issues.apache.org/jira/browse/SLING-2803 https://issues.apache.org/jira/browse/SLING-2803). Previously there was a readme.md describing the node structure of validation nodes at https://github.com/raducotescu/org.apache.sling.validation https://github.com/raducotescu/org.apache.sling.validation. Unfortunately that repo was removed (or is no longer publicly visible). Until we have something documented in http://sling.apache.org/documentation/bundles.html http://sling.apache.org/documentation/bundles.html would it be possible to restore the readme.md in Github? Thanks, Konrad
[jira] [Created] (SLING-4191) Support resolving JSP scripts from the repository
Robert Munteanu created SLING-4191:
--
Summary: Support resolving JSP scripts from the repository
Key: SLING-4191
URL: https://issues.apache.org/jira/browse/SLING-4191
Project: Sling
Issue Type: New Feature
Components: IDE
Reporter: Robert Munteanu
Fix For: Sling Eclipse IDE 1.1.0
A common pattern in Sling applications is to define several taglibs and imports
in a globally included file and reference it from all JSPs, e.g.
{code}%@include file=/libs/foundation/global.jsp%{code}
These files aren't part of the project checkout so the JSP editor will raise an
error and is not able to provide auto-completion based on that global.jsp file.
We should be able to load these files from the repository, although it remains
to be seen what we can do that:
- is fast
- stays in sync with changes in the repository initiated from other sources
- has an a well-defined and intuitive behaviour when the repository is not
available
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: Old website content on Confluence, should we remove it?
On Mon, Nov 24, 2014 at 12:27 PM, Bertrand Delacretaz bdelacre...@apache.org wrote: Hi, https://cwiki.apache.org/confluence/display/SLINGxSITE/ was used to generate our website before switching to the Apache CMS. So it has an outdated version of our content that's useless AFAICS. It's useless and also confusing ; users might pick up outdated/incorrect content. Shall we delete that wiki space now? Or just leave a single page that points to sling.apache.org ? +1 for deleting and putting an announcement on the home page of the wiki space. Robert
Re: [VOTE] Release Apache Sling Resource Resolver 1.1.8
+1 Robert On Mon, Nov 24, 2014 at 9:59 AM, Antonio Sanso asa...@adobe.com wrote: Hi *, We solved 2 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12328780 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1152 You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 1152 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours.
[jira] [Commented] (SLING-4175) Sightly: Do not catch exceptions in ResourceRuntimeExtension and IncludeRuntimeExtension
[
https://issues.apache.org/jira/browse/SLING-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14222938#comment-14222938
]
Konrad Windszus commented on SLING-4175:
Hi [~santiagozky],
that patch looks ok, but since a lot of refactoring of Sightly is currently
oing on in a dedicated feature branch
(http://www.mail-archive.com/dev%40sling.apache.org/msg39738.html) I will wait
until the feature branch was merged back to trunk before applying this. Also I
would like to hear some other opinions on this topic, because we have to be
careful to not break backwards-compatibility with existing scripts.
For the future it would be great if the patches would not include any
unintended changes (like newly inserted empty lines) and follow the general
indentation of the file.
Sightly: Do not catch exceptions in ResourceRuntimeExtension and
IncludeRuntimeExtension
Key: SLING-4175
URL: https://issues.apache.org/jira/browse/SLING-4175
Project: Sling
Issue Type: Bug
Components: Scripting
Reporter: Konrad Windszus
Labels: Sightly
Currently all exceptions being thrown during the execution of
data-sly-include and data-sly-resource are caught and only logged.
Instead those exceptions should be just wrapped (to ease debugging during
development) and also to be consistent with {{sling:call}} (SLING-3459).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Jenkins build is still unstable: sling-trunk-1.8 » Apache Sling Event Support #474
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.event/474/
Jenkins build is back to stable : sling-trunk-1.8 » Apache Sling SlingRepository Integration Tests #474
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.jcr.repository.it-jackrabbit-oak/474/
Jenkins build is still unstable: sling-trunk-1.8 #474
See https://builds.apache.org/job/sling-trunk-1.8/changes
Jenkins build is still unstable: sling-trunk-1.7 » Apache Sling Launchpad Testing #1185
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.launchpad.testing/1185/
Jenkins build is still unstable: sling-trunk-1.7 #1185
See https://builds.apache.org/job/sling-trunk-1.7/changes
[jira] [Created] (SLING-4192) ModelAdapterFactory references the wrong interface for injectAnnotationProcessorFactories2
santiago garcía pimentel created SLING-4192: --- Summary: ModelAdapterFactory references the wrong interface for injectAnnotationProcessorFactories2 Key: SLING-4192 URL: https://issues.apache.org/jira/browse/SLING-4192 Project: Sling Issue Type: Bug Reporter: santiago garcía pimentel in https://github.com/apache/sling/blob/trunk/bundles/extensions/models/impl/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java the reference interface for injectAnnotationProcessorFactories2 is injectAnnotationProcessorFactories.class instead of injectAnnotationProcessorFactories2.class. this is causing the ChildResource injector not to function properly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] sling pull request: SLING-4192 Fix typo in refereceInterface in Mo...
GitHub user santiagozky opened a pull request: https://github.com/apache/sling/pull/47 SLING-4192 Fix typo in refereceInterface in ModelAdapterFactory You can merge this pull request into a Git repository by running: $ git pull https://github.com/santiagozky/sling annotationProcessorFactory2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/sling/pull/47.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #47 commit 5d1a16714b64286ff8f2781acdd73e5cdfdd9e05 Author: Santiago Garcia Pimentel santiago@santiago-2.local Date: 2014-11-24T12:58:45Z Fix typo in refereceInterface in ModelAdapterFactory --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (SLING-4192) ModelAdapterFactory references the wrong interface for injectAnnotationProcessorFactories2
[ https://issues.apache.org/jira/browse/SLING-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14222963#comment-14222963 ] ASF GitHub Bot commented on SLING-4192: --- GitHub user santiagozky opened a pull request: https://github.com/apache/sling/pull/47 SLING-4192 Fix typo in refereceInterface in ModelAdapterFactory You can merge this pull request into a Git repository by running: $ git pull https://github.com/santiagozky/sling annotationProcessorFactory2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/sling/pull/47.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #47 commit 5d1a16714b64286ff8f2781acdd73e5cdfdd9e05 Author: Santiago Garcia Pimentel santiago@santiago-2.local Date: 2014-11-24T12:58:45Z Fix typo in refereceInterface in ModelAdapterFactory ModelAdapterFactory references the wrong interface for injectAnnotationProcessorFactories2 -- Key: SLING-4192 URL: https://issues.apache.org/jira/browse/SLING-4192 Project: Sling Issue Type: Bug Reporter: santiago garcía pimentel in https://github.com/apache/sling/blob/trunk/bundles/extensions/models/impl/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java the reference interface for injectAnnotationProcessorFactories2 is injectAnnotationProcessorFactories.class instead of injectAnnotationProcessorFactories2.class. this is causing the ChildResource injector not to function properly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4192) ModelAdapterFactory references the wrong interface for injectAnnotationProcessorFactories2
[ https://issues.apache.org/jira/browse/SLING-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14222972#comment-14222972 ] Konrad Windszus commented on SLING-4192: Manually applied the fix in r1641391. Thanks [~santiagozky] for spotting this. ModelAdapterFactory references the wrong interface for injectAnnotationProcessorFactories2 -- Key: SLING-4192 URL: https://issues.apache.org/jira/browse/SLING-4192 Project: Sling Issue Type: Bug Reporter: santiago garcía pimentel Assignee: Konrad Windszus in https://github.com/apache/sling/blob/trunk/bundles/extensions/models/impl/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java the reference interface for injectAnnotationProcessorFactories2 is injectAnnotationProcessorFactories.class instead of injectAnnotationProcessorFactories2.class. this is causing the ChildResource injector not to function properly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-4192) ModelAdapterFactory references the wrong interface for injectAnnotationProcessorFactories2
[ https://issues.apache.org/jira/browse/SLING-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-4192: --- Component/s: Extensions ModelAdapterFactory references the wrong interface for injectAnnotationProcessorFactories2 -- Key: SLING-4192 URL: https://issues.apache.org/jira/browse/SLING-4192 Project: Sling Issue Type: Bug Components: Extensions Reporter: santiago garcía pimentel Assignee: Konrad Windszus Fix For: Sling Models Impl 1.2.0 in https://github.com/apache/sling/blob/trunk/bundles/extensions/models/impl/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java the reference interface for injectAnnotationProcessorFactories2 is injectAnnotationProcessorFactories.class instead of injectAnnotationProcessorFactories2.class. this is causing the ChildResource injector not to function properly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-4192) ModelAdapterFactory references the wrong interface for injectAnnotationProcessorFactories2
[ https://issues.apache.org/jira/browse/SLING-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-4192: --- Fix Version/s: Sling Models Impl 1.2.0 ModelAdapterFactory references the wrong interface for injectAnnotationProcessorFactories2 -- Key: SLING-4192 URL: https://issues.apache.org/jira/browse/SLING-4192 Project: Sling Issue Type: Bug Components: Extensions Reporter: santiago garcía pimentel Assignee: Konrad Windszus Fix For: Sling Models Impl 1.2.0 in https://github.com/apache/sling/blob/trunk/bundles/extensions/models/impl/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java the reference interface for injectAnnotationProcessorFactories2 is injectAnnotationProcessorFactories.class instead of injectAnnotationProcessorFactories2.class. this is causing the ChildResource injector not to function properly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4192) ModelAdapterFactory references the wrong interface for injectAnnotationProcessorFactories2
[ https://issues.apache.org/jira/browse/SLING-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14222974#comment-14222974 ] ASF GitHub Bot commented on SLING-4192: --- Github user asfgit closed the pull request at: https://github.com/apache/sling/pull/47 ModelAdapterFactory references the wrong interface for injectAnnotationProcessorFactories2 -- Key: SLING-4192 URL: https://issues.apache.org/jira/browse/SLING-4192 Project: Sling Issue Type: Bug Components: Extensions Reporter: santiago garcía pimentel Assignee: Konrad Windszus Fix For: Sling Models Impl 1.2.0 in https://github.com/apache/sling/blob/trunk/bundles/extensions/models/impl/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java the reference interface for injectAnnotationProcessorFactories2 is injectAnnotationProcessorFactories.class instead of injectAnnotationProcessorFactories2.class. this is causing the ChildResource injector not to function properly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] sling pull request: SLING-4192 Fix typo in refereceInterface in Mo...
Github user asfgit closed the pull request at: https://github.com/apache/sling/pull/47 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Resolved] (SLING-4192) ModelAdapterFactory references the wrong interface for injectAnnotationProcessorFactories2
[ https://issues.apache.org/jira/browse/SLING-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-4192. Resolution: Fixed ModelAdapterFactory references the wrong interface for injectAnnotationProcessorFactories2 -- Key: SLING-4192 URL: https://issues.apache.org/jira/browse/SLING-4192 Project: Sling Issue Type: Bug Components: Extensions Reporter: santiago garcía pimentel Assignee: Konrad Windszus Fix For: Sling Models Impl 1.2.0 in https://github.com/apache/sling/blob/trunk/bundles/extensions/models/impl/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java the reference interface for injectAnnotationProcessorFactories2 is injectAnnotationProcessorFactories.class instead of injectAnnotationProcessorFactories2.class. this is causing the ChildResource injector not to function properly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (SLING-4161) Support Sling Validation through a new field of the Model annotation
[
https://issues.apache.org/jira/browse/SLING-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus reassigned SLING-4161:
--
Assignee: Konrad Windszus
Support Sling Validation through a new field of the Model annotation
Key: SLING-4161
URL: https://issues.apache.org/jira/browse/SLING-4161
Project: Sling
Issue Type: Improvement
Components: Extensions
Affects Versions: Sling Models API 1.0.0, Sling Models Implementation 1.0.0
Reporter: Konrad Windszus
Assignee: Konrad Windszus
The current way of integrating Sling Validation (SLING-2803) with Sling
Models is to inject the validation service and then call it within a
PostConstruct method
(http://www.slideshare.net/raducotescu/apache-sling-generic-validation-framework/16).
This has the drawback that
# the {{ValidationService}} needs to be injected
# a PostConstruct needs to be implemented
# the other injections need to be marked as optional (otherwise the
validation is never triggered in case of e.g. missing required valuemap
values)
Instead it would be good to support this use case with just an additional
field on the annotation {{Model}} which is named {{validate}}. By default
this should be {{false}} (to be backwards compatible), but if it is {{true}}
the Sling Validation should be called before any values are injected into the
model. If validation fails the {{ModelAdapterFactory}} should never
instanciate the model and rather return null (or throw a meaningful exception
for SLING-3709).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-4192) ModelAdapterFactory references the wrong interface for injectAnnotationProcessorFactories2
[ https://issues.apache.org/jira/browse/SLING-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14222979#comment-14222979 ] santiago garcía pimentel commented on SLING-4192: - thanks for applying it. ModelAdapterFactory references the wrong interface for injectAnnotationProcessorFactories2 -- Key: SLING-4192 URL: https://issues.apache.org/jira/browse/SLING-4192 Project: Sling Issue Type: Bug Components: Extensions Reporter: santiago garcía pimentel Assignee: Konrad Windszus Fix For: Sling Models Impl 1.2.0 in https://github.com/apache/sling/blob/trunk/bundles/extensions/models/impl/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java the reference interface for injectAnnotationProcessorFactories2 is injectAnnotationProcessorFactories.class instead of injectAnnotationProcessorFactories2.class. this is causing the ChildResource injector not to function properly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4161) Support Sling Validation through a new field of the Model annotation
[
https://issues.apache.org/jira/browse/SLING-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14222991#comment-14222991
]
Bertrand Delacretaz commented on SLING-4161:
IMO it would be good to specify how to handle the validation is turned on but
no ValidationModel found case.
How about using validate={off/optional/required}?
With optional you'd just ignore the missing ValidationModel, whereas required
causes validation to fail in that case.
Support Sling Validation through a new field of the Model annotation
Key: SLING-4161
URL: https://issues.apache.org/jira/browse/SLING-4161
Project: Sling
Issue Type: Improvement
Components: Extensions
Affects Versions: Sling Models API 1.0.0, Sling Models Implementation 1.0.0
Reporter: Konrad Windszus
Assignee: Konrad Windszus
The current way of integrating Sling Validation (SLING-2803) with Sling
Models is to inject the validation service and then call it within a
PostConstruct method
(http://www.slideshare.net/raducotescu/apache-sling-generic-validation-framework/16).
This has the drawback that
# the {{ValidationService}} needs to be injected
# a PostConstruct needs to be implemented
# the other injections need to be marked as optional (otherwise the
validation is never triggered in case of e.g. missing required valuemap
values)
Instead it would be good to support this use case with just an additional
field on the annotation {{Model}} which is named {{validate}}. By default
this should be {{false}} (to be backwards compatible), but if it is {{true}}
the Sling Validation should be called before any values are injected into the
model. If validation fails the {{ModelAdapterFactory}} should never
instanciate the model and rather return null (or throw a meaningful exception
for SLING-3709).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (SLING-4193) Cannot set Property type in import operation
Ashu Gupta created SLING-4193:
-
Summary: Cannot set Property type in import operation
Key: SLING-4193
URL: https://issues.apache.org/jira/browse/SLING-4193
Project: Sling
Issue Type: Bug
Reporter: Ashu Gupta
In import operation, unable to set property type using TypeHints.
Scenario:
Try to import content structure using sling using the method described in the
documentation as follows:
curl -F:operation=import -F:contentType=json
-F:content={ 'sample' : {'propOne' : 'propOneValue', 'propOne@TypeHint':
'Date','childOne' : { 'childPropOne' : true } } } \
http://host/content
but in the result I get a new String property as follows:
propOne@TypeHint String Date
instead of setting the property as Date. How can I accomplish this?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SLING-4193) Cannot set Property type in import operation using @TypeHint suffix
[
https://issues.apache.org/jira/browse/SLING-4193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashu Gupta updated SLING-4193:
--
Summary: Cannot set Property type in import operation using @TypeHint
suffix (was: Cannot set Property type in import operation)
Cannot set Property type in import operation using @TypeHint suffix
---
Key: SLING-4193
URL: https://issues.apache.org/jira/browse/SLING-4193
Project: Sling
Issue Type: Bug
Reporter: Ashu Gupta
In import operation, unable to set property type using @TypeHint suffix.
Scenario:
Try to import content structure using sling using the method described in the
documentation as follows:
curl -F:operation=import -F:contentType=json
-F:content={ 'sample' : {'propOne' : 'propOneValue', 'propOne@TypeHint':
'Date','childOne' : { 'childPropOne' : true } } } \
http://host/content
but in the result I get a new String property as follows:
propOne@TypeHint String Date
instead of setting the property as Date. How can I accomplish this?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SLING-4193) Cannot set Property type in import operation
[
https://issues.apache.org/jira/browse/SLING-4193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashu Gupta updated SLING-4193:
--
Description:
In import operation, unable to set property type using @TypeHint suffix.
Scenario:
Try to import content structure using sling using the method described in the
documentation as follows:
curl -F:operation=import -F:contentType=json
-F:content={ 'sample' : {'propOne' : 'propOneValue', 'propOne@TypeHint':
'Date','childOne' : { 'childPropOne' : true } } } \
http://host/content
but in the result I get a new String property as follows:
propOne@TypeHint String Date
instead of setting the property as Date. How can I accomplish this?
was:
In import operation, unable to set property type using TypeHints.
Scenario:
Try to import content structure using sling using the method described in the
documentation as follows:
curl -F:operation=import -F:contentType=json
-F:content={ 'sample' : {'propOne' : 'propOneValue', 'propOne@TypeHint':
'Date','childOne' : { 'childPropOne' : true } } } \
http://host/content
but in the result I get a new String property as follows:
propOne@TypeHint String Date
instead of setting the property as Date. How can I accomplish this?
Cannot set Property type in import operation
Key: SLING-4193
URL: https://issues.apache.org/jira/browse/SLING-4193
Project: Sling
Issue Type: Bug
Reporter: Ashu Gupta
In import operation, unable to set property type using @TypeHint suffix.
Scenario:
Try to import content structure using sling using the method described in the
documentation as follows:
curl -F:operation=import -F:contentType=json
-F:content={ 'sample' : {'propOne' : 'propOneValue', 'propOne@TypeHint':
'Date','childOne' : { 'childPropOne' : true } } } \
http://host/content
but in the result I get a new String property as follows:
propOne@TypeHint String Date
instead of setting the property as Date. How can I accomplish this?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SLING-4193) Cannot set Property type in import operation using @TypeHint suffix
[
https://issues.apache.org/jira/browse/SLING-4193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashu Gupta updated SLING-4193:
--
Description:
In import operation, unable to set property type using @TypeHint suffix.
Scenario:
Try to import content structure using sling using the method described in the
documentation as follows:
curl -F:operation=import -F:contentType=json
-F:content={ 'sample' : {'propOne' : 'propOneValue', 'propOne@TypeHint':
'Date','childOne' : { 'childPropOne' : true } } } \
http://host/content
but in the result I get a new String property as follows:
propOne@TypeHint String Date
instead of setting the property as Date. Is there an alternate method to
accomplish this?
was:
In import operation, unable to set property type using @TypeHint suffix.
Scenario:
Try to import content structure using sling using the method described in the
documentation as follows:
curl -F:operation=import -F:contentType=json
-F:content={ 'sample' : {'propOne' : 'propOneValue', 'propOne@TypeHint':
'Date','childOne' : { 'childPropOne' : true } } } \
http://host/content
but in the result I get a new String property as follows:
propOne@TypeHint String Date
instead of setting the property as Date. How can I accomplish this?
Cannot set Property type in import operation using @TypeHint suffix
---
Key: SLING-4193
URL: https://issues.apache.org/jira/browse/SLING-4193
Project: Sling
Issue Type: Bug
Reporter: Ashu Gupta
In import operation, unable to set property type using @TypeHint suffix.
Scenario:
Try to import content structure using sling using the method described in the
documentation as follows:
curl -F:operation=import -F:contentType=json
-F:content={ 'sample' : {'propOne' : 'propOneValue', 'propOne@TypeHint':
'Date','childOne' : { 'childPropOne' : true } } } \
http://host/content
but in the result I get a new String property as follows:
propOne@TypeHint String Date
instead of setting the property as Date. Is there an alternate method to
accomplish this?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SLING-4193) Cannot set Property type in import operation using @TypeHint suffix
[
https://issues.apache.org/jira/browse/SLING-4193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashu Gupta updated SLING-4193:
--
Description:
In import operation, unable to set property type using @TypeHint suffix.
Scenario:
Try to import content structure using sling using the method described in the
documentation as follows:
curl -F:operation=import -F:contentType=json
-F:content={ 'sample' : {'propOne' : 'propOneValue', 'propOne@TypeHint':
'Date','childOne' : { 'childPropOne' : true } } } \
http://host/content
but in the result I get a new String property as follows:
propOne@TypeHint String Date
instead of setting the property as Date.
was:
In import operation, unable to set property type using @TypeHint suffix.
Scenario:
Try to import content structure using sling using the method described in the
documentation as follows:
curl -F:operation=import -F:contentType=json
-F:content={ 'sample' : {'propOne' : 'propOneValue', 'propOne@TypeHint':
'Date','childOne' : { 'childPropOne' : true } } } \
http://host/content
but in the result I get a new String property as follows:
propOne@TypeHint String Date
instead of setting the property as Date. Is there an alternate method to
accomplish this?
Cannot set Property type in import operation using @TypeHint suffix
---
Key: SLING-4193
URL: https://issues.apache.org/jira/browse/SLING-4193
Project: Sling
Issue Type: Bug
Reporter: Ashu Gupta
In import operation, unable to set property type using @TypeHint suffix.
Scenario:
Try to import content structure using sling using the method described in the
documentation as follows:
curl -F:operation=import -F:contentType=json
-F:content={ 'sample' : {'propOne' : 'propOneValue', 'propOne@TypeHint':
'Date','childOne' : { 'childPropOne' : true } } } \
http://host/content
but in the result I get a new String property as follows:
propOne@TypeHint String Date
instead of setting the property as Date.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-4161) Support Sling Validation through a new field of the Model annotation
[
https://issues.apache.org/jira/browse/SLING-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14222994#comment-14222994
]
Konrad Windszus commented on SLING-4161:
[~bdelacretaz] Good idea, I will consider that.
Hopefully I can come up with a patch for that this week.
Support Sling Validation through a new field of the Model annotation
Key: SLING-4161
URL: https://issues.apache.org/jira/browse/SLING-4161
Project: Sling
Issue Type: Improvement
Components: Extensions
Affects Versions: Sling Models API 1.0.0, Sling Models Implementation 1.0.0
Reporter: Konrad Windszus
Assignee: Konrad Windszus
The current way of integrating Sling Validation (SLING-2803) with Sling
Models is to inject the validation service and then call it within a
PostConstruct method
(http://www.slideshare.net/raducotescu/apache-sling-generic-validation-framework/16).
This has the drawback that
# the {{ValidationService}} needs to be injected
# a PostConstruct needs to be implemented
# the other injections need to be marked as optional (otherwise the
validation is never triggered in case of e.g. missing required valuemap
values)
Instead it would be good to support this use case with just an additional
field on the annotation {{Model}} which is named {{validate}}. By default
this should be {{false}} (to be backwards compatible), but if it is {{true}}
the Sling Validation should be called before any values are injected into the
model. If validation fails the {{ModelAdapterFactory}} should never
instanciate the model and rather return null (or throw a meaningful exception
for SLING-3709).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-4193) Cannot set Property type in import operation using @TypeHint suffix
[
https://issues.apache.org/jira/browse/SLING-4193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14223000#comment-14223000
]
Ashu Gupta commented on SLING-4193:
---
Update: Other Suffixes like @Patch etc are also not working for Import
Operation.
Cannot set Property type in import operation using @TypeHint suffix
---
Key: SLING-4193
URL: https://issues.apache.org/jira/browse/SLING-4193
Project: Sling
Issue Type: Bug
Reporter: Ashu Gupta
In import operation, unable to set property type using @TypeHint suffix.
Scenario:
Try to import content structure using sling using the method described in the
documentation as follows:
curl -F:operation=import -F:contentType=json
-F:content={ 'sample' : {'propOne' : 'propOneValue', 'propOne@TypeHint':
'Date','childOne' : { 'childPropOne' : true } } } \
http://host/content
but in the result I get a new String property as follows:
propOne@TypeHint String Date
instead of setting the property as Date.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (SLING-4171) Resource Editor :: pom changes
[ https://issues.apache.org/jira/browse/SLING-4171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-4171. Resolution: Fixed Ok, for now I have added an svn:ignore in http://svn.apache.org/r1641397 - if you later find a way to generate those files under target that's better IMO, but the current way also works of course. Resource Editor :: pom changes -- Key: SLING-4171 URL: https://issues.apache.org/jira/browse/SLING-4171 Project: Sling Issue Type: Sub-task Reporter: Sandro Boehme Assignee: Bertrand Delacretaz Attachments: patch_pom_readme.txt * changed the import-packages to be compatible with the current Sling launchpad * removed Require-Bundle statement from pom * switched from 'private-package' to 'export-package' * small readme change -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (SLING-4169) Resource Editor :: restructuring of folders
[ https://issues.apache.org/jira/browse/SLING-4169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-4169. Resolution: Fixed I have applied your patch and deleted the files mentioned in this issue's description, in http://svn.apache.org/r1641400 - thanks! Please cross-check. Note that you can include deleted files in an svn patch, just remove them with svn remove before generating the patch. Resource Editor :: restructuring of folders --- Key: SLING-4169 URL: https://issues.apache.org/jira/browse/SLING-4169 Project: Sling Issue Type: Sub-task Reporter: Sandro Boehme Assignee: Bertrand Delacretaz Attachments: patch_folder_restructure_add_node_dialog.txt, patch_folder_restructure_add_node_dialog_with_lineending_fix.txt This patch contains the new add-node dialog and restructures the folders to differentiate between static and non-static content. This makes the following files obsolete that have to be removed: * /resource-editor/src/main/java/org/apache/sling/reseditor/ResEditorResourceProvider.java * /resource-editor/src/main/java/org/apache/sling/reseditor/SelectorBasedResourceDecorator.java * /resource-editor/src/main/resources/SLING-INF/libs/reseditor * /resource-editor/src/main/resources/SLING-INF/libs/sling/servlet A leftover that needs to be removed: * /layout.js -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (SLING-4173) Resource Editor :: switched to Resource Provider
[ https://issues.apache.org/jira/browse/SLING-4173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-4173. Resolution: Fixed The above URL does show the editor now, after applying the SLING-4169 patch. Marking this issue fixed, thanks! Resource Editor :: switched to Resource Provider Key: SLING-4173 URL: https://issues.apache.org/jira/browse/SLING-4173 Project: Sling Issue Type: Sub-task Reporter: Sandro Boehme Assignee: Bertrand Delacretaz Attachments: patch_resource_provider.txt Moved from the selector based script resolution to the ResourceProvider based script resolution. The Resource Editor is now available at /reseditor/.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4171) Resource Editor :: pom changes
[ https://issues.apache.org/jira/browse/SLING-4171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14223023#comment-14223023 ] Sandro Boehme commented on SLING-4171: -- Thanks adding the file to svn:ignore! I agree. From a Maven point of view it is no source as it is generated from a source and this is why it belongs to the target directory. As you say - if I later find a way to have the file there I will change it. Resource Editor :: pom changes -- Key: SLING-4171 URL: https://issues.apache.org/jira/browse/SLING-4171 Project: Sling Issue Type: Sub-task Reporter: Sandro Boehme Assignee: Bertrand Delacretaz Attachments: patch_pom_readme.txt * changed the import-packages to be compatible with the current Sling launchpad * removed Require-Bundle statement from pom * switched from 'private-package' to 'export-package' * small readme change -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (SLING-4141) First patch for the Sling Resource Editor
[ https://issues.apache.org/jira/browse/SLING-4141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-4141. Resolution: Fixed All subtasks have been resolved, marking this issue fixed. Thanks [~sandro] for your contributions! First patch for the Sling Resource Editor - Key: SLING-4141 URL: https://issues.apache.org/jira/browse/SLING-4141 Project: Sling Issue Type: Improvement Reporter: Sandro Boehme Attachments: patch.txt This is the first patch for the Sling Resource Editor contribution. It contains the following improvements: o add node functionality for the user o changed the import-packages to be compatible with the current Sling launchpad o moved license information from NOTICE to LICENSE.txt o removed Require-Bundle statement from pom o changed folder structure to separate between static and non-static content o Moved from the selector based script resolution to the ResourceProvider based script resolution. The Resource Editor is now available at /reseditor/.html The following files and folders are obsolete with the patch and have to be deleted: o /layout.js o /NOTICE o /resource-editor/src/main/java/org/apache/sling/reseditor/ResEditorResourceProvider.java o /resource-editor/src/main/java/org/apache/sling/reseditor/SelectorBasedResourceDecorator.java o /resource-editor/src/main/resources/SLING-INF/libs/reseditor o /resource-editor/src/main/resources/SLING-INF/libs/sling/servlet -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Jenkins build is still unstable: sling-trunk-1.7 » Apache Sling Launchpad Testing #1186
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.launchpad.testing/1186/
Jenkins build is still unstable: sling-trunk-1.7 #1186
See https://builds.apache.org/job/sling-trunk-1.7/changes
Jenkins build is unstable: sling-trunk-1.6 #2804
See https://builds.apache.org/job/sling-trunk-1.6/2804/changes
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Launchpad Testing #2804
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing/2804/
Build failed in Jenkins: sling-trunk-1.6 #2805
See https://builds.apache.org/job/sling-trunk-1.6/2805/ -- Started by an SCM change Building remotely on H10 (Ubuntu ubuntu) in workspace https://builds.apache.org/job/sling-trunk-1.6/ws/ Updating http://svn.apache.org/repos/asf/sling/trunk at revision '2014-11-24T15:01:12.668 +' D contrib/explorers/resourceeditor/src/main/java/org/apache/sling/reseditor/ResEditorResourceProvider.java D contrib/explorers/resourceeditor/src/main/java/org/apache/sling/reseditor/SelectorBasedResourceDecorator.java D contrib/explorers/resourceeditor/src/main/resources/SLING-INF/libs/reseditor D contrib/explorers/resourceeditor/src/main/resources/SLING-INF/libs/sling/servlet A contrib/explorers/resourceeditor/src/main/resources/SLING-INF/libs/sling/resource-editor A contrib/explorers/resourceeditor/src/main/resources/SLING-INF/libs/sling/resource-editor/nodes.json.jsp A contrib/explorers/resourceeditor/src/main/resources/SLING-INF/libs/sling/resource-editor/html.jsp A contrib/explorers/resourceeditor/src/main/resources/SLING-INF/libs/sling/resource-editor/nodes.json.incl.jsp A contrib/explorers/resourceeditor/src/main/resources/SLING-INF/libs/sling/resource-editor/rootnodes.json.jsp U contrib/explorers/resourceeditor/src/main/resources/SLING-INF/libs/sling D contrib/explorers/resourceeditor/layout.js A src A src/main A src/main/javadoc AUsrc/main/javadoc/overview.html A src/misc AUsrc/misc/README.txt A src/misc/sling-6-source-release.javadoc.patch svn: E175002: REPORT /repos/asf/!svn/vcc/default failed Updated failed due to local files. Getting a fresh workspace Cleaning local Directory trunk FATAL: hudson.remoting.RequestAbortedException: java.io.IOException: Unexpected termination of the channel hudson.remoting.RequestAbortedException: hudson.remoting.RequestAbortedException: java.io.IOException: Unexpected termination of the channel at hudson.remoting.RequestAbortedException.wrapForRethrow(RequestAbortedException.java:41) at hudson.remoting.RequestAbortedException.wrapForRethrow(RequestAbortedException.java:34) at hudson.remoting.Request.call(Request.java:174) at hudson.remoting.Channel.call(Channel.java:742) at hudson.FilePath.act(FilePath.java:909) at hudson.FilePath.act(FilePath.java:893) at hudson.scm.SubversionSCM.checkout(SubversionSCM.java:936) at hudson.scm.SubversionSCM.checkout(SubversionSCM.java:871) at hudson.model.AbstractProject.checkout(AbstractProject.java:1252) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:615) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:524) at hudson.model.Run.execute(Run.java:1706) at hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:529) at hudson.model.ResourceController.execute(ResourceController.java:88) at hudson.model.Executor.run(Executor.java:232) Caused by: hudson.remoting.RequestAbortedException: java.io.IOException: Unexpected termination of the channel at hudson.remoting.Request.abort(Request.java:299) at hudson.remoting.Channel.terminate(Channel.java:805) at hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:69) Caused by: java.io.IOException: Unexpected termination of the channel at hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:50) Caused by: java.io.EOFException at java.io.ObjectInputStream$PeekInputStream.readFully(ObjectInputStream.java:2325) at java.io.ObjectInputStream$BlockDataInputStream.readShort(ObjectInputStream.java:2794) at java.io.ObjectInputStream.readStreamHeader(ObjectInputStream.java:801) at java.io.ObjectInputStream.init(ObjectInputStream.java:299) at hudson.remoting.ObjectInputStreamEx.init(ObjectInputStreamEx.java:40) at hudson.remoting.AbstractSynchronousByteArrayCommandTransport.read(AbstractSynchronousByteArrayCommandTransport.java:34) at hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:48)
Jenkins build is back to stable : sling-trunk-1.8 » Apache Sling Event Support #475
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.event/475/
Jenkins build is back to stable : sling-trunk-1.8 #475
See https://builds.apache.org/job/sling-trunk-1.8/475/changes
[jira] [Created] (SLING-4194) Validator should take ValueMap instead of regular Map as type for the validator arguments
Konrad Windszus created SLING-4194: -- Summary: Validator should take ValueMap instead of regular Map as type for the validator arguments Key: SLING-4194 URL: https://issues.apache.org/jira/browse/SLING-4194 Project: Sling Issue Type: Bug Components: Validation Reporter: Konrad Windszus Assignee: Konrad Windszus Fix For: Validation 1.0.0 That way it is easily possible to convert the argument values to the appropriate type. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-4194) Validator should take ValueMap instead of regular Map as type for the validator arguments
[ https://issues.apache.org/jira/browse/SLING-4194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-4194: --- Issue Type: Improvement (was: Bug) Validator should take ValueMap instead of regular Map as type for the validator arguments - Key: SLING-4194 URL: https://issues.apache.org/jira/browse/SLING-4194 Project: Sling Issue Type: Improvement Components: Validation Reporter: Konrad Windszus Assignee: Konrad Windszus Fix For: Validation 1.0.0 That way it is easily possible to convert the argument values to the appropriate type. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4194) Validator should take ValueMap instead of regular Map as type for the validator arguments
[ https://issues.apache.org/jira/browse/SLING-4194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14223040#comment-14223040 ] Konrad Windszus commented on SLING-4194: Fixed in r1641407. Validator should take ValueMap instead of regular Map as type for the validator arguments - Key: SLING-4194 URL: https://issues.apache.org/jira/browse/SLING-4194 Project: Sling Issue Type: Improvement Components: Validation Reporter: Konrad Windszus Assignee: Konrad Windszus Fix For: Validation 1.0.0 That way it is easily possible to convert the argument values to the appropriate type. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Jenkins build is still unstable: sling-trunk-1.7 » Apache Sling Launchpad Testing #1187
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.launchpad.testing/1187/
Jenkins build is still unstable: sling-trunk-1.7 #1187
See https://builds.apache.org/job/sling-trunk-1.7/changes
Jenkins build became unstable: sling-trunk-1.8 » Apache Sling Event Support #476
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.event/476/
Jenkins build became unstable: sling-trunk-1.8 #476
See https://builds.apache.org/job/sling-trunk-1.8/476/changes
Jenkins build is still unstable: sling-trunk-1.8 » Apache Sling Event Support #477
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.event/477/
Jenkins build is still unstable: sling-trunk-1.8 #477
See https://builds.apache.org/job/sling-trunk-1.8/changes
Jenkins build is still unstable: sling-trunk-1.7 » Apache Sling Launchpad Testing #1188
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.launchpad.testing/1188/
Re: [VOTE] Release Apache Sling Resource Resolver 1.1.8
On Mon, Nov 24, 2014 at 8:59 AM, Antonio Sanso asa...@adobe.com wrote: ...Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1152 .. +1, checked build, signatures and the following archive matches its svn tag. MD5 (org.apache.sling.resourceresolver-1.1.8-source-release.zip) = bc0b7420f3323069db3bc7dd936f6082 -Bertrand
Jenkins build is still unstable: sling-trunk-1.7 #1188
See https://builds.apache.org/job/sling-trunk-1.7/changes
Jenkins build is back to stable : sling-contrib-1.6 » Apache Sling Distribution Core #1374
See https://builds.apache.org/job/sling-contrib-1.6/org.apache.sling$org.apache.sling.distribution.core/1374/
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Launchpad Testing #2806
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing/2806/
Jenkins build is unstable: sling-trunk-1.6 #2806
See https://builds.apache.org/job/sling-trunk-1.6/2806/changes
[jira] [Updated] (SLING-4161) Support Sling Validation through a new field of the Model annotation
[
https://issues.apache.org/jira/browse/SLING-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-4161:
---
Attachment: SLING-4161-api.patch
SLING-4161-impl.patch
The attached patches allow to leverage the Sling Validation through the model
annotation. The dependency to Sling Validation should be optional.
I renamed the former InvalidModelException to ModelClassException to make more
clear from the name what is a validation exception and what is not.
Also the ModelAdapterFactory might now throw two more exceptions:
SlingValidationException (in case the sling validation model could not be
instanciated) and InvalidModelException (in case the resource is considered
invalid by Sling Validation)
Support Sling Validation through a new field of the Model annotation
Key: SLING-4161
URL: https://issues.apache.org/jira/browse/SLING-4161
Project: Sling
Issue Type: Improvement
Components: Extensions
Affects Versions: Sling Models API 1.0.0, Sling Models Implementation 1.0.0
Reporter: Konrad Windszus
Assignee: Konrad Windszus
Attachments: SLING-4161-api.patch, SLING-4161-impl.patch
The current way of integrating Sling Validation (SLING-2803) with Sling
Models is to inject the validation service and then call it within a
PostConstruct method
(http://www.slideshare.net/raducotescu/apache-sling-generic-validation-framework/16).
This has the drawback that
# the {{ValidationService}} needs to be injected
# a PostConstruct needs to be implemented
# the other injections need to be marked as optional (otherwise the
validation is never triggered in case of e.g. missing required valuemap
values)
Instead it would be good to support this use case with just an additional
field on the annotation {{Model}} which is named {{validate}}. By default
this should be {{false}} (to be backwards compatible), but if it is {{true}}
the Sling Validation should be called before any values are injected into the
model. If validation fails the {{ModelAdapterFactory}} should never
instanciate the model and rather return null (or throw a meaningful exception
for SLING-3709).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SLING-4161) Support Sling Validation through a new field of the Model annotation
[
https://issues.apache.org/jira/browse/SLING-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-4161:
---
Attachment: (was: SLING-4161-impl.patch)
Support Sling Validation through a new field of the Model annotation
Key: SLING-4161
URL: https://issues.apache.org/jira/browse/SLING-4161
Project: Sling
Issue Type: Improvement
Components: Extensions
Affects Versions: Sling Models API 1.0.0, Sling Models Implementation 1.0.0
Reporter: Konrad Windszus
Assignee: Konrad Windszus
Attachments: SLING-4161-api-v02.patch, SLING-4161-impl-v02.patch
The current way of integrating Sling Validation (SLING-2803) with Sling
Models is to inject the validation service and then call it within a
PostConstruct method
(http://www.slideshare.net/raducotescu/apache-sling-generic-validation-framework/16).
This has the drawback that
# the {{ValidationService}} needs to be injected
# a PostConstruct needs to be implemented
# the other injections need to be marked as optional (otherwise the
validation is never triggered in case of e.g. missing required valuemap
values)
Instead it would be good to support this use case with just an additional
field on the annotation {{Model}} which is named {{validate}}. By default
this should be {{false}} (to be backwards compatible), but if it is {{true}}
the Sling Validation should be called before any values are injected into the
model. If validation fails the {{ModelAdapterFactory}} should never
instanciate the model and rather return null (or throw a meaningful exception
for SLING-3709).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SLING-4161) Support Sling Validation through a new field of the Model annotation
[
https://issues.apache.org/jira/browse/SLING-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-4161:
---
Attachment: SLING-4161-api-v02.patch
SLING-4161-impl-v02.patch
Support Sling Validation through a new field of the Model annotation
Key: SLING-4161
URL: https://issues.apache.org/jira/browse/SLING-4161
Project: Sling
Issue Type: Improvement
Components: Extensions
Affects Versions: Sling Models API 1.0.0, Sling Models Implementation 1.0.0
Reporter: Konrad Windszus
Assignee: Konrad Windszus
Attachments: SLING-4161-api-v02.patch, SLING-4161-impl-v02.patch
The current way of integrating Sling Validation (SLING-2803) with Sling
Models is to inject the validation service and then call it within a
PostConstruct method
(http://www.slideshare.net/raducotescu/apache-sling-generic-validation-framework/16).
This has the drawback that
# the {{ValidationService}} needs to be injected
# a PostConstruct needs to be implemented
# the other injections need to be marked as optional (otherwise the
validation is never triggered in case of e.g. missing required valuemap
values)
Instead it would be good to support this use case with just an additional
field on the annotation {{Model}} which is named {{validate}}. By default
this should be {{false}} (to be backwards compatible), but if it is {{true}}
the Sling Validation should be called before any values are injected into the
model. If validation fails the {{ModelAdapterFactory}} should never
instanciate the model and rather return null (or throw a meaningful exception
for SLING-3709).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SLING-4161) Support Sling Validation through a new field of the Model annotation
[
https://issues.apache.org/jira/browse/SLING-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-4161:
---
Attachment: (was: SLING-4161-api.patch)
Support Sling Validation through a new field of the Model annotation
Key: SLING-4161
URL: https://issues.apache.org/jira/browse/SLING-4161
Project: Sling
Issue Type: Improvement
Components: Extensions
Affects Versions: Sling Models API 1.0.0, Sling Models Implementation 1.0.0
Reporter: Konrad Windszus
Assignee: Konrad Windszus
Attachments: SLING-4161-api-v02.patch, SLING-4161-impl-v02.patch
The current way of integrating Sling Validation (SLING-2803) with Sling
Models is to inject the validation service and then call it within a
PostConstruct method
(http://www.slideshare.net/raducotescu/apache-sling-generic-validation-framework/16).
This has the drawback that
# the {{ValidationService}} needs to be injected
# a PostConstruct needs to be implemented
# the other injections need to be marked as optional (otherwise the
validation is never triggered in case of e.g. missing required valuemap
values)
Instead it would be good to support this use case with just an additional
field on the annotation {{Model}} which is named {{validate}}. By default
this should be {{false}} (to be backwards compatible), but if it is {{true}}
the Sling Validation should be called before any values are injected into the
model. If validation fails the {{ModelAdapterFactory}} should never
instanciate the model and rather return null (or throw a meaningful exception
for SLING-3709).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (SLING-4161) Support Sling Validation through a new field of the Model annotation
[
https://issues.apache.org/jira/browse/SLING-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14223188#comment-14223188
]
Konrad Windszus edited comment on SLING-4161 at 11/24/14 5:51 PM:
--
The attached patches allow to leverage the Sling Validation through the model
annotation. The dependency to Sling Validation should be optional.
I renamed the former InvalidModelException to ModelClassException to make more
clear from the name what is a validation exception and what is not.
Also the ModelAdapterFactory might now throw two more exceptions:
SlingValidationException (in case the sling validation model could not be
instanciated) and InvalidResourceException (in case the resource is considered
invalid by Sling Validation)
was (Author: kwin):
The attached patches allow to leverage the Sling Validation through the model
annotation. The dependency to Sling Validation should be optional.
I renamed the former InvalidModelException to ModelClassException to make more
clear from the name what is a validation exception and what is not.
Also the ModelAdapterFactory might now throw two more exceptions:
SlingValidationException (in case the sling validation model could not be
instanciated) and InvalidModelException (in case the resource is considered
invalid by Sling Validation)
Support Sling Validation through a new field of the Model annotation
Key: SLING-4161
URL: https://issues.apache.org/jira/browse/SLING-4161
Project: Sling
Issue Type: Improvement
Components: Extensions
Affects Versions: Sling Models API 1.0.0, Sling Models Implementation 1.0.0
Reporter: Konrad Windszus
Assignee: Konrad Windszus
Attachments: SLING-4161-api-v02.patch, SLING-4161-impl-v02.patch
The current way of integrating Sling Validation (SLING-2803) with Sling
Models is to inject the validation service and then call it within a
PostConstruct method
(http://www.slideshare.net/raducotescu/apache-sling-generic-validation-framework/16).
This has the drawback that
# the {{ValidationService}} needs to be injected
# a PostConstruct needs to be implemented
# the other injections need to be marked as optional (otherwise the
validation is never triggered in case of e.g. missing required valuemap
values)
Instead it would be good to support this use case with just an additional
field on the annotation {{Model}} which is named {{validate}}. By default
this should be {{false}} (to be backwards compatible), but if it is {{true}}
the Sling Validation should be called before any values are injected into the
model. If validation fails the {{ModelAdapterFactory}} should never
instanciate the model and rather return null (or throw a meaningful exception
for SLING-3709).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (SLING-4195) ModelAdapterFactory uses wrong array size for injectAnnotationProcessorFactories2
Konrad Windszus created SLING-4195:
--
Summary: ModelAdapterFactory uses wrong array size for
injectAnnotationProcessorFactories2
Key: SLING-4195
URL: https://issues.apache.org/jira/browse/SLING-4195
Project: Sling
Issue Type: Bug
Components: Extensions
Reporter: Konrad Windszus
Assignee: Konrad Windszus
Fix For: Sling Models Impl 1.2.0
The array sortedInjectAnnotationProcessorFactories2 in the
{{bindInjectAnnotationProcessorFactory2}} and
{{unbindInjectAnnotationProcessorFactory2}} is getting the wrong array size due
to a typo.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-4192) ModelAdapterFactory references the wrong interface for injectAnnotationProcessorFactories2
[ https://issues.apache.org/jira/browse/SLING-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14223209#comment-14223209 ] Konrad Windszus commented on SLING-4192: A very similar bug is described in SLING-4195. ModelAdapterFactory references the wrong interface for injectAnnotationProcessorFactories2 -- Key: SLING-4192 URL: https://issues.apache.org/jira/browse/SLING-4192 Project: Sling Issue Type: Bug Components: Extensions Reporter: santiago garcía pimentel Assignee: Konrad Windszus Fix For: Sling Models Impl 1.2.0 in https://github.com/apache/sling/blob/trunk/bundles/extensions/models/impl/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java the reference interface for injectAnnotationProcessorFactories2 is injectAnnotationProcessorFactories.class instead of injectAnnotationProcessorFactories2.class. this is causing the ChildResource injector not to function properly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (SLING-4195) ModelAdapterFactory uses wrong array size for injectAnnotationProcessorFactories2
[
https://issues.apache.org/jira/browse/SLING-4195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved SLING-4195.
Resolution: Fixed
ModelAdapterFactory uses wrong array size for
injectAnnotationProcessorFactories2
-
Key: SLING-4195
URL: https://issues.apache.org/jira/browse/SLING-4195
Project: Sling
Issue Type: Bug
Components: Extensions
Reporter: Konrad Windszus
Assignee: Konrad Windszus
Fix For: Sling Models Impl 1.2.0
The array sortedInjectAnnotationProcessorFactories2 in the
{{bindInjectAnnotationProcessorFactory2}} and
{{unbindInjectAnnotationProcessorFactory2}} is getting the wrong array size
due to a typo.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-4195) ModelAdapterFactory uses wrong array size for injectAnnotationProcessorFactories2
[
https://issues.apache.org/jira/browse/SLING-4195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14223210#comment-14223210
]
Konrad Windszus commented on SLING-4195:
Fixed in r1641433.
ModelAdapterFactory uses wrong array size for
injectAnnotationProcessorFactories2
-
Key: SLING-4195
URL: https://issues.apache.org/jira/browse/SLING-4195
Project: Sling
Issue Type: Bug
Components: Extensions
Reporter: Konrad Windszus
Assignee: Konrad Windszus
Fix For: Sling Models Impl 1.2.0
The array sortedInjectAnnotationProcessorFactories2 in the
{{bindInjectAnnotationProcessorFactory2}} and
{{unbindInjectAnnotationProcessorFactory2}} is getting the wrong array size
due to a typo.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-4195) ModelAdapterFactory uses wrong array size for injectAnnotationProcessorFactories2
[
https://issues.apache.org/jira/browse/SLING-4195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14223217#comment-14223217
]
Stefan Seifert commented on SLING-4195:
---
this is not the first time we make copypaste error on this boiler plate code
for collection dynamic service references.
perhaps we should introduce a class like
[this|https://github.com/wcm-io/wcm-io/blob/master/sling/commons/src/main/java/io/wcm/sling/commons/osgi/RankedServices.java]
which reduced the boilerplate code to a one-liner in each class that uses it.
usage example is
[here|https://github.com/wcm-io/wcm-io/blob/master/config/core/src/main/java/io/wcm/config/core/management/impl/ApplicationFinderImpl.java].
this could be a nice addition to sling osgi commons. i would be happy to
contribute it. to avoid a dependency update on the sling osgi commons in sling
models implementation we could copy it temporarily to the sling models
implementation.
ModelAdapterFactory uses wrong array size for
injectAnnotationProcessorFactories2
-
Key: SLING-4195
URL: https://issues.apache.org/jira/browse/SLING-4195
Project: Sling
Issue Type: Bug
Components: Extensions
Reporter: Konrad Windszus
Assignee: Konrad Windszus
Fix For: Sling Models Impl 1.2.0
The array sortedInjectAnnotationProcessorFactories2 in the
{{bindInjectAnnotationProcessorFactory2}} and
{{unbindInjectAnnotationProcessorFactory2}} is getting the wrong array size
due to a typo.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Jenkins build became unstable: sling-contrib-1.6 » Apache Sling Distribution Core #1375
See https://builds.apache.org/job/sling-contrib-1.6/org.apache.sling$org.apache.sling.distribution.core/1375/changes
Jenkins build is still unstable: sling-trunk-1.8 #478
See https://builds.apache.org/job/sling-trunk-1.8/changes
Jenkins build became unstable: sling-trunk-1.8 » Apache Sling Sample Integration Tests #478
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.testing.samples.integrationtests/478/
Jenkins build is back to stable : sling-trunk-1.8 » Apache Sling Event Support #478
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.event/478/
Build failed in Jenkins: sling-trunk-1.7 » Apache Sling Sample Integration Tests #1189
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.testing.samples.integrationtests/1189/ -- [INFO] [INFO] [INFO] Building Apache Sling Sample Integration Tests 1.0.7-SNAPSHOT [INFO] Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.junit.scriptable/1.0.8/org.apache.sling.junit.scriptable-1.0.8.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.junit.scriptable/1.0.8/org.apache.sling.junit.scriptable-1.0.8.pom (5 KB at 77.7 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.servlets.post/2.3.4/org.apache.sling.servlets.post-2.3.4.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.servlets.post/2.3.4/org.apache.sling.servlets.post-2.3.4.pom (7 KB at 109.6 KB/sec) Downloading: http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad/7-SNAPSHOT/maven-metadata.xml Downloading: http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad/7-SNAPSHOT/org.apache.sling.launchpad-7-SNAPSHOT.pom [WARNING] The POM for org.apache.sling:org.apache.sling.launchpad:jar:standalone:7-SNAPSHOT is missing, no dependency information available Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.servlets.post/2.3.4/org.apache.sling.servlets.post-2.3.4.jar Downloaded: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.servlets.post/2.3.4/org.apache.sling.servlets.post-2.3.4.jar (139 KB at 776.2 KB/sec) Downloading: http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad/7-SNAPSHOT/org.apache.sling.launchpad-7-SNAPSHOT-standalone.jar [JENKINS] Archiving disabled
Build failed in Jenkins: sling-trunk-1.7 #1189
See https://builds.apache.org/job/sling-trunk-1.7/1189/changes Changes: [tommaso] SLING-4153 - avoiding test failures due to difference in the encapsulating request time -- [...truncated 68609 lines...] [INFO] Apache Sling System Bundle Extension: WS APIs . SUCCESS [9.182s] [INFO] Apache Sling Dynamic Class Loader Support . SUCCESS [21.734s] [INFO] Apache Sling Commons Java Compiler SUCCESS [14.289s] [INFO] Apache Sling JSON Library . SUCCESS [14.882s] [INFO] Apache Sling SLF4J Implementation (Logback) ... SUCCESS [45.317s] [INFO] Apache Sling OSGi LogService Implementation ... SUCCESS [8.868s] [INFO] Apache Sling MIME type mapping support SUCCESS [12.198s] [INFO] Apache Sling Commons OSGi support . SUCCESS [12.185s] [INFO] Apache Sling Scheduler Support SUCCESS [9.404s] [INFO] Apache Sling Testing Utilities SUCCESS [20.842s] [INFO] Apache Sling Thread Dumper SUCCESS [7.380s] [INFO] Apache Sling Thread Support ... SUCCESS [8.883s] [INFO] Apache Sling Authentication Service ... SUCCESS [14.576s] [INFO] Apache Sling Form Based Authentication Handler SUCCESS [15.530s] [INFO] Apache Sling Engine Implementation SUCCESS [33.257s] [INFO] Apache Sling Repository API Bundle SUCCESS [9.450s] [INFO] Apache Sling JCR Base Bundle .. SUCCESS [14.402s] [INFO] Apache Sling JCR ClassLoader .. SUCCESS [9.380s] [INFO] Apache Sling Initial Content Loader ... SUCCESS [14.761s] [INFO] Apache Sling Jackrabbit Embedded Repository ... SUCCESS [23.846s] [INFO] Apache Sling Jackrabbit UserManager Support ... SUCCESS [12.256s] [INFO] Apache Sling Jackrabbit JSR-283 Access Control Manager Support SUCCESS [11.656s] [INFO] Apache Sling Wrapper Bundle for the JCR API ... SUCCESS [8.670s] [INFO] Apache Sling JCR Resource Resolver SUCCESS [48.066s] [INFO] Apache Sling JCR Repository Registration .. SUCCESS [9.646s] [INFO] Apache Sling Simple WebDAV Access to repositories . SUCCESS [11.494s] [INFO] Apache Sling DavEx Access to repositories . SUCCESS [12.436s] [INFO] Apache Sling JCR WebConsole Bundle SUCCESS [8.840s] [INFO] Apache Sling Oak Repository Server SUCCESS [11.855s] [INFO] Apache Sling SlingRepository Integration Tests SUCCESS [1:02.937s] [INFO] Apache Sling Servlet Resolver . SUCCESS [17.577s] [INFO] Apache Sling Default GET Servlets . SUCCESS [12.531s] [INFO] Apache Sling Default POST Servlets SUCCESS [18.184s] [INFO] Apache Sling Compat Servlets .. SUCCESS [8.401s] [INFO] Apache Sling Scripting Implementation API . SUCCESS [9.315s] [INFO] Apache Sling Scripting Core implementation SUCCESS [27.180s] [INFO] Apache Sling Scripting JavaScript Support . SUCCESS [21.732s] [INFO] Apache Sling Scripting JSP Support SUCCESS [18.321s] [INFO] Apache Sling JSP Tag Library .. SUCCESS [17.844s] [INFO] Apache Sling JSP Standard Tag Library . SUCCESS [10.056s] [INFO] Apache Sling Adapter Manager Implementation ... SUCCESS [14.312s] [INFO] Apache Sling Bundle Resource Provider . SUCCESS [7.258s] [INFO] Apache Sling Distributed Event Admin .. SUCCESS [14.822s] [INFO] Apache Sling Discovery API SUCCESS [8.804s] [INFO] Apache Sling Resource-Based Discovery Service . SUCCESS [3:02.408s] [INFO] Apache Sling Discovery Support Bundle . SUCCESS [7.134s] [INFO] Apache Sling Discovery Standalone Implementation .. SUCCESS [11.406s] [INFO] Apache Sling Event Support SUCCESS [12:53.345s] [INFO] Apache Sling Feature Flags SUCCESS [7.081s] [INFO] Apache Sling Filesystem Resource Provider . SUCCESS [9.340s] [INFO] Apache Sling javax.activation bundle .. SUCCESS [9.189s] [INFO] Apache Sling Service User Mapper .. SUCCESS [13.898s] [INFO] Apache Sling Settings . SUCCESS [10.003s] [INFO] Apache Sling Web Console Branding . SUCCESS [8.505s] [INFO] Apache Sling Web Console Security Provider SUCCESS [8.447s] [INFO] Apache Sling Explorer . SUCCESS [10.754s] [INFO] Apache Sling Health Check Core SUCCESS [15.901s] [INFO] Apache Sling Health Check Annotations . SUCCESS [8.441s] [INFO] Apache Sling Health Check Samples . SUCCESS [9.963s] [INFO] Apache Sling Health Check Support Components .. SUCCESS [14.042s] [INFO] Apache Sling Health Check Webconsole Plugin ... SUCCESS [8.649s] [INFO] Apache Sling Health Check JUnit Bridge
Build failed in Jenkins: sling-trunk-1.6 » Apache Sling Sample Integration Tests #2807
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.testing.samples.integrationtests/2807/ -- [INFO] [INFO] [INFO] Building Apache Sling Sample Integration Tests 1.0.7-SNAPSHOT [INFO] Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.junit.scriptable/1.0.8/org.apache.sling.junit.scriptable-1.0.8.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.junit.scriptable/1.0.8/org.apache.sling.junit.scriptable-1.0.8.pom (5 KB at 207.1 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.servlets.post/2.3.4/org.apache.sling.servlets.post-2.3.4.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.servlets.post/2.3.4/org.apache.sling.servlets.post-2.3.4.pom (7 KB at 363.4 KB/sec) Downloading: http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad/7-SNAPSHOT/maven-metadata.xml Downloading: http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad/7-SNAPSHOT/org.apache.sling.launchpad-7-SNAPSHOT.pom [WARNING] The POM for org.apache.sling:org.apache.sling.launchpad:jar:standalone:7-SNAPSHOT is missing, no dependency information available Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.servlets.post/2.3.4/org.apache.sling.servlets.post-2.3.4.jar Downloaded: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.servlets.post/2.3.4/org.apache.sling.servlets.post-2.3.4.jar (139 KB at 2105.2 KB/sec) Downloading: http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad/7-SNAPSHOT/org.apache.sling.launchpad-7-SNAPSHOT-standalone.jar [JENKINS] Archiving disabled
Build failed in Jenkins: sling-trunk-1.6 #2807
See https://builds.apache.org/job/sling-trunk-1.6/2807/changes Changes: [kwin] SLING-4195 array initialized to wrong size due to typo [tommaso] SLING-4153 - avoiding test failures due to difference in the encapsulating request time -- [...truncated 68466 lines...] [INFO] Apache Sling System Bundle Extension: WS APIs . SUCCESS [14.541s] [INFO] Apache Sling Dynamic Class Loader Support . SUCCESS [28.924s] [INFO] Apache Sling Commons Java Compiler SUCCESS [18.488s] [INFO] Apache Sling JSON Library . SUCCESS [18.102s] [INFO] Apache Sling SLF4J Implementation (Logback) ... SUCCESS [54.736s] [INFO] Apache Sling OSGi LogService Implementation ... SUCCESS [15.058s] [INFO] Apache Sling MIME type mapping support SUCCESS [17.985s] [INFO] Apache Sling Commons OSGi support . SUCCESS [17.387s] [INFO] Apache Sling Scheduler Support SUCCESS [15.832s] [INFO] Apache Sling Testing Utilities SUCCESS [29.054s] [INFO] Apache Sling Thread Dumper SUCCESS [14.704s] [INFO] Apache Sling Thread Support ... SUCCESS [16.924s] [INFO] Apache Sling Authentication Service ... SUCCESS [18.114s] [INFO] Apache Sling Form Based Authentication Handler SUCCESS [23.467s] [INFO] Apache Sling Engine Implementation SUCCESS [36.709s] [INFO] Apache Sling Repository API Bundle SUCCESS [14.415s] [INFO] Apache Sling JCR Base Bundle .. SUCCESS [17.729s] [INFO] Apache Sling JCR ClassLoader .. SUCCESS [15.197s] [INFO] Apache Sling Initial Content Loader ... SUCCESS [21.024s] [INFO] Apache Sling Jackrabbit Embedded Repository ... SUCCESS [29.614s] [INFO] Apache Sling Jackrabbit UserManager Support ... SUCCESS [17.697s] [INFO] Apache Sling Jackrabbit JSR-283 Access Control Manager Support SUCCESS [14.685s] [INFO] Apache Sling Wrapper Bundle for the JCR API ... SUCCESS [15.057s] [INFO] Apache Sling JCR Resource Resolver SUCCESS [50.916s] [INFO] Apache Sling JCR Repository Registration .. SUCCESS [15.062s] [INFO] Apache Sling Simple WebDAV Access to repositories . SUCCESS [15.273s] [INFO] Apache Sling DavEx Access to repositories . SUCCESS [17.331s] [INFO] Apache Sling JCR WebConsole Bundle SUCCESS [14.364s] [INFO] Apache Sling Oak Repository Server SUCCESS [17.656s] [INFO] Apache Sling SlingRepository Integration Tests SUCCESS [1:09.190s] [INFO] Apache Sling Servlet Resolver . SUCCESS [18.460s] [INFO] Apache Sling Default GET Servlets . SUCCESS [17.632s] [INFO] Apache Sling Default POST Servlets SUCCESS [24.197s] [INFO] Apache Sling Compat Servlets .. SUCCESS [15.138s] [INFO] Apache Sling Scripting Implementation API . SUCCESS [15.220s] [INFO] Apache Sling Scripting Core implementation SUCCESS [29.652s] [INFO] Apache Sling Scripting JavaScript Support . SUCCESS [26.133s] [INFO] Apache Sling Scripting JSP Support SUCCESS [24.096s] [INFO] Apache Sling JSP Tag Library .. SUCCESS [20.973s] [INFO] Apache Sling JSP Standard Tag Library . SUCCESS [14.663s] [INFO] Apache Sling Adapter Manager Implementation ... SUCCESS [15.134s] [INFO] Apache Sling Bundle Resource Provider . SUCCESS [15.097s] [INFO] Apache Sling Distributed Event Admin .. SUCCESS [20.787s] [INFO] Apache Sling Discovery API SUCCESS [12.033s] [INFO] Apache Sling Resource-Based Discovery Service . SUCCESS [3:03.940s] [INFO] Apache Sling Discovery Support Bundle . SUCCESS [14.042s] [INFO] Apache Sling Discovery Standalone Implementation .. SUCCESS [15.050s] [INFO] Apache Sling Event Support SUCCESS [13:15.317s] [INFO] Apache Sling Feature Flags SUCCESS [14.885s] [INFO] Apache Sling Filesystem Resource Provider . SUCCESS [12.247s] [INFO] Apache Sling javax.activation bundle .. SUCCESS [15.119s] [INFO] Apache Sling Service User Mapper .. SUCCESS [15.350s] [INFO] Apache Sling Settings . SUCCESS [15.114s] [INFO] Apache Sling Web Console Branding . SUCCESS [12.071s] [INFO] Apache Sling Web Console Security Provider SUCCESS [15.091s] [INFO] Apache Sling Explorer . SUCCESS [15.022s] [INFO] Apache Sling Health Check Core SUCCESS [24.248s] [INFO] Apache Sling Health Check Annotations . SUCCESS [11.966s] [INFO] Apache Sling Health Check Samples . SUCCESS [16.882s] [INFO] Apache Sling Health Check Support Components .. SUCCESS [17.959s] [INFO] Apache Sling Health Check Webconsole
Jenkins build is back to stable : sling-trunk-1.8 » Apache Sling Sample Integration Tests #479
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.testing.samples.integrationtests/479/
Jenkins build became unstable: sling-trunk-1.8 » Apache Sling SlingRepository Integration Tests #479
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.jcr.repository.it-jackrabbit-oak/479/
Jenkins build is still unstable: sling-trunk-1.8 #479
See https://builds.apache.org/job/sling-trunk-1.8/changes
Jenkins build is unstable: sling-trunk-1.7 » Apache Sling Launchpad Testing #1190
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.launchpad.testing/1190/
Jenkins build became unstable: sling-trunk-1.7 » Apache Sling Installer Integration Tests #1190
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.installer.it/1190/
Jenkins build is back to normal : sling-trunk-1.7 » Apache Sling Sample Integration Tests #1190
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.testing.samples.integrationtests/1190/
Jenkins build is unstable: sling-trunk-1.7 #1190
See https://builds.apache.org/job/sling-trunk-1.7/1190/changes
Re: Old website content on Confluence, should we remove it?
Hi I think the SLINGxSITE always only served as the source for the site. Information there is outdated. I think we can just drop the space. Regards Felix Am 24.11.2014 um 11:27 schrieb Bertrand Delacretaz bdelacre...@apache.org: Hi, https://cwiki.apache.org/confluence/display/SLINGxSITE/ was used to generate our website before switching to the Apache CMS. So it has an outdated version of our content that's useless AFAICS. Shall we delete that wiki space now? Or just leave a single page that points to sling.apache.org ? -Bertrand
Re: [Sightly] API vs. Implementation
Hi Felix, I've pushed some new changes: BaseRenderUnit is now a part of impl. RenderContext should indeed become an interface. Also, I think that we can get rid of the UnitLocator interface, therefore reducing the size of the exported API to the bare minimum. Thanks, Radu On Mon, Nov 24, 2014 at 12:36 PM, Felix Meschberger fmesc...@adobe.com wrote: Hi Radu Am 21.11.2014 um 18:39 schrieb Radu Cotescu r...@apache.org: Hi Felix, I pushed all the required changes to the forked repo. Things left to do: * check what we actually need to export for preventing class loading problems Excellent. I would prefer to really not export most of the RenderUnit stuff incl. BaseRenderUnit and RenderContext. At one point I had a change, where I actually had RenderContext as an interface with a subset of the API, basically just getWriter (does that need to be a StackedWriter after all ?) and a RenderContextImpl which had all the rest but was internal. * expand JavaDoc At this point I think that we can create a patch with our changes and apply it to trunk. We might want to continue on the fork to find the classes that we really want/need to export. Because this may cause further shuffling of packages etc. Thanks Felix Cheers, Radu On Thu, Nov 20, 2014 at 6:53 PM, Felix Meschberger fmesc...@adobe.com wrote: Hi Thanks for your reply. For those interested in following, Radu and I are cooperating on these changes in my GitHub fork at https://github.com/fmeschbe/sling Am 19.11.2014 um 22:53 schrieb Radu Cotescu r...@cotescu.com: Hi Felix, The API reorganisation looks good to me. On Wed, Nov 19, 2014 at 10:49 PM, Felix Meschberger fmesc...@adobe.com wrote: Apart from splitting the base .api package, this are further discussions: * Exceptions are forming a hierarchy with SightlyEngineException being the root and itself extending from SlingException Sure, it makes sense. Done in the fork. The „root“ exception for Sightly is not SightlyException (SightlyEngineException renamed to SightlyException). * I wonder, whether we should really drop the *Component abstract classes (RuntimeExtensionComponent and UseProviderComponent). I don’t think they provide real value at all but have an activate method, which they expect to be called and which they expect to be a DS component annotated with the Felix annotations. I think this is brittle. The abstract classes were written specifically for that activate method, in order to avoid writing those lines of code for every implementation. We are working on removing these abstract classes by leveraging service properties for * UseProvider ranking (service.ranking) * ExtensionProvider naming * UseProvider defines an ordering method and declares itself being Comparable. I think this is wrong. The UseProviders should be sorted using regular OSGi service ranking. If we make the service.ranking property configurable (metatype = true) I guess we could use the OSGi ranking. Theoretically the Use providers can be configured to be called in a pre-determined order, depending on how the Sightly projects from an instance make use of the Use-API (Java Use-API objects deployed in bundles / Java Use objects near the component script in the repo / JS Use-API, etc.). Having the Use providers called in the most favourable way can increase performance for Sightly applications. Yes, the service.ranking property can be added to metatype for configurable ranking. * I wonder, whether we really have to have all this API exported at all: Some API I don’t see implemented at all (e.g. BaseRenderUnit — or is that the base class for the Java classes generated from the Sightly templates ?) The BaseRenderUnit is indeed the base class for classes generated from Sightly scripts, which is why we need to export the other classes as well. In this regard Sightly is no different from the JSP engine. Ok. We’d have to test this more. But I suspect we don’t really need to export the BaseRenderUnit abstract class. IIRC the reason for exporting the base JSP servlet is that other classes in the same package must be exported. * Last but not least (actually most important of all): There is close to no JavaDoc. Before cutting a release of this bundle, JavaDoc must be provided for the API. For example I am not sure, what the Record or the ObjectModel interfaces are really used for. It's on my TODO list. Cool. Thanks. Regards Felix
[VOTE] Release Apache Sling Resource Merger version 1.2.0
Hi, We solved 5 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12326552 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1153/ You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 1153 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours.
Jenkins build is back to stable : sling-trunk-1.8 #480
See https://builds.apache.org/job/sling-trunk-1.8/480/changes
