[jira] [Resolved] (SLING-4943) ResourceNotFoundException: Include resource path in the getMessage() method
[
https://issues.apache.org/jira/browse/SLING-4943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved SLING-4943.
Resolution: Fixed
Fixed with https://svn.apache.org/r1697957.
ResourceNotFoundException: Include resource path in the getMessage() method
---
Key: SLING-4943
URL: https://issues.apache.org/jira/browse/SLING-4943
Project: Sling
Issue Type: Bug
Components: API
Affects Versions: API 2.9.0
Reporter: Konrad Windszus
Fix For: API 2.10.0
Currently if instantiating a {{ResourceNotFoundException}} with both a
resource path and a message only the message is given out. That is e.g. a
problem in {{DefaultGetServlet}}
(https://github.com/apache/sling/blob/trunk/bundles/servlets/get/src/main/java/org/apache/sling/servlets/get/impl/DefaultGetServlet.java#L218).
That leads to exceptions like this in the log
{code}
...
org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
at
org.apache.sling.engine.impl.SlingRequestProcessorImpl.dispatchRequest(SlingRequestProcessorImpl.java:322)
at
org.apache.sling.engine.impl.request.SlingRequestDispatcher.dispatch(SlingRequestDispatcher.java:216)
at
org.apache.sling.engine.impl.request.SlingRequestDispatcher.include(SlingRequestDispatcher.java:103)
at
...
Caused by: org.apache.sling.api.resource.ResourceNotFoundException: No
resource found
at
org.apache.sling.servlets.get.impl.DefaultGetServlet.doGet(DefaultGetServlet.java:219)
at
org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:269)
at
org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:345)
at
org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:376)
at
org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:533)
at
org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
at
org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:77)
at
org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:68)
...
{code}
You basically have no clue which resource path was requested (especially if
the request was issued through request dispatching. Therefore I propose to
always include the resource path in the message given out by {{getMessage()}}
or {{getLocalizedMessage()}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: content-package-maven-plugin and tooling around it
Almost two years passed and still no sign of the content-package-maven-plugin in the open-source world. Is it probable that this will happen soon? Thanks, Konrad On 14 May 2014, at 15:01, Konrad Windszus konra...@gmx.de wrote: Is there any news about that? Maybe a rough timeline, when the content-package-maven-plugin is becoming Open Source? I would like to get my patch https://issues.apache.org/jira/browse/SLING-3100 in the Sling IDE Tooling in one of the first releases if possible. Thanks, Konrad On 30 Oct 2013, at 08:18, Tobias Bocanegra tri...@day.com wrote: Hi, we will donate the content-package maven plugin (and package manager) to Apache Jackrabbit soon. we just need some time to finalize the contribution. Thanks for your understanding and patience. Regards. Toby On Tue, Oct 29, 2013 at 6:42 AM, Robert Munteanu rob...@lmn.ro wrote: Hi Konrad, On Tue, Oct 29, 2013 at 2:34 PM, Konrad Windszus konra...@gmx.de wrote: Hi, unfortunately right now Sling only supports OSGi bundles as a deployable artifacts (however, the bundles might be extended by JCR content with the help of [0]). On the other hand there is already the content-package-maven-plugin from Adobe [1], which wraps parts of a JCR repository into a deployable artifact (leveraging the JackrabbitFileVaultFS [2]). I would like to extend the Sling IDE Tooling with a custom m2e project configurator for the packaging “content-package”. Right now the patch is not integrated because of the unclear status of the content-package-maven-plugin [3]. Is it supposed to become Open Source like FileVault as indicated in [4]? Do you think that such a m2e project configurator should become part of the Sling IDE Tooling? Just to restate my opinion, I definitely think this configurator should be part of the Sling tooling. However, I'm reluctant to include it until the actual maven plugin is open-sourced. The main reason is that this will not be applicable for/testable by many users, due to its licensing/availability. Robert Thanks for your input on this topic, Konrad [0] - http://sling.apache.org/site/content-loading-jcrcontentloader.html [1] - http://dev.day.com/docs/en/cq/current/core/how_to/how_to_use_the_vlttool/vlt-mavenplugin.html [2] - http://wiki.apache.org/jackrabbit/JackrabbitFileVaultFS [3] - https://issues.apache.org/jira/browse/SLING-3100 [4] - http://mail-archives.apache.org/mod_mbox/jackrabbit-dev/201305.mbox/%3CCAB+dfim97qLN=mv+dleddovvsh5j6puq_2nd9gbr7djo3in...@mail.gmail.com%3E -- Sent from my (old) computer
[jira] [Resolved] (SLING-4938) sling-mock: Transitive dependency reflections includes very old xml-apis
[
https://issues.apache.org/jira/browse/SLING-4938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved SLING-4938.
Resolution: Fixed
Fix Version/s: Testing Sling Mock 1.4.2
Fixed with http://svn.apache.org/r1697964.
sling-mock: Transitive dependency reflections includes very old xml-apis
Key: SLING-4938
URL: https://issues.apache.org/jira/browse/SLING-4938
Project: Sling
Issue Type: Improvement
Components: Testing
Affects Versions: Testing Sling Mock 1.4.0
Reporter: Konrad Windszus
Fix For: Testing Sling Mock 1.4.2
Whenever a maven project depends on {{o.a.s.testing.sling-mock}} it
automatically depends on {{xml-apis}} in version {{1.0.b2}}.
This is problematic as this is not only a very old version but also it is
very hard to determine which version should be used with which JRE
(http://stackoverflow.com/questions/11677572/dealing-with-xerces-hell-in-java-maven).
Therefore could we just explicitly ignore the transitive dependency {{dom4j}}
on the dependency {{reflections}} within {{sling-mock}}?
I see that {{reflections}} is only used in {{ModelAdapterFactoryUtil}} and I
don't see why {{dom4j}} would be necessary there. Maybe we could also get rid
of the other optional dependencies {{javassist}}, {{slf4j-api}}, {{gson}},
{{servlet-api}} (https://github.com/ronmamo/reflections/blob/master/pom.xml)?
That way the classpath would be much leaner and cleaner.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: add JMX MBean for Sling Servlet Filter
Hi, On Wed, Aug 26, 2015 at 8:44 AM, Antonio Sanso asa...@adobe.com wrote: ...it would be nice to have some feedback of which are the statistic we should incorporate Would it make sense to consider the JMX Bean and webconsole plugin as just two views on the same data? That would make things simpler in terms of documentation, for example. -Bertrand
Re: add JMX MBean for Sling Servlet Filter
On Wed, Aug 26, 2015 at 9:25 AM, Antonio Sanso asa...@adobe.com wrote: On Aug 26, 2015, at 9:55 AM, Bertrand Delacretaz bdelacre...@apache.org wrote: ...typically JMX statistics are much more concise than the one we provided in the console I think the following info (provided in a structured way in JMX) is all good to have: 0 : class org.apache.sling.launchpad.testservices.filters.SlingFilter (id: 298, property: none); called: 14; time: 1ms; time/call: 71µs Min/max timings might also be useful to have. And if you represent that as a tree of filters organized in categories that would be convenient IMO, I don't think that's too much information. -Bertrand
Re: add JMX MBean for Sling Servlet Filter
On Aug 26, 2015, at 9:55 AM, Bertrand Delacretaz bdelacre...@apache.org wrote: Hi, On Wed, Aug 26, 2015 at 8:44 AM, Antonio Sanso asa...@adobe.com wrote: ...it would be nice to have some feedback of which are the statistic we should incorporate Would it make sense to consider the JMX Bean and webconsole plugin as just two views on the same data? that it was i had in mind. But typically JMX statistics are much more concise than the one we provided in the console. unless I am wrong :) regards antonio That would make things simpler in terms of documentation, for example. -Bertrand
[jira] [Commented] (SLING-4969) Store aggregated model as artifact
[ https://issues.apache.org/jira/browse/SLING-4969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14713517#comment-14713517 ] Carsten Ziegeler commented on SLING-4969: - First step in rev 1697936 Store aggregated model as artifact -- Key: SLING-4969 URL: https://issues.apache.org/jira/browse/SLING-4969 Project: Sling Issue Type: Improvement Components: Maven Plugins and Archetypes Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Slingstart Maven Plugin 1.3.4 If a model has a dependency to another model, we should store the aggregated model as the attached artifact. Right now the original model with the references is stored. This has at least two problems: - a diff between versions is more difficult as you only get a diff of the reference but not of the artifacts of the included model - further processing with tooling requires the same logic as the slingstart plugin -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4969) Store aggregated model as artifact
[ https://issues.apache.org/jira/browse/SLING-4969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14713532#comment-14713532 ] Carsten Ziegeler commented on SLING-4969: - Fixed accidental variable replacement in rev 1697946 Store aggregated model as artifact -- Key: SLING-4969 URL: https://issues.apache.org/jira/browse/SLING-4969 Project: Sling Issue Type: Improvement Components: Maven Plugins and Archetypes Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Slingstart Maven Plugin 1.3.4 If a model has a dependency to another model, we should store the aggregated model as the attached artifact. Right now the original model with the references is stored. This has at least two problems: - a diff between versions is more difficult as you only get a diff of the reference but not of the artifacts of the included model - further processing with tooling requires the same logic as the slingstart plugin -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (SLING-4969) Store aggregated model as artifact
[ https://issues.apache.org/jira/browse/SLING-4969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-4969. - Resolution: Fixed Store aggregated model as artifact -- Key: SLING-4969 URL: https://issues.apache.org/jira/browse/SLING-4969 Project: Sling Issue Type: Improvement Components: Maven Plugins and Archetypes Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Slingstart Maven Plugin 1.3.4 If a model has a dependency to another model, we should store the aggregated model as the attached artifact. Right now the original model with the references is stored. This has at least two problems: - a diff between versions is more difficult as you only get a diff of the reference but not of the artifacts of the included model - further processing with tooling requires the same logic as the slingstart plugin -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (SLING-4969) Store aggregated model as artifact
Carsten Ziegeler created SLING-4969: --- Summary: Store aggregated model as artifact Key: SLING-4969 URL: https://issues.apache.org/jira/browse/SLING-4969 Project: Sling Issue Type: Improvement Components: Maven Plugins and Archetypes Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Slingstart Maven Plugin 1.3.4 If a model has a dependency to another model, we should store the aggregated model as the attached artifact. Right now the original model with the references is stored. This has at least two problems: - a diff between versions is more difficult as you only get a diff of the reference but not of the artifacts of the included model - further processing with tooling requires the same logic as the slingstart plugin -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[VOTE] Release Slingstart Maven Plugin 1.3.4
Hi, we solved one issue: https://issues.apache.org/jira/browse/SLING-4969 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1318/ You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 1318 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
Re: add JMX MBean for Sling Servlet Filter
nice one and thanks Bertrand . Really appreciated your feedback! regards antonio On Aug 26, 2015, at 10:34 AM, Bertrand Delacretaz bdelacre...@apache.org wrote: On Wed, Aug 26, 2015 at 9:25 AM, Antonio Sanso asa...@adobe.com wrote: On Aug 26, 2015, at 9:55 AM, Bertrand Delacretaz bdelacre...@apache.org wrote: ...typically JMX statistics are much more concise than the one we provided in the console I think the following info (provided in a structured way in JMX) is all good to have: 0 : class org.apache.sling.launchpad.testservices.filters.SlingFilter (id: 298, property: none); called: 14; time: 1ms; time/call: 71µs Min/max timings might also be useful to have. And if you represent that as a tree of filters organized in categories that would be convenient IMO, I don't think that's too much information. -Bertrand
Re: [VOTE] Release Slingstart Maven Plugin 1.3.4
+1 -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
Re: [VOTE] Release Slingstart Maven Plugin 1.3.4
+1 Cheers, Stefan On 26/08/15 16:53, Carsten Ziegeler cziege...@apache.org wrote: Hi, we solved one issue: https://issues.apache.org/jira/browse/SLING-4969 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1318/ You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 1318 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
