[jira] [Commented] (SLING-5831) Support different thread pools for scheduled tasks

[Chetan Mehrotra (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15383602#comment-15383602
 ] 

Chetan Mehrotra commented on SLING-5831:


Tried using the snapshot version to check with Oak. 

# Startup threw NPE as {{allowedPoolNames}} was null. So that would need to be 
initialized
{noformat}
2016-07-19 10:38:40,639 ERROR NA [FelixStartLevel] o.a.sling.commons.scheduler 
- [org.apache.sling.commons.scheduler.impl.QuartzScheduler(156)] The activate 
method has thrown an exception (java.lang.NullPointerException) 
java.lang.NullPointerException: null
at 
org.apache.sling.commons.scheduler.impl.QuartzScheduler.activate(QuartzScheduler.java:137)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at 
org.apache.felix.scr.impl.helper.BaseMethod.invokeMethod(BaseMethod.java:222)
at 
org.apache.felix.scr.impl.helper.BaseMethod.access$500(BaseMethod.java:37)
at 
org.apache.felix.scr.impl.helper.BaseMethod$Resolved.invoke(BaseMethod.java:615)
at 
org.apache.felix.scr.impl.helper.BaseMethod.invoke(BaseMethod.java:499)
at 
org.apache.felix.scr.impl.helper.ActivateMethod.invoke(ActivateMethod.java:295)
{noformat}
# If some job is unregistered which was probably not registered (not sure of 
scenario) then it logs following exception. It does not used to come so far. 
Looking at {{removeJob}} logic I think it would now throw exception if job was 
not registered. While earlier a remove job would have just been a noop if job 
did not existed. So may be 
{noformat}
2016-07-19 10:55:00,357 ERROR NA [CM Event Dispatcher (Fire ConfigurationEvent: 
pid=org.apache.sling.commons.scheduler.impl.QuartzScheduler)] 
c.a.g.w.c.m.WorkflowStatsMBeanImpl - Failed to schedule workflow mbean job 
java.util.NoSuchElementException: No job found with name 
com.adobe.granite.workflow.core.mbean.WorkflowStatsMBean
at 
org.apache.sling.commons.scheduler.impl.QuartzScheduler.removeJob(QuartzScheduler.java:453)
at 
org.apache.sling.commons.scheduler.impl.SchedulerServiceFactory.removeJob(SchedulerServiceFactory.java:188)
at 
com.adobe.granite.workflow.core.mbean.WorkflowStatsMBeanImpl.unscheduleSelf(WorkflowStatsMBeanImpl.java:293)
at 
com.adobe.granite.workflow.core.mbean.WorkflowStatsMBeanImpl.scheduleSelf(WorkflowStatsMBeanImpl.java:280)
at 
com.adobe.granite.workflow.core.mbean.WorkflowStatsMBeanImpl.activate(WorkflowStatsMBeanImpl.java:128)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at 
org.apache.felix.scr.impl.helper.BaseMethod.invokeMethod(BaseMethod.java:222)
{noformat}

Apart from that things seem to work fine. I can see two section in status
{noformat}
Apache Sling Scheduler

Status : active
Name  : ApacheSlingdefault
ThreadPool: default
Id: Tue_Jul_19_10:54:59_IST_20161637082656

Job : Registered Service.574, class: 
org.apache.jackrabbit.oak.jcr.observation.ChangeProcessor$3, concurrent: false, 
bundleId: 76, serviceId: 574
Trigger : Trigger 'DEFAULT.Registered Service.574':  triggerClass: 
'org.quartz.impl.triggers.SimpleTriggerImpl calendar: 'null' 
misfireInstruction: 0 nextFireTime: Tue Jul 19 10:55:13 IST 2016
...

Name  : ApacheSlingoak
ThreadPool: oak
Id: Tue_Jul_19_10:55:00_IST_20161797561492

Job : Registered Service.269, class: 
org.apache.jackrabbit.oak.plugins.index.AsyncIndexUpdate, concurrent: false, 
runOn: [SINGLE], bundleId: 76, serviceId: 269
Trigger : Trigger 'DEFAULT.Registered Service.269':  triggerClass: 
'org.quartz.impl.triggers.SimpleTriggerImpl calendar: 'null' 
misfireInstruction: 0 nextFireTime: Tue Jul 19 10:55:15 IST 2016

Job : Registered Service.266, class: 
org.apache.jackrabbit.oak.plugins.index.AsyncIndexUpdate, concurrent: false, 
runOn: [SINGLE], bundleId: 76, serviceId: 266
Trigger : Trigger 'DEFAULT.Registered Service.266':  triggerClass: 
'org.quartz.impl.triggers.SimpleTriggerImpl calendar: 'null' 
misfireInstruction: 0 nextFireTime: Tue Jul 19 10:55:15 IST 2016
{noformat}

> Support different thread pools for scheduled tasks
> --
>
> Key: SLING-5831
> URL: https://issues.apache.org/jira/browse/SLING-5831
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Reporter: Carsten Ziegeler
>Assignee: 

[jira] [Updated] (SLING-5831) Support different thread pools for scheduled tasks

[Chetan Mehrotra (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra updated SLING-5831:
---
Labels: docs-impacting  (was: )

> Support different thread pools for scheduled tasks
> --
>
> Key: SLING-5831
> URL: https://issues.apache.org/jira/browse/SLING-5831
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>  Labels: docs-impacting
> Fix For: Commons Scheduler 2.4.16
>
>
> Right now the scheduler uses a single thread pool. While this thread pool can 
> be configured, it means that all scheduled tasks share this pool. In order to 
> prioratize different tasks over others and avoid blocking important jobs 
> through unimportant once, we could maybe add a configuration property to 
> select a thread pool name.
> If a pool with that name exists, it's used - if not the default is used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ApacheCon: Getting the word out internally

[Melissa Warnkin]

ApacheCon: Getting the word out internally
Dear Apache Enthusiast,

As you are no doubt already aware, we will be holding ApacheCon in
Seville, Spain, the week of November 14th, 2016. The call for papers
(CFP) for this event is now open, and will remain open until
September 9th.

The event is divided into two parts, each with its own CFP. The first
part of the event, called Apache Big Data, focuses on Big Data
projects and related technologies.

Website: http://events.linuxfoundation.org/events/apache-big-data-europe
CFP:
http://events.linuxfoundation.org/events/apache-big-data-europe/program/cfp

The second part, called ApacheCon Europe, focuses on the Apache
Software Foundation as a whole, covering all projects, community
issues, governance, and so on.

Website: http://events.linuxfoundation.org/events/apachecon-europe
CFP: http://events.linuxfoundation.org/events/apachecon-europe/program/cfp

ApacheCon is the official conference of the Apache Software
Foundation, and is the best place to meet members of your project and
other ASF projects, and strengthen your project's community.

If your organization is interested in sponsoring ApacheCon, contact Rich Bowen
at e...@apache.org  ApacheCon is a great place to find the brightest
developers in the world, and experts on a huge range of technologies.

I hope to see you in Seville!
==

Melissaon behalf of the ApacheCon Team

[jira] [Resolved] (SLING-5865) Models Impl: Update to org.apache.sling.commons.osgi 2.4.0

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert resolved SLING-5865.
---
Resolution: Fixed

Completed: At revision: 1753268  


> Models Impl: Update to org.apache.sling.commons.osgi 2.4.0
> --
>
> Key: SLING-5865
> URL: https://issues.apache.org/jira/browse/SLING-5865
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Sling Models Impl 1.2.8
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Minor
>  Labels: models
> Fix For: Sling Models Impl 1.2.10
>
>
> currently an older org.apache.sling.commons.osgi is included not featuring 
> the latest signature changes to ServiceUtil from SLING-5041. this class is 
> also used in sling-mock and osgi-mock based unit tests.
> the models impl bundle includes the ServiceUtil class in its bundle instead 
> of creating a runtime dependency to it. this creates problem when running 
> unit tests within an IDE or command line because there the OSGi classpath 
> isolation does not take place and the tests may fail with method signature 
> errors.
> to avoid this on future releases we should update to the latest 
> org.apache.sling.commons.osgi 2.4.0.
> workaround for the existing releases is to control the dependency order for 
> the unittest and ensure that org.apache.sling.commons.osgi comes first.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (SLING-5864) i18n: Update to org.apache.sling.commons.osgi 2.4.0

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert resolved SLING-5864.
---
Resolution: Fixed

Completed: At revision: 1753267  


> i18n: Update to org.apache.sling.commons.osgi 2.4.0
> ---
>
> Key: SLING-5864
> URL: https://issues.apache.org/jira/browse/SLING-5864
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: i18n 2.4.6
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Minor
> Fix For: i18n 2.4.8
>
>
> currently an older org.apache.sling.commons.osgi is included not featuring 
> the latest signature changes to ServiceUtil from SLING-5041. this class is 
> also used in sling-mock and osgi-mock based unit tests.
> the i18n bundle includes the ServiceUtil class in its bundle instead of 
> creating a runtime dependency to it. this creates problem when running unit 
> tests within an IDE or command line because there the OSGi classpath 
> isolation does not take place and the tests may fail with method signature 
> errors.
> to avoid this on future releases we should update to the latest 
> org.apache.sling.commons.osgi 2.4.0.
> workaround for the existing releases is to control the dependency order for 
> the unittest and ensure that org.apache.sling.commons.osgi comes first.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (SLING-5865) Models Impl: Update to org.apache.sling.commons.osgi 2.4.0

[Stefan Seifert (JIRA)]

Stefan Seifert created SLING-5865:
-

 Summary: Models Impl: Update to org.apache.sling.commons.osgi 2.4.0
 Key: SLING-5865
 URL: https://issues.apache.org/jira/browse/SLING-5865
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Affects Versions: Sling Models Impl 1.2.8
Reporter: Stefan Seifert
Assignee: Stefan Seifert
Priority: Minor
 Fix For: Sling Models Impl 1.2.10


currently an older org.apache.sling.commons.osgi is included not featuring the 
latest signature changes to ServiceUtil from SLING-5041. this class is also 
used in sling-mock and osgi-mock based unit tests.

the models impl bundle includes the ServiceUtil class in its bundle instead of 
creating a runtime dependency to it. this creates problem when running unit 
tests within an IDE or command line because there the OSGi classpath isolation 
does not take place and the tests may fail with method signature errors.

to avoid this on future releases we should update to the latest 
org.apache.sling.commons.osgi 2.4.0.

workaround for the existing releases is to control the dependency order for the 
unittest and ensure that org.apache.sling.commons.osgi comes first.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (SLING-5864) i18n: Update to org.apache.sling.commons.osgi 2.4.0

[Stefan Seifert (JIRA)]

Stefan Seifert created SLING-5864:
-

 Summary: i18n: Update to org.apache.sling.commons.osgi 2.4.0
 Key: SLING-5864
 URL: https://issues.apache.org/jira/browse/SLING-5864
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Affects Versions: i18n 2.4.6
Reporter: Stefan Seifert
Assignee: Stefan Seifert
Priority: Minor
 Fix For: i18n 2.4.8


currently an older org.apache.sling.commons.osgi is included not featuring the 
latest signature changes to ServiceUtil from SLING-5041. this class is also 
used in sling-mock and osgi-mock based unit tests.

the i18n bundle includes the ServiceUtil class in its bundle instead of 
creating a runtime dependency to it. this creates problem when running unit 
tests within an IDE or command line because there the OSGi classpath isolation 
does not take place and the tests may fail with method signature errors.

to avoid this on future releases we should update to the latest 
org.apache.sling.commons.osgi 2.4.0.

workaround for the existing releases is to control the dependency order for the 
unittest and ensure that org.apache.sling.commons.osgi comes first.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (SLING-5863) Make the sightly-maven-plugin m2e compatible

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-5863:
---
Attachment: 0001-SLING-5863-Make-the-sightly-maven-plugin-m2e-compati.patch

[~radu.cotescu] - I've taken a stab at an initial patch which seems to work for 
me. Tests work, and Eclipse is happy about the result.

WDYT?

> Make the sightly-maven-plugin m2e compatible
> 
>
> Key: SLING-5863
> URL: https://issues.apache.org/jira/browse/SLING-5863
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
> Fix For: Sightly Maven Plugin 1.0.0
>
> Attachments: 
> 0001-SLING-5863-Make-the-sightly-maven-plugin-m2e-compati.patch
>
>
> Maven plug-ins can easily be made compatible with m2e for transparent 
> integration with Eclipse.
> We should add this to the sightly-maven-plugin and make the compilation 
> results available in Eclipse.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (SLING-5863) Make the sightly-maven-plugin m2e compatible

[Robert Munteanu (JIRA)]

Robert Munteanu created SLING-5863:
--

 Summary: Make the sightly-maven-plugin m2e compatible
 Key: SLING-5863
 URL: https://issues.apache.org/jira/browse/SLING-5863
 Project: Sling
  Issue Type: Improvement
  Components: Maven Plugins and Archetypes
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Sightly Maven Plugin 1.0.0


Maven plug-ins can easily be made compatible with m2e for transparent 
integration with Eclipse.

We should add this to the sightly-maven-plugin and make the compilation results 
available in Eclipse.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [DISCUSS] Path filtering support for ResourceChangeListeners

[Radu Cotescu]

Hi,

I'm also a supporter of the glob pattern matching, since those filters are
easier to write than RegEx [3] (and not just because we'd have to escape
every '/'). We could try to support the full syntax described at [4],
though, if we need more flexibility.

Regards,
Radu

[3] - https://xkcd.com/1171/
[4] -
https://docs.oracle.com/javase/7/docs/api/java/nio/file/FileSystem.html#getPathMatcher(java.lang.String
)

On Sat, 16 Jul 2016 at 17:56 Carsten Ziegeler  wrote:

> I think we should keep it simple and model it based on existing use cases.
> So far, the only pattern matching which comes to my mind is matching
> based on the extension. Basically everything that is caching something
> requires this, like the jsp engine being interested in changes of *.jsp
> files etc.
> Apart from that listeners are usually interested in changes in a
> specific sub tree, but without any additional filtering.
>
> Therefore I think the **, * matching similar to what we know from Ant or
> Maven or other tools should be enough.
>
> I wouldn't go with more powerful matching as the idea of the RCLs is
> that the filter matching is done by the underlying storage provider,
> e.g. Oak. This allows to delegate the heavy work to the storage and
> reduce the number of events send by the storage to Sling. Of course, if
> the storage can't filter itself, the Sling provider implementation can
> still do an additional filtering, but that might be rather expensive.
>
> Regards
> Carsten
>
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziege...@apache.org
>
>

[jira] [Comment Edited] (SLING-920) Sling Jenkins setup

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382202#comment-15382202
 ] 

Robert Munteanu edited comment on SLING-920 at 7/18/16 12:29 PM:
-

Updated trunk 7 and 8 builds to only use 
{{ubuntu-1||ubuntu-2||ubuntu-4||ubuntu-5||ubuntu-6}} , which according to INFRA 
are guaranteed to be properly configured in terms of Maven versions.


was (Author: rombert):
Updated trunk 7 and 8 builds to only use 
{{ubuntu-1||ubuntu-2||ubuntu-4||ubuntu-5||ubuntu-6 }} , which according to 
INFRA are guaranteed to be properly configured in terms of Maven versions.

> Sling Jenkins setup
> ---
>
> Key: SLING-920
> URL: https://issues.apache.org/jira/browse/SLING-920
> Project: Sling
>  Issue Type: Task
>  Components: Testing
>Reporter: Bertrand Delacretaz
>
> Use this issue to record changes to the Jenkins setup at 
> https://builds.apache.org/view/S-Z/view/Sling/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-920) Sling Jenkins setup

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382202#comment-15382202
 ] 

Robert Munteanu commented on SLING-920:
---

Updated trunk 7 and 8 builds to only use 
{{ubuntu-1||ubuntu-2||ubuntu-4||ubuntu-5||ubuntu-6 }} , which according to 
INFRA are guaranteed to be properly configured in terms of Maven versions.

> Sling Jenkins setup
> ---
>
> Key: SLING-920
> URL: https://issues.apache.org/jira/browse/SLING-920
> Project: Sling
>  Issue Type: Task
>  Components: Testing
>Reporter: Bertrand Delacretaz
>
> Use this issue to record changes to the Jenkins setup at 
> https://builds.apache.org/view/S-Z/view/Sling/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-920) Sling Jenkins setup

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382145#comment-15382145
 ] 

Robert Munteanu commented on SLING-920:
---

As "Maven 3 (latest)" caused a failure on Jenkins slave H11, I've switched to 
"maven-3.3.9" which INFRA just added ( see INFRA-12296 ).

> Sling Jenkins setup
> ---
>
> Key: SLING-920
> URL: https://issues.apache.org/jira/browse/SLING-920
> Project: Sling
>  Issue Type: Task
>  Components: Testing
>Reporter: Bertrand Delacretaz
>
> Use this issue to record changes to the Jenkins setup at 
> https://builds.apache.org/view/S-Z/view/Sling/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-5860) Require maven version 3.3.9

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382143#comment-15382143
 ] 

Carsten Ziegeler commented on SLING-5860:
-

Thanks, I've switchted back to 3.3.9 now and set Jenkins to use "latest". Once 
a newer Maven version is out, we can change Jenkins to use 3.3.9

> Require maven version 3.3.9
> ---
>
> Key: SLING-5860
> URL: https://issues.apache.org/jira/browse/SLING-5860
> Project: Sling
>  Issue Type: Improvement
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Parent 27
>
>
> According to http://maven.apache.org/download.cgi
> Maven 3.3.9 is the recommended version for all users. We should require it in 
> the parent pom



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (SLING-5520) Update Oak to 1.4

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-5520.
-
Resolution: Done

> Update Oak to 1.4
> -
>
> Key: SLING-5520
> URL: https://issues.apache.org/jira/browse/SLING-5520
> Project: Sling
>  Issue Type: Task
>  Components: JCR, Launchpad, Oak
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
> Fix For: Launchpad Karaf Features 0.2.0, JCR Oak Server 1.0.2, 
> Launchpad Builder 9, JCR Oak Server 1.1.0
>
>
> Doing update in several more steps until Oak {{1.4}} is released due to major 
> changes, one of them being OAK-3842 (removed package exports, tracked in 
> SLING-5511).
> First updating to Oak {{1.3.14}} (latest pre OAK-3842 release) and then to 
> Oak {{1.3.15}}.
> Features deprecated for Oak {{1.4}} should be removed from 
> {{org.apache.sling.jcr.oak.server}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (SLING-5860) Require maven version 3.3.9

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-5860:

Summary: Require maven version 3.3.9  (was: Require maven version 3.3.3)

> Require maven version 3.3.9
> ---
>
> Key: SLING-5860
> URL: https://issues.apache.org/jira/browse/SLING-5860
> Project: Sling
>  Issue Type: Improvement
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Parent 27
>
>
> According to http://maven.apache.org/download.cgi
> Maven 3.3.9 is the recommended version for all users. We should require it in 
> the parent pom



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (SLING-920) Sling Jenkins setup

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382089#comment-15382089
 ] 

Carsten Ziegeler edited comment on SLING-920 at 7/18/16 11:52 AM:
--

Increased the build timeout to 400 minutes for sling trunk 7 and sling trunk 8 
builds

Set maven version to "Maven 3 (latest)" which should be 3.3.9 atm for all builds


was (Author: cziegeler):
Increased the build timeout to 400 minutes and changed maven version to 3.3.3 - 
for sling trunk 7 and sling trunk 8 builds

> Sling Jenkins setup
> ---
>
> Key: SLING-920
> URL: https://issues.apache.org/jira/browse/SLING-920
> Project: Sling
>  Issue Type: Task
>  Components: Testing
>Reporter: Bertrand Delacretaz
>
> Use this issue to record changes to the Jenkins setup at 
> https://builds.apache.org/view/S-Z/view/Sling/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-5520) Update Oak to 1.4

[Oliver Lietz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382134#comment-15382134
 ] 

Oliver Lietz commented on SLING-5520:
-

make use of {{Oak#withAsyncIndexing(String, long):Oak}} in branch for Oak 1.4 
([r1753211|https://svn.apache.org/r1753211])

> Update Oak to 1.4
> -
>
> Key: SLING-5520
> URL: https://issues.apache.org/jira/browse/SLING-5520
> Project: Sling
>  Issue Type: Task
>  Components: JCR, Launchpad, Oak
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
> Fix For: Launchpad Karaf Features 0.2.0, JCR Oak Server 1.0.2, 
> Launchpad Builder 9, JCR Oak Server 1.1.0
>
>
> Doing update in several more steps until Oak {{1.4}} is released due to major 
> changes, one of them being OAK-3842 (removed package exports, tracked in 
> SLING-5511).
> First updating to Oak {{1.3.14}} (latest pre OAK-3842 release) and then to 
> Oak {{1.3.15}}.
> Features deprecated for Oak {{1.4}} should be removed from 
> {{org.apache.sling.jcr.oak.server}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-5847) Deadlock in JcrResourceBundleProvider.getResourceBundleInternal when preloading is enabled

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382131#comment-15382131
 ] 

Carsten Ziegeler commented on SLING-5847:
-

Lgtm

> Deadlock in JcrResourceBundleProvider.getResourceBundleInternal when 
> preloading is enabled
> --
>
> Key: SLING-5847
> URL: https://issues.apache.org/jira/browse/SLING-5847
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: i18n 2.4.4
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Critical
> Fix For: i18n 2.4.8
>
>
> Under particular timing situations the {{reloadBundle}} job and a parallel 
> call to {{JcrResourceBundleProvider.getResourceBundleInternal()}} might block 
> each other and also all new threads calling 
> {{JcrResourceBundleProvider.getResourceBundleInternal()}}.
> The thread dump in that situation looks like follows
> {code}
> "0:0:0:0:0:0:0:1 [1468492407436] GET  HTTP/1.1" - Thread 
> t@69826
>java.lang.Thread.State: BLOCKED
>   at 
> org.apache.sling.i18n.impl.JcrResourceBundleProvider.registerResourceBundle(JcrResourceBundleProvider.java:458)
>   - waiting to lock <19c60354> (a 
> org.apache.sling.i18n.impl.JcrResourceBundleProvider) owned by 
> "pool-8-thread-5" t@111
>   at 
> org.apache.sling.i18n.impl.JcrResourceBundleProvider.getResourceBundleInternal(JcrResourceBundleProvider.java:437)
>   at 
> org.apache.sling.i18n.impl.JcrResourceBundleProvider.createResourceBundle(JcrResourceBundleProvider.java:480)
>   at 
> org.apache.sling.i18n.impl.JcrResourceBundleProvider.getResourceBundleInternal(JcrResourceBundleProvider.java:435)
>   at 
> org.apache.sling.i18n.impl.JcrResourceBundleProvider.getResourceBundle(JcrResourceBundleProvider.java:185)
>   at 
> org.apache.sling.i18n.impl.I18NFilter$CombinedBundleProvider.getResourceBundle(I18NFilter.java:217)
>   at 
> org.apache.sling.i18n.impl.I18NFilter$BaseI18NSlingHttpServletRequest.getResourceBundle(I18NFilter.java:311)
>   at 
> org.apache.sling.api.wrappers.SlingHttpServletRequestWrapper.getResourceBundle(SlingHttpServletRequestWrapper.java:115)
>   at 
> org.apache.sling.api.wrappers.SlingHttpServletRequestWrapper.getResourceBundle(SlingHttpServletRequestWrapper.java:115)
>   at 
> org.apache.sling.api.wrappers.SlingHttpServletRequestWrapper.getResourceBundle(SlingHttpServletRequestWrapper.java:115)
>   at 
> org.apache.sling.api.wrappers.SlingHttpServletRequestWrapper.getResourceBundle(SlingHttpServletRequestWrapper.java:115)
>   at 
> org.apache.sling.api.wrappers.SlingHttpServletRequestWrapper.getResourceBundle(SlingHttpServletRequestWrapper.java:115)
>   at ...
> "pool-8-thread-5" - Thread t@111
>java.lang.Thread.State: WAITING
>   at sun.misc.Unsafe.park(Native Method)
>   - parking to wait for <69b06467> (a 
> java.util.concurrent.Semaphore$NonfairSync)
>   at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
>   at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:836)
>   at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireSharedInterruptibly(AbstractQueuedSynchronizer.java:997)
>   at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireSharedInterruptibly(AbstractQueuedSynchronizer.java:1304)
>   at java.util.concurrent.Semaphore.acquire(Semaphore.java:312)
>   at 
> org.apache.sling.i18n.impl.JcrResourceBundleProvider.getResourceBundleInternal(JcrResourceBundleProvider.java:429)
>   at 
> org.apache.sling.i18n.impl.JcrResourceBundleProvider.createResourceBundle(JcrResourceBundleProvider.java:480)
>   at 
> org.apache.sling.i18n.impl.JcrResourceBundleProvider.getResourceBundleInternal(JcrResourceBundleProvider.java:435)
>   at 
> org.apache.sling.i18n.impl.JcrResourceBundleProvider.getResourceBundle(JcrResourceBundleProvider.java:185)
>   at 
> org.apache.sling.i18n.impl.JcrResourceBundleProvider.reloadBundle(JcrResourceBundleProvider.java:357)
>   at 
> org.apache.sling.i18n.impl.JcrResourceBundleProvider.reloadBundle(JcrResourceBundleProvider.java:352)
>   at 
> org.apache.sling.i18n.impl.JcrResourceBundleProvider$2.run(JcrResourceBundleProvider.java:320)
>   - locked <19c60354> (a 
> org.apache.sling.i18n.impl.JcrResourceBundleProvider)
>   at 
> org.apache.sling.commons.scheduler.impl.QuartzJobExecutor.execute(QuartzJobExecutor.java:115)
>   at org.quartz.core.JobRunShell.run(JobRunShell.java:202)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 

[jira] [Commented] (SLING-5860) Require maven version 3.3.3

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382102#comment-15382102
 ] 

Robert Munteanu commented on SLING-5860:


Apparently 3.3.9 is available on Jenkins, but only as 'latest', not as a fixed 
version.

We can switch back to 3.3.9, and stick with whatever 'latest' means, at the 
risk of being upgraded without knowing to the next Maven version. I would 
prefer the safe route however, and live with 3.3.3 for now.

> Require maven version 3.3.3
> ---
>
> Key: SLING-5860
> URL: https://issues.apache.org/jira/browse/SLING-5860
> Project: Sling
>  Issue Type: Improvement
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Parent 27
>
>
> According to http://maven.apache.org/download.cgi
> Maven 3.3.9 is the recommended version for all users. We should require it in 
> the parent pom



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-920) Sling Jenkins setup

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382089#comment-15382089
 ] 

Carsten Ziegeler commented on SLING-920:


Increased the build timeout to 400 minutes and changed maven version to 3.3.3

> Sling Jenkins setup
> ---
>
> Key: SLING-920
> URL: https://issues.apache.org/jira/browse/SLING-920
> Project: Sling
>  Issue Type: Task
>  Components: Testing
>Reporter: Bertrand Delacretaz
>
> Use this issue to record changes to the Jenkins setup at 
> https://builds.apache.org/view/S-Z/view/Sling/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (SLING-920) Sling Jenkins setup

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382089#comment-15382089
 ] 

Carsten Ziegeler edited comment on SLING-920 at 7/18/16 11:10 AM:
--

Increased the build timeout to 400 minutes and changed maven version to 3.3.3 - 
for sling trunk 7 and sling trunk 8 builds


was (Author: cziegeler):
Increased the build timeout to 400 minutes and changed maven version to 3.3.3

> Sling Jenkins setup
> ---
>
> Key: SLING-920
> URL: https://issues.apache.org/jira/browse/SLING-920
> Project: Sling
>  Issue Type: Task
>  Components: Testing
>Reporter: Bertrand Delacretaz
>
> Use this issue to record changes to the Jenkins setup at 
> https://builds.apache.org/view/S-Z/view/Sling/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-5860) Require maven version 3.3.9

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382079#comment-15382079
 ] 

Carsten Ziegeler commented on SLING-5860:
-

Let's downgrade to 3.3.3 then

> Require maven version 3.3.9
> ---
>
> Key: SLING-5860
> URL: https://issues.apache.org/jira/browse/SLING-5860
> Project: Sling
>  Issue Type: Improvement
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Parent 27
>
>
> According to http://maven.apache.org/download.cgi
> Maven 3.3.9 is the recommended version for all users. We should require it in 
> the parent pom



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (SLING-5860) Require maven version 3.3.3

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-5860:

Summary: Require maven version 3.3.3  (was: Require maven version 3.3.9)

> Require maven version 3.3.3
> ---
>
> Key: SLING-5860
> URL: https://issues.apache.org/jira/browse/SLING-5860
> Project: Sling
>  Issue Type: Improvement
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Parent 27
>
>
> According to http://maven.apache.org/download.cgi
> Maven 3.3.9 is the recommended version for all users. We should require it in 
> the parent pom



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (SLING-5860) Require maven version 3.3.9

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382074#comment-15382074
 ] 

Robert Munteanu edited comment on SLING-5860 at 7/18/16 10:52 AM:
--

Just noticed that this is not available on builds.apache.org - INFRA-12296 . 
Can we downgrade the requirement to 3.3.3 until this gets resolved?

Or alternatively don't upgrade to the latest parent until this is solved.


was (Author: rombert):
Just noticed that this is not available on builds.apache.org - INFRA-12296 . 
Can we downgrade the requirement to 3.3.3 until this gets resolved?

> Require maven version 3.3.9
> ---
>
> Key: SLING-5860
> URL: https://issues.apache.org/jira/browse/SLING-5860
> Project: Sling
>  Issue Type: Improvement
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Parent 27
>
>
> According to http://maven.apache.org/download.cgi
> Maven 3.3.9 is the recommended version for all users. We should require it in 
> the parent pom



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-5860) Require maven version 3.3.9

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382074#comment-15382074
 ] 

Robert Munteanu commented on SLING-5860:


Just noticed that this is not available on builds.apache.org - INFRA-12296 . 
Can we downgrade the requirement to 3.3.3 until this gets resolved?

> Require maven version 3.3.9
> ---
>
> Key: SLING-5860
> URL: https://issues.apache.org/jira/browse/SLING-5860
> Project: Sling
>  Issue Type: Improvement
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Parent 27
>
>
> According to http://maven.apache.org/download.cgi
> Maven 3.3.9 is the recommended version for all users. We should require it in 
> the parent pom



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-5860) Require maven version 3.3.9

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382058#comment-15382058
 ] 

Carsten Ziegeler commented on SLING-5860:
-

Thanks for reporting, I've added the enforcer plugin configuration in rev 
1753202

> Require maven version 3.3.9
> ---
>
> Key: SLING-5860
> URL: https://issues.apache.org/jira/browse/SLING-5860
> Project: Sling
>  Issue Type: Improvement
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Parent 27
>
>
> According to http://maven.apache.org/download.cgi
> Maven 3.3.9 is the recommended version for all users. We should require it in 
> the parent pom



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Updating our parent pom

[Oliver Lietz]

On Monday 18 July 2016 11:11:25 Carsten Ziegeler wrote:
> > On Thursday 14 July 2016 21:43:45 Carsten Ziegeler wrote:
[...]
> 
> I've updated the parent pom as outlined above, including #11.
> 
> It would be great if everyone can have a look before we start a release

LGTM, building Scripting Thymeleaf (which is uses R6 features) with 27-
SNAPSHOT results in same output except import range for Servlets.

How about adding javax.inject to parent?

Do we still need the plugin configuration for maven-bundle-plugin?

O.

> Thanks
> 
>  Carsten

Re: Updating our parent pom

[Konrad Windszus]

> On 14 Jul 2016, at 21:43, Carsten Ziegeler  wrote:
> 
> Hi,
> 
> looking at our parent pom, we have there some really really old
> dependencies. The reasoning behind this is that we usually try to use
> the minimal possible version for a dependency. However, for some things
> newer versions are out for some time and are the de-facto standard.
> 
> I think we should
> 
> 1. Update the default java version for modules from 6 to 7
> 2. Update the dependency to OSGi Core from 4.1.0 to R6
> 3. Update the dependency to OSGi Cmpn from 4.1.0 to R6
> 4. Update the servlet api dependency from 2.4 to 3.0.1 or even 3.1.0
>   (Unfortunately this will break modules as the mvn coordinates have
> changed, but we can easily update those if we update the parent pom in
> those modules)
> 5. Update the jcr dependency to 2.0
> 6. Update the slf4j-api dependency from 1.5.2 to 1.7.6
> 7. Add the dependency for the OSGi annotations (@Version, @ProviderType,
> @ConsumerType)
> 8. Add the dependency for the OSGi DS and metatype annotations
> 9. Add the bnd maven plugin 3.2.0
> (see https://github.com/bndtools/bnd/tree/master/maven/bnd-maven-plugin)
> This plugin is newer than the maven bundle plugin and closer to bnd
> change. So we can start using this in our modules.
> 10. Maybe change the required maven version from 3.0.5 to 3.3.x
The fix being applied to https://issues.apache.org/jira/browse/SLING-5860 
 is not working. You must use 
the maven-enforcer-plugin for build requirements.

> 
> WDYT?
> 
> Regards
> Carsten
> -- 
> Carsten Ziegeler
> Adobe Research Switzerland
> cziege...@apache.org

[jira] [Comment Edited] (SLING-5860) Require maven version 3.3.9

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382029#comment-15382029
 ] 

Konrad Windszus edited comment on SLING-5860 at 7/18/16 10:06 AM:
--

To require a certain maven version the {{prerequisites}} section cannot be used 
(https://issues.apache.org/jira/browse/MNG-5297), except for Maven Plugins 
itself. Instead the maven-enforcer-plugin must be used (see also 
http://maven.apache.org/ref/3.3.9/maven-model/maven.html#class_prerequisites)


was (Author: kwin):
To require a certain maven version the {{prerequisites}} section cannot be used 
(https://issues.apache.org/jira/browse/MNG-5297), except for Maven Plugins 
itself. Instead the maven-enforcer-plugin must be used.

> Require maven version 3.3.9
> ---
>
> Key: SLING-5860
> URL: https://issues.apache.org/jira/browse/SLING-5860
> Project: Sling
>  Issue Type: Improvement
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Parent 27
>
>
> According to http://maven.apache.org/download.cgi
> Maven 3.3.9 is the recommended version for all users. We should require it in 
> the parent pom



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-5860) Require maven version 3.3.9

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382029#comment-15382029
 ] 

Konrad Windszus commented on SLING-5860:


To require a certain maven version the {{prerequisites}} section cannot be used 
(https://issues.apache.org/jira/browse/MNG-5297), except for Maven Plugins 
itself. Instead the maven-enforcer-plugin must be used.

> Require maven version 3.3.9
> ---
>
> Key: SLING-5860
> URL: https://issues.apache.org/jira/browse/SLING-5860
> Project: Sling
>  Issue Type: Improvement
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Parent 27
>
>
> According to http://maven.apache.org/download.cgi
> Maven 3.3.9 is the recommended version for all users. We should require it in 
> the parent pom



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Updating our parent pom

[Robert Munteanu]

On Mon, 2016-07-18 at 11:23 +0200, Carsten Ziegeler wrote:
> > 
> > On Mon, 2016-07-18 at 11:11 +0200, Carsten Ziegeler wrote:
> > > > 
> > > > On Thursday 14 July 2016 21:43:45 Carsten Ziegeler wrote:
> > > > > Hi,
> > > > > 
> > > > > looking at our parent pom, we have there some really really
> > > > > old
> > > > > dependencies. The reasoning behind this is that we usually
> > > > > try to
> > > > > use
> > > > > the minimal possible version for a dependency. However, for
> > > > > some
> > > > > things
> > > > > newer versions are out for some time and are the de-facto
> > > > > standard.
> > > > > 
> > > > > I think we should
> > > > > 
> > > > > 1. Update the default java version for modules from 6 to 7
> > > > > 2. Update the dependency to OSGi Core from 4.1.0 to R6
> > > > > 3. Update the dependency to OSGi Cmpn from 4.1.0 to R6
> > > > > 4. Update the servlet api dependency from 2.4 to 3.0.1 or
> > > > > even
> > > > > 3.1.0
> > > > >    (Unfortunately this will break modules as the mvn
> > > > > coordinates
> > > > > have
> > > > > changed, but we can easily update those if we update the
> > > > > parent
> > > > > pom in
> > > > > those modules)
> > > > > 5. Update the jcr dependency to 2.0
> > > > > 6. Update the slf4j-api dependency from 1.5.2 to 1.7.6
> > > > > 7. Add the dependency for the OSGi annotations (@Version,
> > > > > @ProviderType,
> > > > > @ConsumerType)
> > > > > 8. Add the dependency for the OSGi DS and metatype
> > > > > annotations
> > > > > 9. Add the bnd maven plugin 3.2.0
> > > > > (see https://github.com/bndtools/bnd/tree/master/maven/bnd-ma
> > > > > ven-
> > > > > plugin)
> > > > > This plugin is newer than the maven bundle plugin and closer
> > > > > to
> > > > > bnd
> > > > > change. So we can start using this in our modules.
> > > > > 10. Maybe change the required maven version from 3.0.5 to
> > > > > 3.3.x
> > > > 
> > > > 11. Update maven-bundle-plugin to 3.2.0
> > > > 
> > > I've updated the parent pom as outlined above, including #11.
> > > 
> > > It would be great if everyone can have a look before we start a
> > > release
> > 
> > I'd like to quickly check if we can remove the check-memory-task
> > executions which notify the user about the memory requirements for
> > building Sling.
> > 
> > Since we now require Maven 3.3 and that picks up the
> > .mvn/jvm.config
> > file we should not need them any longer.
> > 
> +1
> 

Done. Also a quick smoke test with the JSON bundle confirms the
findings from SLING-5851

Robert

Re: Build failed in Jenkins: sling-trunk-1.7 #4315

[Carsten Ziegeler]

So the build was successful but did get marked as failed anyways.

Can we increase the timeout:

"[INFO] Total time: 2:23:15.998s"
"Build timed out (after 150 minutes). Marking the build as failed."

I hope this does not start a new round of tests take to long, etc.

Carsten

> See 
> 
> --
> [...truncated 130057 lines...]
> [INFO] Apache Sling JSP Standard Tag Library . SUCCESS [17.434s]
> [INFO] Apache Sling Scripting Sightly Compiler ... SUCCESS [46.358s]
> [INFO] Apache Sling Scripting Sightly Java Compiler .. SUCCESS [37.507s]
> [INFO] Apache Sling Scripting Sightly Engine . SUCCESS [32.291s]
> [INFO] Apache Sling Scripting Sightly JavaScript Use Provider  SUCCESS 
> [17.996s]
> [INFO] Apache Sling Scripting Sightly Models Use Provider  SUCCESS [14.744s]
> [INFO] Apache Sling Scripting Sightly Read-Eval-Print Loop Environment  
> SUCCESS [13.098s]
> [INFO] Apache Sling Scripting Sightly Integration Tests Content  SUCCESS 
> [21.982s]
> [INFO] Apache Sling Launchpad Base ... SUCCESS [42.568s]
> [INFO] Apache Sling Subsystems Base Installer  SUCCESS [17.542s]
> [INFO] Apache Sling Filesystem Resource Provider . SUCCESS [17.037s]
> [INFO] Apache Sling Installer WebConsole Plugin .. SUCCESS [12.016s]
> [INFO] Apache Sling Launchpad Application Builder  SUCCESS [1:27.702s]
> [INFO] Apache Sling Scripting Sightly Integration Tests .. SUCCESS [3:06.273s]
> [INFO] Apache Sling Scripting Sightly Reactor  SUCCESS [4.920s]
> [INFO] Apache Sling Adapter Manager Implementation ... SUCCESS [20.285s]
> [INFO] Apache Sling Bundle Resource Provider . SUCCESS [13.388s]
> [INFO] Apache Sling Distributed Event Admin .. SUCCESS [14.144s]
> [INFO] Apache Sling Discovery API  SUCCESS [10.538s]
> [INFO] Apache Sling Discovery Commons  SUCCESS [1:36.782s]
> [INFO] Apache Sling Discovery Base ... SUCCESS [1:49.113s]
> [INFO] Apache Sling Resource-Based Discovery Service . SUCCESS [4:12.823s]
> [INFO] Apache Sling Oak-Based Discovery Service .. SUCCESS [2:55.776s]
> [INFO] Apache Sling Discovery Support Bundle . SUCCESS [9.003s]
> [INFO] Apache Sling Discovery Standalone Implementation .. SUCCESS [21.179s]
> [INFO] Apache Sling Event Support  SUCCESS 
> [28:09.702s]
> [INFO] Apache Sling Feature Flags  SUCCESS [9.933s]
> [INFO] Apache Sling javax.activation bundle .. SUCCESS [13.614s]
> [INFO] Apache Sling Service User Mapper .. SUCCESS [15.724s]
> [INFO] Apache Sling Settings . SUCCESS [29.168s]
> [INFO] Apache Sling Web Console Branding . SUCCESS [25.910s]
> [INFO] Apache Sling Web Console Security Provider  SUCCESS [14.434s]
> [INFO] Apache Sling Explorer . SUCCESS [13.047s]
> [INFO] Apache Sling Health Check Core  SUCCESS [2:58.838s]
> [INFO] Apache Sling Health Check Samples . SUCCESS [12.115s]
> [INFO] Apache Sling Health Check Support Components .. SUCCESS [11.676s]
> [INFO] Apache Sling Health Check Webconsole Plugin ... SUCCESS [17.549s]
> [INFO] Apache Sling Health Check JUnit Bridge  SUCCESS [13.722s]
> [INFO] Apache Sling Health Check Annotations . SUCCESS [8.844s]
> [INFO] Apache Sling Health Check Integration Tests ... SUCCESS [19.424s]
> [INFO] Apache Sling Health Check Reactor POM . SUCCESS [4.973s]
> [INFO] Apache Sling Resource Access Security . SUCCESS [11.274s]
> [INFO] Apache Sling Resource Access Security Integration Tests  SUCCESS 
> [1:26.205s]
> [INFO] Apache Sling Models API ... SUCCESS [32.164s]
> [INFO] Apache Sling Models Implementation  SUCCESS [4:07.081s]
> [INFO] Apache Sling Models Integration Tests . SUCCESS [2:24.310s]
> [INFO] Apache Sling Internationalization Support . SUCCESS [2:49.372s]
> [INFO] Apache Sling XSS Protection Bundle  SUCCESS [4:07.763s]
> [INFO] Apache Sling JUnit Core ... SUCCESS [2:00.259s]
> [INFO] Apache Sling JUnit Tests Teleporter ... SUCCESS [1:04.453s]
> [INFO] Apache Sling Resource Builder . SUCCESS [3:06.272s]
> [INFO] Apache Sling Servlet Helpers .. SUCCESS [1:07.742s]
> [INFO] Apache Sling RepoInit Integration Tests ... SUCCESS [2:45.547s]
> [INFO] Apache Sling RepoInit Reactor . SUCCESS [1:15.556s]
> [INFO] Apache Sling Test Tools ... SUCCESS [1:23.368s]
> [INFO] Apache Sling Testing Clients .. SUCCESS [59.677s]
> [INFO] Apache Sling Testing Hamcrest . SUCCESS 

[jira] [Resolved] (SLING-5862) Remove maven-antrun-plugin executions related to memory checks

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-5862.

Resolution: Fixed

> Remove maven-antrun-plugin executions related to memory checks
> --
>
> Key: SLING-5862
> URL: https://issues.apache.org/jira/browse/SLING-5862
> Project: Sling
>  Issue Type: Improvement
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
> Fix For: Parent 27
>
>
> WIth SLING-5860 we now require Maven 3.3.9. This means that we can remove the 
> antrun executions which output warnings related to the memory needed to build 
> Sling.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-5862) Remove maven-antrun-plugin executions related to memory checks

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381970#comment-15381970
 ] 

Robert Munteanu commented on SLING-5862:


Fixed in [r1753187|https://svn.apache.org/r1753187]

> Remove maven-antrun-plugin executions related to memory checks
> --
>
> Key: SLING-5862
> URL: https://issues.apache.org/jira/browse/SLING-5862
> Project: Sling
>  Issue Type: Improvement
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
> Fix For: Parent 27
>
>
> WIth SLING-5860 we now require Maven 3.3.9. This means that we can remove the 
> antrun executions which output warnings related to the memory needed to build 
> Sling.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Updating our parent pom

[Carsten Ziegeler]

>> On Thursday 14 July 2016 21:43:45 Carsten Ziegeler wrote:
>>> Hi,
>>>
>>> looking at our parent pom, we have there some really really old
>>> dependencies. The reasoning behind this is that we usually try to use
>>> the minimal possible version for a dependency. However, for some things
>>> newer versions are out for some time and are the de-facto standard.
>>>
>>> I think we should
>>>
>>> 1. Update the default java version for modules from 6 to 7
>>> 2. Update the dependency to OSGi Core from 4.1.0 to R6
>>> 3. Update the dependency to OSGi Cmpn from 4.1.0 to R6
>>> 4. Update the servlet api dependency from 2.4 to 3.0.1 or even 3.1.0
>>>(Unfortunately this will break modules as the mvn coordinates have
>>> changed, but we can easily update those if we update the parent pom in
>>> those modules)
>>> 5. Update the jcr dependency to 2.0
>>> 6. Update the slf4j-api dependency from 1.5.2 to 1.7.6
>>> 7. Add the dependency for the OSGi annotations (@Version, @ProviderType,
>>> @ConsumerType)
>>> 8. Add the dependency for the OSGi DS and metatype annotations
>>> 9. Add the bnd maven plugin 3.2.0
>>> (see https://github.com/bndtools/bnd/tree/master/maven/bnd-maven-plugin)
>>> This plugin is newer than the maven bundle plugin and closer to bnd
>>> change. So we can start using this in our modules.
>>> 10. Maybe change the required maven version from 3.0.5 to 3.3.x
>>
>> 11. Update maven-bundle-plugin to 3.2.0
>>
> I've updated the parent pom as outlined above, including #11.
> 
> It would be great if everyone can have a look before we start a release
> 

I've also created https://issues.apache.org/jira/browse/SLING-5851
which lists changes we must do for a module to update to parent pom 27.

Carsten

 

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Re: Updating our parent pom

[Carsten Ziegeler]

> On Mon, 2016-07-18 at 11:11 +0200, Carsten Ziegeler wrote:
>>>
>>> On Thursday 14 July 2016 21:43:45 Carsten Ziegeler wrote:
 Hi,

 looking at our parent pom, we have there some really really old
 dependencies. The reasoning behind this is that we usually try to
 use
 the minimal possible version for a dependency. However, for some
 things
 newer versions are out for some time and are the de-facto
 standard.

 I think we should

 1. Update the default java version for modules from 6 to 7
 2. Update the dependency to OSGi Core from 4.1.0 to R6
 3. Update the dependency to OSGi Cmpn from 4.1.0 to R6
 4. Update the servlet api dependency from 2.4 to 3.0.1 or even
 3.1.0
(Unfortunately this will break modules as the mvn coordinates
 have
 changed, but we can easily update those if we update the parent
 pom in
 those modules)
 5. Update the jcr dependency to 2.0
 6. Update the slf4j-api dependency from 1.5.2 to 1.7.6
 7. Add the dependency for the OSGi annotations (@Version,
 @ProviderType,
 @ConsumerType)
 8. Add the dependency for the OSGi DS and metatype annotations
 9. Add the bnd maven plugin 3.2.0
 (see https://github.com/bndtools/bnd/tree/master/maven/bnd-maven-
 plugin)
 This plugin is newer than the maven bundle plugin and closer to
 bnd
 change. So we can start using this in our modules.
 10. Maybe change the required maven version from 3.0.5 to 3.3.x
>>>
>>> 11. Update maven-bundle-plugin to 3.2.0
>>>
>> I've updated the parent pom as outlined above, including #11.
>>
>> It would be great if everyone can have a look before we start a
>> release
> 
> I'd like to quickly check if we can remove the check-memory-task
> executions which notify the user about the memory requirements for
> building Sling.
> 
> Since we now require Maven 3.3 and that picks up the .mvn/jvm.config
> file we should not need them any longer.
> 
+1


 

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[jira] [Resolved] (SLING-5854) Update servlet api dependency to 3.1.0

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-5854.
-
Resolution: Fixed

Updated in 1753175

> Update servlet api dependency to 3.1.0
> --
>
> Key: SLING-5854
> URL: https://issues.apache.org/jira/browse/SLING-5854
> Project: Sling
>  Issue Type: Improvement
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Parent 27
>
>
> We should update the dependency to the servlet api to 3.1.0 (currently 2.4) 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (SLING-5862) Remove maven-antrun-plugin executions related to memory checks

[Robert Munteanu (JIRA)]

Robert Munteanu created SLING-5862:
--

 Summary: Remove maven-antrun-plugin executions related to memory 
checks
 Key: SLING-5862
 URL: https://issues.apache.org/jira/browse/SLING-5862
 Project: Sling
  Issue Type: Improvement
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Parent 27


WIth SLING-5860 we now require Maven 3.3.9. This means that we can remove the 
antrun executions which output warnings related to the memory needed to build 
Sling.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (SLING-5846) Update SCR Annotations to 1.11.0

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-5846.
-
Resolution: Fixed

Updated in 1752731

> Update SCR Annotations to 1.11.0
> 
>
> Key: SLING-5846
> URL: https://issues.apache.org/jira/browse/SLING-5846
> Project: Sling
>  Issue Type: Task
>  Components: General
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Parent 27
>
>
> Due to FELIX-5304 we should update the scr annotations



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Updating our parent pom

[Robert Munteanu]

On Mon, 2016-07-18 at 11:11 +0200, Carsten Ziegeler wrote:
> > 
> > On Thursday 14 July 2016 21:43:45 Carsten Ziegeler wrote:
> > > Hi,
> > > 
> > > looking at our parent pom, we have there some really really old
> > > dependencies. The reasoning behind this is that we usually try to
> > > use
> > > the minimal possible version for a dependency. However, for some
> > > things
> > > newer versions are out for some time and are the de-facto
> > > standard.
> > > 
> > > I think we should
> > > 
> > > 1. Update the default java version for modules from 6 to 7
> > > 2. Update the dependency to OSGi Core from 4.1.0 to R6
> > > 3. Update the dependency to OSGi Cmpn from 4.1.0 to R6
> > > 4. Update the servlet api dependency from 2.4 to 3.0.1 or even
> > > 3.1.0
> > >    (Unfortunately this will break modules as the mvn coordinates
> > > have
> > > changed, but we can easily update those if we update the parent
> > > pom in
> > > those modules)
> > > 5. Update the jcr dependency to 2.0
> > > 6. Update the slf4j-api dependency from 1.5.2 to 1.7.6
> > > 7. Add the dependency for the OSGi annotations (@Version,
> > > @ProviderType,
> > > @ConsumerType)
> > > 8. Add the dependency for the OSGi DS and metatype annotations
> > > 9. Add the bnd maven plugin 3.2.0
> > > (see https://github.com/bndtools/bnd/tree/master/maven/bnd-maven-
> > > plugin)
> > > This plugin is newer than the maven bundle plugin and closer to
> > > bnd
> > > change. So we can start using this in our modules.
> > > 10. Maybe change the required maven version from 3.0.5 to 3.3.x
> > 
> > 11. Update maven-bundle-plugin to 3.2.0
> > 
> I've updated the parent pom as outlined above, including #11.
> 
> It would be great if everyone can have a look before we start a
> release

I'd like to quickly check if we can remove the check-memory-task
executions which notify the user about the memory requirements for
building Sling.

Since we now require Maven 3.3 and that picks up the .mvn/jvm.config
file we should not need them any longer.

Robert

[jira] [Resolved] (SLING-5859) Add bnd-bundle-plugin 3.2.0

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-5859.
-
Resolution: Fixed
  Assignee: Carsten Ziegeler

> Add bnd-bundle-plugin 3.2.0
> ---
>
> Key: SLING-5859
> URL: https://issues.apache.org/jira/browse/SLING-5859
> Project: Sling
>  Issue Type: Improvement
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Parent 27
>
>
> In order to make the use of the bnd-bundle-plugin easier we should add it to 
> the parent pom
> https://github.com/bndtools/bnd/tree/master/maven/bnd-maven-plugin)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Updating our parent pom

[Carsten Ziegeler]

> On Thursday 14 July 2016 21:43:45 Carsten Ziegeler wrote:
>> Hi,
>>
>> looking at our parent pom, we have there some really really old
>> dependencies. The reasoning behind this is that we usually try to use
>> the minimal possible version for a dependency. However, for some things
>> newer versions are out for some time and are the de-facto standard.
>>
>> I think we should
>>
>> 1. Update the default java version for modules from 6 to 7
>> 2. Update the dependency to OSGi Core from 4.1.0 to R6
>> 3. Update the dependency to OSGi Cmpn from 4.1.0 to R6
>> 4. Update the servlet api dependency from 2.4 to 3.0.1 or even 3.1.0
>>(Unfortunately this will break modules as the mvn coordinates have
>> changed, but we can easily update those if we update the parent pom in
>> those modules)
>> 5. Update the jcr dependency to 2.0
>> 6. Update the slf4j-api dependency from 1.5.2 to 1.7.6
>> 7. Add the dependency for the OSGi annotations (@Version, @ProviderType,
>> @ConsumerType)
>> 8. Add the dependency for the OSGi DS and metatype annotations
>> 9. Add the bnd maven plugin 3.2.0
>> (see https://github.com/bndtools/bnd/tree/master/maven/bnd-maven-plugin)
>> This plugin is newer than the maven bundle plugin and closer to bnd
>> change. So we can start using this in our modules.
>> 10. Maybe change the required maven version from 3.0.5 to 3.3.x
> 
> 11. Update maven-bundle-plugin to 3.2.0
> 
I've updated the parent pom as outlined above, including #11.

It would be great if everyone can have a look before we start a release

Thanks

 Carsten

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[jira] [Resolved] (SLING-5861) Update org.jmock:jmock-junit4 to 2.8.2

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-5861.
-
Resolution: Fixed

Updated in rev 1753186

> Update org.jmock:jmock-junit4 to 2.8.2
> --
>
> Key: SLING-5861
> URL: https://issues.apache.org/jira/browse/SLING-5861
> Project: Sling
>  Issue Type: Improvement
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Parent 27
>
>
> We should udpate org.jmock:jmock-junit4 to the latest version



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (SLING-5861) Update org.jmock:jmock-junit4 to 2.8.2

[Carsten Ziegeler (JIRA)]

Carsten Ziegeler created SLING-5861:
---

 Summary: Update org.jmock:jmock-junit4 to 2.8.2
 Key: SLING-5861
 URL: https://issues.apache.org/jira/browse/SLING-5861
 Project: Sling
  Issue Type: Improvement
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Parent 27


We should udpate org.jmock:jmock-junit4 to the latest version



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (SLING-5860) Require maven version 3.3.9

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-5860.
-
Resolution: Fixed

Fixed in rev 1753185

> Require maven version 3.3.9
> ---
>
> Key: SLING-5860
> URL: https://issues.apache.org/jira/browse/SLING-5860
> Project: Sling
>  Issue Type: Improvement
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Parent 27
>
>
> According to http://maven.apache.org/download.cgi
> Maven 3.3.9 is the recommended version for all users. We should require it in 
> the parent pom



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (SLING-5860) Require maven version 3.3.9

[Carsten Ziegeler (JIRA)]

Carsten Ziegeler created SLING-5860:
---

 Summary: Require maven version 3.3.9
 Key: SLING-5860
 URL: https://issues.apache.org/jira/browse/SLING-5860
 Project: Sling
  Issue Type: Improvement
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Parent 27


According to http://maven.apache.org/download.cgi
Maven 3.3.9 is the recommended version for all users. We should require it in 
the parent pom



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (SLING-5858) Update maven-bundle-plugin to 3.2.0

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-5858.
-
Resolution: Fixed

Updated in rev 1753182

> Update maven-bundle-plugin to 3.2.0
> ---
>
> Key: SLING-5858
> URL: https://issues.apache.org/jira/browse/SLING-5858
> Project: Sling
>  Issue Type: Improvement
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Parent 27
>
>
> We should update the maven-bundle-plugin to version 3.2.0



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (SLING-5859) Add bnd-bundle-plugin 3.2.0

[Carsten Ziegeler (JIRA)]

Carsten Ziegeler created SLING-5859:
---

 Summary: Add bnd-bundle-plugin 3.2.0
 Key: SLING-5859
 URL: https://issues.apache.org/jira/browse/SLING-5859
 Project: Sling
  Issue Type: Improvement
Reporter: Carsten Ziegeler
 Fix For: Parent 27


In order to make the use of the bnd-bundle-plugin easier we should add it to 
the parent pom
https://github.com/bndtools/bnd/tree/master/maven/bnd-maven-plugin)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (SLING-5857) Add official DS and metatype annotations

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-5857.
-
Resolution: Fixed

Added in rev 1753181, deprecated Apache Felix annotations

> Add official DS and metatype annotations
> 
>
> Key: SLING-5857
> URL: https://issues.apache.org/jira/browse/SLING-5857
> Project: Sling
>  Issue Type: Improvement
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Parent 27
>
>
> We should add the official annotations for DS and metatype



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (SLING-5858) Update maven-bundle-plugin to 3.2.0

[Carsten Ziegeler (JIRA)]

Carsten Ziegeler created SLING-5858:
---

 Summary: Update maven-bundle-plugin to 3.2.0
 Key: SLING-5858
 URL: https://issues.apache.org/jira/browse/SLING-5858
 Project: Sling
  Issue Type: Improvement
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Parent 27


We should update the maven-bundle-plugin to version 3.2.0



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (SLING-5857) Add official DS and metatype annotations

[Carsten Ziegeler (JIRA)]

Carsten Ziegeler created SLING-5857:
---

 Summary: Add official DS and metatype annotations
 Key: SLING-5857
 URL: https://issues.apache.org/jira/browse/SLING-5857
 Project: Sling
  Issue Type: Improvement
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Parent 27


We should add the official annotations for DS and metatype



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (SLING-5856) Add osgi.annotation to parent pom

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-5856.
-
Resolution: Fixed

Added in rev 1753180. Also added a deprecation note to bndlib

> Add osgi.annotation to parent pom
> -
>
> Key: SLING-5856
> URL: https://issues.apache.org/jira/browse/SLING-5856
> Project: Sling
>  Issue Type: Improvement
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Parent 27
>
>
> We should add osgi.annotation 6.0.1 to the parent pom as it provides newer 
> and official versions of annotations for version and service type



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (SLING-5856) Add osgi.annotation to parent pom

[Carsten Ziegeler (JIRA)]

Carsten Ziegeler created SLING-5856:
---

 Summary: Add osgi.annotation to parent pom
 Key: SLING-5856
 URL: https://issues.apache.org/jira/browse/SLING-5856
 Project: Sling
  Issue Type: Improvement
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Parent 27


We should add osgi.annotation 6.0.1 to the parent pom as it provides newer and 
official versions of annotations for version and service type



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (SLING-5855) Update slf4j dependency to 1.7.6

[Carsten Ziegeler (JIRA)]

Carsten Ziegeler created SLING-5855:
---

 Summary: Update slf4j dependency to 1.7.6
 Key: SLING-5855
 URL: https://issues.apache.org/jira/browse/SLING-5855
 Project: Sling
  Issue Type: Bug
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Parent 27


We should udpate the dependency to slf4j to at least 1.7.6



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (SLING-5855) Update slf4j dependency to 1.7.6

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-5855.
-
Resolution: Fixed

Updated in rev 1753179

> Update slf4j dependency to 1.7.6
> 
>
> Key: SLING-5855
> URL: https://issues.apache.org/jira/browse/SLING-5855
> Project: Sling
>  Issue Type: Bug
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Parent 27
>
>
> We should udpate the dependency to slf4j to at least 1.7.6



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (SLING-5851) Update to parent pom 27

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381881#comment-15381881
 ] 

Carsten Ziegeler edited comment on SLING-5851 at 7/18/16 8:52 AM:
--

- maven coordinates for osgi.core and osgi.compendium changed (org.osgi.core -> 
osgi.core and org.osgi.compendium -> osgi.cmpn)
- maven coordinates for servlet api changed (servlet-api -> javax.servlet-api)


was (Author: cziegeler):
- maven coordinates for osgi.core and osgi.compendium changed (org.osgi.core -> 
osgi.core and org.osgi.compendium -> osgi.cmpn)

> Update to parent pom 27
> ---
>
> Key: SLING-5851
> URL: https://issues.apache.org/jira/browse/SLING-5851
> Project: Sling
>  Issue Type: Improvement
>Reporter: Carsten Ziegeler
>
> Once the new parent pom 27 is out, we need to update all modules.
> This includes:
> - checking the sling.java.property. If 7 or below remove it



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (SLING-5854) Update servlet api dependency to 3.1.0

[Carsten Ziegeler (JIRA)]

Carsten Ziegeler created SLING-5854:
---

 Summary: Update servlet api dependency to 3.1.0
 Key: SLING-5854
 URL: https://issues.apache.org/jira/browse/SLING-5854
 Project: Sling
  Issue Type: Improvement
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Parent 27


We should update the dependency to the servlet api to 3.1.0 (currently 2.4) 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (SLING-5851) Update to parent pom 27

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381881#comment-15381881
 ] 

Carsten Ziegeler edited comment on SLING-5851 at 7/18/16 8:33 AM:
--

- maven coordinates for osgi.core and osgi.compendium changed (org.osgi.core -> 
osgi.core and org.osgi.compendium -> osgi.cmpn)


was (Author: cziegeler):
- maven coordinates for osgi.core and osgi.compendium changed

> Update to parent pom 27
> ---
>
> Key: SLING-5851
> URL: https://issues.apache.org/jira/browse/SLING-5851
> Project: Sling
>  Issue Type: Improvement
>Reporter: Carsten Ziegeler
>
> Once the new parent pom 27 is out, we need to update all modules.
> This includes:
> - checking the sling.java.property. If 7 or below remove it



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (SLING-5853) Update jcr dependency to 2.0

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-5853.
-
Resolution: Fixed

Updated in rev 1753173

> Update jcr dependency to 2.0
> 
>
> Key: SLING-5853
> URL: https://issues.apache.org/jira/browse/SLING-5853
> Project: Sling
>  Issue Type: Improvement
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Parent 27
>
>
> We should udpate the dependency in the parent pom from 1.0 to 2.0 for JCR



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (SLING-5853) Update jcr dependency to 2.0

[Carsten Ziegeler (JIRA)]

Carsten Ziegeler created SLING-5853:
---

 Summary: Update jcr dependency to 2.0
 Key: SLING-5853
 URL: https://issues.apache.org/jira/browse/SLING-5853
 Project: Sling
  Issue Type: Improvement
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Parent 27


We should udpate the dependency in the parent pom from 1.0 to 2.0 for JCR



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (SLING-5852) Update OSGi core and cmpn dependencies to R6

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-5852.
-
Resolution: Fixed

Updated the dependencies in rev 1753171
Unfortunately, the maven coordinates changed 

> Update OSGi core and cmpn dependencies to R6
> 
>
> Key: SLING-5852
> URL: https://issues.apache.org/jira/browse/SLING-5852
> Project: Sling
>  Issue Type: Improvement
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Parent 27
>
>
> R6 is out for some time and we should leverage the new functionality in our 
> modules. Therefore we should update the dependencies in the parent pom



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-5851) Update to parent pom 27

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381881#comment-15381881
 ] 

Carsten Ziegeler commented on SLING-5851:
-

- maven coordinates for osgi.core and osgi.compendium changed

> Update to parent pom 27
> ---
>
> Key: SLING-5851
> URL: https://issues.apache.org/jira/browse/SLING-5851
> Project: Sling
>  Issue Type: Improvement
>Reporter: Carsten Ziegeler
>
> Once the new parent pom 27 is out, we need to update all modules.
> This includes:
> - checking the sling.java.property. If 7 or below remove it



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (SLING-5852) Update OSGi core and cmpn dependencies to R6

[Carsten Ziegeler (JIRA)]

Carsten Ziegeler created SLING-5852:
---

 Summary: Update OSGi core and cmpn dependencies to R6
 Key: SLING-5852
 URL: https://issues.apache.org/jira/browse/SLING-5852
 Project: Sling
  Issue Type: Improvement
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Parent 27


R6 is out for some time and we should leverage the new functionality in our 
modules. Therefore we should update the dependencies in the parent pom



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (SLING-5850) Update default java version to 7

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-5850.
-
Resolution: Fixed

Done in rev 1753169

> Update default java version to 7
> 
>
> Key: SLING-5850
> URL: https://issues.apache.org/jira/browse/SLING-5850
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Parent 27
>
>
> We should set the default java version to 7 (currently 6). If a module wants 
> to use java 6 it can still do so by setting this property.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Updating our parent pom

[Robert Munteanu]

On Fri, 2016-07-15 at 10:34 +0200, Bertrand Delacretaz wrote:
> On Thu, Jul 14, 2016 at 9:43 PM, Carsten Ziegeler  rg> wrote:
> > ...looking at our parent pom, we have there some really really old
> > dependencies
> 
> +1 for the updates that you mentioned, as long as our full build with
> integration tests still works after that.

Our builds are unstable ATM, so any new errors might be missed since
tests are already failing.

Robert

[jira] [Created] (SLING-5851) Update to parent pom 27

[Carsten Ziegeler (JIRA)]

Carsten Ziegeler created SLING-5851:
---

 Summary: Update to parent pom 27
 Key: SLING-5851
 URL: https://issues.apache.org/jira/browse/SLING-5851
 Project: Sling
  Issue Type: Improvement
Reporter: Carsten Ziegeler


Once the new parent pom 27 is out, we need to update all modules.

This includes:
- checking the sling.java.property. If 7 or below remove it



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (SLING-5850) Update default java version to 7

[Carsten Ziegeler (JIRA)]

Carsten Ziegeler created SLING-5850:
---

 Summary: Update default java version to 7
 Key: SLING-5850
 URL: https://issues.apache.org/jira/browse/SLING-5850
 Project: Sling
  Issue Type: Improvement
  Components: Maven Plugins and Archetypes
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Parent 27


We should set the default java version to 7 (currently 6). If a module wants to 
use java 6 it can still do so by setting this property.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Updating our parent pom

[Oliver Lietz]

On Thursday 14 July 2016 21:43:45 Carsten Ziegeler wrote:
> Hi,
> 
> looking at our parent pom, we have there some really really old
> dependencies. The reasoning behind this is that we usually try to use
> the minimal possible version for a dependency. However, for some things
> newer versions are out for some time and are the de-facto standard.
> 
> I think we should
> 
> 1. Update the default java version for modules from 6 to 7
> 2. Update the dependency to OSGi Core from 4.1.0 to R6
> 3. Update the dependency to OSGi Cmpn from 4.1.0 to R6
> 4. Update the servlet api dependency from 2.4 to 3.0.1 or even 3.1.0
>(Unfortunately this will break modules as the mvn coordinates have
> changed, but we can easily update those if we update the parent pom in
> those modules)
> 5. Update the jcr dependency to 2.0
> 6. Update the slf4j-api dependency from 1.5.2 to 1.7.6
> 7. Add the dependency for the OSGi annotations (@Version, @ProviderType,
> @ConsumerType)
> 8. Add the dependency for the OSGi DS and metatype annotations
> 9. Add the bnd maven plugin 3.2.0
> (see https://github.com/bndtools/bnd/tree/master/maven/bnd-maven-plugin)
> This plugin is newer than the maven bundle plugin and closer to bnd
> change. So we can start using this in our modules.
> 10. Maybe change the required maven version from 3.0.5 to 3.3.x

11. Update maven-bundle-plugin to 3.2.0

O.

> WDYT?
> 
> Regards
> Carsten

Re: Updating our parent pom

[Carsten Ziegeler]

> On Thu, Jul 14, 2016 at 9:43 PM, Carsten Ziegeler  
> wrote:
>> ...looking at our parent pom, we have there some really really old
>> dependencies
> 
> +1 for the updates that you mentioned, as long as our full build with
> integration tests still works after that.
> 
That's of course the goal, but I think I need to rely on everyone to
help with fixing if things break without an apparent reason.

 Carsten

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[jira] [Commented] (SLING-5831) Support different thread pools for scheduled tasks

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381830#comment-15381830
 ] 

Carsten Ziegeler commented on SLING-5831:
-

I've added a warn log statement in this case

> Support different thread pools for scheduled tasks
> --
>
> Key: SLING-5831
> URL: https://issues.apache.org/jira/browse/SLING-5831
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Commons Scheduler 2.4.16
>
>
> Right now the scheduler uses a single thread pool. While this thread pool can 
> be configured, it means that all scheduled tasks share this pool. In order to 
> prioratize different tasks over others and avoid blocking important jobs 
> through unimportant once, we could maybe add a configuration property to 
> select a thread pool name.
> If a pool with that name exists, it's used - if not the default is used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-5831) Support different thread pools for scheduled tasks

[Chetan Mehrotra (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381803#comment-15381803
 ] 

Chetan Mehrotra commented on SLING-5831:


bq. Allowing to create an indefinite number of thread pools is maybe not the 
best idea

Fair enough. Lets require explicit config then

bq. But I see your point that Sling would not work ootb without a 
configuration, which is bad.

I think it should work. Just that it uses default thread pool (sized to 5 per 
default). So even if Oak specifies a thread pool name then and such a name is 
not part of allowed list then it would be using the default pool which is same 
as it is now.

btw can we add some warn or debug logging if a pool name is specified and 
corresponding pool name is not part of whitelist

> Support different thread pools for scheduled tasks
> --
>
> Key: SLING-5831
> URL: https://issues.apache.org/jira/browse/SLING-5831
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Commons Scheduler 2.4.16
>
>
> Right now the scheduler uses a single thread pool. While this thread pool can 
> be configured, it means that all scheduled tasks share this pool. In order to 
> prioratize different tasks over others and avoid blocking important jobs 
> through unimportant once, we could maybe add a configuration property to 
> select a thread pool name.
> If a pool with that name exists, it's used - if not the default is used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-5831) Support different thread pools for scheduled tasks

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381796#comment-15381796
 ] 

Carsten Ziegeler commented on SLING-5831:
-

I think we (probably I) made a big mistake when the thread pool manager api was 
created. Allowing to create an indefinite number of thread pools is maybe not 
the best idea, so I would like to restrict it sooner than later. With the 
whiteboard scheduling it is pretty easy to mess up.
But I see your point that Sling would not work ootb without a configuration, 
which is bad.
So what about we come up with a good thread pool name and have it as a default 
configuration?

> Support different thread pools for scheduled tasks
> --
>
> Key: SLING-5831
> URL: https://issues.apache.org/jira/browse/SLING-5831
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Commons Scheduler 2.4.16
>
>
> Right now the scheduler uses a single thread pool. While this thread pool can 
> be configured, it means that all scheduled tasks share this pool. In order to 
> prioratize different tasks over others and avoid blocking important jobs 
> through unimportant once, we could maybe add a configuration property to 
> select a thread pool name.
> If a pool with that name exists, it's used - if not the default is used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-5831) Support different thread pools for scheduled tasks

[Chetan Mehrotra (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381789#comment-15381789
 ] 

Chetan Mehrotra commented on SLING-5831:


bq. I'm not in favour of by default allowing all pool names and giving a way to 
restrict this.

I am fine with providing a way to restrict it. Just suggesting that by default 
its not restricted. If the sys admin wants he can configure  a whitelist on the 
setup

We anyway allow creation of threadpool without any explicit config i.e. just a 
lookup call with anyname leads to creation of pool. In similar way just having 
the config present in scheduled job should allow such a pool to be used. 

Right now to make use of this feature we would always have to modify the 
Scheduler config. 

> Support different thread pools for scheduled tasks
> --
>
> Key: SLING-5831
> URL: https://issues.apache.org/jira/browse/SLING-5831
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Commons Scheduler 2.4.16
>
>
> Right now the scheduler uses a single thread pool. While this thread pool can 
> be configured, it means that all scheduled tasks share this pool. In order to 
> prioratize different tasks over others and avoid blocking important jobs 
> through unimportant once, we could maybe add a configuration property to 
> select a thread pool name.
> If a pool with that name exists, it's used - if not the default is used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-5831) Support different thread pools for scheduled tasks

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381783#comment-15381783
 ] 

Carsten Ziegeler commented on SLING-5831:
-

[~chetanm] Step #1 is optional. If a pool with a name is not configured yet, 
thread pool manager creates it and uses the default configuration.
I'm not in favour of by default allowing all pool names and giving a way to 
restrict this. This is easily overlooked and easily abused. If your code needs 
a separate thread pool this is a conscious decision and therefore I think it 
makes sense that it requires some steps to configure it

> Support different thread pools for scheduled tasks
> --
>
> Key: SLING-5831
> URL: https://issues.apache.org/jira/browse/SLING-5831
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Commons Scheduler 2.4.16
>
>
> Right now the scheduler uses a single thread pool. While this thread pool can 
> be configured, it means that all scheduled tasks share this pool. In order to 
> prioratize different tasks over others and avoid blocking important jobs 
> through unimportant once, we could maybe add a configuration property to 
> select a thread pool name.
> If a pool with that name exists, it's used - if not the default is used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)