[jira] [Resolved] (SLING-7182) No OSGi SCR metadata found on test case

2017-10-09 Thread Gustavo Doriguetto (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gustavo Doriguetto resolved SLING-7182. --- Resolution: Fixed > No OSGi SCR metadata found on test case >

[jira] [Commented] (SLING-7182) No OSGi SCR metadata found on test case

2017-10-09 Thread Gustavo Doriguetto (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16197884#comment-16197884 ] Gustavo Doriguetto commented on SLING-7182: --- Spot on! After including the suggested

[jira] [Commented] (SLING-7135) Sling Model object can't be instantiated on Java 9

2017-10-09 Thread Karl Pauls (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16197734#comment-16197734 ] Karl Pauls commented on SLING-7135: --- I created SLING-7186 to try and address the missing classes issue.

[jira] [Created] (SLING-7186) System bundle + extension bundles should only export available packages on java9

2017-10-09 Thread Karl Pauls (JIRA)
Karl Pauls created SLING-7186: - Summary: System bundle + extension bundles should only export available packages on java9 Key: SLING-7186 URL: https://issues.apache.org/jira/browse/SLING-7186 Project:

[jira] [Resolved] (SLING-6887) Remove commons.json and org.json from trunk

2017-10-09 Thread Karl Pauls (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls resolved SLING-6887. --- Resolution: Fixed I broke out the one remaining issue as a separate one (the maintainer wants to

[jira] [Updated] (SLING-6901) Remove commons.json from org.apache.sling.jcr.js.nodetypes

2017-10-09 Thread Karl Pauls (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated SLING-6901: -- Issue Type: Bug (was: Sub-task) Parent: (was: SLING-6887) > Remove commons.json from

[jira] [Created] (SLING-7185) Content Parser: Support for ISO-8601

2017-10-09 Thread Jason E Bailey (JIRA)
Jason E Bailey created SLING-7185: - Summary: Content Parser: Support for ISO-8601 Key: SLING-7185 URL: https://issues.apache.org/jira/browse/SLING-7185 Project: Sling Issue Type: Improvement

Re: [git] Move testing/samples to samples?

2017-10-09 Thread Konrad Windszus
That is fine for me. We just need to make sure to adjust the documentation links afterwards Konrad > Am 09.10.2017 um 20:57 schrieb Robert Munteanu : > > Hi, > > Given that we're going to have a single samples repository, would it > make sense to move the modules from

[jira] [Commented] (SLING-7167) Adjust READMEs

2017-10-09 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16197504#comment-16197504 ] Robert Munteanu commented on SLING-7167: Thanks! I'm going to wait until tomorrow evening to allow

[git] Move testing/samples to samples?

2017-10-09 Thread Robert Munteanu
Hi, Given that we're going to have a single samples repository, would it make sense to move the modules from under testing/samples under samples/testing? testing/samples/ |-- bundle-with-it `-- module-with-it I would also rename the artifact ids from org.apache.sling.testing.samples.FOO to

Re: Git migration - handling commits and PRs across multiple modules

2017-10-09 Thread Robert Munteanu
Hi Andrei, On Mon, 2017-10-09 at 17:18 +, Andrei Dulvac wrote: > On Mon, Oct 9, 2017 at 5:03 PM Robert Munteanu > wrote: > > > > > > > > With the git extreme repo split, how will commits that touch two > > > repos be > > > handled? Or pull-requests? Would I have to open

Re: Canonical URL for Git

2017-10-09 Thread Chetan Mehrotra
I believe Github would provide more convenience and if dual system is approved then we should use Github as the preferred master. Chetan Mehrotra On Mon, Oct 9, 2017 at 7:58 AM, Robert Munteanu wrote: > On Mon, 2017-10-09 at 11:21 +0200, Konrad Windszus wrote: >> > - account

[jira] [Assigned] (SLING-7184) SlingOptions.slingScriptingSightly fails to

2017-10-09 Thread Oliver Lietz (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz reassigned SLING-7184: --- Assignee: Oliver Lietz > SlingOptions.slingScriptingSightly fails to >

Re: Git migration - handling commits and PRs across multiple modules

2017-10-09 Thread Andrei Dulvac
On Mon, Oct 9, 2017 at 5:03 PM Robert Munteanu wrote: > Hi Andrei, > > On Mon, 2017-10-09 at 14:58 +, Andrei Dulvac wrote: > > Hi, > > > > Sorry I'm asking this so late, I wasn't available when this > > discussion was > > at its peak. > > Welcome to the discussion :-) >

Re: [discuss][git] Repository names cannot contain dots

2017-10-09 Thread Oliver Lietz
On Monday 09 October 2017 17:49:52 Robert Munteanu wrote: > On Mon, 2017-10-09 at 14:25 +, Stefan Seifert wrote: > > if the git repo names are still based on artifact id with only "." > > replaced by "-" i suppose this would be ok from my side. > > we mainly wanted to avoid to choose

[jira] [Commented] (SLING-7167) Adjust READMEs

2017-10-09 Thread Oliver Lietz (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16197262#comment-16197262 ] Oliver Lietz commented on SLING-7167: - [~rombert], I've added the missing READMEs and the one in

[jira] [Comment Edited] (SLING-7167) Adjust READMEs

2017-10-09 Thread Oliver Lietz (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189515#comment-16189515 ] Oliver Lietz edited comment on SLING-7167 at 10/9/17 4:33 PM: -- All of our

[jira] [Commented] (SLING-7184) SlingOptions.slingScriptingSightly fails to

2017-10-09 Thread Nicolas Peltier (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16197172#comment-16197172 ] Nicolas Peltier commented on SLING-7184: cc [~olli] > SlingOptions.slingScriptingSightly fails to

[jira] [Created] (SLING-7184) SlingOptions.slingScriptingSightly fails to

2017-10-09 Thread Nicolas Peltier (JIRA)
Nicolas Peltier created SLING-7184: -- Summary: SlingOptions.slingScriptingSightly fails to Key: SLING-7184 URL: https://issues.apache.org/jira/browse/SLING-7184 Project: Sling Issue Type:

[jira] [Created] (SLING-7183) Retire old 'sling' github mirror and replace with new one

2017-10-09 Thread Robert Munteanu (JIRA)
Robert Munteanu created SLING-7183: -- Summary: Retire old 'sling' github mirror and replace with new one Key: SLING-7183 URL: https://issues.apache.org/jira/browse/SLING-7183 Project: Sling

RE: [discuss][git] Repository names cannot contain dots

2017-10-09 Thread Stefan Seifert
>We have some repos which don't follow that convention > >- Maven toooling ( artifactId does not start with org.apache.sling ) >- Various tools and scripts ( migrated as sling-tooling-scm and sling- >tooling-jenkins ) >- Samples ( sling-samples ) > >So maybe it would be simpler to keep the

Re: Git migration - handling commits and PRs across multiple modules

2017-10-09 Thread Robert Munteanu
Hi Andrei, On Mon, 2017-10-09 at 14:58 +, Andrei Dulvac wrote: > Hi, > > Sorry I'm asking this so late, I wasn't available when this > discussion was > at its peak. Welcome to the discussion :-) > > With the git extreme repo split, how will commits that touch two > repos be > handled? Or

Git migration - handling commits and PRs across multiple modules

2017-10-09 Thread Andrei Dulvac
Hi, Sorry I'm asking this so late, I wasn't available when this discussion was at its peak. With the git extreme repo split, how will commits that touch two repos be handled? Or pull-requests? Would I have to open two PRs for a functionally-atomic change? How are projects that have reactors and

Re: Canonical URL for Git

2017-10-09 Thread Robert Munteanu
On Mon, 2017-10-09 at 11:21 +0200, Konrad Windszus wrote: > > - account linking and personal access token generation are one-time > > actions that take little time to perform > > right, but at least for the sling-site case committing to gitbox is > even less effort, because every committer

Re: [discuss][git] Repository names cannot contain dots

2017-10-09 Thread Robert Munteanu
On Mon, 2017-10-09 at 14:54 +, Stefan Seifert wrote: > > E.g. instead of sling-org.apache.sling.api we'd have sling-org- > > apache-sling-api . > > reading this we might also decide to omit the "org-apache-sling" part > in here. otherwise all and every repo would start with "sling-org- >

RE: [discuss][git] Repository names cannot contain dots

2017-10-09 Thread Stefan Seifert
>E.g. instead of sling-org.apache.sling.api we'd have >sling-org-apache-sling-api . reading this we might also decide to omit the "org-apache-sling" part in here. otherwise all and every repo would start with "sling-org-apache-sling-". and it's still a clear rule. stefan

Re: [discuss][git] Repository names cannot contain dots

2017-10-09 Thread Konrad Windszus
No one will ever manually type the clone URLs but always copy from some web page or use the repo manifest. Therefore having it close to the artifact id is good enough. I am fine as well with replacing "." by "-" in the artifact id. Konrad > On 9. Oct 2017, at 16:25, Stefan Seifert

Re: [discuss][git] Repository names cannot contain dots

2017-10-09 Thread Robert Munteanu
On Mon, 2017-10-09 at 14:25 +, Stefan Seifert wrote: > if the git repo names are still based on artifact id with only "." > replaced by "-" i suppose this would be ok from my side. > we mainly wanted to avoid to choose completely different naming > schema which may be hard to guess if you have

Re: Canonical URL for Git

2017-10-09 Thread Robert Munteanu
On Mon, 2017-10-09 at 11:22 +0200, Oliver Lietz wrote: > > Also, pushing to github is a supported setup, this was why we > > decided > > to go with gitbox in the first place [1]. Pushing to the ASF repos > > sort > > of defeats the purpose of that. > > why is making GitBox URLs the canonical ones

RE: [discuss][git] Repository names cannot contain dots

2017-10-09 Thread Stefan Seifert
if the git repo names are still based on artifact id with only "." replaced by "-" i suppose this would be ok from my side. we mainly wanted to avoid to choose completely different naming schema which may be hard to guess if you have only the artifact id of a given bundle. stefan

[discuss][git] Repository names cannot contain dots

2017-10-09 Thread Robert Munteanu
Hi, Well, word came back from infra that we can't use dots in the repository names [1]. I asked about the reasoning for that but did not yet get an answer. The question is - what do we do now? Do we want to replace dots with something else and live with a discrepancy between artifact ids and

[jira] [Commented] (SLING-7167) Adjust READMEs

2017-10-09 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16197031#comment-16197031 ] Robert Munteanu commented on SLING-7167: Absolutely [~olli] . Should I just wait for this task to

[jira] [Commented] (SLING-7167) Adjust READMEs

2017-10-09 Thread Oliver Lietz (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196799#comment-16196799 ] Oliver Lietz commented on SLING-7167: - [~rombert], I would like to add those two missing READMEs and

Re: Canonical URL for Git

2017-10-09 Thread Konrad Windszus
When looking at other projects, this is how Apache CXF 1. documents it: http://cxf.apache.org/source-repository.html 2. and uses it in Maven: https://github.com/apache/cxf/blob/master/pom.xml#L31 So gitbox is the canonical one there. > On 9. Oct 2017, at 11:22, Oliver Lietz

Re: Canonical URL for Git

2017-10-09 Thread Oliver Lietz
On Monday 09 October 2017 11:54:17 Robert Munteanu wrote: > Hi, Hi, > On Mon, 2017-10-09 at 10:35 +0200, Konrad Windszus wrote: > > I understand that I can commit to both the Gitbox repo as well as the > > linked Github repo now. The former works without further actions for > > the latter 2fa

Re: Canonical URL for Git

2017-10-09 Thread Konrad Windszus
Hi Robert, see my comment inline > On 9. Oct 2017, at 10:54, Robert Munteanu wrote: > > Hi, > > On Mon, 2017-10-09 at 10:35 +0200, Konrad Windszus wrote: >> I understand that I can commit to both the Gitbox repo as well as the >> linked Github repo now. The former works

Re: Canonical URL for Git

2017-10-09 Thread Robert Munteanu
Hi, On Mon, 2017-10-09 at 10:35 +0200, Konrad Windszus wrote: > I understand that I can commit to both the Gitbox repo as well as the > linked Github repo now. The former works without further actions for > the latter 2fa needs to be enabled on github and the account needs to > be properly

Canonical URL for Git

2017-10-09 Thread Konrad Windszus
I understand that I can commit to both the Gitbox repo as well as the linked Github repo now. The former works without further actions for the latter 2fa needs to be enabled on github and the account needs to be properly linked. I am wondering which of the two URLs should be used within the

[jira] [Closed] (SLING-7165) CAConfig Impl: Potential data loss when saving multiple nested configuration lists

2017-10-09 Thread Stefan Seifert (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert closed SLING-7165. - > CAConfig Impl: Potential data loss when saving multiple nested configuration > lists >

[RESULT] [VOTE] Release Apache Sling Context-Aware Configuration Impl 1.4.6

2017-10-09 Thread Stefan Seifert
Hi, The vote has passed with the following result : +1 (binding): Stefan Seifert, Carsten Ziegeler, Robert Munteanu I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. stefan

[jira] [Commented] (SLING-7182) No OSGi SCR metadata found on test case

2017-10-09 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196585#comment-16196585 ] Konrad Windszus commented on SLING-7182: You most probably didn't configure the Maven build

[job]Why are multiple commits needed when writing a job to the resource tree?

2017-10-09 Thread Satya Deep Maheshwari
Hi I was investigating the number of commits done while adding a sling job via AEM workflow for performance implications. I see that while writing the job to the resource tree, there's a commit made at each level of the tree when creating the resource. See [1], [2] .This can inadvertently lead to