[jira] [Created] (SLING-3270) html-generator to support html5
Jason E Bailey created SLING-3270: - Summary: html-generator to support html5 Key: SLING-3270 URL: https://issues.apache.org/jira/browse/SLING-3270 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: Extensions Rewriter 1.0.2 Reporter: Jason E Bailey Given the following fragment of HTML a href=urldiv/div/a This is invalid html4 and valid html5, as html5 allows anchor tags to contain block elements. The current html-generator corrects the bad html4 and produces the following output a href=url/adiv/div -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Created] (SLING-3861) Sling Models: Add support for the condition field
Jason E Bailey created SLING-3861: - Summary: Sling Models: Add support for the condition field Key: SLING-3861 URL: https://issues.apache.org/jira/browse/SLING-3861 Project: Sling Issue Type: Improvement Components: Extensions Reporter: Jason E Bailey Priority: Trivial Provide the option to define a condition field within the Model annotation that will be used by the adapter web console plugin to provide additional information about the adaptable -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3715) Sling Models: Support for class-based dependency injection
[
https://issues.apache.org/jira/browse/SLING-3715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14104799#comment-14104799
]
Jason E Bailey commented on SLING-3715:
---
I think you'll need to increase the service ranking to be around the same as
the osgi-service injector, because of the Resource object. In the case of the
Inject annotation you'll want to go through all the services that are
explicitly naming an object that returns a Resource before assuming the
Resource wanted is the current one.
Sling Models: Support for class-based dependency injection
--
Key: SLING-3715
URL: https://issues.apache.org/jira/browse/SLING-3715
Project: Sling
Issue Type: Improvement
Components: Extensions
Reporter: Stefan Seifert
Priority: Minor
Labels: models
Attachments: 140820_SLING-3715_sling-object-injector.patch
Currently Sling Models dependency injection is primary based on parameter
name-based injection, and not on class-based injection (the latter is more
common in Spring and comparable frameworks).
here is Justins opinion on this topic (from the mailing list) and why he
prefers name-based injection:
{quote}
Hi Stefan,
The big problem IMHO with injecting by class vs. name is that by class
is too ambigious in many cases. For example, in AEM, it is relatively
common to want to inject a Page object, but in fact there are two
different page objects which come into play (currentPage and
resourcePage) and getting the wrong one could be highly problematic.
You are correct that things like the request and response could
presumably be injected by class rather than by name, but the question
then becomes how do we judge these cases? In my opinion, the bindings
names are sensible. I personally don't find myself wanting to write
this very often:
{code:java}
@Inject
private SlingHttpServletRequest somenameOtherThanRequest;
{code}
\[...\]
Regards,
Justin
{quote}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (SLING-3886) Sling Models: support adapters for models different from the implementation class
[ https://issues.apache.org/jira/browse/SLING-3886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14112674#comment-14112674 ] Jason E Bailey commented on SLING-3886: --- I'm having a hard time understanding the use case for what you are describing. From what you are stating it appears that you want to have an implementation of a service with injected fields? Sling Models: support adapters for models different from the implementation class - Key: SLING-3886 URL: https://issues.apache.org/jira/browse/SLING-3886 Project: Sling Issue Type: New Feature Components: Extensions Reporter: Stefan Seifert Labels: models Fix For: Sling Models Implementation 1.0.8, Sling Models API 1.0.4 Attachments: 140827_SLING-3886_adapters_support.patch currently, as adapter (adaption target) only the implementation class itself that is annotated with the @Model annotation is supported (which can be either an interface or a class). if the model is not just a simple model but a class with more complex business logic the following scenario is required: * a service interface is defined * this service interface ist not directly mapped to injected values, but provides higher-level method * an implementation class with @Model annotation is implemented which gets the required values injectd internally, but implements the interface for outside access this is currently not possible with sling models. the attached patch extends the following features: * extends the @Model annotation with an optional adapters attribute * if defined, only the listed adapters are registered for the adapter factory, not the implementation class itself (unless it is listed the adapters attribute as well) * in the adapters attribute only the implementation class itself or interfaces that it implements or superclasses can be defined * with this the scenario above is perfectly possible * unit tests included which simulate the bundle add/remove usecases which is required to do the indirect implementation class mapping -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3886) Sling Models: support adapters for models different from the implementation class
[
https://issues.apache.org/jira/browse/SLING-3886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14112759#comment-14112759
]
Jason E Bailey commented on SLING-3886:
---
I understand where my misunderstanding occurred. Although I'm still unclear of
the actual use cases that would require this. In the above mentioned example.
{code}
A result = resource.adaptTo(A.class)
{code}
The idea here is to hide the actual class that I am getting returned. It could
be B.class or C.class so to the end developer I have to treat is as the class
that I requested. I see no value of this over just calling B.class directly
unless there's a way to configure the ability to select from a series of
classes that implement A.class in a contextual manner.
Sling Models: support adapters for models different from the implementation
class
-
Key: SLING-3886
URL: https://issues.apache.org/jira/browse/SLING-3886
Project: Sling
Issue Type: New Feature
Components: Extensions
Reporter: Stefan Seifert
Labels: models
Fix For: Sling Models Implementation 1.0.8, Sling Models API 1.0.4
Attachments: 140827_SLING-3886_adapters_support.patch
currently, as adapter (adaption target) only the implementation class itself
that is annotated with the @Model annotation is supported (which can be
either an interface or a class).
if the model is not just a simple model but a class with more complex
business logic the following scenario is required:
* a service interface is defined
* this service interface ist not directly mapped to injected values, but
provides higher-level method
* an implementation class with @Model annotation is implemented which gets
the required values injectd internally, but implements the interface for
outside access
this is currently not possible with sling models.
the attached patch extends the following features:
* extends the @Model annotation with an optional adapters attribute
* if defined, only the listed adapters are registered for the adapter
factory, not the implementation class itself (unless it is listed the
adapters attribute as well)
* in the adapters attribute only the implementation class itself or
interfaces that it implements or superclasses can be defined
* with this the scenario above is perfectly possible
* unit tests included which simulate the bundle add/remove usecases which is
required to do the indirect implementation class mapping
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Created] (SLING-3911) Sling Models: Unexpected behaviour from Default
Jason E Bailey created SLING-3911:
-
Summary: Sling Models: Unexpected behaviour from Default
Key: SLING-3911
URL: https://issues.apache.org/jira/browse/SLING-3911
Project: Sling
Issue Type: Bug
Components: Extensions
Reporter: Jason E Bailey
Priority: Minor
Current application of the @Default annotation has unexpected results
{code}
@Default() int[] intExample;
// sets intExample to a non empty array of [0]
@Default(longValues={1,1}) int[] intExample2;
// sets intExample2 to a non empty array of [0]
{code}
This experience occurs will all supported array types
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SLING-3911) Sling Models: Unexpected behaviour from Default
[
https://issues.apache.org/jira/browse/SLING-3911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason E Bailey updated SLING-3911:
--
Attachment: SLING-3911-2.patch
SLING-3911-1.patch
Patches change 3 things. First, replaces the default assignments in the Default
anotation to empty arrays. Second, adds a Map that returns the default value
based on Class based key. Third rewrites the Default injection method to
utilize the above two mentioned changes.
Sling Models: Unexpected behaviour from Default
---
Key: SLING-3911
URL: https://issues.apache.org/jira/browse/SLING-3911
Project: Sling
Issue Type: Bug
Components: Extensions
Reporter: Jason E Bailey
Priority: Minor
Labels: models
Attachments: SLING-3911-1.patch, SLING-3911-2.patch
Current application of the @Default annotation has unexpected results
{code}
@Default() int[] intExample;
// sets intExample to a non empty array of [0]
@Default(longValues={1,1}) int[] intExample2;
// sets intExample2 to a non empty array of [0]
{code}
This experience occurs will all supported array types
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-3911) Sling Models: Unexpected behaviour from Default
[
https://issues.apache.org/jira/browse/SLING-3911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14131623#comment-14131623
]
Jason E Bailey commented on SLING-3911:
---
[~justin.edel...@mtvi.com] This meets expectations and I can appreciate the
simpler integration. Thanks!
Sling Models: Unexpected behaviour from Default
---
Key: SLING-3911
URL: https://issues.apache.org/jira/browse/SLING-3911
Project: Sling
Issue Type: Bug
Components: Extensions
Reporter: Jason E Bailey
Assignee: Justin Edelson
Priority: Minor
Labels: models
Fix For: Sling Models API 1.1.2, Sling Models Impl 1.1.2
Attachments: SLING-3911-1.patch, SLING-3911-2.patch
Current application of the @Default annotation has unexpected results
{code}
@Default() int[] intExample;
// sets intExample to a non empty array of [0]
@Default(longValues={1,1}) int[] intExample2;
// sets intExample2 to a non empty array of [0]
{code}
This experience occurs will all supported array types
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (SLING-3949) Sling Models: Add via support to Self annotation
Jason E Bailey created SLING-3949:
-
Summary: Sling Models: Add via support to Self annotation
Key: SLING-3949
URL: https://issues.apache.org/jira/browse/SLING-3949
Project: Sling
Issue Type: Improvement
Reporter: Jason E Bailey
Priority: Minor
Allows the object that is to be applied or adapted to come from a property of
the given adaptable.
example:
{code}
@Model(adaptables = SlingHttpServletRequest.class)
public class Foo {
@Self(via = resourceResolver)
TagManager tagManager;
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-3949) Sling Models: Add via support to Self annotation
[
https://issues.apache.org/jira/browse/SLING-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14152718#comment-14152718
]
Jason E Bailey commented on SLING-3949:
---
[~sseif...@pro-vision.de] Custom injector annotations replace the default
annotations and specifically indicate which optional elements are supported.
Currently if you look at the chart in the documentation, via is called out as
an optional element for ValueMapValue, ChildResource, and RequestAttribute.
[~kwin] @ChildResource is using the getChild method of the resource, if the
adaptable is a resouce. I'm referring to using the via attribute to access a
method oon the object.
I think, in retrospect, my example may have been poor because there is a way to
replicate it with the existing set of injectors(resource-resolver). We have a
number of rich models that don't constrain themselves to just resource and
servletrequest and to extract information from these objects we've been using a
custom BeanValue injector. Which is where I was going with the modification of
the @Self annotation. I thought it would be a little less intrusive then adding
another injector.
So let me provide another mock example:
{code}
@Model(adaptables = Page.class)
public class Foo {
@Self(via = path)
String path; //Page.getPath()
@Self(via=pageTitle)
String title;
@Self(via=parent')
Brand current;
/* useful logic */
}
{code}
Sling Models: Add via support to Self annotation
Key: SLING-3949
URL: https://issues.apache.org/jira/browse/SLING-3949
Project: Sling
Issue Type: Improvement
Reporter: Jason E Bailey
Priority: Minor
Labels: models
Allows the object that is to be applied or adapted to come from a property of
the given adaptable.
example:
{code}
@Model(adaptables = SlingHttpServletRequest.class)
public class Foo {
@Self(via = resourceResolver)
TagManager tagManager;
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-3949) Sling Models: Add via support to Self annotation
[
https://issues.apache.org/jira/browse/SLING-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14153175#comment-14153175
]
Jason E Bailey commented on SLING-3949:
---
I'll need to clear the donation with my employers and work on some unit cases.
I'll see what I can do.
Sling Models: Add via support to Self annotation
Key: SLING-3949
URL: https://issues.apache.org/jira/browse/SLING-3949
Project: Sling
Issue Type: Improvement
Reporter: Jason E Bailey
Priority: Minor
Labels: models
Allows the object that is to be applied or adapted to come from a property of
the given adaptable.
example:
{code}
@Model(adaptables = SlingHttpServletRequest.class)
public class Foo {
@Self(via = resourceResolver)
TagManager tagManager;
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (SLING-3949) Sling Models: Add via support to Self annotation
[
https://issues.apache.org/jira/browse/SLING-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason E Bailey resolved SLING-3949.
---
Resolution: Won't Fix
As per the comment by [~justinedelson]. The @Self annotation won't be applied.
Rather a preferred solution would be a contribution of a Bean based injector.
Will create a specific story for that at the time of contribution.
Sling Models: Add via support to Self annotation
Key: SLING-3949
URL: https://issues.apache.org/jira/browse/SLING-3949
Project: Sling
Issue Type: Improvement
Reporter: Jason E Bailey
Priority: Minor
Labels: models
Allows the object that is to be applied or adapted to come from a property of
the given adaptable.
example:
{code}
@Model(adaptables = SlingHttpServletRequest.class)
public class Foo {
@Self(via = resourceResolver)
TagManager tagManager;
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-4531) sling:Folder should include a mix:title mixin.
[ https://issues.apache.org/jira/browse/SLING-4531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385508#comment-14385508 ] Jason E Bailey commented on SLING-4531: --- I'm not sure if I understand a use case for this. sling:Folder should include a mix:title mixin. -- Key: SLING-4531 URL: https://issues.apache.org/jira/browse/SLING-4531 Project: Sling Issue Type: Improvement Components: Best practices Affects Versions: API 2.9.0 Reporter: Ben Helleman It would be nice to have a consistent definition to define a title for a sling:Folder. To provide consistency it adding a mixin mix:title would help provide clarity. Adding mix:title includes: jcr:description jcr:title -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-2387) OBR at http://sling.apache.org/obr/repository.xml is totally out of date
[ https://issues.apache.org/jira/browse/SLING-2387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14376042#comment-14376042 ] Jason E Bailey commented on SLING-2387: --- We're looking at the OBR to solve a number of issues we have from a maintenance POV in our build and production environments. According to this page; https://sling.apache.org/documentation/development/release-management.html#appendix-c-deploy-bundles-on-the-sling-obr It indicates that the release to the OBR is part of the release process. It would be very helpful to us if the current OBR could be updated. OBR at http://sling.apache.org/obr/repository.xml is totally out of date Key: SLING-2387 URL: https://issues.apache.org/jira/browse/SLING-2387 Project: Sling Issue Type: Bug Reporter: Markus Joschko Priority: Minor It would be quite handy to have the most recent stable bundles of sling available in a bundle repository so that existing installations can easily be updated. However the versions in the existing obr are out of date (way out of date). If there is a way to automate the deployment I might be able to give a hand. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-2387) OBR at http://sling.apache.org/obr/repository.xml is totally out of date
[ https://issues.apache.org/jira/browse/SLING-2387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-2387: -- Attachment: screenshot-1.png OBR at http://sling.apache.org/obr/repository.xml is totally out of date Key: SLING-2387 URL: https://issues.apache.org/jira/browse/SLING-2387 Project: Sling Issue Type: Bug Reporter: Markus Joschko Priority: Minor Attachments: screenshot-1.png It would be quite handy to have the most recent stable bundles of sling available in a bundle repository so that existing installations can easily be updated. However the versions in the existing obr are out of date (way out of date). If there is a way to automate the deployment I might be able to give a hand. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-6478) Add a Sling model annotation+injector for request parameters
[
https://issues.apache.org/jira/browse/SLING-6478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15831950#comment-15831950
]
Jason E Bailey commented on SLING-6478:
---
Would this work as a target of a Source annotation?
i.e.
{code:java}
@Inject @Source("request-parameters")
String foo;
{code}
> Add a Sling model annotation+injector for request parameters
>
>
> Key: SLING-6478
> URL: https://issues.apache.org/jira/browse/SLING-6478
> Project: Sling
> Issue Type: New Feature
> Components: Extensions
>Reporter: Christophe Jelger
>Priority: Minor
> Attachments: SLING-6478-patch.diff
>
>
> It would be handy to have a @RequestParameter annotation to inject request
> parameters in Sling models.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-5841) Self closing DIV when using 'html' context in Sightly
[
https://issues.apache.org/jira/browse/SLING-5841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15449726#comment-15449726
]
Jason E Bailey commented on SLING-5841:
---
Can you clarify a bit on closing this? It sounds like your saying that slightly
doesn't support HTML5? Is there a time period where this is going to change?
> Self closing DIV when using 'html' context in Sightly
> -
>
> Key: SLING-5841
> URL: https://issues.apache.org/jira/browse/SLING-5841
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Reporter: Dan Chapman
>Priority: Minor
>
> When I do:
> ${'' @context='html'}
> It outputs invalid HTML, it self-closes the element:
>
> Only a set number of elements are permitted to self-close -
> http://xahlee.info/js/html5_non-closing_tag.html.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-3270) html-generator to support html5
[ https://issues.apache.org/jira/browse/SLING-3270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978638#comment-15978638 ] Jason E Bailey commented on SLING-3270: --- The solution in stackoverflow was also the one that came up in the tagsoup mail list https://groups.google.com/forum/#!topic/tagsoup-friends/09RCeHzo9yM I'm working on making on implementing a custom schema that extends the original to handle all of the html5 changes. > html-generator to support html5 > --- > > Key: SLING-3270 > URL: https://issues.apache.org/jira/browse/SLING-3270 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Rewriter 1.0.2 >Reporter: Jason E Bailey > > Given the following fragment of HTML > > This is invalid html4 and valid html5, as html5 allows anchor tags to contain > block elements. > The current html-generator corrects the bad html4 and produces the following > output > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SLING-6785) Add support for scoped lifecycle of sling models
[
https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978813#comment-15978813
]
Jason E Bailey commented on SLING-6785:
---
I have concerns with the utility of this. It would be adding a layer of
complexity to the design that would only benefit a very narrow range of models
and the only scope that makes sense in my understanding of Sling would be the
'request' scope.
An example of potential confusion is a model that adapts from a
SlingHttpServletRequest but retrieves the current resource from it. In a
component I could call slingRequest.adaptTo(MyModel.class) with the expectation
that the returned model represents my component. Only to discover that it
doesn't. It returns the model from a prior adaption, same component, different
data. This would be a violation of expectations. Not to say that there
shouldn't be an easy way to transfer data through the hierarchy of includes and
forwarding. I just don't think caching of the models is it.
> Add support for scoped lifecycle of sling models
>
>
> Key: SLING-6785
> URL: https://issues.apache.org/jira/browse/SLING-6785
> Project: Sling
> Issue Type: New Feature
> Components: Extensions
>Reporter: Christophe Jelger
>Priority: Minor
>
> Similar to the scopes of JEE beans
> (http://docs.oracle.com/javaee/6/tutorial/doc/gjbbk.html), it would be nice
> to have the possibility to set a scope for sling models.
> For example, a sling model instance could be reused for all the components
> within the same HTTP request, thus avoiding that multiple instances of the
> "same" model are created.
> This could be an attribute of the {{@model}} annotation, for example
> something like:
> {{@model(scope="request")}}
> The {{request}} scope sounds straightforward for a sling model adapted from a
> request.
> For models adapted from a resource, there are scenarios where the resource
> itself is not relevant once the model has been instantiated, so it would
> still be useful to be able to obtain the same model instance for different
> components and resources within the same HTTP request.
> We could possibly have the same scopes than the JEE beans scope: {{request}},
> {{session}}, and {{application}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SLING-6785) Add support for scoped lifecycle of sling models
[
https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978921#comment-15978921
]
Jason E Bailey commented on SLING-6785:
---
[~justinedelson] Wouldn't placing this in the AdapterManager persist the
caching of this object beyond a single request?
> Add support for scoped lifecycle of sling models
>
>
> Key: SLING-6785
> URL: https://issues.apache.org/jira/browse/SLING-6785
> Project: Sling
> Issue Type: New Feature
> Components: Extensions
>Reporter: Christophe Jelger
>Priority: Minor
> Attachments: SLING-6785.diff
>
>
> Similar to the scopes of JEE beans
> (http://docs.oracle.com/javaee/6/tutorial/doc/gjbbk.html), it would be nice
> to have the possibility to set a scope for sling models.
> For example, a sling model instance could be reused for all the components
> within the same HTTP request, thus avoiding that multiple instances of the
> "same" model are created.
> This could be an attribute of the {{@model}} annotation, for example
> something like:
> {{@model(scope="request")}}
> The {{request}} scope sounds straightforward for a sling model adapted from a
> request.
> For models adapted from a resource, there are scenarios where the resource
> itself is not relevant once the model has been instantiated, so it would
> still be useful to be able to obtain the same model instance for different
> components and resources within the same HTTP request.
> We could possibly have the same scopes than the JEE beans scope: {{request}},
> {{session}}, and {{application}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Closed] (SLING-3861) Sling Models: Add support for the condition field
[ https://issues.apache.org/jira/browse/SLING-3861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey closed SLING-3861. - > Sling Models: Add support for the condition field > - > > Key: SLING-3861 > URL: https://issues.apache.org/jira/browse/SLING-3861 > Project: Sling > Issue Type: Improvement > Components: Extensions >Reporter: Jason E Bailey >Assignee: Justin Edelson >Priority: Trivial > Labels: models > Fix For: Sling Models API 1.1.0, Sling Models Implementation 1.1.0 > > Original Estimate: 0h > Remaining Estimate: 0h > > Provide the option to define a condition field within the Model annotation > that will be used by the adapter web console plugin to provide additional > information about the adaptable -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Closed] (SLING-3949) Sling Models: Add via support to Self annotation
[
https://issues.apache.org/jira/browse/SLING-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason E Bailey closed SLING-3949.
-
> Sling Models: Add via support to Self annotation
>
>
> Key: SLING-3949
> URL: https://issues.apache.org/jira/browse/SLING-3949
> Project: Sling
> Issue Type: Improvement
>Reporter: Jason E Bailey
>Priority: Minor
> Labels: models
>
> Allows the object that is to be applied or adapted to come from a property of
> the given adaptable.
> example:
> {code}
> @Model(adaptables = SlingHttpServletRequest.class)
> public class Foo {
> @Self(via = "resourceResolver")
> TagManager tagManager;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Created] (SLING-6783) update for org.apache.commons.html
Jason E Bailey created SLING-6783: - Summary: update for org.apache.commons.html Key: SLING-6783 URL: https://issues.apache.org/jira/browse/SLING-6783 Project: Sling Issue Type: Improvement Components: Commons Reporter: Jason E Bailey Priority: Minor Attachments: sling.patch Following updates: Updated tagsoup lib to 1.2.1 which has the following modifications * DOCTYPE is now recognized even in lower case. * We make sure to buffer the reader, eliminating a long-standing bug that would crash on certain inputs, such as & followed by CR+LF. * The HTML scanner's table is precompiled at run time for efficiency, causing a 4x speedup on large input documents. * ]] within a CDATA section no longer causes input to be discarded. * Remove bogus newline after printing children of the root element. * Allow the noscript element anywhere, the same as the script element. * Updated to the 2011 edition of the W3C character entity list. Additionally: Updated license with new home page for tagsoup Updated annotations to OSGi annotations Added the ability to specify additional features/properties for the parser Documented available settings -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (SLING-3270) html-generator to support html5
[ https://issues.apache.org/jira/browse/SLING-3270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-3270: -- Attachment: 218.patch To fully support HTML5 you would need to do something like the referenced Univeristy of Warwick repo. I'm reluctant to do that without fully understanding all of the potential changes involved. Additionally, while reviewing the tagsoup codebase it does look like there's room to improve the overall efficiency of this library. Both cases would assume pulling in this parser into Sling for maintenance. I've attached what I consider the smallest change possible which will support the HTML5 version of the 'a' tag. This is generated from the github pr. > html-generator to support html5 > --- > > Key: SLING-3270 > URL: https://issues.apache.org/jira/browse/SLING-3270 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Rewriter 1.0.2 >Reporter: Jason E Bailey > Attachments: 218.patch > > > Given the following fragment of HTML > > This is invalid html4 and valid html5, as html5 allows anchor tags to contain > block elements. > The current html-generator corrects the bad html4 and produces the following > output > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SLING-7185) Content Parser: Support for ISO-8601
[ https://issues.apache.org/jira/browse/SLING-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16206179#comment-16206179 ] Jason E Bailey commented on SLING-7185: --- So is your thinking a configurable formatting or a cascade? I can go ahead and implement the cascade handling of formatting if that's acceptable. > Content Parser: Support for ISO-8601 > > > Key: SLING-7185 > URL: https://issues.apache.org/jira/browse/SLING-7185 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Priority: Minor > > The class org.apache.sling.jcr.contentparser.impl.ParserHelper defines the > Json format for a date to a defined value of ECMA_DATE_FORMAT. > Please support ISO-8601 as a date format. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SLING-7185) Content Parser: Support for ISO-8601
[ https://issues.apache.org/jira/browse/SLING-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207497#comment-16207497 ] Jason E Bailey commented on SLING-7185: --- Kept it Java 7 based, thanks for pointing out the IS08601 class from jackrabbit. It's a lot easier to use compared to what's in Java 8. Although it is more strict from an input point of view. > Content Parser: Support for ISO-8601 > > > Key: SLING-7185 > URL: https://issues.apache.org/jira/browse/SLING-7185 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Priority: Minor > > The class org.apache.sling.jcr.contentparser.impl.ParserHelper defines the > Json format for a date to a defined value of ECMA_DATE_FORMAT. > Please support ISO-8601 as a date format. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SLING-7185) Content Parser: Support for ISO-8601
[ https://issues.apache.org/jira/browse/SLING-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16203851#comment-16203851 ] Jason E Bailey commented on SLING-7185: --- I found the formatting for the date to be odd and specific since Sling is specifically looking for a specific date format in a US locale formatting. Then it was brought to my attention that Sling is exporting the date field in this format as well. So my assumptions at this point is that the main focus of JSON output was to create JSON specifically for browsers and at *that* point in time the formatting of dates in javascript was the US focused format currently being used by Sling Notes: * JavaScript has supported an ISO8601 subset since EcmaScript 5.1 * In JavaScript the default implementation of Date.toJSON() is an ISO8601 string. see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/toJSON * ISO8601 is the standard for String representations of dates. see https://xkcd.com/1179/ Would there be support in adding this to the Content Parser? > Content Parser: Support for ISO-8601 > > > Key: SLING-7185 > URL: https://issues.apache.org/jira/browse/SLING-7185 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Priority: Minor > > The class org.apache.sling.jcr.contentparser.impl.ParserHelper defines the > Json format for a date to a defined value of ECMA_DATE_FORMAT. > Please support ISO-8601 as a date format. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SLING-7185) Content Parser: Support for ISO-8601
[ https://issues.apache.org/jira/browse/SLING-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16206504#comment-16206504 ] Jason E Bailey commented on SLING-7185: --- Would it be a problem to update the Content Parser to require Java 8 as part of this? I'm looking at using the java.time package to handle the parsing. If so, all I would need to do is update the parent version number in the POM, correct? > Content Parser: Support for ISO-8601 > > > Key: SLING-7185 > URL: https://issues.apache.org/jira/browse/SLING-7185 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Priority: Minor > > The class org.apache.sling.jcr.contentparser.impl.ParserHelper defines the > Json format for a date to a defined value of ECMA_DATE_FORMAT. > Please support ISO-8601 as a date format. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (SLING-7185) Content Parser: Support for ISO-8601
Jason E Bailey created SLING-7185: - Summary: Content Parser: Support for ISO-8601 Key: SLING-7185 URL: https://issues.apache.org/jira/browse/SLING-7185 Project: Sling Issue Type: Improvement Reporter: Jason E Bailey Priority: Minor The class org.apache.sling.jcr.contentparser.impl.ParserHelper defines the Json format for a date to a defined value of ECMA_DATE_FORMAT. Please support ISO-8601 as a date format. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SLING-7255) Donating Sling Resource Encryption Utils
[ https://issues.apache.org/jira/browse/SLING-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278623#comment-16278623 ] Jason E Bailey commented on SLING-7255: --- Removing source attachments as this appears to be no longer needed with the source for the donation being in github > Donating Sling Resource Encryption Utils > > > Key: SLING-7255 > URL: https://issues.apache.org/jira/browse/SLING-7255 > Project: Sling > Issue Type: Task >Reporter: Jason E Bailey > > Issue to track donation of Sling resource encryption > Codebase > https://github.com/JEBailey/sling-encrypt > source code is attached with sha1 checksum of > 717e84c0ec45191d14d93cebbe8795961b393610 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SLING-7255) Donating Sling Resource Encryption Utils
[ https://issues.apache.org/jira/browse/SLING-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-7255: -- Attachment: (was: sling-encrypt-0.0.3-beta.zip) > Donating Sling Resource Encryption Utils > > > Key: SLING-7255 > URL: https://issues.apache.org/jira/browse/SLING-7255 > Project: Sling > Issue Type: Task >Reporter: Jason E Bailey > > Issue to track donation of Sling resource encryption > Codebase > https://github.com/JEBailey/sling-encrypt > source code is attached with sha1 checksum of > 717e84c0ec45191d14d93cebbe8795961b393610 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SLING-7255) Donating Sling Resource Encryption Utils
[ https://issues.apache.org/jira/browse/SLING-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-7255: -- Attachment: sling-encrypt-1.0.0-beta.zip Attaching 1.0.0-beta.zip with sha1 - 11e3933e6170dd4e783cbf6bcbe72ed5961baa29 > Donating Sling Resource Encryption Utils > > > Key: SLING-7255 > URL: https://issues.apache.org/jira/browse/SLING-7255 > Project: Sling > Issue Type: Task > Components: Extensions >Reporter: Jason E Bailey >Assignee: Robert Munteanu > Attachments: sling-encrypt-1.0.0-beta.zip > > > Issue to track donation of Sling EncryptableValueMap and associated Services > and Utilities > API > https://github.com/JEBailey/sling-encrypt > Implementation > https://github.com/JEBailey/sling-encryption-provider -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SLING-7255) Donating Sling Resource Encryption Utils
[ https://issues.apache.org/jira/browse/SLING-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-7255: -- Attachment: (was: sling-encrypt-0.0.1-beta.zip) > Donating Sling Resource Encryption Utils > > > Key: SLING-7255 > URL: https://issues.apache.org/jira/browse/SLING-7255 > Project: Sling > Issue Type: Task >Reporter: Jason E Bailey > > Issue to track donation of Sling resource encryption > Codebase > https://github.com/JEBailey/sling-encrypt > source code is attached with sha1 checksum of > 717e84c0ec45191d14d93cebbe8795961b393610 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SLING-7255) Donating Sling Resource Encryption Utils
[ https://issues.apache.org/jira/browse/SLING-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-7255: -- Attachment: sling-encrypt-0.0.2-beta.zip sha1 ea1448cab0b96864257783a76aadfab3ca419262 > Donating Sling Resource Encryption Utils > > > Key: SLING-7255 > URL: https://issues.apache.org/jira/browse/SLING-7255 > Project: Sling > Issue Type: Task >Reporter: Jason E Bailey > Attachments: sling-encrypt-0.0.2-beta.zip > > > Issue to track donation of Sling resource encryption > Codebase > https://github.com/JEBailey/sling-encrypt > source code is attached with sha1 checksum of > 717e84c0ec45191d14d93cebbe8795961b393610 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SLING-7255) Donating Sling Resource Encryption Utils
[ https://issues.apache.org/jira/browse/SLING-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16259745#comment-16259745 ] Jason E Bailey commented on SLING-7255: --- Documentation has been updated in the README. Encryption has been updated to "AES/GCM/NoPadding" Additionally, I extended the API to accept an AAD. EncryptionValueMap uses the property name of the encrypted value as the AAD so that will prevent someone accidentally moving an encrypted value to a different property and exposing the content. > Donating Sling Resource Encryption Utils > > > Key: SLING-7255 > URL: https://issues.apache.org/jira/browse/SLING-7255 > Project: Sling > Issue Type: Task >Reporter: Jason E Bailey > Attachments: sling-encrypt-0.0.2-beta.zip > > > Issue to track donation of Sling resource encryption > Codebase > https://github.com/JEBailey/sling-encrypt > source code is attached with sha1 checksum of > 717e84c0ec45191d14d93cebbe8795961b393610 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (SLING-7255) Donating Sling Resource Encryption Utils
Jason E Bailey created SLING-7255: - Summary: Donating Sling Resource Encryption Utils Key: SLING-7255 URL: https://issues.apache.org/jira/browse/SLING-7255 Project: Sling Issue Type: Task Reporter: Jason E Bailey Attachments: sling-encrypt-0.0.1-beta.zip Issue to track donation of Sling resource encryption Codebase https://github.com/JEBailey/sling-encrypt source code is attached with sha1 checksum of 717e84c0ec45191d14d93cebbe8795961b393610 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (SLING-7254) Donating Sling Resource Encryption Utils
Jason E Bailey created SLING-7254: - Summary: Donating Sling Resource Encryption Utils Key: SLING-7254 URL: https://issues.apache.org/jira/browse/SLING-7254 Project: Sling Issue Type: Task Reporter: Jason E Bailey Attachments: sling-encrypt-0.0.1-beta.zip Issue to track donation of Sling resource encryption Codebase https://github.com/JEBailey/sling-encrypt source code is attached with sha1 checksum of 717e84c0ec45191d14d93cebbe8795961b393610 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SLING-7255) Donating Sling Resource Encryption Utils
[ https://issues.apache.org/jira/browse/SLING-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-7255: -- Attachment: sling-encrypt-0.0.3-beta.zip attached v0.0.3 SHA1 128feca1006bb76fe0fa3a634fbb4de8b2dfd964 Renamed EncryptionValueMap to EncryptableValueMap. Moved the AesEncryptionProvider out to have a separate bundle provide implementation. Added some additional unit tests > Donating Sling Resource Encryption Utils > > > Key: SLING-7255 > URL: https://issues.apache.org/jira/browse/SLING-7255 > Project: Sling > Issue Type: Task >Reporter: Jason E Bailey > Attachments: sling-encrypt-0.0.2-beta.zip, > sling-encrypt-0.0.3-beta.zip > > > Issue to track donation of Sling resource encryption > Codebase > https://github.com/JEBailey/sling-encrypt > source code is attached with sha1 checksum of > 717e84c0ec45191d14d93cebbe8795961b393610 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SLING-7255) Donating Sling Resource Encryption Utils
[ https://issues.apache.org/jira/browse/SLING-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16276966#comment-16276966 ] Jason E Bailey commented on SLING-7255: --- Linked repository has been updated. Currently re-merged api and implementation while looking for clarification on the process and added a KeyProvider api to better facilitate key handling and the ability to do key rotations. What are next steps? > Donating Sling Resource Encryption Utils > > > Key: SLING-7255 > URL: https://issues.apache.org/jira/browse/SLING-7255 > Project: Sling > Issue Type: Task >Reporter: Jason E Bailey > Attachments: sling-encrypt-0.0.2-beta.zip, > sling-encrypt-0.0.3-beta.zip > > > Issue to track donation of Sling resource encryption > Codebase > https://github.com/JEBailey/sling-encrypt > source code is attached with sha1 checksum of > 717e84c0ec45191d14d93cebbe8795961b393610 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SLING-7255) Donating Sling Resource Encryption Utils
[ https://issues.apache.org/jira/browse/SLING-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-7255: -- Description: Issue to track donation of Sling EncryptableValueMap and associated Services and Utilities API https://github.com/JEBailey/sling-encrypt Implementation https://github.com/JEBailey/sling-encryption-provider was: Issue to track donation of Sling resource encryption Codebase https://github.com/JEBailey/sling-encrypt source code is attached with sha1 checksum of 717e84c0ec45191d14d93cebbe8795961b393610 > Donating Sling Resource Encryption Utils > > > Key: SLING-7255 > URL: https://issues.apache.org/jira/browse/SLING-7255 > Project: Sling > Issue Type: Task >Reporter: Jason E Bailey > > Issue to track donation of Sling EncryptableValueMap and associated Services > and Utilities > API > https://github.com/JEBailey/sling-encrypt > Implementation > https://github.com/JEBailey/sling-encryption-provider -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SLING-6783) Updates for Commons HTML
[ https://issues.apache.org/jira/browse/SLING-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465236#comment-16465236 ] Jason E Bailey commented on SLING-6783: --- [~olli] When I first encountered issues with this and HTML 5 support I did some looking around and discovered that there have been some forks of taglib that supported HTML 5. That's an option. Last I checked jsoup was working on a SAX interface but I don't know the status of that. Changing the API and creating a bridge for that into the re-writer would be useful. It might be time as well to take a look at the re-writer and potentially do a re-write. Honestly that would be my preferred option, look at doing an event based rewriting flow. > Updates for Commons HTML > > > Key: SLING-6783 > URL: https://issues.apache.org/jira/browse/SLING-6783 > Project: Sling > Issue Type: Improvement > Components: Commons >Reporter: Jason E Bailey >Assignee: Oliver Lietz >Priority: Minor > Fix For: Commons HTML 1.0.2 > > Attachments: sling.patch > > > Following updates: > Updated tagsoup lib to 1.2.1 which has the following modifications > * DOCTYPE is now recognized even in lower case. > * We make sure to buffer the reader, eliminating a long-standing bug that > would crash on certain inputs, such as & followed by CR+LF. > * The HTML scanner's table is precompiled at run time for efficiency, causing > a 4x speedup on large input documents. > * ]] within a CDATA section no longer causes input to be discarded. > * Remove bogus newline after printing children of the root element. > * Allow the noscript element anywhere, the same as the script element. > * Updated to the 2011 edition of the W3C character entity list. > Additionally: > Updated license with new home page for tagsoup > Updated annotations to OSGi annotations > Added the ability to specify additional features/properties for the parser > Documented available settings > Javadoc fixed > Prepared for different parsers by renaming HtmlParserImpl and adding > component properties > Configuration improved -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-7656) Unit test improvements for Sling Default GET Servlet
Jason E Bailey created SLING-7656: - Summary: Unit test improvements for Sling Default GET Servlet Key: SLING-7656 URL: https://issues.apache.org/jira/browse/SLING-7656 Project: Sling Issue Type: Improvement Components: Servlets Affects Versions: Servlets Get 2.1.30 Reporter: Jason E Bailey Assignee: Jason E Bailey Unit test cases need to be improved to cover content as well, since the content is being generated with the default GET servlet renderers -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-7657) MockSlingHttpServletRequest throws exception on getResponseContentType
[ https://issues.apache.org/jira/browse/SLING-7657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-7657: -- Summary: MockSlingHttpServletRequest throws exception on getResponseContentType (was: Sling Mock Request should not throw exceptions on method invocation) > MockSlingHttpServletRequest throws exception on getResponseContentType > -- > > Key: SLING-7657 > URL: https://issues.apache.org/jira/browse/SLING-7657 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > > MockSlingHttpServletRequest has multiple methods which throw an Unsupported > Operation Exception. These methods are unable to be mocked because of this > exception. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-7657) MockSlingHttpServletRequest throws exception on getResponseContentType
[ https://issues.apache.org/jira/browse/SLING-7657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-7657: -- Description: org.apache.sling.servlethelpers.MockSlingHttpServletRequest throws an exception by default for the method . (was: MockSlingHttpServletRequest has multiple methods which throw an Unsupported Operation Exception. These methods are unable to be mocked because of this exception.) > MockSlingHttpServletRequest throws exception on getResponseContentType > -- > > Key: SLING-7657 > URL: https://issues.apache.org/jira/browse/SLING-7657 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > > org.apache.sling.servlethelpers.MockSlingHttpServletRequest throws an > exception by default for the method . -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-7657) MockSlingHttpServletRequest throws exception on getResponseContentType
[ https://issues.apache.org/jira/browse/SLING-7657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-7657: -- Description: org.apache.sling.servlethelpers.MockSlingHttpServletRequest throws an exception by default for the method getResponseContentType() this prevents the method from being mocked and prevents the Request object being usable to test the default GET servlet (was: org.apache.sling.servlethelpers.MockSlingHttpServletRequest throws an exception by default for the method .) > MockSlingHttpServletRequest throws exception on getResponseContentType > -- > > Key: SLING-7657 > URL: https://issues.apache.org/jira/browse/SLING-7657 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: Servlet Helpers 1.1.4 > > > org.apache.sling.servlethelpers.MockSlingHttpServletRequest throws an > exception by default for the method getResponseContentType() this prevents > the method from being mocked and prevents the Request object being usable to > test the default GET servlet -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-7657) MockSlingHttpServletRequest throws exception on getResponseContentType
[ https://issues.apache.org/jira/browse/SLING-7657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-7657: -- Fix Version/s: Servlet Helpers 1.1.4 > MockSlingHttpServletRequest throws exception on getResponseContentType > -- > > Key: SLING-7657 > URL: https://issues.apache.org/jira/browse/SLING-7657 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: Servlet Helpers 1.1.4 > > > org.apache.sling.servlethelpers.MockSlingHttpServletRequest throws an > exception by default for the method getResponseContentType() this prevents > the method from being mocked and prevents the Request object being usable to > test the default GET servlet -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-6783) Updates for Commons HTML
[ https://issues.apache.org/jira/browse/SLING-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16466388#comment-16466388 ] Jason E Bailey commented on SLING-6783: --- [~olli] do you want to do the release on this? > Updates for Commons HTML > > > Key: SLING-6783 > URL: https://issues.apache.org/jira/browse/SLING-6783 > Project: Sling > Issue Type: Improvement > Components: Commons >Reporter: Jason E Bailey >Assignee: Oliver Lietz >Priority: Minor > Fix For: Commons HTML 1.0.2 > > Attachments: sling.patch > > > Following updates: > Updated tagsoup lib to 1.2.1 which has the following modifications > * DOCTYPE is now recognized even in lower case. > * We make sure to buffer the reader, eliminating a long-standing bug that > would crash on certain inputs, such as & followed by CR+LF. > * The HTML scanner's table is precompiled at run time for efficiency, causing > a 4x speedup on large input documents. > * ]] within a CDATA section no longer causes input to be discarded. > * Remove bogus newline after printing children of the root element. > * Allow the noscript element anywhere, the same as the script element. > * Updated to the 2011 edition of the W3C character entity list. > Additionally: > Updated license with new home page for tagsoup > Updated annotations to OSGi annotations > Added the ability to specify additional features/properties for the parser > Documented available settings > Javadoc fixed > Prepared for different parsers by renaming HtmlParserImpl and adding > component properties > Configuration improved -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7659) Test using o.a.s.testing.paxexam block if run without "mvn clean"
[
https://issues.apache.org/jira/browse/SLING-7659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468788#comment-16468788
]
Jason E Bailey commented on SLING-7659:
---
I don't think it's unreasonable to need a clean before executing the OSGi
framework. Would it be acceptable to exit the integration test with an error if
the folder already exists?
> Test using o.a.s.testing.paxexam block if run without "mvn clean"
> -
>
> Key: SLING-7659
> URL: https://issues.apache.org/jira/browse/SLING-7659
> Project: Sling
> Issue Type: Bug
> Components: Testing
>Affects Versions: Testing PaxExam 2.0.0
>Reporter: Bertrand Delacretaz
>Priority: Minor
> Attachments: testing.log
>
>
> This happens for (at least) the following modules:
> * sling-org-apache-sling-commons-html which uses o.a.s.testing.paxexam 2.0.0
> * sling-org-apache-sling-resource-presence which uses o.a.s.testing.paxexam
> 0.0.4
> The integration tests work fine with {{mvn clean install}} but running {{mvn
> install}} right after that causes the tests to hang and time out (after
> approximately 6 minutes).
> Deleting {{target/paxexam}} folder before running {{mvn install}} fixes the
> issue, so it's linked to existing OSGi state apparently.
> I'll attach a {{testing.log}}, I don't see any obvious clues in it but the
> tests block after this line:
> {code:java}
> 2018-05-09 11:59:56,003 DEBUG [BundleWatcher: 1] o.o.p.e.r.e.i.Probe
> [Parser.java : 64] Registering Service: org.ops4j.pax.exam.ProbeInvoker
> with Probe-Signature="PaxExam-d4e46627-3b02-462a-aa46-883ce54e3f9f"
> and expression=
> "org.apache.sling.commons.html.it.TagsoupHtmlParserIT;testFeaturesConfiguration"
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7593) ResourceTraversor doesn't support ResourceDecorator pattern
[ https://issues.apache.org/jira/browse/SLING-7593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468739#comment-16468739 ] Jason E Bailey commented on SLING-7593: --- Hi [~joannajasnowska] I'm in the process of doing some updates to that bundle. I'm hoping to get a release out no later then the end of next week, March 18th > ResourceTraversor doesn't support ResourceDecorator pattern > --- > > Key: SLING-7593 > URL: https://issues.apache.org/jira/browse/SLING-7593 > Project: Sling > Issue Type: Bug > Components: API, Servlets >Reporter: Joanna Jasnowska >Assignee: Carsten Ziegeler >Priority: Blocker > Fix For: API 2.18.2, Servlets Get 2.1.32 > > Attachments: > calling_deprecated_ResourceUtil_listChildren(resource)_replaced_with_resource_listChildren.patch, > listChildren_method_fixed.patch > > > In my current project, we are using ResourceDecorator pattern. In one case we > would like to decorate a resource with additional children. Unfortunately > ResourceTraversor object doesn't accept information about children from > ResourceDecorator. It is caused by usage of > ResourceUtil.listChildren(resource) method (inside ResourceTraversor class) > which is deprecated. Under the hood the method invokes > resource.getResourceResolver.listChildren(resource) method which reads data > directly from repo. In result our additional children are not returned. > Moreover, we don't have a place to add them to the list returned from > resourceResolver.listChildren method. > When we change the approach and we invoke resource.listChildren() method > instead of ResourceUtil.listChildren(resource) then we get solution which is > compatible with ResourceDecorator pattern and on the other hand when > resources are not decorated then no changes should be observed. > Additionally I have one additional question about > org.apache.sling.servlets.get bundle imported packages. Why do we have the > following dependency org.apache.sling.api.resource.external;version="[1.0,2)" > in the latest released version? On the other hand the same bundle has > dependency on org.apache.sling.api.resource; version="[2.10,3)". Is it > expected? If yes then how to provide > org.apache.sling.api.resource.external;version="[1.0,2)" on my environment, > because now I don't have it. > In the attachment section, you could find patch containing fix for the > described scenario. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-7590) Content Loaders not respecting time zone for Dates
[ https://issues.apache.org/jira/browse/SLING-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey resolved SLING-7590. --- Resolution: Fixed > Content Loaders not respecting time zone for Dates > -- > > Key: SLING-7590 > URL: https://issues.apache.org/jira/browse/SLING-7590 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: JCR ContentLoader 2.2.6, JCR Content Parser 1.2.6 > > Time Spent: 20m > Remaining Estimate: 0h > > When importing content, the JCR supports the setting of the time zone for a > jcr Date. However we currently have several processes that fail to set the > time zone correctly. > org.apache.sling.jcr.contentparser.impl.ParserHelper > org.apache.sling.jcr.contentloader.internal.DefaultContentCreator > org.apache.sling.servlets.post.impl.helper.DateParser > Take a String based time representation that includes a time offset and > convert it to Date that looses that information, before conversion to a > Calendar object. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SLING-7625) Refactor Default Get Servlets
[ https://issues.apache.org/jira/browse/SLING-7625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey reassigned SLING-7625: - Assignee: Jason E Bailey > Refactor Default Get Servlets > -- > > Key: SLING-7625 > URL: https://issues.apache.org/jira/browse/SLING-7625 > Project: Sling > Issue Type: Improvement > Components: Servlets >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: Servlets Get 2.1.32 > > Time Spent: 50m > Remaining Estimate: 0h > > This started off with an attempt to update the Date rendering and got > sidetracked. The majority of changes here are clean up and with all the > classes being under an .impl folder there should be no external impact. > Remove all uses of deprecated API's > Remove all methods that aren't being used > Re-organize GET servlets to be in one location > Rename objects to better represent their purpose > Reduce memory consumption by removing unnecessary Object creation > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-7625) Refactor Default Get Servlets
[ https://issues.apache.org/jira/browse/SLING-7625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-7625: -- Component/s: Servlets > Refactor Default Get Servlets > -- > > Key: SLING-7625 > URL: https://issues.apache.org/jira/browse/SLING-7625 > Project: Sling > Issue Type: Improvement > Components: Servlets >Reporter: Jason E Bailey >Priority: Major > Fix For: Servlets Get 2.1.32 > > > This started off with an attempt to update the Date rendering and got > sidetracked. The majority of changes here are clean up and with all the > classes being under an .impl folder there should be no external impact. > Remove all uses of deprecated API's > Remove all methods that aren't being used > Re-organize GET servlets to be in one location > Rename objects to better represent their purpose > Reduce memory consumption by removing unnecessary Object creation > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-7625) Refactor Default Get Servlets
[ https://issues.apache.org/jira/browse/SLING-7625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-7625: -- Fix Version/s: Servlets Get 2.1.32 > Refactor Default Get Servlets > -- > > Key: SLING-7625 > URL: https://issues.apache.org/jira/browse/SLING-7625 > Project: Sling > Issue Type: Improvement > Components: Servlets >Reporter: Jason E Bailey >Priority: Major > Fix For: Servlets Get 2.1.32 > > > This started off with an attempt to update the Date rendering and got > sidetracked. The majority of changes here are clean up and with all the > classes being under an .impl folder there should be no external impact. > Remove all uses of deprecated API's > Remove all methods that aren't being used > Re-organize GET servlets to be in one location > Rename objects to better represent their purpose > Reduce memory consumption by removing unnecessary Object creation > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-7625) Refactor Default Get Servlets
Jason E Bailey created SLING-7625: - Summary: Refactor Default Get Servlets Key: SLING-7625 URL: https://issues.apache.org/jira/browse/SLING-7625 Project: Sling Issue Type: Improvement Reporter: Jason E Bailey This started off with an attempt to update the Date rendering and got sidetracked. The majority of changes here are clean up and with all the classes being under an .impl folder there should be no external impact. Remove all uses of deprecated API's Remove all methods that aren't being used Re-organize GET servlets to be in one location Rename objects to better represent their purpose Reduce memory consumption by removing unnecessary Object creation -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7625) Refactor Default Get Servlets
[ https://issues.apache.org/jira/browse/SLING-7625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456355#comment-16456355 ] Jason E Bailey commented on SLING-7625: --- Created a Pull request for this for review as this is a lot of changes, even though the majority of it is cosmetic. [https://github.com/apache/sling-org-apache-sling-servlets-get/pull/2] Unit tests could stand to be improved as well and I'm taking that on next. > Refactor Default Get Servlets > -- > > Key: SLING-7625 > URL: https://issues.apache.org/jira/browse/SLING-7625 > Project: Sling > Issue Type: Improvement > Components: Servlets >Reporter: Jason E Bailey >Priority: Major > Fix For: Servlets Get 2.1.32 > > Time Spent: 20m > Remaining Estimate: 0h > > This started off with an attempt to update the Date rendering and got > sidetracked. The majority of changes here are clean up and with all the > classes being under an .impl folder there should be no external impact. > Remove all uses of deprecated API's > Remove all methods that aren't being used > Re-organize GET servlets to be in one location > Rename objects to better represent their purpose > Reduce memory consumption by removing unnecessary Object creation > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SLING-7657) MockSlingHttpServletRequest throws exception on getResponseContentType
[ https://issues.apache.org/jira/browse/SLING-7657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey closed SLING-7657. - > MockSlingHttpServletRequest throws exception on getResponseContentType > -- > > Key: SLING-7657 > URL: https://issues.apache.org/jira/browse/SLING-7657 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: Servlet Helpers 1.1.6 > > > org.apache.sling.servlethelpers.MockSlingHttpServletRequest throws an > exception by default for the method getResponseContentType() this prevents > the method from being mocked and prevents the Request object being usable to > test the default GET servlet -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SLING-6783) Updates for Commons HTML
[ https://issues.apache.org/jira/browse/SLING-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey closed SLING-6783. - > Updates for Commons HTML > > > Key: SLING-6783 > URL: https://issues.apache.org/jira/browse/SLING-6783 > Project: Sling > Issue Type: Improvement > Components: Commons >Reporter: Jason E Bailey >Assignee: Oliver Lietz >Priority: Minor > Fix For: Commons HTML 1.0.2 > > Attachments: sling.patch > > > Following updates: > Updated tagsoup lib to 1.2.1 which has the following modifications > * DOCTYPE is now recognized even in lower case. > * We make sure to buffer the reader, eliminating a long-standing bug that > would crash on certain inputs, such as & followed by CR+LF. > * The HTML scanner's table is precompiled at run time for efficiency, causing > a 4x speedup on large input documents. > * ]] within a CDATA section no longer causes input to be discarded. > * Remove bogus newline after printing children of the root element. > * Allow the noscript element anywhere, the same as the script element. > * Updated to the 2011 edition of the W3C character entity list. > Additionally: > Updated license with new home page for tagsoup > Updated annotations to OSGi annotations > Added the ability to specify additional features/properties for the parser > Documented available settings > Javadoc fixed > Prepared for different parsers by renaming HtmlParserImpl and adding > component properties > Configuration improved -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SLING-7556) Use bnd Maven plugins
[ https://issues.apache.org/jira/browse/SLING-7556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey closed SLING-7556. - > Use bnd Maven plugins > - > > Key: SLING-7556 > URL: https://issues.apache.org/jira/browse/SLING-7556 > Project: Sling > Issue Type: Improvement > Components: Commons >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Commons HTML 1.0.2 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SLING-7557) Add initial integration tests
[ https://issues.apache.org/jira/browse/SLING-7557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey closed SLING-7557. - > Add initial integration tests > - > > Key: SLING-7557 > URL: https://issues.apache.org/jira/browse/SLING-7557 > Project: Sling > Issue Type: Improvement > Components: Commons >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Commons HTML 1.0.2 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-7663) convert site to HTML5 specification
Jason E Bailey created SLING-7663: - Summary: convert site to HTML5 specification Key: SLING-7663 URL: https://issues.apache.org/jira/browse/SLING-7663 Project: Sling Issue Type: Improvement Reporter: Jason E Bailey Assignee: Jason E Bailey Update Sling site to HTML5 standards -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-7657) MockSlingHttpServletRequest throws exception on getResponseContentType
[ https://issues.apache.org/jira/browse/SLING-7657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-7657: -- Fix Version/s: (was: Servlet Helpers 1.1.4) Servlet Helpers 1.1.6 > MockSlingHttpServletRequest throws exception on getResponseContentType > -- > > Key: SLING-7657 > URL: https://issues.apache.org/jira/browse/SLING-7657 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: Servlet Helpers 1.1.6 > > > org.apache.sling.servlethelpers.MockSlingHttpServletRequest throws an > exception by default for the method getResponseContentType() this prevents > the method from being mocked and prevents the Request object being usable to > test the default GET servlet -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-7657) MockSlingHttpServletRequest throws exception on getResponseContentType
[ https://issues.apache.org/jira/browse/SLING-7657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey resolved SLING-7657. --- Resolution: Fixed > MockSlingHttpServletRequest throws exception on getResponseContentType > -- > > Key: SLING-7657 > URL: https://issues.apache.org/jira/browse/SLING-7657 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: Servlet Helpers 1.1.6 > > > org.apache.sling.servlethelpers.MockSlingHttpServletRequest throws an > exception by default for the method getResponseContentType() this prevents > the method from being mocked and prevents the Request object being usable to > test the default GET servlet -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-6783) Updates for Commons HTML
[ https://issues.apache.org/jira/browse/SLING-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467505#comment-16467505 ] Jason E Bailey commented on SLING-6783: --- [~olli] I'm running into problems with the paxexam test. [INFO] Results: [INFO] [ERROR] Errors: [ERROR] TagsoupHtmlParserIT.testFeaturesConfiguration » IllegalState services vanished... [ERROR] TagsoupHtmlParserIT.testHtmlParser » IllegalState services vanished too fast. [INFO] [ERROR] Tests run: 2, Failures: 0, Errors: 2, Skipped: 0 Any idea? I'm not able to deploy. > Updates for Commons HTML > > > Key: SLING-6783 > URL: https://issues.apache.org/jira/browse/SLING-6783 > Project: Sling > Issue Type: Improvement > Components: Commons >Reporter: Jason E Bailey >Assignee: Oliver Lietz >Priority: Minor > Fix For: Commons HTML 1.0.2 > > Attachments: sling.patch > > > Following updates: > Updated tagsoup lib to 1.2.1 which has the following modifications > * DOCTYPE is now recognized even in lower case. > * We make sure to buffer the reader, eliminating a long-standing bug that > would crash on certain inputs, such as & followed by CR+LF. > * The HTML scanner's table is precompiled at run time for efficiency, causing > a 4x speedup on large input documents. > * ]] within a CDATA section no longer causes input to be discarded. > * Remove bogus newline after printing children of the root element. > * Allow the noscript element anywhere, the same as the script element. > * Updated to the 2011 edition of the W3C character entity list. > Additionally: > Updated license with new home page for tagsoup > Updated annotations to OSGi annotations > Added the ability to specify additional features/properties for the parser > Documented available settings > Javadoc fixed > Prepared for different parsers by renaming HtmlParserImpl and adding > component properties > Configuration improved -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-7657) Sling Mock Request should not throw exceptions on method invocation
Jason E Bailey created SLING-7657: - Summary: Sling Mock Request should not throw exceptions on method invocation Key: SLING-7657 URL: https://issues.apache.org/jira/browse/SLING-7657 Project: Sling Issue Type: Improvement Reporter: Jason E Bailey Assignee: Jason E Bailey MockSlingHttpServletRequest has multiple methods which throw an Unsupported Operation Exception. These methods are unable to be mocked because of this exception. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SLING-7185) Content Parser: Support for ISO-8601
[ https://issues.apache.org/jira/browse/SLING-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey closed SLING-7185. - > Content Parser: Support for ISO-8601 > > > Key: SLING-7185 > URL: https://issues.apache.org/jira/browse/SLING-7185 > Project: Sling > Issue Type: Improvement > Components: JCR >Affects Versions: JCR Content Parser 1.2.4 >Reporter: Jason E Bailey >Assignee: Stefan Seifert >Priority: Minor > Fix For: JCR Content Parser 1.2.6 > > > The class org.apache.sling.jcr.contentparser.impl.ParserHelper defines the > Json format for a date to a defined value of ECMA_DATE_FORMAT. > Please support ISO-8601 as a date format. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SLING-7520) Sling Query - shortened URL goes to non apache site
[ https://issues.apache.org/jira/browse/SLING-7520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey closed SLING-7520. - > Sling Query - shortened URL goes to non apache site > --- > > Key: SLING-7520 > URL: https://issues.apache.org/jira/browse/SLING-7520 > Project: Sling > Issue Type: Improvement > Components: Sling Query >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Trivial > Fix For: Sling Query 4.0.2 > > > Warning is generated out of Sling Query which contains a shortened url that > links to the previous site before it was merged. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SLING-7524) Sling Query - unique function does not not remove all duplicates
[ https://issues.apache.org/jira/browse/SLING-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey closed SLING-7524. - > Sling Query - unique function does not not remove all duplicates > > > Key: SLING-7524 > URL: https://issues.apache.org/jira/browse/SLING-7524 > Project: Sling > Issue Type: Improvement > Components: Sling Query >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: Sling Query 4.0.2 > > > the function for unique does not match the contract a unique function usually > provides including JQuery, rather it's providing a sequential deduplicator. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SLING-7540) Sling Query - Iterator improvements
[ https://issues.apache.org/jira/browse/SLING-7540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey closed SLING-7540. - > Sling Query - Iterator improvements > --- > > Key: SLING-7540 > URL: https://issues.apache.org/jira/browse/SLING-7540 > Project: Sling > Issue Type: Improvement > Components: Sling Query >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: Sling Query 4.0.2 > > > Cover some minor improvements to Iterators, specifically > AlternativeIterator - prevent iterator from continuing with iteration after > item to be returned has been discovered. > LastIterator - current design predetermines end item. Removes that and makes > it more "lazy" > SuppIterator - removes recursion -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SLING-7590) Content Loaders not respecting time zone for Dates
[ https://issues.apache.org/jira/browse/SLING-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey closed SLING-7590. - > Content Loaders not respecting time zone for Dates > -- > > Key: SLING-7590 > URL: https://issues.apache.org/jira/browse/SLING-7590 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: JCR ContentLoader 2.2.6, JCR Content Parser 1.2.6 > > Time Spent: 20m > Remaining Estimate: 0h > > When importing content, the JCR supports the setting of the time zone for a > jcr Date. However we currently have several processes that fail to set the > time zone correctly. > org.apache.sling.jcr.contentparser.impl.ParserHelper > org.apache.sling.jcr.contentloader.internal.DefaultContentCreator > org.apache.sling.servlets.post.impl.helper.DateParser > Take a String based time representation that includes a time offset and > convert it to Date that looses that information, before conversion to a > Calendar object. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-7663) convert site to HTML5 specification
[ https://issues.apache.org/jira/browse/SLING-7663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-7663: -- Description: Utilizing validation tools such as [https://validator.w3.org|https://validator.w3.org/] validate that the site is providing HTML correctly. (was: Update Sling site to HTML5 standards) > convert site to HTML5 specification > --- > > Key: SLING-7663 > URL: https://issues.apache.org/jira/browse/SLING-7663 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Minor > > Utilizing validation tools such as > [https://validator.w3.org|https://validator.w3.org/] validate that the site > is providing HTML correctly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7242) [Shiny] Sling Website Design
[ https://issues.apache.org/jira/browse/SLING-7242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477587#comment-16477587 ] Jason E Bailey commented on SLING-7242: --- [~auniverseaway] This is great. Is there any movement on this or assistance needed? > [Shiny] Sling Website Design > > > Key: SLING-7242 > URL: https://issues.apache.org/jira/browse/SLING-7242 > Project: Sling > Issue Type: Task >Reporter: Chris Millar >Priority: Minor > Attachments: Web 1920 – 1.png, browser-comparison.jpg > > > As part of SLING-, it was mentioned the Sling website needs a re-design > to help attract new developers and make the site easier to use on mobile > devices. > Now that the site is on JBake, it probably makes sense to start working on > this. > The attached mockup is an initial take on the homepage. It's not meant to be > all-encompassing, but should provide a view into what the site could look > like and how it could match the new Sling Launchpad design. > *Notes* > * The image is pulled from Adobe Stock. Hopefully this can be donated, or we > can pull from the community to get an image we want to use. Was thinking > "greenfield" and not overly distracting. > * I was looking for something punchy for the title text. "Effortlessly build > resource-driven web-applications." is what I came up with. > * About text has been un-touched. > * Easy build instructions are right on the homepage. Docker first, with Java > just a tab click away. This follows Docker now being the priority on the > getting started page. > * News, Get Involved, and Additional Resource should be mostly > self-explanatory. > * The navigation is designed around the common areas of the current left hand > rail, but with tutorials being broken out. This is a result of the many devs > I've on-boarded that prefer walk-throughs over raw docs. > Overall the idea is to give a single page of the main topics, but kick out to > the pages already established. > Let me know your thoughts. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7663) convert site to HTML5 specification
[ https://issues.apache.org/jira/browse/SLING-7663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477598#comment-16477598 ] Jason E Bailey commented on SLING-7663: --- [~bdelacretaz] makes sense, thanks for linking these together > convert site to HTML5 specification > --- > > Key: SLING-7663 > URL: https://issues.apache.org/jira/browse/SLING-7663 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Minor > > Utilizing validation tools such as > [https://validator.w3.org|https://validator.w3.org/] validate that the site > is providing HTML correctly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7242) [Shiny] Sling Website Design
[ https://issues.apache.org/jira/browse/SLING-7242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482471#comment-16482471 ] Jason E Bailey commented on SLING-7242: --- [~auniverseaway] This is such a significant refresh. It's impressive. +1 My thoughts * +1 to moving forward on this aggressively * The only awkward is the TOC, maybe a different hued nav bar to separate from page nav? * 'Response Status' is showing up as an ID and an anchor multiple times. * I would support an update now and improve approach over a delay to achieve the perfect page > [Shiny] Sling Website Design > > > Key: SLING-7242 > URL: https://issues.apache.org/jira/browse/SLING-7242 > Project: Sling > Issue Type: Task >Reporter: Chris Millar >Priority: Minor > Attachments: Sling - Page.png, Web 1920 – 1.png, > browser-comparison.jpg, screenshot-1.png > > > As part of SLING-, it was mentioned the Sling website needs a re-design > to help attract new developers and make the site easier to use on mobile > devices. > Now that the site is on JBake, it probably makes sense to start working on > this. > The attached mockup is an initial take on the homepage. It's not meant to be > all-encompassing, but should provide a view into what the site could look > like and how it could match the new Sling Launchpad design. > *Notes* > * The image is pulled from Adobe Stock. Hopefully this can be donated, or we > can pull from the community to get an image we want to use. Was thinking > "greenfield" and not overly distracting. > * I was looking for something punchy for the title text. "Effortlessly build > resource-driven web-applications." is what I came up with. > * About text has been un-touched. > * Easy build instructions are right on the homepage. Docker first, with Java > just a tab click away. This follows Docker now being the priority on the > getting started page. > * News, Get Involved, and Additional Resource should be mostly > self-explanatory. > * The navigation is designed around the common areas of the current left hand > rail, but with tutorials being broken out. This is a result of the many devs > I've on-boarded that prefer walk-throughs over raw docs. > Overall the idea is to give a single page of the main topics, but kick out to > the pages already established. > Let me know your thoughts. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SLING-7619) Redirect Servlet - consolidate configuration
[ https://issues.apache.org/jira/browse/SLING-7619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey closed SLING-7619. - > Redirect Servlet - consolidate configuration > > > Key: SLING-7619 > URL: https://issues.apache.org/jira/browse/SLING-7619 > Project: Sling > Issue Type: Improvement > Components: Servlets >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: Servlets Get 2.1.32 > > > Currently the Redirect Servlet handles a GET for a node with a > sling:resourceType of sling:redirect and a .json extension like generic GET > request however it does it separately from the the DefaultGetServlets > implementation. This then requires a separate configuration for the > JSONRendererServlet. > This modifies the RedirectServlet so that a request it receives with the > .json extension is handed off to the DefaultGetServlet for completion. This > centralizes the configuration for the json renderer. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SLING-7670) Default JSON Get Servlet provide ISO-8601 formatted date
[ https://issues.apache.org/jira/browse/SLING-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey closed SLING-7670. - > Default JSON Get Servlet provide ISO-8601 formatted date > > > Key: SLING-7670 > URL: https://issues.apache.org/jira/browse/SLING-7670 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: Servlets Get 2.1.32 > > > Default JSON Get Servlet was providing an ECMA formatted date string by > default. Changed to ISO-8601 formatted date and added configurations to > enable the older format if desired. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SLING-7625) Refactor Default Get Servlets
[ https://issues.apache.org/jira/browse/SLING-7625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey closed SLING-7625. - > Refactor Default Get Servlets > -- > > Key: SLING-7625 > URL: https://issues.apache.org/jira/browse/SLING-7625 > Project: Sling > Issue Type: Improvement > Components: Servlets >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: Servlets Get 2.1.32 > > Time Spent: 1h > Remaining Estimate: 0h > > This started off with an attempt to update the Date rendering and got > sidetracked. The majority of changes here are clean up and with all the > classes being under an .impl folder there should be no external impact. > Remove all uses of deprecated API's > Remove all methods that aren't being used > Re-organize GET servlets to be in one location > Rename objects to better represent their purpose > Reduce memory consumption by removing unnecessary Object creation > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SLING-7656) Unit test improvements for Sling Default GET Servlet
[ https://issues.apache.org/jira/browse/SLING-7656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey closed SLING-7656. - > Unit test improvements for Sling Default GET Servlet > > > Key: SLING-7656 > URL: https://issues.apache.org/jira/browse/SLING-7656 > Project: Sling > Issue Type: Improvement > Components: Servlets >Affects Versions: Servlets Get 2.1.30 >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: Servlets Get 2.1.32 > > > Unit test cases need to be improved to cover content as well, since the > content is being generated with the default GET servlet renderers -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7593) ResourceTraversor doesn't support ResourceDecorator pattern
[ https://issues.apache.org/jira/browse/SLING-7593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16484016#comment-16484016 ] Jason E Bailey commented on SLING-7593: --- [~joannajasnowska] processes are sometimes slow. Technically the release date was yesterday, but I'm waiting to have the release pushed to our download site before I can update all of the pages. > ResourceTraversor doesn't support ResourceDecorator pattern > --- > > Key: SLING-7593 > URL: https://issues.apache.org/jira/browse/SLING-7593 > Project: Sling > Issue Type: Bug > Components: API, Servlets >Reporter: Joanna Jasnowska >Assignee: Carsten Ziegeler >Priority: Blocker > Fix For: API 2.18.2, Servlets Get 2.1.32 > > Attachments: > calling_deprecated_ResourceUtil_listChildren(resource)_replaced_with_resource_listChildren.patch, > listChildren_method_fixed.patch > > > In my current project, we are using ResourceDecorator pattern. In one case we > would like to decorate a resource with additional children. Unfortunately > ResourceTraversor object doesn't accept information about children from > ResourceDecorator. It is caused by usage of > ResourceUtil.listChildren(resource) method (inside ResourceTraversor class) > which is deprecated. Under the hood the method invokes > resource.getResourceResolver.listChildren(resource) method which reads data > directly from repo. In result our additional children are not returned. > Moreover, we don't have a place to add them to the list returned from > resourceResolver.listChildren method. > When we change the approach and we invoke resource.listChildren() method > instead of ResourceUtil.listChildren(resource) then we get solution which is > compatible with ResourceDecorator pattern and on the other hand when > resources are not decorated then no changes should be observed. > Additionally I have one additional question about > org.apache.sling.servlets.get bundle imported packages. Why do we have the > following dependency org.apache.sling.api.resource.external;version="[1.0,2)" > in the latest released version? On the other hand the same bundle has > dependency on org.apache.sling.api.resource; version="[2.10,3)". Is it > expected? If yes then how to provide > org.apache.sling.api.resource.external;version="[1.0,2)" on my environment, > because now I don't have it. > In the attachment section, you could find patch containing fix for the > described scenario. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7656) Unit test improvements for Sling Default GET Servlet
[ https://issues.apache.org/jira/browse/SLING-7656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480654#comment-16480654 ] Jason E Bailey commented on SLING-7656: --- That's fair, I haven't paid much attention to the white space. I will get that changed and committed for a follow up release > Unit test improvements for Sling Default GET Servlet > > > Key: SLING-7656 > URL: https://issues.apache.org/jira/browse/SLING-7656 > Project: Sling > Issue Type: Improvement > Components: Servlets >Affects Versions: Servlets Get 2.1.30 >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: Servlets Get 2.1.32 > > > Unit test cases need to be improved to cover content as well, since the > content is being generated with the default GET servlet renderers -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-7619) Redirect Servlet - consolidate configuration
[ https://issues.apache.org/jira/browse/SLING-7619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey resolved SLING-7619. --- Resolution: Fixed > Redirect Servlet - consolidate configuration > > > Key: SLING-7619 > URL: https://issues.apache.org/jira/browse/SLING-7619 > Project: Sling > Issue Type: Improvement > Components: Servlets >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: Servlets Get 2.1.32 > > > Currently the Redirect Servlet handles a GET for a node with a > sling:resourceType of sling:redirect and a .json extension like generic GET > request however it does it separately from the the DefaultGetServlets > implementation. This then requires a separate configuration for the > JSONRendererServlet. > This modifies the RedirectServlet so that a request it receives with the > .json extension is handed off to the DefaultGetServlet for completion. This > centralizes the configuration for the json renderer. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-7625) Refactor Default Get Servlets
[ https://issues.apache.org/jira/browse/SLING-7625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey resolved SLING-7625. --- Resolution: Fixed > Refactor Default Get Servlets > -- > > Key: SLING-7625 > URL: https://issues.apache.org/jira/browse/SLING-7625 > Project: Sling > Issue Type: Improvement > Components: Servlets >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: Servlets Get 2.1.32 > > Time Spent: 1h > Remaining Estimate: 0h > > This started off with an attempt to update the Date rendering and got > sidetracked. The majority of changes here are clean up and with all the > classes being under an .impl folder there should be no external impact. > Remove all uses of deprecated API's > Remove all methods that aren't being used > Re-organize GET servlets to be in one location > Rename objects to better represent their purpose > Reduce memory consumption by removing unnecessary Object creation > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-7656) Unit test improvements for Sling Default GET Servlet
[ https://issues.apache.org/jira/browse/SLING-7656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey resolved SLING-7656. --- Resolution: Fixed > Unit test improvements for Sling Default GET Servlet > > > Key: SLING-7656 > URL: https://issues.apache.org/jira/browse/SLING-7656 > Project: Sling > Issue Type: Improvement > Components: Servlets >Affects Versions: Servlets Get 2.1.30 >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: Servlets Get 2.1.32 > > > Unit test cases need to be improved to cover content as well, since the > content is being generated with the default GET servlet renderers -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-7656) Unit test improvements for Sling Default GET Servlet
[ https://issues.apache.org/jira/browse/SLING-7656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-7656: -- Fix Version/s: Servlets Get 2.1.32 > Unit test improvements for Sling Default GET Servlet > > > Key: SLING-7656 > URL: https://issues.apache.org/jira/browse/SLING-7656 > Project: Sling > Issue Type: Improvement > Components: Servlets >Affects Versions: Servlets Get 2.1.30 >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: Servlets Get 2.1.32 > > > Unit test cases need to be improved to cover content as well, since the > content is being generated with the default GET servlet renderers -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-7670) Default JSON Get Servlet provide ISO-8601 formatted date
[ https://issues.apache.org/jira/browse/SLING-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey resolved SLING-7670. --- Resolution: Fixed > Default JSON Get Servlet provide ISO-8601 formatted date > > > Key: SLING-7670 > URL: https://issues.apache.org/jira/browse/SLING-7670 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: Servlets Get 2.1.32 > > > Default JSON Get Servlet was providing an ECMA formatted date string by > default. Changed to ISO-8601 formatted date and added configurations to > enable the older format if desired. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-7670) Default JSON Get Servlet provide ISO-8601 formatted date
Jason E Bailey created SLING-7670: - Summary: Default JSON Get Servlet provide ISO-8601 formatted date Key: SLING-7670 URL: https://issues.apache.org/jira/browse/SLING-7670 Project: Sling Issue Type: Improvement Reporter: Jason E Bailey Assignee: Jason E Bailey -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-7670) Default JSON Get Servlet provide ISO-8601 formatted date
[ https://issues.apache.org/jira/browse/SLING-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-7670: -- Fix Version/s: Servlets Get 2.1.32 > Default JSON Get Servlet provide ISO-8601 formatted date > > > Key: SLING-7670 > URL: https://issues.apache.org/jira/browse/SLING-7670 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: Servlets Get 2.1.32 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-7670) Default JSON Get Servlet provide ISO-8601 formatted date
[ https://issues.apache.org/jira/browse/SLING-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-7670: -- Description: Default JSON Get Servlet was providing an ECMA formatted date string by default. Changed to ISO-8601 formatted date and added configurations to enable the older format if desired. > Default JSON Get Servlet provide ISO-8601 formatted date > > > Key: SLING-7670 > URL: https://issues.apache.org/jira/browse/SLING-7670 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: Servlets Get 2.1.32 > > > Default JSON Get Servlet was providing an ECMA formatted date string by > default. Changed to ISO-8601 formatted date and added configurations to > enable the older format if desired. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-7699) Add ability to stream a Resource tree to API
Jason E Bailey created SLING-7699: - Summary: Add ability to stream a Resource tree to API Key: SLING-7699 URL: https://issues.apache.org/jira/browse/SLING-7699 Project: Sling Issue Type: Improvement Components: API Reporter: Jason E Bailey Assignee: Jason E Bailey Fix For: API 2.18.2 Add an ability to stream a Resource tree starting from a specific resource -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7695) Introduce Readable Names for SDI Configuration Entries in OSGi
[ https://issues.apache.org/jira/browse/SLING-7695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495552#comment-16495552 ] Jason E Bailey commented on SLING-7695: --- (y) I'm a fan. > Introduce Readable Names for SDI Configuration Entries in OSGi > -- > > Key: SLING-7695 > URL: https://issues.apache.org/jira/browse/SLING-7695 > Project: Sling > Issue Type: Improvement >Affects Versions: Dynamic Include 3.1.0 >Reporter: Tomasz Niedźwiedź >Priority: Minor > Attachments: sdi_cryptic_config.png, sdi_readable_config.png > > > Hello, > I've found that managing multiple configuration entries is a bit difficult > due to how they're presented in the OSGi console. > !sdi_cryptic_config.png! > I think it would be easier to find a specific config if the include type, > resource type and path were displayed for each entry. Here's how it could > look: > !sdi_readable_config.png! > This appears to be a relatively straightforward change so I've already given > it a shot. Here's a pull request > [https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/4] > Please let me know what you think about the idea. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-3619) Content Loader should handle input errors gracefully
[ https://issues.apache.org/jira/browse/SLING-3619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-3619: -- Fix Version/s: (was: JCR ContentLoader 2.2.6) JCR ContentLoader 2.2.8 > Content Loader should handle input errors gracefully > > > Key: SLING-3619 > URL: https://issues.apache.org/jira/browse/SLING-3619 > Project: Sling > Issue Type: Improvement > Components: JCR >Affects Versions: JCR ContentLoader 2.1.8 >Reporter: Yogesh Upadhyay >Assignee: Oliver Lietz >Priority: Minor > Fix For: JCR ContentLoader 2.2.8 > > > After upgrading to latest sling jar file, content loader stopped working to > load content using Sling-Initial-Content. Getting following message in log > 29.05.2014 23:20:21.504 *INFO* [Background Install > /var/folders/mh/tkx6mmq53tb_bcph_cfp7wzmgn/T/install277506169886207.tmp] > org.apache.sling.jcr.contentloader.internal.DefaultContentCreator > createFile: Cannot find content type for body.jsp, using > application/octet-stream -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-3533) improve error handling and logging in content loader
[ https://issues.apache.org/jira/browse/SLING-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-3533: -- Fix Version/s: (was: JCR ContentLoader 2.2.6) JCR ContentLoader 2.2.8 > improve error handling and logging in content loader > > > Key: SLING-3533 > URL: https://issues.apache.org/jira/browse/SLING-3533 > Project: Sling > Issue Type: Improvement > Components: JCR >Affects Versions: JCR ContentLoader 2.1.6 >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: JCR ContentLoader 2.2.8 > > > handle errors more appropriate and use proper log levels -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-3535) reduce duplicated code in content loader
[
https://issues.apache.org/jira/browse/SLING-3535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason E Bailey updated SLING-3535:
--
Fix Version/s: (was: JCR ContentLoader 2.2.6)
JCR ContentLoader 2.2.8
> reduce duplicated code in content loader
>
>
> Key: SLING-3535
> URL: https://issues.apache.org/jira/browse/SLING-3535
> Project: Sling
> Issue Type: Improvement
> Components: JCR
>Affects Versions: JCR ContentLoader 2.1.6
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: JCR ContentLoader 2.2.8
>
>
> e.g. {{DefaultContentImporter}} and {{Loader}} can share more code in
> {{BaseImportLoader}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (SLING-7699) Add ability to stream a Resource tree to the API bundle
[ https://issues.apache.org/jira/browse/SLING-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-7699: -- Summary: Add ability to stream a Resource tree to the API bundle (was: Add ability to stream a Resource tree to API) > Add ability to stream a Resource tree to the API bundle > > > Key: SLING-7699 > URL: https://issues.apache.org/jira/browse/SLING-7699 > Project: Sling > Issue Type: Improvement > Components: API >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: API 3.0.0 > > Time Spent: 2h 40m > Remaining Estimate: 0h > > Add an ability to stream a Resource tree starting from a specific resource -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-7510) UriProvider throws unchecked IllegalArgumentException that must be handled by consumers
[
https://issues.apache.org/jira/browse/SLING-7510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason E Bailey updated SLING-7510:
--
Fix Version/s: (was: API 3.0.0)
API 3.0.1
> UriProvider throws unchecked IllegalArgumentException that must be handled by
> consumers
> ---
>
> Key: SLING-7510
> URL: https://issues.apache.org/jira/browse/SLING-7510
> Project: Sling
> Issue Type: Improvement
> Components: API
>Affects Versions: API 2.16.4
>Reporter: Alexander Klimetschek
>Priority: Major
> Fix For: API 3.0.1
>
>
> h3. Status quo
> A consumer of the
> [UriProvider|https://github.com/apache/sling-org-apache-sling-api/blob/dfc41640031bc87ec271c648b22073e65f4f171a/src/main/java/org/apache/sling/api/resource/external/URIProvider.java#L45]
> currently is required to handle an unchecked {{IllegalArgumentException}},
> which is thrown when the provider is not able to handle the binary. Note that
> it is not supposed to ever return null per the javadoc. The
> [JcrNodeResource|https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/0e2ebd0f1a5c7cb2044b2d754945eb0ee7641081/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrNodeResource.java#L233-L242]
> shows a typical consumer code (although it still does do a null check).
> For the use case of asking multiple providers and taking the first one that
> responds it's not an optimal pattern to rely on an unchecked exception for
> the expected failure case that one provider by design cannot handle a certain
> binary or request. Throwing an {{IllegalArgumentException}} if there is no
> problem with the argument passed from the client, but a limit or
> configuration setting of the provider, is misleading. Also, given there are
> multiple providers active, a client cannot know upfront which provider is the
> right one for a given binary and somehow prevent the "illegal argument" call
> in the first place.
> h3. Suggestion
> Often, {{null}} return values are used in such a case. The provider can log
> any possible useful information itself, on why it could not handle it, if
> needed. This would simplify the consumer code (no try/catch necessary) and
> remove unnecessary cost of exception handling for normal code paths.
> JcrNodeResource itself it uses a null return value to pass on the "could not
> retrieve anything" state to the upper layers.
> If the goal really is to use exceptions here, the API should add a
> {{@Nonnull}} annotation for the return value _and_ the expected failure
> exception should be a checked one such as a new {{UriProviderException}}.
> Then for any unexpected faults (e.g. network error), it's fine to allow
> providers to throw a unchecked runtime exception, and usually that's not
> something that is explicitly mentioned in javadoc, but would definitely not
> hurt.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (SLING-7760) Contextual Additional Response Headers
Jason E Bailey created SLING-7760: - Summary: Contextual Additional Response Headers Key: SLING-7760 URL: https://issues.apache.org/jira/browse/SLING-7760 Project: Sling Issue Type: Improvement Reporter: Jason E Bailey Currently, for us to set the global response headers we need to add these to the Sling Main Servlet. The problem with this is * Any changes to the Sling Main Servlet ends up with the service restarting. This has a negative overall effect to the environment * We run multiple domains out of a single instance. For a Content-Security-Header we end up putting in exemptions that should apply to one site for all sites. This is problematic from a security perspective Ideally we would be able to configure headers based on the domain that's being requested -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-7751) Commons Html - Underlying parser implementation uses system charset
[ https://issues.apache.org/jira/browse/SLING-7751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-7751: -- Priority: Minor (was: Major) Issue Type: Improvement (was: Bug) > Commons Html - Underlying parser implementation uses system charset > --- > > Key: SLING-7751 > URL: https://issues.apache.org/jira/browse/SLING-7751 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Minor > Fix For: Commons HTML 1.0.4 > > > While re-writing the underlying tagsoup library I discovered that, by > default, the internal InputStreamReader is created with the system default > charset. > This can be overridden with a custom AutoDetector. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7751) Commons Html - Underlying parser implementation uses system charset
[ https://issues.apache.org/jira/browse/SLING-7751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522389#comment-16522389 ] Jason E Bailey commented on SLING-7751: --- Issue only occurs if no char encoding is set on the InputSource this is done by the TagSoupHtmlParser. Adding unit test case as validation of implementation. > Commons Html - Underlying parser implementation uses system charset > --- > > Key: SLING-7751 > URL: https://issues.apache.org/jira/browse/SLING-7751 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Minor > Fix For: Commons HTML 1.0.4 > > > While re-writing the underlying tagsoup library I discovered that, by > default, the internal InputStreamReader is created with the system default > charset. > This can be overridden with a custom AutoDetector. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-7751) Commons Html - Underlying parser implementation uses system charset
[ https://issues.apache.org/jira/browse/SLING-7751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey resolved SLING-7751. --- Resolution: Fixed > Commons Html - Underlying parser implementation uses system charset > --- > > Key: SLING-7751 > URL: https://issues.apache.org/jira/browse/SLING-7751 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Minor > Fix For: Commons HTML 1.0.4 > > > While re-writing the underlying tagsoup library I discovered that, by > default, the internal InputStreamReader is created with the system default > charset. > This can be overridden with a custom AutoDetector. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (SLING-7751) Commons Html - Underlying parser implementation uses system charset
[ https://issues.apache.org/jira/browse/SLING-7751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522389#comment-16522389 ] Jason E Bailey edited comment on SLING-7751 at 6/25/18 2:57 PM: Issue only occurs if no char encoding is set on the InputSource. This is being done by the TagSoupHtmlParser. Adding unit test case as validation of implementation. was (Author: jebailey): Issue only occurs if no char encoding is set on the InputSource this is done by the TagSoupHtmlParser. Adding unit test case as validation of implementation. > Commons Html - Underlying parser implementation uses system charset > --- > > Key: SLING-7751 > URL: https://issues.apache.org/jira/browse/SLING-7751 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Minor > Fix For: Commons HTML 1.0.4 > > > While re-writing the underlying tagsoup library I discovered that, by > default, the internal InputStreamReader is created with the system default > charset. > This can be overridden with a custom AutoDetector. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7748) Value of Month from jcr:lastModified is INCORRECT when org.apache.sling.api.resource.Resource.getValueMap() is used
[
https://issues.apache.org/jira/browse/SLING-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16518356#comment-16518356
]
Jason E Bailey commented on SLING-7748:
---
Taking a look at the attachments, I noticed that second attachment, which
depicts the wrong date, has more information then the first image showing the
crx console. The second image is showing data from what looks like the metadata
node that's beneath the jcr:content node. Could you check the data on the
metadata node to see if the incorrect jcr:lastModified date is coming from
there?
> Value of Month from jcr:lastModified is INCORRECT when
> org.apache.sling.api.resource.Resource.getValueMap() is used
> ---
>
> Key: SLING-7748
> URL: https://issues.apache.org/jira/browse/SLING-7748
> Project: Sling
> Issue Type: Bug
> Components: API
>Affects Versions: API 2.16.2
>Reporter: Suren Konathala
>Priority: Major
> Attachments: Screen Shot 2018-06-19 at 4.09.38 PM.png, Screen Shot
> 2018-06-19 at 4.09.56 PM.png
>
>
> When using *org.apache.sling.api.resource.Resource* , the method *getValueMap
> (*
> [https://sling.apache.org/apidocs/sling9/org/apache/sling/api/resource/Resource.html#getValueMap--]
> ), returns a ValueMap of all the properties.
> We observed that the "*month*" in "*jcr:lastModified*" is off by 1 month.
> While Year, Day, Hour, Min, Seconds are all correct. Please see the
> attachments. And this is the same for all Nodes.
> The last date modified was
> "2018-*{color:#d04437}05{color}*-29T10:31:49.123-05:00" while the value from
> the above method returned as below:
> {color:#33}jcr:lastModified\"{\"year\":2018,*{color:#d04437}\"month\":4,\{color}*"dayOfMonth\":29,\"hourOfDay\":10,\"minute\":31,\"second\":49}{color}
> We did not test this on all nodes though.
>
> Sample code:
> {code:java}
> Resource jcrdataResource = resource.getChild("jcr:content");
> ValueMap jcrProperties = ResourceUtil.getValueMap(jcrdataResource);
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
