Re: Compatibility of Sling with Oak 1.2

2015-09-16 Thread Konrad Windszus
Unfortunately not as I need the fix for 
https://issues.apache.org/jira/browse/SLING-4974 
 (JCR Resource 2.5.6).
But the compatibility to Oak 1.2 was removed with 
https://issues.apache.org/jira/browse/SLING-4820 
 (JCR Resource 2.5.2)

Konrad

> On 16 Sep 2015, at 11:41, Bertrand Delacretaz  wrote:
> 
> Hi,
> 
> On Tue, Sep 15, 2015 at 11:35 AM, Konrad Windszus  wrote:
>> ...In the case of https://issues.apache.org/jira/browse/SLING-4820
>> there is no simple solution to support both Oak 1.2 and 1.3
> 
> I'm not sure what to suggest...would using older released versions of
> the affected Sling modules work for you?
> 
> -Bertrand



Re: Compatibility of Sling with Oak 1.2

2015-09-16 Thread Bertrand Delacretaz
Hi,

On Tue, Sep 15, 2015 at 11:35 AM, Konrad Windszus  wrote:
> ...In the case of https://issues.apache.org/jira/browse/SLING-4820
> there is no simple solution to support both Oak 1.2 and 1.3

I'm not sure what to suggest...would using older released versions of
the affected Sling modules work for you?

-Bertrand


Re: Compatibility of Sling with Oak 1.2

2015-09-16 Thread Bertrand Delacretaz
On Wed, Sep 16, 2015 at 11:44 AM, Konrad Windszus  wrote:
>> On 16 Sep 2015, at 11:41, Bertrand Delacretaz  wrote:
>> ...I'm not sure what to suggest...would using older released versions of
>> the affected Sling modules work for you?..

> Unfortunately not as I need the fix for 
> https://issues.apache.org/jira/browse/SLING-4974 
>  (JCR Resource 2.5.6).
> But the compatibility to Oak 1.2 was removed with 
> https://issues.apache.org/jira/browse/SLING-4820 
>  (JCR Resource 2.5.2)...

So I guess the only way is to backport the changes that you need to an
older version of that bundle, and keep it compatible with Oak 1.2 ?

-Bertrand


Compatibility of Sling with Oak 1.2

2015-09-15 Thread Konrad Windszus
I just ran into the problem that the package version of 
org/apache/jackrabbit/oak/plugins/observation changed from 1.0 (in Oak prior 
1.3) to 2.0  (since Oak 1.3).
This is a major version change not compatible with any version ranges being 
generated by the maven-bundle-plugin.

Due to this fact the dependency to Oak Core was raised to 1.3 in the JCR 
Resource bundle (in https://issues.apache.org/jira/browse/SLING-4820 
).
This leads to the fact, that now the JCR Resource bundle is no longer 
compatible with older versions of Oak (at least the OakResourceListener isn’t)
Since Oak 1.2 is considered the stable release branch it would be beneficial if 
Sling could support this version.

What is the policy of supporting Oak 1.2 in Sling?
Thanks for your input,
Konrad



Re: Compatibility of Sling with Oak 1.2

2015-09-15 Thread Bertrand Delacretaz
Hi,

On Tue, Sep 15, 2015 at 9:26 AM, Konrad Windszus  wrote:
> ...What is the policy of supporting Oak 1.2 in Sling?...

I don't think we have a defined policy so far - in general I like our
tests to run against the latest Oak to stay on top of things, but
you're right that it makes sense to also support the latest stable
version.

Do you know what changes are needed for that?

-Bertrand


Re: Compatibility of Sling with Oak 1.2

2015-09-15 Thread Konrad Windszus
In the case of https://issues.apache.org/jira/browse/SLING-4820 
 there is no simple solution 
to support both Oak 1.2 and 1.3.
Since Oak incremented the major version of the package (although at first 
glance the used interfaces from 
https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/observation/NodeObserver.java
 

 look like they haven’t been changed), the only solution would be to increase 
the version range of the Import-Package statement within the JCR Resource 
bundle manually to cover both 1.0 and 2.0. But this looks really like a hack 
and is IMHO too dangerous, as it may lead to not-running bundles although all 
dependencies could be resolved.
This is exactly what we want to prevent with semantic versioning.
Konrad

> On 15 Sep 2015, at 11:22, Bertrand Delacretaz  wrote:
> 
> Hi,
> 
> On Tue, Sep 15, 2015 at 9:26 AM, Konrad Windszus  wrote:
>> ...What is the policy of supporting Oak 1.2 in Sling?...
> 
> I don't think we have a defined policy so far - in general I like our
> tests to run against the latest Oak to stay on top of things, but
> you're right that it makes sense to also support the latest stable
> version.
> 
> Do you know what changes are needed for that?
> 
> -Bertrand