Re: Sightly Integration Test execution fails for me
It's cool that you figured out the culprit so fast. On Thu, Feb 19, 2015 at 11:53 PM, Konrad Windszus konra...@gmx.de wrote: Hi Radu, I use UTF-8 as default encoding as well. The issue only occurs when using it with JDK 1.7.0_55. Using JDK 1.7.0_60 or later solves the issue. So it is probably related to one issue being fixed in 1.7.0_60: http://www.oracle.com/technetwork/java/javase/2col/7u60-bugfixes-2202029.html http://www.oracle.com/technetwork/java/javase/2col/7u60-bugfixes-2202029.html Konrad On 20 Feb 2015, at 02:33, Radu Cotescu r...@cotescu.com wrote: Hi Konrad, The code does indeed rely on the default platform encoding. However, on my Mac, the default encoding is UTF-8. mvn -version Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1; 2014-12-14T09:29:23-08:00) Maven home: /usr/local/Cellar/maven/3.2.5/libexec Java version: 1.7.0_67, vendor: Oracle Corporation Java home: /Library/Java/JavaVirtualMachines/jdk1.7.0_67.jdk/Contents/Home/jre Default locale: en_US, platform encoding: UTF-8 OS name: mac os x, version: 10.10.2, arch: x86_64, family: mac Is the encoding different on your box? Regards, Radu On Thu, Feb 19, 2015 at 4:13 AM, Konrad Windszus konra...@gmx.de wrote: I just tried to execute the Sightly Integration Tests and I get the following error: ... Tests run: 336, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.994 sec FAILURE! - in io.sightly.tck.TestsRunner String Expressions: String quotes and escaping - #unicode_escape(io.sightly.tck.tests.TestBuilder$1) Time elapsed: 0.007 sec FAILURE! junit.framework.AssertionFailedError: Expected value 'This 'Atilde;' is a string with unicode escaping' for selector '#unicode_escape'. Instead we got 'This '??' is a string with unicode escaping'. Please check the expected markup from /testfiles/output/exprlang/strings.html. at junit.framework.Assert.fail(Assert.java:47) at junit.framework.Assert.assertTrue(Assert.java:20) at io.sightly.tck.tests.TestBuilder$1.runTest(TestBuilder.java:146) Results : Failed tests: TestBuilder$1.runTest:146 Expected value 'This 'Atilde;' is a string with unicode escaping' for selector '#unicode_escape'. Instead we got 'This '??' is a string with unicode escaping'. Please check the expected markup from /testfiles/output/exprlang/strings.html. Tests run: 340, Failures: 1, Errors: 0, Skipped: 0 ... This happens with the most recent trunk and I just recompiled the XSS module on my own before that. I am using JDK 1.7.0_55 on a Mac. Any ideas what might be wrong? Is the code relying on the default encoding maybe? Thanks, Konrad
Sightly Integration Test execution fails for me
I just tried to execute the Sightly Integration Tests and I get the following error: ... Tests run: 336, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.994 sec FAILURE! - in io.sightly.tck.TestsRunner String Expressions: String quotes and escaping - #unicode_escape(io.sightly.tck.tests.TestBuilder$1) Time elapsed: 0.007 sec FAILURE! junit.framework.AssertionFailedError: Expected value 'This 'Atilde;' is a string with unicode escaping' for selector '#unicode_escape'. Instead we got 'This '??' is a string with unicode escaping'. Please check the expected markup from /testfiles/output/exprlang/strings.html. at junit.framework.Assert.fail(Assert.java:47) at junit.framework.Assert.assertTrue(Assert.java:20) at io.sightly.tck.tests.TestBuilder$1.runTest(TestBuilder.java:146) Results : Failed tests: TestBuilder$1.runTest:146 Expected value 'This 'Atilde;' is a string with unicode escaping' for selector '#unicode_escape'. Instead we got 'This '??' is a string with unicode escaping'. Please check the expected markup from /testfiles/output/exprlang/strings.html. Tests run: 340, Failures: 1, Errors: 0, Skipped: 0 ... This happens with the most recent trunk and I just recompiled the XSS module on my own before that. I am using JDK 1.7.0_55 on a Mac. Any ideas what might be wrong? Is the code relying on the default encoding maybe? Thanks, Konrad
Re: Sightly Integration Test execution fails for me
Hi Radu, I use UTF-8 as default encoding as well. The issue only occurs when using it with JDK 1.7.0_55. Using JDK 1.7.0_60 or later solves the issue. So it is probably related to one issue being fixed in 1.7.0_60: http://www.oracle.com/technetwork/java/javase/2col/7u60-bugfixes-2202029.html http://www.oracle.com/technetwork/java/javase/2col/7u60-bugfixes-2202029.html Konrad On 20 Feb 2015, at 02:33, Radu Cotescu r...@cotescu.com wrote: Hi Konrad, The code does indeed rely on the default platform encoding. However, on my Mac, the default encoding is UTF-8. mvn -version Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1; 2014-12-14T09:29:23-08:00) Maven home: /usr/local/Cellar/maven/3.2.5/libexec Java version: 1.7.0_67, vendor: Oracle Corporation Java home: /Library/Java/JavaVirtualMachines/jdk1.7.0_67.jdk/Contents/Home/jre Default locale: en_US, platform encoding: UTF-8 OS name: mac os x, version: 10.10.2, arch: x86_64, family: mac Is the encoding different on your box? Regards, Radu On Thu, Feb 19, 2015 at 4:13 AM, Konrad Windszus konra...@gmx.de wrote: I just tried to execute the Sightly Integration Tests and I get the following error: ... Tests run: 336, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.994 sec FAILURE! - in io.sightly.tck.TestsRunner String Expressions: String quotes and escaping - #unicode_escape(io.sightly.tck.tests.TestBuilder$1) Time elapsed: 0.007 sec FAILURE! junit.framework.AssertionFailedError: Expected value 'This 'Atilde;' is a string with unicode escaping' for selector '#unicode_escape'. Instead we got 'This '??' is a string with unicode escaping'. Please check the expected markup from /testfiles/output/exprlang/strings.html. at junit.framework.Assert.fail(Assert.java:47) at junit.framework.Assert.assertTrue(Assert.java:20) at io.sightly.tck.tests.TestBuilder$1.runTest(TestBuilder.java:146) Results : Failed tests: TestBuilder$1.runTest:146 Expected value 'This 'Atilde;' is a string with unicode escaping' for selector '#unicode_escape'. Instead we got 'This '??' is a string with unicode escaping'. Please check the expected markup from /testfiles/output/exprlang/strings.html. Tests run: 340, Failures: 1, Errors: 0, Skipped: 0 ... This happens with the most recent trunk and I just recompiled the XSS module on my own before that. I am using JDK 1.7.0_55 on a Mac. Any ideas what might be wrong? Is the code relying on the default encoding maybe? Thanks, Konrad
Re: Sightly Integration Test execution fails for me
Hi Konrad, The code does indeed rely on the default platform encoding. However, on my Mac, the default encoding is UTF-8. mvn -version Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1; 2014-12-14T09:29:23-08:00) Maven home: /usr/local/Cellar/maven/3.2.5/libexec Java version: 1.7.0_67, vendor: Oracle Corporation Java home: /Library/Java/JavaVirtualMachines/jdk1.7.0_67.jdk/Contents/Home/jre Default locale: en_US, platform encoding: UTF-8 OS name: mac os x, version: 10.10.2, arch: x86_64, family: mac Is the encoding different on your box? Regards, Radu On Thu, Feb 19, 2015 at 4:13 AM, Konrad Windszus konra...@gmx.de wrote: I just tried to execute the Sightly Integration Tests and I get the following error: ... Tests run: 336, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.994 sec FAILURE! - in io.sightly.tck.TestsRunner String Expressions: String quotes and escaping - #unicode_escape(io.sightly.tck.tests.TestBuilder$1) Time elapsed: 0.007 sec FAILURE! junit.framework.AssertionFailedError: Expected value 'This 'Atilde;' is a string with unicode escaping' for selector '#unicode_escape'. Instead we got 'This '??' is a string with unicode escaping'. Please check the expected markup from /testfiles/output/exprlang/strings.html. at junit.framework.Assert.fail(Assert.java:47) at junit.framework.Assert.assertTrue(Assert.java:20) at io.sightly.tck.tests.TestBuilder$1.runTest(TestBuilder.java:146) Results : Failed tests: TestBuilder$1.runTest:146 Expected value 'This 'Atilde;' is a string with unicode escaping' for selector '#unicode_escape'. Instead we got 'This '??' is a string with unicode escaping'. Please check the expected markup from /testfiles/output/exprlang/strings.html. Tests run: 340, Failures: 1, Errors: 0, Skipped: 0 ... This happens with the most recent trunk and I just recompiled the XSS module on my own before that. I am using JDK 1.7.0_55 on a Mac. Any ideas what might be wrong? Is the code relying on the default encoding maybe? Thanks, Konrad
