Daniel Quinlan wrote:
Please try to use the more standard perl formatting:
Do you see anything wrong other than two of the lines being more than 80
characters? I'll check in an update to fix that as soon as I finish
running a make test on the change.
-- sidney
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Daniel Quinlan writes:
[EMAIL PROTECTED] writes:
[...]
sub service_unavailable_error {
my ($err) = @_;
my $resp = EX_UNAVAILABLE;
- print $client SPAMD/1.0 $resphash{$resp} Service Unavailable: $err\r\n;
+ syswrite( $client,
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Sidney Markowitz writes:
Daniel Quinlan wrote:
Please try to use the more standard perl formatting:
Do you see anything wrong other than two of the lines being more than 80
characters? I'll check in an update to fix that as soon as I finish
Justin Mason wrote:
Sidney -- I think it's the
foo( bar )
vs.
foo(bar)
I prefer that too. I copied the style that was already in the code, and
I looked for something about that in the style guide and did not see any
mention of it one way or the other. Unless it is there and I missed it,
Sidney Markowitz [EMAIL PROTECTED] writes:
I prefer that too. I copied the style that was already in the code, and
I looked for something about that in the style guide and did not see any
mention of it one way or the other. Unless it is there and I missed it,
you or Daniel should add
Daniel Quinlan wrote:
* No space between function name and its opening paren
thesis.
I did see that. That would allow foo( bar ) which is what I did. If you
want foo(bar) as a preferred style it would have to be added to the wiki
page.
-- sidney
Sidney Markowitz [EMAIL PROTECTED] writes:
I did see that. That would allow foo( bar ) which is what I did. If you
want foo(bar) as a preferred style it would have to be added to the wiki
page.
I will do.
--
Daniel Quinlan
http://www.pathname.com/~quinlan/
