Re: svn commit: r644364 - in /stdcxx/trunk: src/locale_global.cpp tests/localization/22.locale.statics.mt.cpp

2008-04-03 Thread Martin Sebor
Travis Vitek wrote: -Original Message- From: Martin Sebor [mailto:[EMAIL PROTECTED] Sent: Thursday, April 03, 2008 8:55 AM To: dev@stdcxx.apache.org Subject: Re: svn commit: r644364 - in /stdcxx/trunk: src/locale_global.cpp tests/localization/22.locale.statics.mt.cpp [EMAIL

RE: svn commit: r644364 - in /stdcxx/trunk: src/locale_global.cpp tests/localization/22.locale.statics.mt.cpp

2008-04-03 Thread Eric Lemings
-Original Message- From: Martin Sebor [mailto:[EMAIL PROTECTED] Sent: Thursday, April 03, 2008 11:06 AM To: dev@stdcxx.apache.org Subject: Re: svn commit: r644364 - in /stdcxx/trunk: src/locale_global.cpp tests/localization/22.locale.statics.mt.cpp Travis Vitek wrote

RE: svn commit: r644364 - in /stdcxx/trunk: src/locale_global.cpp tests/localization/22.locale.statics.mt.cpp

2008-04-03 Thread Travis Vitek
Eric Lemings wrote: file src/setlocale.cpp: 83 // acquire global per-process lock 84 __rw_setlocale_mutex._C_acquire (); 85 86 // retrieve previous locale name and check if it is already set 87 const char* const curname = ::setlocale (cat, 0); The mutex doesn't need to

Re: svn commit: r644364 - in /stdcxx/trunk: src/locale_global.cpp tests/localization/22.locale.statics.mt.cpp

2008-04-03 Thread Martin Sebor
Travis Vitek wrote: Martin Sebor wrote: Travis Vitek wrote: Right. It seems that for this to be mt-safe with respect to other library code that calls setlocale(), we would need to lock the same lock that is used by _RW::__rw_setlocale. If don't use the same lock it would be possible for

RE: svn commit: r644364 - in /stdcxx/trunk: src/locale_global.cpp tests/localization/22.locale.statics.mt.cpp

2008-04-03 Thread Eric Lemings
-Original Message- From: Eric Lemings Sent: Thursday, April 03, 2008 11:12 AM To: 'dev@stdcxx.apache.org' Subject: RE: svn commit: r644364 - in /stdcxx/trunk: src/locale_global.cpp tests/localization/22.locale.statics.mt.cpp -Original Message- From: Martin

RE: svn commit: r644364 - in /stdcxx/trunk: src/locale_global.cpp tests/localization/22.locale.statics.mt.cpp

2008-04-03 Thread Travis Vitek
Eric Lemings wrote: Please peer review the following patch at your earliest convenience. Brad, I don't think that this patch is going to work. The unnecessary changes to the __rw_setlocale ctor and dtor will cause new failures. The __rw_setlocale type is supposed to hold the lock for its

RE: svn commit: r644364 - in /stdcxx/trunk: src/locale_global.cpp tests/localization/22.locale.statics.mt.cpp

2008-04-03 Thread Eric Lemings
-Original Message- From: Travis Vitek [mailto:[EMAIL PROTECTED] Sent: Thursday, April 03, 2008 1:05 PM To: dev@stdcxx.apache.org Subject: RE: svn commit: r644364 - in /stdcxx/trunk: src/locale_global.cpp tests/localization/22.locale.statics.mt.cpp Eric Lemings wrote

RE: svn commit: r644364 - in /stdcxx/trunk: src/locale_global.cpp tests/localization/22.locale.statics.mt.cpp

2008-04-03 Thread Eric Lemings
-Original Message- From: Martin Sebor [mailto:[EMAIL PROTECTED] Sent: Thursday, April 03, 2008 1:02 PM To: dev@stdcxx.apache.org Subject: Re: svn commit: r644364 - in /stdcxx/trunk: src/locale_global.cpp tests/localization/22.locale.statics.mt.cpp ... __rw_setlocale code