Re: Struts2 jQuery Plugin - Logo

2009-07-29 Thread Rainer Hermanns
Don, nope, that fault we did once before in webwork and early s2 releases :) The jQuery plugin should be/get one of the core plugins, not part of the struts2-core artifact. Rainer On Tue, Jul 28, 2009 at 9:29 PM, Rainer Hermannsherma...@aixcept.de wrote: I'm really happy, that Johannes

Re: ognl 2.7.3 performance

2009-07-29 Thread Rainer Hermanns
Musachy, thanks! I'll wait for the TextProvider problem to be fixed and then fire up the release process. I start a new gig next week, so this will most likely happen until/over the weekend. Rainer showcase seems fine. Rainer, whenever you can, get us an xwork release :) musachy On Thu,

Re: ognl 2.7.3 performance

2009-07-29 Thread Lukasz Lenart
2009/7/29 Rainer Hermanns herma...@aixcept.de: thanks! I'll wait for the TextProvider problem to be fixed and then fire up the release process. I start a new gig next week, so this will most likely happen until/over the weekend. I solved these problems and was able to confirm that with test,

Re: Struts2 jQuery Plugin - Logo

2009-07-29 Thread Rene Gielen
First and foremost, I totally agree that we should avoid to have a driven-by-excitement attitude on this topic, and develop a reasonable consensus and plan. See further comments inline Martin Cooper schrieb: I'm here, and I've been following along. I just haven't had time to consolidate my

Re: svn commit: r798892 - in /struts/struts2/trunk: bundles/demo/ plugins/javatemplates/ plugins/oval/

2009-07-29 Thread Antonio Petrelli
Just a suggestion, why don't you ignore all the .* resources? Antonio 2009/7/29 w...@apache.org: Author: wesw Date: Wed Jul 29 13:24:43 2009 New Revision: 798892 URL: http://svn.apache.org/viewvc?rev=798892view=rev Log: adding ignores for target dir and IDE artifacts Modified:    

Re: svn commit: r798892 - in /struts/struts2/trunk: bundles/demo/ plugins/javatemplates/ plugins/oval/

2009-07-29 Thread Wes Wannemacher
Sorry, some keystrokes are becoming habit from my current job. .* is much more effective and I'll try to remember to use it next time. In this case, the problem was the target directories, the rest was just my fingers doing ad-libbing :) -Wes On Wed, Jul 29, 2009 at 9:26 AM, Antonio

Missing class

2009-07-29 Thread Lukasz Lenart
Hi, I build my custom Xwork distro and tried to use it with Struts 2.1.8-SNAPSHOT but I've got such exception from Convention plugin: java.lang.NoClassDefFoundError: org/objectweb/asm/xwork/ClassVisitor at

Re: Missing class

2009-07-29 Thread Musachy Barroso
did you update/build convention? On Wed, Jul 29, 2009 at 9:53 AM, Lukasz Lenartlukasz.len...@googlemail.com wrote: Hi, I build my custom Xwork distro and tried to use it with Struts 2.1.8-SNAPSHOT but I've got such exception from Convention plugin: java.lang.NoClassDefFoundError:

Re: Missing class

2009-07-29 Thread Lukasz Lenart
2009/7/29 Musachy Barroso musa...@gmail.com: did you update/build convention? Yes, I updated it but when tried to install two tests are falling: testActionPackages(org.apache.struts2.convention.PackageBasedActionConfigBuilderTest) Time elapsed: 0.078 sec ERROR!

Re: Missing class

2009-07-29 Thread Musachy Barroso
It works for me, one thing that is weird, it should be complaining about not finding the shadowed class, like org/objectweb/asm/xwork/ClassVisitor instead of the original class org/objectweb/asm/ClassVisitor. Check your xwork jars and see if the shadowed classes are there. On Wed, Jul 29, 2009 at

Re: Missing class

2009-07-29 Thread Lukasz Lenart
I found one think in struts2-core pom.xml - unpack goal use xwork-core-2.1.4 but the whole project depend on xwork-2.1.5-SNAPSHOT. Shouldn't it be in sync? Regards -- Lukasz http://www.lenart.org.pl/ http://dailylog.lenart.org.pl/

Re: Missing class

2009-07-29 Thread Rainer Hermanns
Yes, it should be in sync... Rainer I found one think in struts2-core pom.xml - unpack goal use xwork-core-2.1.4 but the whole project depend on xwork-2.1.5-SNAPSHOT. Shouldn't it be in sync? Regards -- Lukasz http://www.lenart.org.pl/ http://dailylog.lenart.org.pl/

Re: Missing class

2009-07-29 Thread Musachy Barroso
someone forgot to update that.../rolls_eyes :) musachy On Wed, Jul 29, 2009 at 11:05 AM, Rainer Hermannsherma...@aixcept.de wrote: Yes, it should be in sync... Rainer I found one think in struts2-core pom.xml - unpack goal use xwork-core-2.1.4 but the whole project depend on

Re: Missing class

2009-07-29 Thread Lukasz Lenart
2009/7/29 Rainer Hermanns herma...@aixcept.de: Yes, it should be in sync... So I can make my first commit to Struts2 ;-) Should I prepare JIRA ticket for that? Regards -- Lukasz http://www.lenart.org.pl/ http://dailylog.lenart.org.pl/

Re: Missing class

2009-07-29 Thread Musachy Barroso
meh, not really. On Wed, Jul 29, 2009 at 11:10 AM, Lukasz Lenartlukasz.len...@googlemail.com wrote: 2009/7/29 Rainer Hermanns herma...@aixcept.de: Yes, it should be in sync... So I can make my first commit to Struts2 ;-) Should I prepare JIRA ticket for that? Regards -- Lukasz

Re: Missing class

2009-07-29 Thread Lukasz Lenart
2009/7/29 Musachy Barroso musa...@gmail.com: It works for me, one thing that is weird, it should be complaining about not finding the shadowed class, like org/objectweb/asm/xwork/ClassVisitor instead of the original class org/objectweb/asm/ClassVisitor. Check your xwork jars and see if the

Re: Missing class

2009-07-29 Thread Musachy Barroso
Not sure what is going on, it works for me, and if the classes are getting shadowed properly, they should be inside the xwork jar. On Wed, Jul 29, 2009 at 11:20 AM, Lukasz Lenartlukasz.len...@googlemail.com wrote: 2009/7/29 Musachy Barroso musa...@gmail.com: It works for me, one thing that is

Re: Missing class

2009-07-29 Thread Lukasz Lenart
2009/7/29 Musachy Barroso musa...@gmail.com: Not sure what is going on, it works for me, and if the classes are getting shadowed properly, they should be inside the xwork jar. I cleaned up my local Maven repo, rebuild and reinstall xwork and I checked the built jar - it's missing shaded asm but

Re: Missing class

2009-07-29 Thread Musachy Barroso
hum..interesting..let me try to delete asm from my repo and see if it doesn't shade the classes. musachy On Wed, Jul 29, 2009 at 11:34 AM, Lukasz Lenartlukasz.len...@googlemail.com wrote: 2009/7/29 Musachy Barroso musa...@gmail.com: Not sure what is going on, it works for me, and if the

Re: Class reloading

2009-07-29 Thread Dale Newfield
Musachy Barroso wrote: I added struts.class.reloading.acceptClasses, so now I can make the reloading class loader handle only action classes, so I don't get ClassCastException(s) I also added support for the relative paths, @Dale, take it for a spin and let me know how it works. I don't think

Re: about json plugin...again

2009-07-29 Thread Martin Cooper
On Tue, Jul 28, 2009 at 11:17 AM, Musachy Barroso musa...@gmail.com wrote: We have talked like 276 times about bringing the json plugin in, the reason we were not able to do it before was because one of the main contributors is not a struts committer and didn't have a CLA in file either. I

Re: Missing class

2009-07-29 Thread Lukasz Lenart
2009/7/29 Musachy Barroso musa...@gmail.com: hum..interesting..let me try to delete asm from my repo and see if it doesn't shade the classes. I think I found the reason - in parent pom, the asm was marked as a provided. When I removed that I was able to built package with shaded asm ;-)

Re: Class reloading

2009-07-29 Thread Musachy Barroso
I am, I am using it with convention and spring. if you touch the files, do you see any message about detecting a change? musachy On Wed, Jul 29, 2009 at 11:51 AM, Dale Newfieldd...@newfield.org wrote: Musachy Barroso wrote: I added struts.class.reloading.acceptClasses, so now I can make the

Re: about json plugin...again

2009-07-29 Thread Musachy Barroso
these are struts committers: jeromyevans jmitchtx jholmes612 w...@wantii.com (I wonder who this is? lol) musachy jjlindal: submitted his changes granting ASF the rights in jira: omikheev : I am pretty sure he has an iCLA in file, check please. these guys, I don't know if

Re: Missing class

2009-07-29 Thread Musachy Barroso
the problem is that it then becomes a transitive dependency. (even when market as optional) musachy On Wed, Jul 29, 2009 at 12:20 PM, Lukasz Lenartlukasz.len...@googlemail.com wrote: 2009/7/29 Musachy Barroso musa...@gmail.com: hum..interesting..let me try to delete asm from my repo and see if

Re: about json plugin...again

2009-07-29 Thread Musachy Barroso
There are no commits from the last three, so if there is a CLA in file for Oleg Mikheev, we are clear. musachy On Wed, Jul 29, 2009 at 12:34 PM, Musachy Barrosomusa...@gmail.com wrote: these are struts committers: jeromyevans jmitchtx jholmes612 w...@wantii.com (I wonder who this is? lol)

Re: Class reloading

2009-07-29 Thread Dale Newfield
Musachy Barroso wrote: I am, I am using it with convention and spring. Of course I meant anyone other than you -- I assumed you had it working, or you wouldn't have checked it in :-) if you touch the files, do you see any message about detecting a change? No. Should that

Re: Class reloading

2009-07-29 Thread Musachy Barroso
touche :). The FAM starts a thread that watches the dir, so it will callback ClassReloadingXMLWebApplicationContext.onFileChange as soon as a file is changed(set a breakpoint there and see if it is stopping, there is also a log statement there). Are you using relative or absolute paths for

Re: Class reloading

2009-07-29 Thread Dale Newfield
Musachy Barroso wrote: touche :). The FAM starts a thread that watches the dir, so it will callback ClassReloadingXMLWebApplicationContext.onFileChange as soon as a file is changed(set a breakpoint there and see if it is stopping, there is also a log statement there). I included a log message

Re: Class reloading

2009-07-29 Thread Musachy Barroso
Let me try with relative paths. musachy On Wed, Jul 29, 2009 at 1:02 PM, Dale Newfieldd...@newfield.org wrote: Musachy Barroso wrote: touche :). The FAM starts a thread that watches the dir, so it will callback ClassReloadingXMLWebApplicationContext.onFileChange as soon as a file is

Re: Class reloading

2009-07-29 Thread Musachy Barroso
It works for me (is that a trademark already?). My config is like: constant name=struts.class.reloading.watchList value=WEB-INF/classes/com/company / constant name=struts.class.reloading.acceptClasses value=com\.company\.sandbox\.actions.* / constant name=struts.convention.classes.reload

Re: about json plugin...again

2009-07-29 Thread Martin Cooper
On Wed, Jul 29, 2009 at 12:45 PM, Musachy Barroso musa...@gmail.com wrote: There are no commits from the last three, so if there is a CLA in file for Oleg Mikheev, we are clear. No iCLA on file for him, no. Could you (or someone) ask him to file one, please, assuming he's OK with that? TIA.

Re: about json plugin...again

2009-07-29 Thread Musachy Barroso
I sent him an email. musachy On Wed, Jul 29, 2009 at 1:47 PM, Martin Coopermart...@apache.org wrote: On Wed, Jul 29, 2009 at 12:45 PM, Musachy Barroso musa...@gmail.com wrote: There are no commits from the last three, so if there is a CLA in file for Oleg Mikheev, we are clear. No iCLA on