s:action tag major issues: threadlocals

2008-04-22 Thread Jeromy Evans
I'm investigating some of issues related to the s:action tag. This tag sets up a new context and ActionInvocation and invokes the action and result correctly. The problem is that within that process the DefaultActionInvocation replaces the ActionInvocation in the ThreadLocal ActionContext

Re: s:action tag major issues: threadlocals

2008-04-22 Thread Dave Newton
At first glance that seems like a *great* catch. --- Jeromy Evans [EMAIL PROTECTED] wrote: I'm investigating some of issues related to the s:action tag. This tag sets up a new context and ActionInvocation and invokes the action and result correctly. The problem is that within that process

Re: s:action tag major issues: threadlocals

2008-04-22 Thread Jeromy Evans
Dave Newton wrote: My naïve reaction would be to put it on a stack, since we're talking nested contexts, and set the thread local from it. But I can't even find that code right now :/ Dave Yeah, that seems a major change to xwork. By use of threadlocals it appears it was not intended to