Christian Stone wrote:
It isn't a problem if you use the filter bundled with Sitemesh.
However, it doesn't work if you use the plugin filters...
Does that include com.opensymphony.module.sitemesh.filter.PageFilter ?
I use .jsp decorators and use s: tags within them (by putting the
sitemesh
Yes it does (well, it did... my changes to the FreeMarkerPageFilter
use the newer SiteMeshFilter). They not only deprecated PageFilter,
but deleted the code within it.
You do not have access to everything in the decorators with
SiteMeshFilter that you do with FreeMarkerPageFilter. For
So some of the sitemesh 3 code is in the latest drop apparently, and
it is marked alpha. So I am doing 2 things...
1. Updating the existing filters code (FreeMarkerPageFilter and
VelocityPageFilter) to use the PageFilter.java implementation in
SiteMesh 2.3
(note that I presume that I can
Oh, a second issue, this one with struts.
I (temporarily) built xwork using the no tests option (mvn -
Dmaven.test.skip=true -Pextras,plugins,xwork). Then after the
artifacts were in place, I attempted to build struts... and have this
issue:
[INFO]
[ERROR] BUILD FAILURE
[INFO]
[INFO] Compilation failure
error: error reading
That did it. Still have build failures on the tests though (both xwork and struts 2).On a positive note... I was able to get the struts2-sitemesh pluging working with velocity and freemarker (using 2 filters, 1 for each).Is there a need for a combined filter, such as a velocity and freemarker
We can't take a jar, create a patch from your modified sources and
attach it to the jira issue related to upgrading sitemesh. One of us
will take a look at the failing test if you don't figure it out.
-Wes
On 10/21/09, Christian Stone xt...@stonescape.net wrote:
That did it. Still have build
I use struts 2.1.8 with freemarker 2.3.15 and sitemesh 2.4.2...I haven't
witnessed any problems, but besides the freemarker that struts uses to
expand tags I don't use freemarker in my project. Are there issues that
I've not noticed, or do those issues only arise when using freemarker
more
Here is a JIRA tag to catch several other bugs (including two marked
resolved when they were not). The patch file is included with the
ticket!
Please let me know how it goes. I have only minimally tested
velocity, but have tested the FreeMarker side extensively. I am
throwing the
I think this problem shows up when using Freemarker as the result of actions.
On Wed, Oct 21, 2009 at 9:00 AM, Dale Newfield d...@newfield.org wrote:
I use struts 2.1.8 with freemarker 2.3.15 and sitemesh 2.4.2...I haven't
witnessed any problems, but besides the freemarker that struts uses to
It isn't a problem if you use the filter bundled with Sitemesh.
However, it doesn't work if you use the plugin filters...
filter
filter-namesitemesh/filter-name
filter-
classorg.apache.struts2.sitemesh.FreeMarkerPageFilter/filter-class
/filter
You need to use
that was a quick turn around for a patch!
thanks
musachy
On Wed, Oct 21, 2009 at 11:48 AM, Christian Stone xt...@stonescape.net wrote:
It isn't a problem if you use the filter bundled with Sitemesh. However, it
doesn't work if you use the plugin filters...
filter
Welcome! By the way, I wrote the developer of Sitemesh 3, and will
see about getting a plugin available for the new codebase too.
By the way, I am testing a version of the plugin now with a bit more
detail in the error reporting (reports URL and query with failed
decorator). This is nice
Okay, I'll do it... will take perhaps a day (free time... you know).
-- Christian
On Oct 20, 2009, at 9:14 PM, Musachy Barroso wrote:
I don't think anyone here knows much about the sitemesh codebase, so
feel free to take a shot at it and ask for help here if you need it.
thanks for reporting
To help with both the patch creation and your sanity (matching up
xwork and struts versions), work off of trunk for both of them. Check
out xwork from subversion here -
svn co http://svn.opensymphony.com/svn/xwork/trunk xwork
and build it -
cd xwork ; mvn clean install
Then, checkout and build
15 matches
Mail list logo
