Re: svn commit: r980106 - in /tomcat/trunk: build.properties.default build.xml

2010-07-29 Thread Mark Thomas
On 29/07/2010 03:53, Bill Barker wrote: ma...@apache.org wrote in message news:20100728155830.a602f2388...@eris.apache.org... Author: markt Date: Wed Jul 28 15:58:30 2010 New Revision: 980106 URL: http://svn.apache.org/viewvc?rev=980106view=rev Log: Only download Checkstyle if it is

svn commit: r980347 - in /tomcat/trunk: java/org/apache/catalina/startup/WebRuleSet.java webapps/docs/changelog.xml

2010-07-29 Thread markt
Author: markt Date: Thu Jul 29 07:52:07 2010 New Revision: 980347 URL: http://svn.apache.org/viewvc?rev=980347view=rev Log: Fix copy/paste typo Modified: tomcat/trunk/java/org/apache/catalina/startup/WebRuleSet.java tomcat/trunk/webapps/docs/changelog.xml Modified:

svn commit: r980355 - in /tomcat/trunk/java/org/apache/catalina/ha/session: ReplicatedSession.java SimpleTcpReplicationManager.java mbeans-descriptors.xml

2010-07-29 Thread markt
Author: markt Date: Thu Jul 29 08:11:52 2010 New Revision: 980355 URL: http://svn.apache.org/viewvc?rev=980355view=rev Log: Remove unused SimpleTcpReplicationManager and associated ReplicatedSession Removed: tomcat/trunk/java/org/apache/catalina/ha/session/ReplicatedSession.java

Re: svn commit: r980355 - in /tomcat/trunk/java/org/apache/catalina/ha/session: ReplicatedSession.java SimpleTcpReplicationManager.java mbeans-descriptors.xml

2010-07-29 Thread Mark Thomas
On 29/07/2010 09:11, ma...@apache.org wrote: Author: markt Date: Thu Jul 29 08:11:52 2010 New Revision: 980355 URL: http://svn.apache.org/viewvc?rev=980355view=rev Log: Remove unused SimpleTcpReplicationManager and associated ReplicatedSession AFAICT there are a bunch of old classes that

DO NOT REPLY [Bug 49665] New: When file not found error occurs it does not tell you which file caused the error.

2010-07-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49665 Summary: When file not found error occurs it does not tell you which file caused the error. Product: Tomcat 6 Version: 6.0.29 Platform: PC OS/Version: All

DO NOT REPLY [Bug 49665] When file not found error occurs it does not tell you which file caused the error.

2010-07-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49665 --- Comment #1 from Ted Leung tedmanle...@gmail.com 2010-07-29 05:10:22 EDT --- The previously uploaded patch was made off of svn tc6.0.x 966937 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You

svn commit: r980378 - in /tomcat/trunk: java/org/apache/catalina/ha/ java/org/apache/catalina/ha/session/ java/org/apache/catalina/ha/tcp/ webapps/docs/config/

2010-07-29 Thread markt
Author: markt Date: Thu Jul 29 09:45:32 2010 New Revision: 980378 URL: http://svn.apache.org/viewvc?rev=980378view=rev Log: Remove deprecated defaultMode attribute Clarify current behaviour of maxActiveSessions Clean-up cluster-manager docs Modified:

svn commit: r980379 - /tomcat/tc6.0.x/trunk/webapps/docs/config/cluster-manager.xml

2010-07-29 Thread markt
Author: markt Date: Thu Jul 29 09:45:55 2010 New Revision: 980379 URL: http://svn.apache.org/viewvc?rev=980379view=rev Log: Clarify current behaviour of maxActiveSessions Clean-up cluster-manager docs Modified: tomcat/tc6.0.x/trunk/webapps/docs/config/cluster-manager.xml Modified:

DO NOT REPLY [Bug 49665] When file not found error occurs it does not tell you which file caused the error.

2010-07-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49665 Ted Leung tedmanle...@gmail.com changed: What|Removed |Added Attachment #25814|0 |1 is

svn commit: r980399 - in /tomcat/trunk/java/org/apache/catalina/session: StandardManager.java mbeans-descriptors.xml

2010-07-29 Thread markt
Author: markt Date: Thu Jul 29 11:03:32 2010 New Revision: 980399 URL: http://svn.apache.org/viewvc?rev=980399view=rev Log: Remove unused property Modified: tomcat/trunk/java/org/apache/catalina/session/StandardManager.java

svn commit: r980401 - in /tomcat/trunk/java/org/apache/catalina: Manager.java ha/session/DeltaManager.java ha/session/mbeans-descriptors.xml session/PersistentManagerBase.java session/StandardManager.

2010-07-29 Thread markt
Author: markt Date: Thu Jul 29 11:10:00 2010 New Revision: 980401 URL: http://svn.apache.org/viewvc?rev=980401view=rev Log: Rejected session count should not be writable Modified: tomcat/trunk/java/org/apache/catalina/Manager.java

svn commit: r980407 - /tomcat/trunk/java/org/apache/catalina/session/ManagerBase.java

2010-07-29 Thread markt
Author: markt Date: Thu Jul 29 11:24:45 2010 New Revision: 980407 URL: http://svn.apache.org/viewvc?rev=980407view=rev Log: Fix an Eclipse nag Modified: tomcat/trunk/java/org/apache/catalina/session/ManagerBase.java Modified: tomcat/trunk/java/org/apache/catalina/session/ManagerBase.java

svn commit: r980408 - /tomcat/trunk/java/org/apache/catalina/session/mbeans-descriptors.xml

2010-07-29 Thread markt
Author: markt Date: Thu Jul 29 11:26:02 2010 New Revision: 980408 URL: http://svn.apache.org/viewvc?rev=980408view=rev Log: Revert part of r980399 - attribute is present and used in ManagerBase so will be inherited Modified:

svn commit: r980411 - in /tomcat/trunk/java/org/apache/catalina: ha/session/ session/

2010-07-29 Thread markt
Author: markt Date: Thu Jul 29 11:49:47 2010 New Revision: 980411 URL: http://svn.apache.org/viewvc?rev=980411view=rev Log: Refactoring - reduce duplication Handle maxActiveSessions, rejectedSessions and processingTime in ManagerBase Modified:

svn commit: r980418 - in /tomcat/trunk/java/org/apache/catalina: ha/session/ session/

2010-07-29 Thread markt
Author: markt Date: Thu Jul 29 12:10:51 2010 New Revision: 980418 URL: http://svn.apache.org/viewvc?rev=980418view=rev Log: Refactoring Move propertyChange() implementation to ManagerBase to reduce code duplication Modified:

svn commit: r980421 - in /tomcat/trunk/java/org/apache/catalina/ha/session: BackupManager.java ClusterManagerBase.java DeltaManager.java

2010-07-29 Thread markt
Author: markt Date: Thu Jul 29 12:22:27 2010 New Revision: 980421 URL: http://svn.apache.org/viewvc?rev=980421view=rev Log: Refactoring Change BackupManager to extend ClusterManagerBase rather than StandardManager - The functionality being inherited from StandardManager (persistence over

svn commit: r980424 - in /tomcat/trunk/java/org/apache/catalina: ha/session/DeltaManager.java session/ManagerBase.java session/PersistentManagerBase.java session/StandardManager.java

2010-07-29 Thread markt
Author: markt Date: Thu Jul 29 12:28:40 2010 New Revision: 980424 URL: http://svn.apache.org/viewvc?rev=980424view=rev Log: Follow on to r980418 Need to move registration with context to ManagerBase too Modified: tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java

svn commit: r980425 - /tomcat/trunk/webapps/docs/changelog.xml

2010-07-29 Thread markt
Author: markt Date: Thu Jul 29 12:34:59 2010 New Revision: 980425 URL: http://svn.apache.org/viewvc?rev=980425view=rev Log: Update the changelog with a note on the session manager refactoring Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml

[PROPOSAL] Definition of active sessions

2010-07-29 Thread Mark Thomas
The current Manager implementations have slightly different definitions of 'active session' that I would like to make consistent in 7.0.x (and maybe backport to 6.0.x) Ignoring expired and invalidated sessions: - in the StandardManager, all sessions are primary and all are active - in the

Re: [PROPOSAL] Definition of active sessions

2010-07-29 Thread Rainer Jung
On 29.07.2010 15:02, Mark Thomas wrote: The current Manager implementations have slightly different definitions of 'active session' that I would like to make consistent in 7.0.x (and maybe backport to 6.0.x) Ignoring expired and invalidated sessions: - in the StandardManager, all sessions are

DO NOT REPLY [Bug 49667] New: JdbcLeakPrevention class can register unregistered JCBC Driver

2010-07-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49667 Summary: JdbcLeakPrevention class can register unregistered JCBC Driver Product: Tomcat 7 Version: 7.0.0 Platform: PC OS/Version: Solaris Status: NEW

Re: [PROPOSAL] Definition of active sessions

2010-07-29 Thread Yoav Shapira
On Thu, Jul 29, 2010 at 9:02 AM, Mark Thomas ma...@apache.org wrote: The current Manager implementations have slightly different definitions of 'active session' that I would like to make consistent in 7.0.x (and maybe backport to 6.0.x) snip / I intend to make the following changes unless

DO NOT REPLY [Bug 49668] New: Deeply nested references from ThreadLocal objects are not cleared

2010-07-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49668 Summary: Deeply nested references from ThreadLocal objects are not cleared Product: Tomcat 7 Version: 7.0.0 Platform: Sun OS/Version: Solaris Status: NEW

DO NOT REPLY [Bug 49667] JdbcLeakPrevention class can register unregistered JCBC Driver

2010-07-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49667 Arjen Knibbe arjencornelis.kni...@getronics.com changed: What|Removed |Added Platform|PC

DO NOT REPLY [Bug 49669] New: Static reference from javax.security.auth.Policy.contextClassLoader prevents an undeployed Web application from being garbage collected

2010-07-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49669 Summary: Static reference from javax.security.auth.Policy.contextClassLoader prevents an undeployed Web application from being garbage collected Product:

DO NOT REPLY [Bug 49670] New: org.apache.catalina.authenticator.SingleSignOn valve does not function

2010-07-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49670 Summary: org.apache.catalina.authenticator.SingleSignOn valve does not function Product: Tomcat 7 Version: 7.0.0 Platform: PC Status: NEW Severity:

Re: More sources of Tomcat memory leaks

2010-07-29 Thread Arjen Knibbe
markt-2 wrote: Please could you create a Bugzilla entry (against Tomact 7) for each issue you identified so that this valuable work doesn't get forgotten about? 95% of the work should just be a copy and paste. I created three Bugzilla entries: 49667 for the JdbcLeakPreventer issue.

Re: More sources of Tomcat memory leaks

2010-07-29 Thread Rainer Jung
On 29.07.2010 17:00, Arjen Knibbe wrote: I searched for an upgrading to Tomcat 7 manual in the Tomcat documentation to check if the new JreMemoryLeakPreventionListener is mentioned, but I could not find any guidelines for upgrading... There is some info about major version differences at

svn commit: r980476 - in /tomcat/site/trunk: docs/migration.html xdocs/migration.xml

2010-07-29 Thread markt
Author: markt Date: Thu Jul 29 15:39:56 2010 New Revision: 980476 URL: http://svn.apache.org/viewvc?rev=980476view=rev Log: Add note on dynamic thread pools Modified: tomcat/site/trunk/docs/migration.html tomcat/site/trunk/xdocs/migration.xml Modified:

svn commit: r980524 - /tomcat/native/trunk/native/include/tcn_version.h

2010-07-29 Thread mturk
Author: mturk Date: Thu Jul 29 17:59:32 2010 New Revision: 980524 URL: http://svn.apache.org/viewvc?rev=980524view=rev Log: Declare trunk as 1.2 instead 2.0 Modified: tomcat/native/trunk/native/include/tcn_version.h Modified: tomcat/native/trunk/native/include/tcn_version.h URL:

svn commit: r980527 - in /tomcat/native/trunk/native/src: ssl.c sslcontext.c sslnetwork.c

2010-07-29 Thread mturk
Author: mturk Date: Thu Jul 29 18:05:39 2010 New Revision: 980527 URL: http://svn.apache.org/viewvc?rev=980527view=rev Log: Sync SSL renegotiation from 1.1.x branch Modified: tomcat/native/trunk/native/src/ssl.c tomcat/native/trunk/native/src/sslcontext.c

svn commit: r980529 - /tomcat/native/trunk/native/src/jnilib.c

2010-07-29 Thread mturk
Author: mturk Date: Thu Jul 29 18:07:25 2010 New Revision: 980529 URL: http://svn.apache.org/viewvc?rev=980529view=rev Log: Require APR 1.4.0 as minimum version needed Modified: tomcat/native/trunk/native/src/jnilib.c Modified: tomcat/native/trunk/native/src/jnilib.c URL:

DO NOT REPLY [Bug 49668] Deeply nested references from ThreadLocal objects are not cleared

2010-07-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49668 sylvain.laur...@gmail.com changed: What|Removed |Added Severity|normal |enhancement ---

svn commit: r980532 - in /tomcat/trunk/webapps/manager/WEB-INF/jsp: sessionDetail.jsp sessionsList.jsp

2010-07-29 Thread markt
Author: markt Date: Thu Jul 29 18:17:15 2010 New Revision: 980532 URL: http://svn.apache.org/viewvc?rev=980532view=rev Log: Enable the HTML Manager application to differentiate between primary backup sessions. Both can be invalidated Attributes can be viewed in both Attributes can only be

svn commit: r980535 - in /tomcat/trunk: java/org/apache/catalina/session/ManagerBase.java java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java webapps/docs/changelog.xml

2010-07-29 Thread markt
Author: markt Date: Thu Jul 29 18:32:58 2010 New Revision: 980535 URL: http://svn.apache.org/viewvc?rev=980535view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49407 Make BackupManager and DeltaManager handle primary and backup sessions consistently Modified:

Re: svn commit: r980535 - in /tomcat/trunk: java/org/apache/catalina/session/ManagerBase.java java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java webapps/docs/changelog.xml

2010-07-29 Thread Mark Thomas
On 29/07/2010 19:32, ma...@apache.org wrote: Author: markt Date: Thu Jul 29 18:32:58 2010 New Revision: 980535 URL: http://svn.apache.org/viewvc?rev=980535view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49407 Make BackupManager and DeltaManager handle primary and

DO NOT REPLY [Bug 49672] New: Apache service fails to start when using windows service

2010-07-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49672 Summary: Apache service fails to start when using windows service Product: Tomcat 6 Version: 6.0.29 Platform: PC Status: NEW Severity: normal

DO NOT REPLY [Bug 49672] Apache service fails to start when using windows service

2010-07-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49672 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r980567 - in /tomcat/trunk: java/org/apache/catalina/ha/session/ java/org/apache/catalina/manager/ java/org/apache/catalina/manager/util/ webapps/docs/ webapps/manager/WEB-INF/ webapps/man

2010-07-29 Thread markt
Author: markt Date: Thu Jul 29 20:53:26 2010 New Revision: 980567 URL: http://svn.apache.org/viewvc?rev=980567view=rev Log: Add optional support to the HTML Manager application to display Proxy sessions. It is disabled by default. Added:

DO NOT REPLY [Bug 49407] backup manager reports too few current sessions

2010-07-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49407 --- Comment #1 from Mark Thomas ma...@apache.org 2010-07-29 16:56:34 EDT --- This has been fixed for Tomcat 7 and the HTML Manager application enhanced to differentiate between Primary, Backup and Proxy sessions. I suspect the changes are

Re: More sources of Tomcat memory leaks

2010-07-29 Thread Sylvain Laurent
IMHO, clearing threadlocals is a bad idea, it has even been disabled by default because of concurrency issues. Furthermore, the solution you propose would be limited to some type of classes (Map in your case). https://issues.apache.org/bugzilla/show_bug.cgi?id=49159 is still pending but the

DO NOT REPLY [Bug 49673] New: JNDI not working

2010-07-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49673 Summary: JNDI not working Product: Tomcat 6 Version: 6.0.29 Platform: All OS/Version: All Status: NEW Severity: regression Priority: P2 Component:

DO NOT REPLY [Bug 49132] JNDI not working

2010-07-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49132 Steve Mitchell mitch...@intertrust.com changed: What|Removed |Added Blocks||49673 --

DO NOT REPLY [Bug 49673] JNDI not working

2010-07-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49673 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

DO NOT REPLY [Bug 49665] When file not found error occurs it does not tell you which file caused the error.

2010-07-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49665 Ted Leung tedmanle...@gmail.com changed: What|Removed |Added Attachment #25815|0 |1 is

DO NOT REPLY [Bug 49674] New: libservice.a: Malformed archive in commons-daemon

2010-07-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49674 Summary: libservice.a: Malformed archive in commons-daemon Product: Tomcat 6 Version: 6.0.29 Platform: All OS/Version: Linux Status: NEW Severity: trivial

Re: [PROPOSAL] Definition of active sessions

2010-07-29 Thread Keiichi Fujino
I intend to make the following changes unless there are any objections: - modify BackupManager to treat backup sessions as active - list all known sessions in the manager application - mark sessions as primary, backup or proxy in the manager application user interface - only provide session

Re: svn commit: r980378 - in /tomcat/trunk: java/org/apache/catalina/ha/ java/org/apache/catalina/ha/session/ java/org/apache/catalina/ha/tcp/ webapps/docs/config/

2010-07-29 Thread Keiichi Fujino
Hi. SimpleTcpCluster#sendClusterDomain called when domainReplication is true is as follows now. ===SimpleTcpCluster#sendClusterDomain=== public void sendClusterDomain(ClusterMessage msg) { send(msg,null); } === === the msg is transmitted to all cluster members. domainReplication does not

Re: svn commit: r980378 - in /tomcat/trunk: java/org/apache/catalina/ha/ java/org/apache/catalina/ha/session/ java/org/apache/catalina/ha/tcp/ webapps/docs/config/

2010-07-29 Thread Keiichi Fujino
Sorry. This rev is just remove defaultMode and add maxActiveSessions. domainReplication was not related. I send another proposal mail. -- Keiichi.Fujino Fujino kfuj...@apache.org: Hi. SimpleTcpCluster#sendClusterDomain called when domainReplication is true is as follows now.

[PROPOSAL] remove domainReplication propety

2010-07-29 Thread Keiichi Fujino
Hi. SimpleTcpCluster#sendClusterDomain called when domainReplication is true is as follows now. ===SimpleTcpCluster#sendClusterDomain=== public void sendClusterDomain(ClusterMessage msg) { send(msg,null); } === === the msg is transmitted to all cluster members. domainReplication does not work