Re: APR, WebSocket and Servlet 3.1 NIO refactoring

2013-01-16 Thread Mark Thomas
On 16/01/2013 06:50, Mladen Turk wrote: On 01/15/2013 02:29 PM, Mark Thomas wrote: Hi, 3. Currently, we have no record of which Poller a socket is registered with. This makes 2) more expensive as we have to iterate through the Pollers to find the socket. Tracking the current poller used by a

[RESULT] [VOTE] Release Apache Tomcat 7.0.35

2013-01-16 Thread Mark Thomas
Votes were as follows: +1 (binding): kkolinko, rjung, yoavs, olamy, markt No other votes were cast. The vote therefore passes. I'll publish the binaries and announce later today once the mirrors have caught up. Mark - To

svn commit: r1248 - /dev/tomcat/tomcat-7/v7.0.35/ /release/tomcat/tomcat-7/v7.0.35/

2013-01-16 Thread markt
Author: markt Date: Wed Jan 16 09:42:49 2013 New Revision: 1248 Log: Release 7.0.35 Added: release/tomcat/tomcat-7/v7.0.35/ - copied from r1247, dev/tomcat/tomcat-7/v7.0.35/ Removed: dev/tomcat/tomcat-7/v7.0.35/

svn commit: r1248 - /dev/tomcat/tomcat-7/v7.0.35/ /release/tomcat/tomcat-7/v7.0.35/

2013-01-16 Thread markt
Author: markt Date: Wed Jan 16 09:42:49 2013 New Revision: 1248 Log: Release 7.0.35 Added: release/tomcat/tomcat-7/v7.0.35/ - copied from r1247, dev/tomcat/tomcat-7/v7.0.35/ Removed: dev/tomcat/tomcat-7/v7.0.35/

Re: APR, WebSocket and Servlet 3.1 NIO refactoring

2013-01-16 Thread Remy Maucherat
On Wed, 2013-01-16 at 07:50 +0100, Mladen Turk wrote: On 01/15/2013 02:29 PM, Mark Thomas wrote: Hi, 3. Currently, we have no record of which Poller a socket is registered with. This makes 2) more expensive as we have to iterate through the Pollers to find the socket. Tracking the

Re: APR, WebSocket and Servlet 3.1 NIO refactoring

2013-01-16 Thread Remy Maucherat
On Wed, 2013-01-16 at 09:35 +, Mark Thomas wrote: That would be really nice. What I'd need is this: int removeFromPollset(long socket) where the return value is either -ve for an error code or +ve for the current flags. Looking at the code, by the time I have finished the other

Re: APR, WebSocket and Servlet 3.1 NIO refactoring

2013-01-16 Thread Mark Thomas
On 16/01/2013 10:43, Remy Maucherat wrote: On Wed, 2013-01-16 at 09:35 +, Mark Thomas wrote: That would be really nice. What I'd need is this: int removeFromPollset(long socket) where the return value is either -ve for an error code or +ve for the current flags. Looking at the code,

Re: APR, WebSocket and Servlet 3.1 NIO refactoring

2013-01-16 Thread Remy Maucherat
On Wed, 2013-01-16 at 11:43 +, Mark Thomas wrote: Using multiple pollsets is only needed on some platforms (Windows ...), and it is possible it is not supposed to be mandatory now (Windows should be able to handle large pollsets now). So if you accept to drop support for running

Re: APR, WebSocket and Servlet 3.1 NIO refactoring

2013-01-16 Thread Mark Thomas
On 16/01/2013 12:05, Remy Maucherat wrote: On Wed, 2013-01-16 at 11:43 +, Mark Thomas wrote: Using multiple pollsets is only needed on some platforms (Windows ...), and it is possible it is not supposed to be mandatory now (Windows should be able to handle large pollsets now). So if you

svn commit: r1433908 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2013-01-16 Thread markt
Author: markt Date: Wed Jan 16 12:10:35 2013 New Revision: 1433908 URL: http://svn.apache.org/viewvc?rev=1433908view=rev Log: Trivial comment corrections Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Modified:

Re: APR, WebSocket and Servlet 3.1 NIO refactoring

2013-01-16 Thread Mladen Turk
On 01/16/2013 01:05 PM, Remy Maucherat wrote: On Wed, 2013-01-16 at 11:43 +, Mark Thomas wrote: It is not really a bug: only the newer Windows (Vista+) have efficient polling. With previous versions, small pollsets have to be used because (apparently) it can only poll over 64 sockets at a

Re: APR, WebSocket and Servlet 3.1 NIO refactoring

2013-01-16 Thread Remy Maucherat
On Wed, 2013-01-16 at 12:08 +, Mark Thomas wrote: It is not really a bug: only the newer Windows (Vista+) have efficient polling. With previous versions, small pollsets have to be used because (apparently) it can only poll over 64 sockets at a time. If the size is over 1000, there is a

Re: APR, WebSocket and Servlet 3.1 NIO refactoring

2013-01-16 Thread Mark Thomas
On 16/01/2013 13:19, Remy Maucherat wrote: On Wed, 2013-01-16 at 12:08 +, Mark Thomas wrote: It is not really a bug: only the newer Windows (Vista+) have efficient polling. With previous versions, small pollsets have to be used because (apparently) it can only poll over 64 sockets at a

svn commit: r1433928 - /tomcat/trunk/java/org/apache/tomcat/util/net/res/LocalStrings.properties

2013-01-16 Thread markt
Author: markt Date: Wed Jan 16 13:26:40 2013 New Revision: 1433928 URL: http://svn.apache.org/viewvc?rev=1433928view=rev Log: Re-order Modified: tomcat/trunk/java/org/apache/tomcat/util/net/res/LocalStrings.properties Modified:

Re: svn commit: r1433976 - in /tomcat/trunk/java/org/apache: coyote/ajp/AjpAprProtocol.java coyote/http11/Http11AprProtocol.java tomcat/util/net/AprEndpoint.java tomcat/util/net/res/LocalStrings.prope

2013-01-16 Thread Remy Maucherat
On Wed, 2013-01-16 at 15:14 +, ma...@apache.org wrote: This is untested (I don't have an OSX build of the native lib handy right now). I'll test later today. I'm not sure native on OS X is 100% stable, for whatever reason (due to apparent concurrency issues with the poller once read +

Re: svn commit: r1433976 - in /tomcat/trunk/java/org/apache: coyote/ajp/AjpAprProtocol.java coyote/http11/Http11AprProtocol.java tomcat/util/net/AprEndpoint.java tomcat/util/net/res/LocalStrings.prope

2013-01-16 Thread jean-frederic clere
On 01/16/2013 04:53 PM, Remy Maucherat wrote: On Wed, 2013-01-16 at 15:14 +, ma...@apache.org wrote: This is untested (I don't have an OSX build of the native lib handy right now). I'll test later today. I'm not sure native on OS X is 100% stable, for whatever reason (due to apparent

Re: svn commit: r1433976 - in /tomcat/trunk/java/org/apache: coyote/ajp/AjpAprProtocol.java coyote/http11/Http11AprProtocol.java tomcat/util/net/AprEndpoint.java tomcat/util/net/res/LocalStrings.prope

2013-01-16 Thread Mark Thomas
On 16/01/2013 16:12, jean-frederic clere wrote: On 01/16/2013 04:53 PM, Remy Maucherat wrote: On Wed, 2013-01-16 at 15:14 +, ma...@apache.org wrote: This is untested (I don't have an OSX build of the native lib handy right now). I'll test later today. I'm not sure native on OS X is 100%

svn commit: r1434050 - /tomcat/maven-plugin/trunk/pom.xml

2013-01-16 Thread olamy
Author: olamy Date: Wed Jan 16 17:17:23 2013 New Revision: 1434050 URL: http://svn.apache.org/viewvc?rev=1434050view=rev Log: use tomcat 7.0.35 artifacts Modified: tomcat/maven-plugin/trunk/pom.xml Modified: tomcat/maven-plugin/trunk/pom.xml URL:

svn commit: r1434051 - /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/pom.xml

2013-01-16 Thread olamy
Author: olamy Date: Wed Jan 16 17:17:42 2013 New Revision: 1434051 URL: http://svn.apache.org/viewvc?rev=1434051view=rev Log: use last cxf 2.6.5 in archetype Modified: tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/pom.xml Modified:

[jira] [Commented] (MTOMCAT-46) Plugins tomcat:run and tomcat:run-war are not loading the Provided and Runtime dependencies.

2013-01-16 Thread Ludwig Magnusson (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13555387#comment-13555387 ] Ludwig Magnusson commented on MTOMCAT-46: - I encountered this error as well when I

[Bug 54437] New: Update PoolProperties javadoc for ConnectState interceptor-managed defaults

2013-01-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54437 Bug ID: 54437 Summary: Update PoolProperties javadoc for ConnectState interceptor-managed defaults Product: Tomcat Modules Version: unspecified Hardware: All

[Bug 54437] Update PoolProperties javadoc for ConnectState interceptor-managed defaults

2013-01-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54437 --- Comment #1 from Chris Pimlott asf.bugzi...@chris.pimlott.net --- There's an existing example in removeAbandonedTimeout setter/getter, which reference the ResetAbandonedTimer interceptor. -- You are receiving this mail because: You are

[jira] [Commented] (MTOMCAT-200) Tomcat7:redeploy

2013-01-16 Thread Glen Mazza (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13555430#comment-13555430 ] Glen Mazza commented on MTOMCAT-200: I think this can be Resolved/Fixed -- it is

[jira] [Closed] (MTOMCAT-200) Tomcat7:redeploy

2013-01-16 Thread *$^¨%`£
[ https://issues.apache.org/jira/browse/MTOMCAT-200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) closed MTOMCAT-200. -- Resolution: Fixed Tomcat7:redeploy

svn commit: r1434380 - in /tomcat/site/trunk/docs/tomcat-7.0-doc: ./ api/ api/org/apache/catalina/ api/org/apache/catalina/ant/ api/org/apache/catalina/ant/jmx/ api/org/apache/catalina/authenticator/

2013-01-16 Thread markt
Author: markt Date: Wed Jan 16 20:48:07 2013 New Revision: 1434380 URL: http://svn.apache.org/viewvc?rev=1434380view=rev Log: Update docs for 7.0.35 [This commit notification would consist of 58 parts, which exceeds the limit of 50 ones, so it was shortened to the summary.]

svn commit: r1434385 - in /tomcat/site/trunk: ./ docs/ xdocs/

2013-01-16 Thread markt
Author: markt Date: Wed Jan 16 20:53:54 2013 New Revision: 1434385 URL: http://svn.apache.org/viewvc?rev=1434385view=rev Log: Update site for 7.0.35 release. Modified: tomcat/site/trunk/build.properties.default tomcat/site/trunk/docs/doap_Tomcat.rdf

[ANN] Apache Tomcat 7.0.35 released

2013-01-16 Thread Mark Thomas
The Apache Tomcat team announces the immediate availability of Apache Tomcat 7.0.35. Apache Tomcat is an open source software implementation of the Java Servlet and JavaServer Pages technologies. This release contains a small number of bug fixes and improvements compared to version 7.0.34. The

svn commit: r1434403 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2013-01-16 Thread markt
Author: markt Date: Wed Jan 16 21:12:20 2013 New Revision: 1434403 URL: http://svn.apache.org/viewvc?rev=1434403view=rev Log: Ensure sockets are always destroyed via destroySocket(). A single place for actions on socket destroy will make later changes simpler. Modified:

[Bug 54438] New: Bug fix 52953 introduces NullPointerException in RealBase.java line 409 when user not found in JDBC

2013-01-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54438 Bug ID: 54438 Summary: Bug fix 52953 introduces NullPointerException in RealBase.java line 409 when user not found in JDBC Product: Tomcat 7 Version: 7.0.27

[Bug 54438] Bug fix 52953 introduces NullPointerException in RealBase.java line 409 when user not found in JDBC

2013-01-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54438 bruce weertman br...@iris.washington.edu changed: What|Removed |Added OS||All ---

[Bug 54438] Bug fix 52953 introduces NullPointerException in RealBase.java line 409 when user not found in JDBC

2013-01-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54438 bruce weertman br...@iris.washington.edu changed: What|Removed |Added CC|

svn commit: r1434428 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2013-01-16 Thread markt
Author: markt Date: Wed Jan 16 21:52:58 2013 New Revision: 1434428 URL: http://svn.apache.org/viewvc?rev=1434428view=rev Log: APR/native refactoring - Remove SocketEventProcessor - Align code with JIO connector (with a view to further refactoring) Modified:

[Bug 54439] New: Undeploy unable to remove JAR files

2013-01-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54439 Bug ID: 54439 Summary: Undeploy unable to remove JAR files Product: Tomcat 7 Version: 7.0.32 Hardware: All OS: All Status: NEW Severity: normal

svn commit: r1434438 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2013-01-16 Thread markt
Author: markt Date: Wed Jan 16 22:11:53 2013 New Revision: 1434438 URL: http://svn.apache.org/viewvc?rev=1434438view=rev Log: APR/native refactoring - Clean-up Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Modified:

[Bug 54438] Bug fix 52953 introduces NullPointerException in RealmBase.java line 409 when user not found in JDBC

2013-01-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54438 bruce weertman br...@iris.washington.edu changed: What|Removed |Added Summary|Bug fix 52953 introduces|Bug fix

svn commit: r1434447 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2013-01-16 Thread markt
Author: markt Date: Wed Jan 16 22:22:22 2013 New Revision: 1434447 URL: http://svn.apache.org/viewvc?rev=1434447view=rev Log: Ensure maxKeepAliveRequests is honoured by the APR/native connector. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Modified:

svn commit: r1434456 - in /tomcat/trunk/java/org/apache: coyote/http11/Http11AprProtocol.java tomcat/util/net/AprEndpoint.java tomcat/util/net/NioEndpoint.java tomcat/util/net/SocketWrapper.java

2013-01-16 Thread markt
Author: markt Date: Wed Jan 16 22:40:40 2013 New Revision: 1434456 URL: http://svn.apache.org/viewvc?rev=1434456view=rev Log: APR/native refactoring - Pull up comet flag to SocketWrappoer - Remove dedicated Comet Poller Modified:

svn commit: r1434463 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2013-01-16 Thread markt
Author: markt Date: Wed Jan 16 22:51:11 2013 New Revision: 1434463 URL: http://svn.apache.org/viewvc?rev=1434463view=rev Log: APR/native refactoring - Add an endpoint implementation specific SocketWrapper - Track poller flags in new wrapper Modified:

svn commit: r1434500 - in /tomcat/trunk/java/org/apache: coyote/http11/Http11AprProtocol.java coyote/http11/upgrade/AprProcessor.java coyote/http11/upgrade/AprServletOutputStream.java tomcat/util/net/

2013-01-16 Thread markt
Author: markt Date: Wed Jan 16 23:43:23 2013 New Revision: 1434500 URL: http://svn.apache.org/viewvc?rev=1434500view=rev Log: Final parts of the puzzle to get APR/native to support the JSR356 WebSocket. There are a small number of Autobahn failures still. I'll look at those next. Modified:

[Bug 54440] New: TagPluginManager.init() throws NPE when used in Ant jasper task

2013-01-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54440 Bug ID: 54440 Summary: TagPluginManager.init() throws NPE when used in Ant jasper task Product: Tomcat 7 Version: 7.0.35 Hardware: Macintosh Status: NEW