https://issues.apache.org/bugzilla/show_bug.cgi?id=56449
--- Comment #3 from Mark Thomas ma...@apache.org ---
Thanks for that.
An immediate close was one of the options I considered but I dismissed it as I
didn't think the close message could have been read that early. What i didn't
consider was
Author: markt
Date: Thu Apr 24 06:09:02 2014
New Revision: 1589598
URL: http://svn.apache.org/r1589598
Log:
Whitespace police
Modified:
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
https://issues.apache.org/bugzilla/show_bug.cgi?id=53011
--- Comment #4 from Marc Pompl marc.po...@lynorics.de ---
Created attachment 31555
-- https://issues.apache.org/bugzilla/attachment.cgi?id=31555action=edit
Patch to add an option failFast
Appended is a patch that adds an option failFast.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53011
--- Comment #5 from Marc Pompl marc.po...@lynorics.de ---
(In reply to Marc Pompl from comment #4)
Patch to add an option failFast
See corresponding issue for the maven-jspc-plugin
https://github.com/Jasig/jspc-maven-plugin/issues/17
--
https://issues.apache.org/bugzilla/show_bug.cgi?id=56383
--- Comment #5 from Violeta Georgieva violet...@apache.org ---
Hi,
I see that you are removing the CSS when showReport is false. Why is that?
When showServerInfo is false you are removing the whole footer. Why is that?
You can remove only
Author: markt
Date: Thu Apr 24 08:08:05 2014
New Revision: 1589630
URL: http://svn.apache.org/r1589630
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56449
When creating a new session, add the message handlers to the session before
calling Endpoint.onOpen() so the message handlers
https://issues.apache.org/bugzilla/show_bug.cgi?id=56449
--- Comment #4 from vlcvlc veliscu.cri...@gmail.com ---
(In reply to Mark Thomas from comment #1)
At the moment, I don't see a code path that could trigger this. The session
is open when it is created so something must be closing it very
Author: markt
Date: Thu Apr 24 08:11:30 2014
New Revision: 1589631
URL: http://svn.apache.org/r1589631
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56449
When creating a new session, add the message handlers to the session before
calling Endpoint.onOpen() so the message handlers
https://issues.apache.org/bugzilla/show_bug.cgi?id=56449
--- Comment #5 from vlcvlc veliscu.cri...@gmail.com ---
(In reply to Mark Thomas from comment #3)
Thanks for that.
An immediate close was one of the options I considered but I dismissed it as
I didn't think the close message could have
https://issues.apache.org/bugzilla/show_bug.cgi?id=56449
Mark Thomas ma...@apache.org changed:
What|Removed |Added
Status|NEW |RESOLVED
Author: markt
Date: Thu Apr 24 08:28:41 2014
New Revision: 1589633
URL: http://svn.apache.org/r1589633
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56430
Extend checks for suspicious URL patterns to include patterns of the form
code*.a.b/code which are not valid patterns for
Author: markt
Date: Thu Apr 24 08:29:34 2014
New Revision: 1589634
URL: http://svn.apache.org/r1589634
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56430
Extend checks for suspicious URL patterns to include patterns of the form
code*.a.b/code which are not valid patterns for
https://issues.apache.org/bugzilla/show_bug.cgi?id=56430
Mark Thomas ma...@apache.org changed:
What|Removed |Added
Resolution|INVALID |FIXED
--- Comment
Author: markt
Date: Thu Apr 24 08:35:06 2014
New Revision: 1589635
URL: http://svn.apache.org/r1589635
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56334
Correct double unescaping
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
https://issues.apache.org/bugzilla/show_bug.cgi?id=56334
Mark Thomas ma...@apache.org changed:
What|Removed |Added
Status|NEW |RESOLVED
Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=1589637r1=1589636r2=1589637view=diff
==
---
https://issues.apache.org/bugzilla/show_bug.cgi?id=56369
--- Comment #3 from Mark Thomas ma...@apache.org ---
The fix has been applied to 6.0.x and will be included in 6.0.40 onwards.
--
You are receiving this mail because:
You are the assignee for the bug.
Author: markt
Date: Thu Apr 24 08:49:58 2014
New Revision: 1589638
URL: http://svn.apache.org/r1589638
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56369
Ensure that removing an MBean notification listener reverts all the operations
performed when adding an MBean notification
https://issues.apache.org/bugzilla/show_bug.cgi?id=56452
Bug ID: 56452
Summary: IPv6 address and log level debug caused crash
Product: Tomcat Connectors
Version: 1.2.40
Hardware: PC
OS: Linux
Status: NEW
Author: markt
Date: Thu Apr 24 08:54:26 2014
New Revision: 1589640
URL: http://svn.apache.org/r1589640
Log:
Avoid memory leak and add small optimisation to default Servlet
Modified:
tomcat/tc6.0.x/trunk/ (props changed)
tomcat/tc6.0.x/trunk/STATUS.txt
2014-04-24 12:35 GMT+04:00 ma...@apache.org:
Author: markt
Date: Thu Apr 24 08:35:06 2014
New Revision: 1589635
URL: http://svn.apache.org/r1589635
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56334
Correct double unescaping
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt
Date: Thu Apr 24 11:32:27 2014
New Revision: 1589666
URL: http://svn.apache.org/r1589666
Log:
Align the AJP and HTTP connector implementations with the documented behaviour
and use JVM defaults for socket linger.
Modified:
Author: violetagg
Date: Thu Apr 24 11:35:40 2014
New Revision: 1589668
URL: http://svn.apache.org/r1589668
Log:
Fixed broken links to java.sun.com. Issue reported via comments.apache.org
Modified:
tomcat/trunk/webapps/docs/funcspecs/fs-admin-apps.xml
https://issues.apache.org/bugzilla/show_bug.cgi?id=56416
Mark Thomas ma...@apache.org changed:
What|Removed |Added
Status|NEW |RESOLVED
Author: markt
Date: Thu Apr 24 11:38:13 2014
New Revision: 1589672
URL: http://svn.apache.org/r1589672
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56416
Align the AJP and HTTP connector implementations with the documented behaviour
and use JVM defaults for socket linger.
Author: violetagg
Date: Thu Apr 24 11:41:13 2014
New Revision: 1589676
URL: http://svn.apache.org/r1589676
Log:
Merged revision 1589668 from tomcat/trunk:
Fixed broken links to java.sun.com. Issue reported via comments.apache.org
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
https://issues.apache.org/bugzilla/show_bug.cgi?id=56449
--- Comment #7 from vlcvlc veliscu.cri...@gmail.com ---
(In reply to Mark Thomas from comment #6)
(In reply to Mark Thomas from comment #3)
What I
didn't consider was that the close of the connection rather than the close
message may
Author: violetagg
Date: Thu Apr 24 12:50:39 2014
New Revision: 1589698
URL: http://svn.apache.org/r1589698
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56382
Add information about finished deployment and its execution time to the logs.
Patch provided by Danila Galimov.
Modified:
Author: violetagg
Date: Thu Apr 24 12:59:10 2014
New Revision: 1589703
URL: http://svn.apache.org/r1589703
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56382
Merged revision 1589698 from tomcat/trunk:
Add information about finished deployment and its execution time to the logs.
Author: remm
Date: Thu Apr 24 13:01:55 2014
New Revision: 1589705
URL: http://svn.apache.org/r1589705
Log:
With the linger change, I am now getting async close exceptions on the accept
on shutdown. Ignore exceptions when not running and cleanup.
Modified:
https://issues.apache.org/bugzilla/show_bug.cgi?id=56382
Violeta Georgieva violet...@apache.org changed:
What|Removed |Added
Status|NEW |RESOLVED
2014-04-24 15:38 GMT+04:00 ma...@apache.org:
Author: markt
Date: Thu Apr 24 11:38:13 2014
New Revision: 1589672
URL: http://svn.apache.org/r1589672
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56416
Align the AJP and HTTP connector implementations with the documented
2014-04-24 15:04 GMT+02:00 Konstantin Kolinko knst.koli...@gmail.com:
2. AbstractEndpoint,unlockAccept()
s.setSoLinger(getSocketProperties().getSoLingerOn(),getSocketProperties().getSoLingerTime());
I expect the above call to be broken because of NPE.
I don't see the NPE, but that would
2014-04-24 17:14 GMT+04:00 Rémy Maucherat r...@apache.org:
2014-04-24 15:04 GMT+02:00 Konstantin Kolinko knst.koli...@gmail.com:
2. AbstractEndpoint,unlockAccept()
s.setSoLinger(getSocketProperties().getSoLingerOn(),getSocketProperties().getSoLingerTime());
I expect the above call to be
On 24/04/2014 14:14, Rémy Maucherat wrote:
2014-04-24 15:04 GMT+02:00 Konstantin Kolinko knst.koli...@gmail.com:
2. AbstractEndpoint,unlockAccept()
s.setSoLinger(getSocketProperties().getSoLingerOn(),getSocketProperties().getSoLingerTime());
I expect the above call to be broken because of
Author: markt
Date: Thu Apr 24 13:30:49 2014
New Revision: 1589724
URL: http://svn.apache.org/r1589724
Log:
Revert 1589672. Default linger setting is required.
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/coyote/ajp/AjpAprProtocol.java
https://issues.apache.org/bugzilla/show_bug.cgi?id=56416
Mark Thomas ma...@apache.org changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Author: markt
Date: Thu Apr 24 13:33:19 2014
New Revision: 1589725
URL: http://svn.apache.org/r1589725
Log:
Revert 1589666. Default linger setting is required.
Modified:
tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProtocol.java
Author: markt
Date: Thu Apr 24 13:36:38 2014
New Revision: 1589726
URL: http://svn.apache.org/r1589726
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56416
Document correct default for socket linger.
Modified:
tomcat/trunk/webapps/docs/changelog.xml
https://issues.apache.org/bugzilla/show_bug.cgi?id=56416
Mark Thomas ma...@apache.org changed:
What|Removed |Added
Status|REOPENED|RESOLVED
Author: markt
Date: Thu Apr 24 13:38:08 2014
New Revision: 1589728
URL: http://svn.apache.org/r1589728
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56416
Document correct default for socket linger.
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
https://issues.apache.org/bugzilla/show_bug.cgi?id=56416
--- Comment #4 from David david.lan...@telus.com ---
Mark,
On my end we have the following scenario:
1) Start Tomcat
2) Tomcat binds to port and starts loading webapps
3) My web app has a servlet for which load-on-startup is set to
https://issues.apache.org/bugzilla/show_bug.cgi?id=56416
--- Comment #5 from Mark Thomas ma...@apache.org ---
(In reply to David from comment #4)
On my end we have the following scenario:
snip/
Bugzilla is not a support forum. This question belongs on the Tomcat users
mailing list.
--
You
On 24/04/2014 10:00, Konstantin Kolinko wrote:
2014-04-24 12:35 GMT+04:00 ma...@apache.org:
Author: markt
Date: Thu Apr 24 08:35:06 2014
New Revision: 1589635
snip/
Modified: tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/ELParser.java
URL:
Author: markt
Date: Thu Apr 24 14:11:02 2014
New Revision: 1589737
URL: http://svn.apache.org/r1589737
Log:
Minor optimisation
Modified:
tomcat/trunk/java/org/apache/jasper/compiler/ELParser.java
Modified: tomcat/trunk/java/org/apache/jasper/compiler/ELParser.java
URL:
Author: markt
Date: Thu Apr 24 14:12:35 2014
New Revision: 1589738
URL: http://svn.apache.org/r1589738
Log:
Fix text
Modified:
tomcat/trunk/java/org/apache/jasper/resources/LocalStrings.properties
Modified: tomcat/trunk/java/org/apache/jasper/resources/LocalStrings.properties
URL:
Author: markt
Date: Thu Apr 24 14:13:40 2014
New Revision: 1589740
URL: http://svn.apache.org/r1589740
Log:
Minor clean-up. kkolinko review.
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/jasper/compiler/ELParser.java
Author: markt
Date: Thu Apr 24 14:15:48 2014
New Revision: 1589743
URL: http://svn.apache.org/r1589743
Log:
Complete backport of r1587887 - add missing resources
Modified:
tomcat/tc6.0.x/trunk/java/org/apache/jasper/resources/LocalStrings.properties
Modified:
Author: markt
Date: Thu Apr 24 15:06:32 2014
New Revision: 1589763
URL: http://svn.apache.org/r1589763
Log:
Refactoring to reduce code duplication.
Added:
tomcat/trunk/java/org/apache/tomcat/util/security/
tomcat/trunk/java/org/apache/tomcat/util/security/PrivilegedGetTccl.java
(with
https://issues.apache.org/bugzilla/show_bug.cgi?id=56416
--- Comment #6 from Konstantin Kolinko knst.koli...@gmail.com ---
(In reply to David from comment #4)
First, that would better be tracked as a separate issue.
Second, it cannot be said much without knowing your Tomcat version and
https://issues.apache.org/bugzilla/show_bug.cgi?id=56383
--- Comment #6 from Nick Bunn thrain...@gmail.com ---
My first patch did actually keep the css. However, after talking more with my
team at work and looking at what the TomEE team has done(doesn't have css as
well), it was determined if i
Author: markt
Date: Thu Apr 24 19:16:21 2014
New Revision: 1589837
URL: http://svn.apache.org/r1589837
Log:
Add some defensive coding around some XML activities that are triggered by web
applications and are therefore at potential risk of a memory leak.
Modified:
Author: markt
Date: Thu Apr 24 19:26:45 2014
New Revision: 1589842
URL: http://svn.apache.org/r1589842
Log:
More refactoring to reduce code duplication.
Modified:
tomcat/trunk/java/org/apache/jasper/compiler/ELFunctionMapper.java
Modified:
Author: markt
Date: Thu Apr 24 19:43:55 2014
New Revision: 1589851
URL: http://svn.apache.org/r1589851
Log:
Refactoring to reduce code duplication.
Added:
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/security/
- copied from r1589763,
https://issues.apache.org/bugzilla/show_bug.cgi?id=56452
--- Comment #1 from Christopher Schultz ch...@christopherschultz.net ---
Agreed.
The use of 'buf' when passed-into inet_ntop4|6 inside jk_dump_sinfo is also not
sane: the final argument should be the length of the buffer available. It is
https://issues.apache.org/bugzilla/show_bug.cgi?id=56452
--- Comment #2 from Christopher Schultz ch...@christopherschultz.net ---
Created attachment 31557
-- https://issues.apache.org/bugzilla/attachment.cgi?id=31557action=edit
Proposed patch (against mod_jk/trunk)
I have raised the size of
https://issues.apache.org/bugzilla/show_bug.cgi?id=56452
--- Comment #3 from Konstantin Kolinko knst.koli...@gmail.com ---
(In reply to Christopher Schultz from comment #2)
Created attachment 31557 [details]
Proposed patch (against mod_jk/trunk)
I have raised the size of buf from 64 to 100
https://issues.apache.org/bugzilla/show_bug.cgi?id=56456
Bug ID: 56456
Summary: Suggesting lock-free endpoint state machine
Product: Tomcat 8
Version: trunk
Hardware: PC
OS: Linux
Status: NEW
Severity:
https://issues.apache.org/bugzilla/show_bug.cgi?id=56456
--- Comment #1 from Eugene Chung (TmaxSoft) bluewolf.ch...@gmail.com ---
Created attachment 31559
-- https://issues.apache.org/bugzilla/attachment.cgi?id=31559action=edit
RemoteEndpoint which uses EndpointStateMachine
--
You are
https://issues.apache.org/bugzilla/show_bug.cgi?id=56456
--- Comment #2 from Eugene Chung (TmaxSoft) bluewolf.ch...@gmail.com ---
Created attachment 31560
-- https://issues.apache.org/bugzilla/attachment.cgi?id=31560action=edit
junit test for EndpointStateMachine
--
You are receiving this
60 matches
Mail list logo
