Re: Building Tomcat 7 with JDK 7

2014-05-29 Thread Emmanuel Bourg
Le 29/05/2014 05:26, Andrew Carr a écrit : option by the devs was to fix JDK 7 building in Tomcat 8 and tell people to compile Tomcat 7 with JDK 6, running it with Java 7. Is this true? Are there plans to fix TC 7 to compile with JDK7? Should there be? FWIW Tomcat 7 is built with Java 7 in

Re: Building Tomcat 7 with JDK 7

2014-05-29 Thread Mark Thomas
On 29/05/2014 04:26, Andrew Carr wrote: From what I have read building Tomcat 7 has to be done with JDK 6 and the option by the devs was to fix JDK 7 building in Tomcat 8 and tell people to compile Tomcat 7 with JDK 6, running it with Java 7. Is this true? No. There are many reasons why

svn commit: r1598242 - /tomcat/trunk/java/org/apache/coyote/Response.java

2014-05-29 Thread markt
Author: markt Date: Thu May 29 10:21:08 2014 New Revision: 1598242 URL: http://svn.apache.org/r1598242 Log: Fix indent Modified: tomcat/trunk/java/org/apache/coyote/Response.java Modified: tomcat/trunk/java/org/apache/coyote/Response.java URL:

svn commit: r1598246 - in /tomcat/trunk/java/org/apache: catalina/connector/OutputBuffer.java catalina/connector/Response.java coyote/Response.java coyote/spdy/SpdyProcessor.java

2014-05-29 Thread markt
Author: markt Date: Thu May 29 10:28:23 2014 New Revision: 1598246 URL: http://svn.apache.org/r1598246 Log: Remove Response methods where the only function is to call action() and call action() directly. Modified: tomcat/trunk/java/org/apache/catalina/connector/OutputBuffer.java

svn commit: r1598248 - /tomcat/trunk/java/org/apache/coyote/Response.java

2014-05-29 Thread markt
Author: markt Date: Thu May 29 10:33:06 2014 New Revision: 1598248 URL: http://svn.apache.org/r1598248 Log: Remove unnecessary method Modified: tomcat/trunk/java/org/apache/coyote/Response.java Modified: tomcat/trunk/java/org/apache/coyote/Response.java URL:

svn commit: r1598266 - /tomcat/trunk/java/org/apache/catalina/valves/ErrorReportValve.java

2014-05-29 Thread markt
Author: markt Date: Thu May 29 12:07:09 2014 New Revision: 1598266 URL: http://svn.apache.org/r1598266 Log: Better comments Formatting (use longer line lengths) Modified: tomcat/trunk/java/org/apache/catalina/valves/ErrorReportValve.java Modified:

svn commit: r1598267 - in /tomcat/trunk/java/org/apache: catalina/connector/Response.java coyote/Response.java

2014-05-29 Thread markt
Author: markt Date: Thu May 29 12:13:28 2014 New Revision: 1598267 URL: http://svn.apache.org/r1598267 Log: Formatting clean-up No functional change Modified: tomcat/trunk/java/org/apache/catalina/connector/Response.java tomcat/trunk/java/org/apache/coyote/Response.java Modified:

svn commit: r1598269 - /tomcat/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletInputStream.java

2014-05-29 Thread remm
Author: remm Date: Thu May 29 12:20:07 2014 New Revision: 1598269 URL: http://svn.apache.org/r1598269 Log: Less fuzzy way to call onDataAvailable (no real fix though). Modified: tomcat/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletInputStream.java Modified:

Error handling

2014-05-29 Thread Mark Thomas
You've probably noticed I've been poking around the ErrorReportValve, the Response objects and other related code. I've been looking into an issue that one of the groups at $work has raised around Tomcat's error handling and I've been cleaning things up as I notice them to stop me getting

[Bug 56575] New: [websocket][AsyncContext][Ubuntu] java.lang.IllegalStateException: Not supported. event when async-supported set to true

2014-05-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56575 Bug ID: 56575 Summary: [websocket][AsyncContext][Ubuntu] java.lang.IllegalStateException: Not supported. event when async-supported set to true Product: Tomcat 8

[Bug 56575] [websocket][AsyncContext][Ubuntu] java.lang.IllegalStateException: Not supported. event when async-supported set to true

2014-05-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56575 Jean-Francois Arcand jfarc...@apache.org changed: What|Removed |Added CC|

buildbot failure in ASF Buildbot on tomcat-trunk

2014-05-29 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/120 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

svn commit: r1598304 - /tomcat/trunk/java/org/apache/coyote/Response.java

2014-05-29 Thread markt
Author: markt Date: Thu May 29 14:34:37 2014 New Revision: 1598304 URL: http://svn.apache.org/r1598304 Log: Check committed before changing any field values Remove various incorrect comments Modified: tomcat/trunk/java/org/apache/coyote/Response.java Modified:

svn commit: r1598307 - in /tomcat/trunk/java/org/apache/coyote: Response.java http11/AbstractOutputBuffer.java

2014-05-29 Thread markt
Author: markt Date: Thu May 29 14:39:25 2014 New Revision: 1598307 URL: http://svn.apache.org/r1598307 Log: Simplify logic Call Response.recycle() from Response.reset() rather than in Response.reset(): - doing ~half of what recycle() does - calling ActionCode.RESET which resets the OutputBuffer

svn commit: r1598310 - /tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java

2014-05-29 Thread markt
Author: markt Date: Thu May 29 14:44:38 2014 New Revision: 1598310 URL: http://svn.apache.org/r1598310 Log: Trivial format fix Modified: tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java Modified: tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java

svn commit: r1598311 - /tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java

2014-05-29 Thread markt
Author: markt Date: Thu May 29 14:51:45 2014 New Revision: 1598311 URL: http://svn.apache.org/r1598311 Log: Trivial format tweaks Modified: tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java Modified:

svn commit: r1598313 - in /tomcat/trunk/java/org/apache/catalina/connector: OutputBuffer.java Response.java

2014-05-29 Thread markt
Author: markt Date: Thu May 29 14:55:28 2014 New Revision: 1598313 URL: http://svn.apache.org/r1598313 Log: More formatting changes Modified: tomcat/trunk/java/org/apache/catalina/connector/OutputBuffer.java tomcat/trunk/java/org/apache/catalina/connector/Response.java Modified:

Re: svn commit: r1598307 - in /tomcat/trunk/java/org/apache/coyote: Response.java http11/AbstractOutputBuffer.java

2014-05-29 Thread Konstantin Kolinko
2014-05-29 18:39 GMT+04:00 ma...@apache.org: Author: markt Date: Thu May 29 14:39:25 2014 New Revision: 1598307 URL: http://svn.apache.org/r1598307 Log: Simplify logic Call Response.recycle() from Response.reset() rather than in Response.reset(): - doing ~half of what recycle() does -

Re: Error handling

2014-05-29 Thread Rémy Maucherat
2014-05-29 14:31 GMT+02:00 Mark Thomas ma...@apache.org: There are four variations: 1. Content length set, some content written, response not committed. 2. Content length set, some content written, response committed. 3. Content length not set, some content written, response not committed.

Re: Building Tomcat 7 with JDK 7

2014-05-29 Thread Konstantin Kolinko
2014-05-29 7:26 GMT+04:00 Andrew Carr andrewlanec...@gmail.com: From what I have read building Tomcat 7 has to be done with JDK 6 and the option by the devs was to fix JDK 7 building in Tomcat 8 and tell people to compile Tomcat 7 with JDK 6, running it with Java 7. Is this true? Are there

[Bug 56576] New: Websocket support

2014-05-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56576 Bug ID: 56576 Summary: Websocket support Product: Tomcat Connectors Version: unspecified Hardware: PC OS: All Status: NEW Severity: enhancement

[Bug 56576] Websocket support

2014-05-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56576 André Moreira andre@gmail.com changed: What|Removed |Added CC|

Re: [SECURITY] CVE-2014-0095 Apache Tomcat denial of service

2014-05-29 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, On 5/27/14, 2:41 PM, Christopher Schultz wrote: All, On 5/27/14, 8:46 AM, Mark Thomas wrote: CVE-2014-0095 Denial of Service Severity: Important Vendor: The Apache Software Foundation Versions Affected: - Apache Tomcat 8.0.0-RC2

Re: svn commit: r1598307 - in /tomcat/trunk/java/org/apache/coyote: Response.java http11/AbstractOutputBuffer.java

2014-05-29 Thread Mark Thomas
On 29/05/2014 16:27, Konstantin Kolinko wrote: 2014-05-29 18:39 GMT+04:00 ma...@apache.org: Author: markt Date: Thu May 29 14:39:25 2014 New Revision: 1598307 URL: http://svn.apache.org/r1598307 Log: Simplify logic Call Response.recycle() from Response.reset() rather than in

Re: Error handling

2014-05-29 Thread Mark Thomas
On 29/05/2014 16:54, Rémy Maucherat wrote: 2014-05-29 14:31 GMT+02:00 Mark Thomas ma...@apache.org: There are four variations: 1. Content length set, some content written, response not committed. 2. Content length set, some content written, response committed. 3. Content length not set,

Re: svn commit: r1598307 - in /tomcat/trunk/java/org/apache/coyote: Response.java http11/AbstractOutputBuffer.java

2014-05-29 Thread Mark Thomas
On 29/05/2014 19:36, Mark Thomas wrote: On 29/05/2014 16:27, Konstantin Kolinko wrote: 2014-05-29 18:39 GMT+04:00 ma...@apache.org: Author: markt Date: Thu May 29 14:39:25 2014 New Revision: 1598307 URL: http://svn.apache.org/r1598307 Log: Simplify logic Call Response.recycle() from

[Bug 56577] New: [websocket] Inappropriate executor in WsServerContainer

2014-05-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56577 Bug ID: 56577 Summary: [websocket] Inappropriate executor in WsServerContainer Product: Tomcat 7 Version: 7.0.54 Hardware: PC OS: Linux

buildbot success in ASF Buildbot on tomcat-trunk

2014-05-29 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/122 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

[Bug 56555] Multiple connection headers for status 400 when keep-alive is specified

2014-05-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56555 --- Comment #7 from Christopher Schultz ch...@christopherschultz.net --- (In reply to Mark Thomas from comment #5) The correct response code for invalid credentials should be 401. Use of 401 is only appropriate when using

Re: Error handling

2014-05-29 Thread Christopher Schultz
Mark, On 5/29/14, 8:31 AM, Mark Thomas wrote: You've probably noticed I've been poking around the ErrorReportValve, the Response objects and other related code. I've been looking into an issue that one of the groups at $work has raised around Tomcat's error handling and I've been cleaning

[Bug 56578] New: session.invalidate does not work on cluster enabled webapps

2014-05-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56578 Bug ID: 56578 Summary: session.invalidate does not work on cluster enabled webapps Product: Tomcat 7 Version: 7.0.54 Hardware: All OS: Linux

[Bug 56578] session.invalidate does not work on cluster enabled webapps

2014-05-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56578 --- Comment #1 from David Rees dree...@gmail.com --- Created attachment 31678 -- https://issues.apache.org/bugzilla/attachment.cgi?id=31678action=edit session.jsp -- You are receiving this mail because: You are the assignee for the bug.

[Bug 56578] session.invalidate does not work on cluster enabled webapps

2014-05-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56578 --- Comment #2 from David Rees dree...@gmail.com --- Created attachment 31679 -- https://issues.apache.org/bugzilla/attachment.cgi?id=31679action=edit invalidate.jsp -- You are receiving this mail because: You are the assignee for the

svn commit: r1598453 - /tomcat/tc6.0.x/trunk/STATUS.txt

2014-05-29 Thread kkolinko
Author: kkolinko Date: Fri May 30 02:01:21 2014 New Revision: 1598453 URL: http://svn.apache.org/r1598453 Log: vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL:

[Bug 56555] Multiple connection headers for status 400 when keep-alive is specified

2014-05-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56555 Konstantin Kolinko knst.koli...@gmail.com changed: What|Removed |Added Status|RESOLVED