Re: [VOTE] Release Apache Tomcat 8.5.9

2016-12-06 Thread Keiichi Fujino
2016-12-06 5:44 GMT+09:00 Mark Thomas : > The proposed Apache Tomcat 8.5.9 release is now available for voting. > > The major changes compared to the 8.5.8 release are: > > > - Improvements to SPNEGO authentication. Patches provided by Michael > Osipov. > > - Correct

Re: [VOTE] Release Apache Tomcat 9.0.0.M15

2016-12-06 Thread Keiichi Fujino
2016-12-05 23:47 GMT+09:00 Mark Thomas : > The proposed Apache Tomcat 9.0.0.M15 release is now available for voting. > > This is a milestone release for the 9.0.x branch. It should be > noted that, as a milestone release: > - Servlet 4.0 is not finalised > - The EGs have not

Re: Same request object passed to two threads

2016-12-06 Thread Matthew Bellew
Thanks for the pointer to org.apache.catalina.connector.RECYCLE_FACADES. I will try running our integration server with that set both ways and compare. I don't see how an application bug could cause the same RequestFacade to be passed to the webapp on two thread concurrently, however. I'm not

RE: Same request object passed to two threads

2016-12-06 Thread Caldarale, Charles R
From: Matthew Bellew [mailto:matth...@labkey.com] > Subject: Re: Same request object passed to two threads This should be on the users' mailing list, not dev. > Just realized that in the case above, I couldn't have hit the quoted code, > since neither call to AuthFilter.doFilter() had returned.

Re: Same request object passed to two threads

2016-12-06 Thread Matthew Bellew
Just realized that in the case above, I couldn't have hit the quoted code, since neither call to AuthFilter.doFilter() had returned. I can build and debug Tomcat, so any advice would be very welcome. Matt On Tue, Dec 6, 2016 at 2:20 PM, Matthew Bellew wrote: > I have an

Same request object passed to two threads

2016-12-06 Thread Matthew Bellew
I have an intermittent bug that I've been trying to trying to track down for a long time. The symptom is that the same tomcat request object is being processed by two different threads. The symptom is a random crash when one thread returns and recycles the request, and the other thread access

Re: Typo on monitoring.html

2016-12-06 Thread Felix Schumacher
Am 06.12.2016 um 18:09 schrieb Emmanuel Bourg: Hi, There is a typo on the monitoring.html pages, "Ichinga" should be replaced by "Icinga". Fixed. Thanks Felix Emmanuel Bourg - To unsubscribe, e-mail:

svn commit: r1772950 - in /tomcat/tc7.0.x/trunk: ./ webapps/docs/monitoring.xml

2016-12-06 Thread fschumacher
Author: fschumacher Date: Tue Dec 6 19:57:08 2016 New Revision: 1772950 URL: http://svn.apache.org/viewvc?rev=1772950=rev Log: Fix typo Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/webapps/docs/monitoring.xml Propchange: tomcat/tc7.0.x/trunk/

svn commit: r1772949 - in /tomcat/tc8.0.x/trunk: ./ webapps/docs/monitoring.xml

2016-12-06 Thread fschumacher
Author: fschumacher Date: Tue Dec 6 19:55:40 2016 New Revision: 1772949 URL: http://svn.apache.org/viewvc?rev=1772949=rev Log: Fix typo Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/webapps/docs/monitoring.xml Propchange: tomcat/tc8.0.x/trunk/

svn commit: r1772948 - in /tomcat/tc8.5.x/trunk: ./ webapps/docs/monitoring.xml

2016-12-06 Thread fschumacher
Author: fschumacher Date: Tue Dec 6 19:54:19 2016 New Revision: 1772948 URL: http://svn.apache.org/viewvc?rev=1772948=rev Log: Fix typo Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/webapps/docs/monitoring.xml Propchange: tomcat/tc8.5.x/trunk/

svn commit: r1772947 - /tomcat/trunk/webapps/docs/monitoring.xml

2016-12-06 Thread fschumacher
Author: fschumacher Date: Tue Dec 6 19:53:09 2016 New Revision: 1772947 URL: http://svn.apache.org/viewvc?rev=1772947=rev Log: Fix typo Modified: tomcat/trunk/webapps/docs/monitoring.xml Modified: tomcat/trunk/webapps/docs/monitoring.xml URL:

Re: [VOTE] Release Apache Tomcat 8.5.9

2016-12-06 Thread Rémy Maucherat
2016-12-05 21:44 GMT+01:00 Mark Thomas : > The proposed Apache Tomcat 8.5.9 release is now available for voting. > > The major changes compared to the 8.5.8 release are: > > > - Improvements to SPNEGO authentication. Patches provided by Michael > Osipov. > > - Correct

Re: [VOTE] Release Apache Tomcat 9.0.0.M15

2016-12-06 Thread Rémy Maucherat
2016-12-05 15:47 GMT+01:00 Mark Thomas : > The proposed Apache Tomcat 9.0.0.M15 release is now available for voting. > > This is a milestone release for the 9.0.x branch. It should be > noted that, as a milestone release: > - Servlet 4.0 is not finalised > - The EGs have not

Typo on monitoring.html

2016-12-06 Thread Emmanuel Bourg
Hi, There is a typo on the monitoring.html pages, "Ichinga" should be replaced by "Icinga". Emmanuel Bourg - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1772886 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2016-12-06 Thread markt
Author: markt Date: Tue Dec 6 12:47:28 2016 New Revision: 1772886 URL: http://svn.apache.org/viewvc?rev=1772886=rev Log: Refactor to better align APR and NIO/NIO2 Acceptor classes - Re-use IOException handling during accept from NIO/NIO2 (it is slightly better) - Align comments Modified:

svn commit: r1772887 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/AprEndpoint.java

2016-12-06 Thread markt
Author: markt Date: Tue Dec 6 12:47:51 2016 New Revision: 1772887 URL: http://svn.apache.org/viewvc?rev=1772887=rev Log: Refactor to better align APR and NIO/NIO2 Acceptor classes - Re-use IOException handling during accept from NIO/NIO2 (it is slightly better) - Align comments Modified:

svn commit: r1772882 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/Nio2Endpoint.java java/org/apache/tomcat/util/net/NioEndpoint.java

2016-12-06 Thread markt
Author: markt Date: Tue Dec 6 12:39:52 2016 New Revision: 1772882 URL: http://svn.apache.org/viewvc?rev=1772882=rev Log: Refactor - reduce duplication - better alignment with APR Modified: tomcat/tc8.5.x/trunk/ (props changed)

svn commit: r1772881 - in /tomcat/trunk/java/org/apache/tomcat/util/net: Nio2Endpoint.java NioEndpoint.java

2016-12-06 Thread markt
Author: markt Date: Tue Dec 6 12:39:29 2016 New Revision: 1772881 URL: http://svn.apache.org/viewvc?rev=1772881=rev Log: Refactor - reduce duplication - better alignment with APR Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

svn commit: r1772878 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/NioEndpoint.java

2016-12-06 Thread markt
Author: markt Date: Tue Dec 6 12:29:19 2016 New Revision: 1772878 URL: http://svn.apache.org/viewvc?rev=1772878=rev Log: Remove unnecessary code a) this is called during socketProperties.setProperties() above b) it has no effect since accept() is not subject to a timeout with NIO Modified:

svn commit: r1772877 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/NioEndpoint.java

2016-12-06 Thread markt
Author: markt Date: Tue Dec 6 12:29:02 2016 New Revision: 1772877 URL: http://svn.apache.org/viewvc?rev=1772877=rev Log: Remove unnecessary code ServerSocketChannel does not timeout calls to accept() (ServerSocket aka BIO does) Modified: tomcat/tc8.5.x/trunk/ (props changed)

[Bug 60446] New: SecretKeyCredentialHandler ignores key length when matching

2016-12-06 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60446 Bug ID: 60446 Summary: SecretKeyCredentialHandler ignores key length when matching Product: Tomcat 9 Version: 9.0.0.M13 Hardware: All OS: All

svn commit: r1772876 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

2016-12-06 Thread markt
Author: markt Date: Tue Dec 6 12:27:55 2016 New Revision: 1772876 URL: http://svn.apache.org/viewvc?rev=1772876=rev Log: Remove unnecessary code a) this is called during socketProperties.setProperties() above b) it has no effect since accept() is not subject to a timeout with NIO Modified:

svn commit: r1772875 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

2016-12-06 Thread markt
Author: markt Date: Tue Dec 6 12:26:51 2016 New Revision: 1772875 URL: http://svn.apache.org/viewvc?rev=1772875=rev Log: Remove unnecessary code ServerSocketChannel does not timeout calls to accept() (ServerSocket aka BIO does) Modified:

Re: [VOTE] Release Apache Tomcat 8.5.9

2016-12-06 Thread Coty Sutherland
> The proposed 8.5.9 release is: > [ ] Broken - do not release > [x] Stable - go ahead and release as 8.5.9 (there's a typo here in the > original email) +1 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For

Re: [VOTE] Release Apache Tomcat 8.5.9

2016-12-06 Thread Violeta Georgieva
Hi, 2016-12-05 22:44 GMT+02:00 Mark Thomas : > > The proposed Apache Tomcat 8.5.9 release is now available for voting. > > The major changes compared to the 8.5.8 release are: > > > - Improvements to SPNEGO authentication. Patches provided by Michael > Osipov. > > - Correct

svn commit: r1772873 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/Nio2Endpoint.java java/org/apache/tomcat/util/net/NioEndpoint.java

2016-12-06 Thread markt
Author: markt Date: Tue Dec 6 12:08:19 2016 New Revision: 1772873 URL: http://svn.apache.org/viewvc?rev=1772873=rev Log: Refactor to better align NIO and NIO2 Acceptor classes - Re-use IOException handling during accept from NIO2 (it is slightly better) - Align comments Modified:

svn commit: r1772872 - in /tomcat/trunk/java/org/apache/tomcat/util/net: Nio2Endpoint.java NioEndpoint.java

2016-12-06 Thread markt
Author: markt Date: Tue Dec 6 11:47:01 2016 New Revision: 1772872 URL: http://svn.apache.org/viewvc?rev=1772872=rev Log: Refactor to better align NIO and NIO2 Acceptor classes - Re-use IOException handling during accept from NIO2 (it is slightly better) - Align comments Modified:

svn commit: r1772871 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/Nio2Endpoint.java java/org/apache/tomcat/util/net/NioEndpoint.java

2016-12-06 Thread markt
Author: markt Date: Tue Dec 6 11:38:33 2016 New Revision: 1772871 URL: http://svn.apache.org/viewvc?rev=1772871=rev Log: Refactor to better align NIO and NIO2 Acceptor classes Modified: tomcat/tc8.5.x/trunk/ (props changed)

svn commit: r1772870 - in /tomcat/trunk/java/org/apache/tomcat/util/net: Nio2Endpoint.java NioEndpoint.java

2016-12-06 Thread markt
Author: markt Date: Tue Dec 6 11:37:51 2016 New Revision: 1772870 URL: http://svn.apache.org/viewvc?rev=1772870=rev Log: Refactor to better align NIO and NIO2 Acceptor classes Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

svn commit: r1772868 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/Nio2Endpoint.java

2016-12-06 Thread markt
Author: markt Date: Tue Dec 6 11:30:41 2016 New Revision: 1772868 URL: http://svn.apache.org/viewvc?rev=1772868=rev Log: Correct comment Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java Propchange:

svn commit: r1772865 - /tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

2016-12-06 Thread markt
Author: markt Date: Tue Dec 6 11:24:23 2016 New Revision: 1772865 URL: http://svn.apache.org/viewvc?rev=1772865=rev Log: Correct comment Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java URL:

[jira] [Commented] (MTOMCAT-234) Tomcat8 Maven Plugin

2016-12-06 Thread JIRA
[ https://issues.apache.org/jira/browse/MTOMCAT-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15724855#comment-15724855 ] Björn Raupach commented on MTOMCAT-234: --- Any updates? > Tomcat8 Maven Plugin >

svn commit: r1772857 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/realm/ test/org/apache/catalina/filters/ test/org/apache/catalina/loader/ test/org/apache/jasper/runtime/ test/org/apache/t

2016-12-06 Thread markt
Author: markt Date: Tue Dec 6 10:12:22 2016 New Revision: 1772857 URL: http://svn.apache.org/viewvc?rev=1772857=rev Log: Remove extra space between import groups identified by Gump when running with latest Checkstyle HEAD Modified: tomcat/tc7.0.x/trunk/ (props changed)

buildbot success in on tomcat-8-trunk

2016-12-06 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-8-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-8-trunk/builds/864 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

svn commit: r1772851 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/valves/rewrite/ java/org/apache/tomcat/dbcp/dbcp2/ java/org/apache/tomcat/dbcp/dbcp2/datasources/ test/org/apache/catalina/

2016-12-06 Thread markt
Author: markt Date: Tue Dec 6 09:32:09 2016 New Revision: 1772851 URL: http://svn.apache.org/viewvc?rev=1772851=rev Log: Remove extra space between import groups identified by Gump when running with latest Checkstyle HEAD Modified: tomcat/tc8.0.x/trunk/ (props changed)

svn commit: r1772850 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/valves/rewrite/ java/org/apache/tomcat/dbcp/dbcp2/ java/org/apache/tomcat/dbcp/dbcp2/datasources/ test/org/apache/catalina/

2016-12-06 Thread markt
Author: markt Date: Tue Dec 6 09:31:33 2016 New Revision: 1772850 URL: http://svn.apache.org/viewvc?rev=1772850=rev Log: Remove extra space between import groups identified by Gump when running with latest Checkstyle HEAD Modified: tomcat/tc8.5.x/trunk/ (props changed)

svn commit: r1772849 - in /tomcat/trunk: java/org/apache/catalina/valves/rewrite/ java/org/apache/tomcat/dbcp/dbcp2/datasources/ test/org/apache/catalina/filters/ test/org/apache/catalina/loader/ test

2016-12-06 Thread markt
Author: markt Date: Tue Dec 6 09:31:01 2016 New Revision: 1772849 URL: http://svn.apache.org/viewvc?rev=1772849=rev Log: Remove extra space between import groups identified by Gump when running with latest Checkstyle HEAD Modified:

Re: [VOTE] Release Apache Tomcat 9.0.0.M15

2016-12-06 Thread Violeta Georgieva
Hi, 2016-12-05 16:47 GMT+02:00 Mark Thomas : > > The proposed Apache Tomcat 9.0.0.M15 release is now available for voting. > > This is a milestone release for the 9.0.x branch. It should be > noted that, as a milestone release: > - Servlet 4.0 is not finalised > - The EGs have

Re: [VOTE] Release Apache Tomcat 8.5.9

2016-12-06 Thread Emmanuel Bourg
Le 5/12/2016 à 21:44, Mark Thomas a écrit : > [X] Stable - go ahead and release as 8.5.8 I successfully ran the the NIO/NIO2/APR test suites on Debian with OpenJDK 8u111. Emmanuel Bourg - To unsubscribe, e-mail: