svn commit: r1789031 - /tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/AbstractInputBuffer.java

2017-03-27 Thread markt
Author: markt Date: Mon Mar 27 23:41:46 2017 New Revision: 1789031 URL: http://svn.apache.org/viewvc?rev=1789031=rev Log: Formatting Modified: tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/AbstractInputBuffer.java Modified:

[Bug 60925] Running with SecurityManager - Property 'serverInfo' not found on type org.apache.catalina.core.ApplicationContextFacade

2017-03-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60925 --- Comment #2 from Konstantin Kolinko --- I think that this is triggered by the change in r1784768, that changed inheritance hierarchy in ApplicationContextFacade and the cause is that the solution implemented in

[Bug 60926] New: Servlet 4 method ApplicationContextFacade.setSessionTimeout() calls wrong method

2017-03-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60926 Bug ID: 60926 Summary: Servlet 4 method ApplicationContextFacade.setSessionTimeout() calls wrong method Product: Tomcat 8 Version: 8.5.12 Hardware:

[Bug 60925] Running with SecurityManager - Property 'serverInfo' not found on type org.apache.catalina.core.ApplicationContextFacade

2017-03-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60925 Konstantin Kolinko changed: What|Removed |Added OS||All ---

[Bug 60925] New: Running with SecurityManager - Property 'serverInfo' not found on type org.apache.catalina.core.ApplicationContextFacade

2017-03-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60925 Bug ID: 60925 Summary: Running with SecurityManager - Property 'serverInfo' not found on type org.apache.catalina.core.ApplicationContextFacade Product: Tomcat 8

buildbot failure in on tomcat-6-trunk

2017-03-27 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-6-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-6-trunk/builds/215 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

svn commit: r1789024 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/

2017-03-27 Thread markt
Author: markt Date: Mon Mar 27 22:02:50 2017 New Revision: 1789024 URL: http://svn.apache.org/viewvc?rev=1789024=rev Log: Improve sendfile handling when requests are pipelined. Added: tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/SendfileKeepAliveState.java - copied unchanged

svn commit: r1789008 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/ java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/

2017-03-27 Thread markt
Author: markt Date: Mon Mar 27 20:35:27 2017 New Revision: 1789008 URL: http://svn.apache.org/viewvc?rev=1789008=rev Log: Improve sendfile handling when requests are pipelined. Added: tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/SendfileKeepAliveState.java - copied unchanged

svn commit: r1789001 - in /tomcat/tc8.5.x/trunk: build.properties.default res/maven/mvn.properties.default webapps/docs/changelog.xml

2017-03-27 Thread markt
Author: markt Date: Mon Mar 27 20:01:52 2017 New Revision: 1789001 URL: http://svn.apache.org/viewvc?rev=1789001=rev Log: Increment version for next development cycle Modified: tomcat/tc8.5.x/trunk/build.properties.default tomcat/tc8.5.x/trunk/res/maven/mvn.properties.default

svn commit: r1788999 - in /tomcat/tc8.0.x/trunk: java/org/apache/coyote/ java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/

2017-03-27 Thread markt
Author: markt Date: Mon Mar 27 19:52:30 2017 New Revision: 1788999 URL: http://svn.apache.org/viewvc?rev=1788999=rev Log: Improve sendfile handling when requests are pipelined. Added: tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/net/SendfileKeepAliveState.java (with props) Modified:

Re: [VOTE] Release Apache Tomcat 9.0.0.M19

2017-03-27 Thread Violeta Georgieva
Hi, 2017-03-27 15:56 GMT+03:00 Mark Thomas : > > The proposed Apache Tomcat 9.0.0.M19 release is now available for voting. > > This is a milestone release for the 9.0.x branch. It should be > noted that, as a milestone release: > - Servlet 4.0 is not finalised > - The EGs have

[VOTE] Release Apache Tomcat 8.5.13

2017-03-27 Thread Mark Thomas
The proposed Apache Tomcat 8.5.13 release is now available for voting. The major changes compared to the 8.5.12 release are: - Various HTTP/2 improvements - Fixes for sendfile related issues that could cause subsequent requests to experience IllegalStateExceptions - Servlet 4.0 updates It

svn commit: r18928 - in /dev/tomcat/tomcat-8/v8.5.13: ./ bin/ bin/embed/ bin/extras/ src/

2017-03-27 Thread markt
Author: markt Date: Mon Mar 27 14:54:46 2017 New Revision: 18928 Log: Upload 8.5.13 for voting Added: dev/tomcat/tomcat-8/v8.5.13/ dev/tomcat/tomcat-8/v8.5.13/KEYS dev/tomcat/tomcat-8/v8.5.13/README.html dev/tomcat/tomcat-8/v8.5.13/RELEASE-NOTES

svn commit: r1788935 - in /tomcat/tc8.5.x: TOMCAT_8_5_13/ tags/TOMCAT_8_5_13/

2017-03-27 Thread markt
Author: markt Date: Mon Mar 27 14:22:35 2017 New Revision: 1788935 URL: http://svn.apache.org/viewvc?rev=1788935=rev Log: Correct tag location Added: tomcat/tc8.5.x/tags/TOMCAT_8_5_13/ (props changed) - copied from r1788934, tomcat/tc8.5.x/TOMCAT_8_5_13/ Removed:

svn commit: r1788934 - in /tomcat/tc8.5.x/TOMCAT_8_5_13: ./ build.properties.default webapps/docs/changelog.xml

2017-03-27 Thread markt
Author: markt Date: Mon Mar 27 14:21:01 2017 New Revision: 1788934 URL: http://svn.apache.org/viewvc?rev=1788934=rev Log: Tag 8.5.13 Added: tomcat/tc8.5.x/TOMCAT_8_5_13/ (props changed) - copied from r1788933, tomcat/tc8.5.x/trunk/ Modified:

svn commit: r1788932 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/coyote/ java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/

2017-03-27 Thread markt
Author: markt Date: Mon Mar 27 13:56:40 2017 New Revision: 1788932 URL: http://svn.apache.org/viewvc?rev=1788932=rev Log: Improve sendfile handling when requests are pipelined. Added: tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/net/SendfileKeepAliveState.java (with props) Modified:

[Bug 60750] A response that uses Transfer-Encoding: chunked is missing the last zero-length chunk

2017-03-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60750 --- Comment #23 from Mark Thomas --- As does 8.5.x -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail:

[Bug 60362] Missing reason phrase in response

2017-03-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60362 --- Comment #46 from Remy Maucherat --- Ok, it's a good compromise then if 8.0 indeed does not go on (I'll believe that when it actually happens ;) ). -- You are receiving this mail because: You are the assignee for the bug.

[VOTE] Release Apache Tomcat 9.0.0.M19

2017-03-27 Thread Mark Thomas
The proposed Apache Tomcat 9.0.0.M19 release is now available for voting. This is a milestone release for the 9.0.x branch. It should be noted that, as a milestone release: - Servlet 4.0 is not finalised - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0 The major changes

svn commit: r1788927 - /tomcat/trunk/webapps/docs/changelog.xml

2017-03-27 Thread markt
Author: markt Date: Mon Mar 27 12:55:53 2017 New Revision: 1788927 URL: http://svn.apache.org/viewvc?rev=1788927=rev Log: Increment version for next development cycle Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL:

svn commit: r1788926 - in /tomcat/trunk: build.properties.default res/maven/mvn.properties.default

2017-03-27 Thread markt
Author: markt Date: Mon Mar 27 12:55:04 2017 New Revision: 1788926 URL: http://svn.apache.org/viewvc?rev=1788926=rev Log: Increment version for next development cycle Modified: tomcat/trunk/build.properties.default tomcat/trunk/res/maven/mvn.properties.default Modified:

svn commit: r18927 - in /dev/tomcat/tomcat-9/v9.0.0.M19: ./ bin/ bin/embed/ bin/extras/ src/

2017-03-27 Thread markt
Author: markt Date: Mon Mar 27 12:52:30 2017 New Revision: 18927 Log: Upload 9.0.0.M19 for voting Added: dev/tomcat/tomcat-9/v9.0.0.M19/ dev/tomcat/tomcat-9/v9.0.0.M19/KEYS dev/tomcat/tomcat-9/v9.0.0.M19/README.html dev/tomcat/tomcat-9/v9.0.0.M19/RELEASE-NOTES

svn commit: r1788909 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/http/HttpMessages.java

2017-03-27 Thread violetagg
Author: violetagg Date: Mon Mar 27 11:52:06 2017 New Revision: 1788909 URL: http://svn.apache.org/viewvc?rev=1788909=rev Log: Add 500 ISE to the most common reason phrases that can happen. Modified: tomcat/tc7.0.x/trunk/ (props changed)

svn commit: r1788908 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/util/http/HttpMessages.java

2017-03-27 Thread violetagg
Author: violetagg Date: Mon Mar 27 11:49:52 2017 New Revision: 1788908 URL: http://svn.apache.org/viewvc?rev=1788908=rev Log: Add 500 ISE to the most common reason phrases that can happen. Modified: tomcat/tc8.0.x/trunk/ (props changed)

svn commit: r1788905 - /tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/http/HttpMessages.java

2017-03-27 Thread violetagg
Author: violetagg Date: Mon Mar 27 11:40:44 2017 New Revision: 1788905 URL: http://svn.apache.org/viewvc?rev=1788905=rev Log: Add 500 ISE to the most common reason phrases that can happen. Modified: tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/http/HttpMessages.java Modified:

[Bug 60362] Missing reason phrase in response

2017-03-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60362 Violeta Georgieva changed: What|Removed |Added Resolution|--- |FIXED

svn commit: r1788896 - in /tomcat/tags/TOMCAT_9_0_0_M19: ./ build.properties.default webapps/docs/changelog.xml

2017-03-27 Thread markt
Author: markt Date: Mon Mar 27 11:13:25 2017 New Revision: 1788896 URL: http://svn.apache.org/viewvc?rev=1788896=rev Log: Tag 9.0.0.M19 Added: tomcat/tags/TOMCAT_9_0_0_M19/ - copied from r1788895, tomcat/trunk/ Modified: tomcat/tags/TOMCAT_9_0_0_M19/build.properties.default

[Bug 60750] A response that uses Transfer-Encoding: chunked is missing the last zero-length chunk

2017-03-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60750 --- Comment #22 from Mark Thomas --- 9.0.x behaves as expected and closes the connection without a final chunk. -- You are receiving this mail because: You are the assignee for the bug.

buildbot success in on tomcat-trunk

2017-03-27 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/2226 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

svn commit: r1788890 - in /tomcat/trunk: java/org/apache/coyote/ java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/

2017-03-27 Thread markt
Author: markt Date: Mon Mar 27 10:59:54 2017 New Revision: 1788890 URL: http://svn.apache.org/viewvc?rev=1788890=rev Log: Improve sendfile handling when requests are pipelined. Added: tomcat/trunk/java/org/apache/tomcat/util/net/SendfileKeepAliveState.java (with props) Modified:

svn commit: r1788884 - in /tomcat/tc8.5.x/trunk: ./ webapps/docs/changelog.xml

2017-03-27 Thread violetagg
Author: violetagg Date: Mon Mar 27 10:52:07 2017 New Revision: 174 URL: http://svn.apache.org/viewvc?rev=174=rev Log: Fixes having an issue number are sorted by their number, ascending. Modified: tomcat/tc8.5.x/trunk/ (props changed)

svn commit: r1788883 - /tomcat/trunk/webapps/docs/changelog.xml

2017-03-27 Thread violetagg
Author: violetagg Date: Mon Mar 27 10:46:45 2017 New Revision: 173 URL: http://svn.apache.org/viewvc?rev=173=rev Log: Fixes having an issue number are sorted by their number, ascending. Modified: tomcat/trunk/webapps/docs/changelog.xml Modified:

svn commit: r1788882 - /tomcat/tc8.5.x/trunk/java/org/apache/coyote/AbstractProtocol.java

2017-03-27 Thread violetagg
Author: violetagg Date: Mon Mar 27 10:40:42 2017 New Revision: 172 URL: http://svn.apache.org/viewvc?rev=172=rev Log: ws police Modified: tomcat/tc8.5.x/trunk/java/org/apache/coyote/AbstractProtocol.java Modified: tomcat/tc8.5.x/trunk/java/org/apache/coyote/AbstractProtocol.java

svn commit: r1788881 - in /tomcat/tc8.5.x/trunk: java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/tomcat/util/http/ java/org/apache/tomcat/util/http/r

2017-03-27 Thread violetagg
Author: violetagg Date: Mon Mar 27 10:38:29 2017 New Revision: 171 URL: http://svn.apache.org/viewvc?rev=171=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60362 Add a new Connector configuration sendReasonPhrase. When this attribute is set to true, a reason phrase will be

[Bug 60918] Process Send File releases the same Http11Processor in two threads, leading to java.lang.IllegalStateException: Unexpected state: headers already parsed. Buffer not recycled?

2017-03-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60918 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED

[Bug 60854] Unintended JSESSIONID value change

2017-03-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60854 Mark Thomas changed: What|Removed |Added Resolution|--- |WONTFIX

[Bug 60362] Missing reason phrase in response

2017-03-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60362 --- Comment #44 from mgrigorov --- +1 for the change! -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe,

buildbot failure in on tomcat-trunk

2017-03-27 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/2225 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

svn commit: r1788861 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/coyote/http2/ConnectionException.java java/org/apache/coyote/http2/Http2Exception.java java/org/apache/coyote/http2/Http2Parser.java

2017-03-27 Thread markt
Author: markt Date: Mon Mar 27 09:23:46 2017 New Revision: 1788861 URL: http://svn.apache.org/viewvc?rev=1788861=rev Log: Improve debug logging for HPACK errors. Expose rather than swallow HpackException Modified: tomcat/tc8.5.x/trunk/ (props changed)

svn commit: r1788860 - in /tomcat/trunk/java/org/apache/coyote/http2: ConnectionException.java Http2Exception.java Http2Parser.java

2017-03-27 Thread markt
Author: markt Date: Mon Mar 27 09:22:08 2017 New Revision: 1788860 URL: http://svn.apache.org/viewvc?rev=1788860=rev Log: Improve debug logging for HPACK errors. Expose rather than swallow HpackException Modified: tomcat/trunk/java/org/apache/coyote/http2/ConnectionException.java

svn commit: r1788853 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/coyote/http2/HpackDecoder.java

2017-03-27 Thread markt
Author: markt Date: Mon Mar 27 09:15:20 2017 New Revision: 1788853 URL: http://svn.apache.org/viewvc?rev=1788853=rev Log: Header table size agreed in HPACK should never exceed limit set by HTTP/2. Use separate hard/soft limits to track the two. Found with the h2spec tool written by Moto

svn commit: r1788852 - /tomcat/trunk/java/org/apache/coyote/http2/HpackDecoder.java

2017-03-27 Thread markt
Author: markt Date: Mon Mar 27 09:14:45 2017 New Revision: 1788852 URL: http://svn.apache.org/viewvc?rev=1788852=rev Log: Header table size agreed in HPACK should never exceed limit set by HTTP/2. Use separate hard/soft limits to track the two. Found with the h2spec tool written by Moto

[Bug 58433] RemoteIpValve not activated on redirect from mapping

2017-03-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58433 gonzalad changed: What|Removed |Added CC|

[Bug 60362] Missing reason phrase in response

2017-03-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60362 --- Comment #43 from Violeta Georgieva --- (In reply to Remy Maucherat from comment #42) > Ok, I thought the 8.0 plan was long gone. But the patch is only for 8.5 then > ? If so, then I can withdraw the -1. The patch is

[Bug 60362] Missing reason phrase in response

2017-03-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60362 --- Comment #42 from Remy Maucherat --- Ok, I thought the 8.0 plan was long gone. But the patch is only for 8.5 then ? If so, then I can withdraw the -1. -- You are receiving this mail because: You are the assignee for the

svn commit: r1788843 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/coyote/http2/Http2UpgradeHandler.java java/org/apache/coyote/http2/LocalStrings.properties java/org/apache/coyote/http2/Stream.java

2017-03-27 Thread markt
Author: markt Date: Mon Mar 27 08:13:35 2017 New Revision: 1788843 URL: http://svn.apache.org/viewvc?rev=1788843=rev Log: Total data sent should agree with any content-length header Found with the h2spec tool written by Moto Ishizawa. Modified: tomcat/tc8.5.x/trunk/ (props changed)

[Bug 60362] Missing reason phrase in response

2017-03-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60362 --- Comment #41 from Mark Thomas --- One of the main reasons 8.0.x is maintained is because this option isn't available in 8.5.x. (The other is the sendfile issues which I think we are getting to the bottom of). The patch

svn commit: r1788841 - in /tomcat/trunk/java/org/apache/coyote/http2: Http2UpgradeHandler.java LocalStrings.properties Stream.java StreamProcessor.java

2017-03-27 Thread markt
Author: markt Date: Mon Mar 27 08:02:38 2017 New Revision: 1788841 URL: http://svn.apache.org/viewvc?rev=1788841=rev Log: Total data sent should agree with any content-length header Found with the h2spec tool written by Moto Ishizawa. Modified:

[Bug 60362] Missing reason phrase in response

2017-03-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60362 --- Comment #40 from Remy Maucherat --- -1. It should be removed at some point, so let it be now. It turns out (given what I see) that we're going to maintain 7.0 and 8.0 for at least as long as 8.5, so it's good enough. --

[Bug 60362] Missing reason phrase in response

2017-03-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60362 --- Comment #39 from Violeta Georgieva --- Hi, I created a patch that adds an option for sending a reason phrase with the response. https://github.com/apache/tomcat85/pull/7 By default a reason phrase will not be sent

Re: svn commit: r1788771 - in /tomcat/trunk/java/org/apache/coyote/http2: LocalStrings.properties Stream.java

2017-03-27 Thread Mark Thomas
On 26/03/17 20:37, Martin Grigorov wrote: >> Author: markt >> Date: Sun Mar 26 19:31:25 2017 >> New Revision: 1788771 > Small typo in "tohave" - misses space. Thanks for pointing that out. Fixed. Mark - To unsubscribe,

svn commit: r1788835 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/coyote/http2/LocalStrings.properties

2017-03-27 Thread markt
Author: markt Date: Mon Mar 27 07:20:01 2017 New Revision: 1788835 URL: http://svn.apache.org/viewvc?rev=1788835=rev Log: Fix typo Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/coyote/http2/LocalStrings.properties Propchange:

svn commit: r1788834 - /tomcat/trunk/java/org/apache/coyote/http2/LocalStrings.properties

2017-03-27 Thread markt
Author: markt Date: Mon Mar 27 07:19:34 2017 New Revision: 1788834 URL: http://svn.apache.org/viewvc?rev=1788834=rev Log: Fix typo Modified: tomcat/trunk/java/org/apache/coyote/http2/LocalStrings.properties Modified: tomcat/trunk/java/org/apache/coyote/http2/LocalStrings.properties URL: