Re: [VOTE] Release Apache Tomcat 9.0.10

2018-06-22 Thread Mark Thomas
On 22/06/18 12:40, Mark Thomas wrote: > On 22/06/18 10:20, Konstantin Kolinko wrote: >> I think that I found it: >> they are lost when you upload binaries to Maven staging repository. > > That makes sense. Sometimes I copy the files to my dist checkout and > then start Maven. Sometimes I do

svn commit: r27665 - in /dev/tomcat/tomcat-9/v9.0.10: bin/ bin/embed/ bin/extras/ src/

2018-06-22 Thread markt
Author: markt Date: Fri Jun 22 17:52:33 2018 New Revision: 27665 Log: Re-sign with correct key Modified: dev/tomcat/tomcat-9/v9.0.10/bin/apache-tomcat-9.0.10-deployer.tar.gz.asc dev/tomcat/tomcat-9/v9.0.10/bin/apache-tomcat-9.0.10-deployer.zip.asc

svn commit: r27664 - in /dev/tomcat/tomcat-8/v8.5.32: bin/ bin/embed/ bin/extras/ src/

2018-06-22 Thread markt
Author: markt Date: Fri Jun 22 17:48:57 2018 New Revision: 27664 Log: Re-sign with correct key Modified: dev/tomcat/tomcat-8/v8.5.32/bin/apache-tomcat-8.5.32-deployer.tar.gz.asc dev/tomcat/tomcat-8/v8.5.32/bin/apache-tomcat-8.5.32-deployer.zip.asc

[Bug 62312] Add Proxy Authentication support to websocket client

2018-06-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62312 --- Comment #6 from Joe Mokos --- I've made the changes you outlined in your previous comments. The diff file is against the trunk as of 6/22/2018. It also contains changes to do realm validation. Let me know if additional info is needed.

[Bug 62312] Add Proxy Authentication support to websocket client

2018-06-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62312 --- Comment #5 from Joe Mokos --- I've made the changes you outlined in your previous comments. The diff file also contains changes to do realm validation. Let me know if additional info is needed. -- You are receiving this mail because:

[Bug 62312] Add Proxy Authentication support to websocket client

2018-06-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62312 Joe Mokos changed: What|Removed |Added Attachment #35887|0 |1 is obsolete|

[Bug 62479] TLS Mutual Authentication use case: Using pkcs12 format truststore on connector yields exception "the trustAnchors parameter must be non-empty"

2018-06-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62479 --- Comment #16 from Nicolas Therrien --- Ha! I could NOT see the difference! Must have been blind to it from using version 8 for so long. Thank you for providing the information. I have verified the PKCS12 truststore is loaded successfully

Re: JDK 11 EA 18

2018-06-22 Thread William L. Thomson Jr.
On Fri, 22 Jun 2018 08:41:20 +0100 Mark Thomas wrote: > > Rather than repeating what has been said many times before, I suggest > you look in the archives for past discussions on source structure. > They are usually part of a discussion about switching to Maven as a > build system. While

Re: [VOTE] Release Apache Tomcat 8.5.32

2018-06-22 Thread Huxing Zhang
Hi, The proposed 8.5.32 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 8.5.32 Unit test passed on Java 10. Examples ok. Test web application works fine. On Thu, Jun 21, 2018 at 4:27 AM, Mark Thomas wrote: > The proposed Apache Tomcat 8.5.32 release is now

[Bug 62479] TLS Mutual Authentication use case: Using pkcs12 format truststore on connector yields exception "the trustAnchors parameter must be non-empty"

2018-06-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62479 Mark Thomas changed: What|Removed |Added Resolution|--- |INVALID Status|REOPENED

[Bug 62479] TLS Mutual Authentication use case: Using pkcs12 format truststore on connector yields exception "the trustAnchors parameter must be non-empty"

2018-06-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62479 --- Comment #15 from Konstantin Kolinko --- (In reply to Nicolas Therrien from comment #14) > truststorePasswordThe password to access the trust store. The above one is misspelled. -- You are receiving this mail because: You are the

buildbot success in on tomcat-trunk

2018-06-22 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3389 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

[Bug 62479] TLS Mutual Authentication use case: Using pkcs12 format truststore on connector yields exception "the trustAnchors parameter must be non-empty"

2018-06-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62479 Nicolas Therrien changed: What|Removed |Added Resolution|INVALID |--- Status|RESOLVED

svn commit: r1834126 - /tomcat/trunk/java/org/apache/tomcat/util/http/FastHttpDateFormat.java

2018-06-22 Thread markt
Author: markt Date: Fri Jun 22 12:38:58 2018 New Revision: 1834126 URL: http://svn.apache.org/viewvc?rev=1834126=rev Log: Fix Javadoc Modified: tomcat/trunk/java/org/apache/tomcat/util/http/FastHttpDateFormat.java Modified:

svn commit: r1834124 - in /tomcat/trunk: java/org/apache/catalina/connector/Request.java webapps/docs/default-servlet.xml webapps/docs/jasper-howto.xml webapps/docs/setup.xml

2018-06-22 Thread kkolinko
Author: kkolinko Date: Fri Jun 22 11:58:35 2018 New Revision: 1834124 URL: http://svn.apache.org/viewvc?rev=1834124=rev Log: Fix typos. Modified: tomcat/trunk/java/org/apache/catalina/connector/Request.java tomcat/trunk/webapps/docs/default-servlet.xml

svn commit: r1834123 - in /tomcat/tc8.0.x/trunk: ./ webapps/docs/rewrite.xml

2018-06-22 Thread ebourg
Author: ebourg Date: Fri Jun 22 11:55:17 2018 New Revision: 1834123 URL: http://svn.apache.org/viewvc?rev=1834123=rev Log: Fixed a broken perldoc link Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/webapps/docs/rewrite.xml Propchange: tomcat/tc8.0.x/trunk/

svn commit: r1834122 - in /tomcat/tc8.5.x/trunk: ./ webapps/docs/rewrite.xml

2018-06-22 Thread ebourg
Author: ebourg Date: Fri Jun 22 11:54:10 2018 New Revision: 1834122 URL: http://svn.apache.org/viewvc?rev=1834122=rev Log: Fixed a broken perldoc link Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/webapps/docs/rewrite.xml Propchange: tomcat/tc8.5.x/trunk/

svn commit: r1834121 - in /tomcat/tc8.5.x/trunk/modules/jdbc-pool: build.xml doc/jdbc-pool.xml

2018-06-22 Thread ebourg
Author: ebourg Date: Fri Jun 22 11:52:32 2018 New Revision: 1834121 URL: http://svn.apache.org/viewvc?rev=1834121=rev Log: Fixed several links pointing to the documentation of older Tomcat releases (more) Modified: tomcat/tc8.5.x/trunk/modules/jdbc-pool/build.xml

svn commit: r1834120 - in /tomcat/tc7.0.x/trunk: ./ modules/jdbc-pool/build.xml

2018-06-22 Thread ebourg
Author: ebourg Date: Fri Jun 22 11:50:41 2018 New Revision: 1834120 URL: http://svn.apache.org/viewvc?rev=1834120=rev Log: Fixed several links pointing to the documentation of older Tomcat releases Modified: tomcat/tc7.0.x/trunk/ (props changed)

svn commit: r1834119 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/ant/jmx/package.html java/org/apache/catalina/ant/package.html modules/jdbc-pool/build.xml

2018-06-22 Thread ebourg
Author: ebourg Date: Fri Jun 22 11:47:07 2018 New Revision: 1834119 URL: http://svn.apache.org/viewvc?rev=1834119=rev Log: Fixed several links pointing to the documentation of older Tomcat releases Modified: tomcat/tc8.0.x/trunk/ (props changed)

svn commit: r1834118 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/ant/jmx/package.html java/org/apache/catalina/ant/package.html modules/jdbc-pool/build.xml modules/jdbc-pool/doc/jdbc-pool.

2018-06-22 Thread ebourg
Author: ebourg Date: Fri Jun 22 11:43:42 2018 New Revision: 1834118 URL: http://svn.apache.org/viewvc?rev=1834118=rev Log: Fixed several links pointing to the documentation of older Tomcat releases Modified: tomcat/tc8.5.x/trunk/ (props changed)

buildbot failure in on tomcat-trunk

2018-06-22 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3387 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

svn commit: r1834116 - in /tomcat/tc8.0.x/trunk: ./ BUILDING.txt build.xml modules/jdbc-pool/build.properties.default modules/jdbc-pool/build.xml webapps/docs/building.xml webapps/docs/changelog.xml

2018-06-22 Thread ebourg
Author: ebourg Date: Fri Jun 22 11:40:29 2018 New Revision: 1834116 URL: http://svn.apache.org/viewvc?rev=1834116=rev Log: Added the new javac release attribute to be able to build Tomcat with recent JDKs without compromising the compatibility with older versions (requires Ant 1.9.8 or later)

Re: [VOTE] Release Apache Tomcat 9.0.10

2018-06-22 Thread Mark Thomas
On 22/06/18 10:20, Konstantin Kolinko wrote: > 2018-06-22 11:41 GMT+03:00 Konstantin Kolinko : >> 2018-06-22 11:03 GMT+03:00 Mark Thomas : >>> On 22/06/18 00:25, Konstantin Kolinko wrote: 2018-06-20 22:45 GMT+03:00 Mark Thomas : > The proposed Apache Tomcat 9.0.10 release is now available

svn commit: r1834114 - in /tomcat/trunk: java/org/apache/catalina/authenticator/ java/org/apache/catalina/connector/ java/org/apache/catalina/filters/ java/org/apache/catalina/servlets/ java/org/apach

2018-06-22 Thread markt
Author: markt Date: Fri Jun 22 11:36:01 2018 New Revision: 1834114 URL: http://svn.apache.org/viewvc?rev=1834114=rev Log: Refactor HTTP date creation and parsing to reduce code duplication, reduce the use of ThreadLocals and to increase the use of caching. Added:

svn commit: r1834113 - in /tomcat/tc8.5.x/trunk: ./ BUILDING.txt build.xml modules/jdbc-pool/build.properties.default modules/jdbc-pool/build.xml webapps/docs/building.xml webapps/docs/changelog.xml

2018-06-22 Thread ebourg
Author: ebourg Date: Fri Jun 22 11:33:23 2018 New Revision: 1834113 URL: http://svn.apache.org/viewvc?rev=1834113=rev Log: Added the new javac release attribute to be able to build Tomcat with recent JDKs without compromising the compatibility with older versions (requires Ant 1.9.8 or later)

Re: svn commit: r1834060 - in /tomcat/tc8.5.x/trunk: ./ build.xml

2018-06-22 Thread Rainer Jung
Thanks for the info. I wasn't expecting that. Will check the file tomorrow (can't do it right now). Hopefully that will be in time before a 7.0 gets cut. For 8.5 the tag was before the inclusion of the md README file. Thanks and regards, Rainer Am 22.06.2018 um 00:11 schrieb Konstantin

Re: [VOTE] Release Apache Tomcat 8.5.32

2018-06-22 Thread Konstantin Kolinko
2018-06-20 23:27 GMT+03:00 Mark Thomas : > The proposed Apache Tomcat 8.5.32 release is now available for voting. > > The proposed 8.5.32 release is: > [ ] Broken - do not release > [x] Stable - go ahead and release as 8.5.32 1. Smoke testing: OK 2. Unit tests (Java 8u172, Java 7u80 (32-bit) x

Re: [VOTE] Release Apache Tomcat 9.0.10

2018-06-22 Thread Konstantin Kolinko
2018-06-20 22:45 GMT+03:00 Mark Thomas : > The proposed Apache Tomcat 9.0.10 release is now available for voting. > > The proposed 9.0.10 release is: > [ ] Broken - do not release > [x] Stable - go ahead and release as 9.0.10 1. Smoke testing: OK 2. Unit tests (Java 8u172 32-bit x All

Re: [VOTE] Release Apache Tomcat 9.0.10

2018-06-22 Thread Konstantin Kolinko
2018-06-22 11:41 GMT+03:00 Konstantin Kolinko : > 2018-06-22 11:03 GMT+03:00 Mark Thomas : >> On 22/06/18 00:25, Konstantin Kolinko wrote: >>> 2018-06-20 22:45 GMT+03:00 Mark Thomas : The proposed Apache Tomcat 9.0.10 release is now available for voting. >>> >>> I have not tested this

Re: [VOTE] Release Apache Tomcat 9.0.10

2018-06-22 Thread Konstantin Kolinko
2018-06-22 11:03 GMT+03:00 Mark Thomas : > On 22/06/18 00:25, Konstantin Kolinko wrote: >> 2018-06-20 22:45 GMT+03:00 Mark Thomas : >>> The proposed Apache Tomcat 9.0.10 release is now available for voting. >>> >> >> I have not tested this version yet (running 8.5 tests now), but I note >> that

svn commit: r1834080 - /tomcat/trunk/modules/jdbc-pool/build.properties.default

2018-06-22 Thread ebourg
Author: ebourg Date: Fri Jun 22 08:03:21 2018 New Revision: 1834080 URL: http://svn.apache.org/viewvc?rev=1834080=rev Log: Fixed the java release version for the jdbc-pool module Modified: tomcat/trunk/modules/jdbc-pool/build.properties.default Modified:

Re: [VOTE] Release Apache Tomcat 9.0.10

2018-06-22 Thread Mark Thomas
On 22/06/18 00:25, Konstantin Kolinko wrote: > 2018-06-20 22:45 GMT+03:00 Mark Thomas : >> The proposed Apache Tomcat 9.0.10 release is now available for voting. >> > > I have not tested this version yet (running 8.5 tests now), but I note > that the following *.asc files are missing, > both in

svn commit: r27648 - in /dev/tomcat/tomcat-8/v8.5.32/bin: apache-tomcat-8.5.32.tar.gz.asc apache-tomcat-8.5.32.zip.asc

2018-06-22 Thread markt
Author: markt Date: Fri Jun 22 08:01:49 2018 New Revision: 27648 Log: Add missing sigs Added: dev/tomcat/tomcat-8/v8.5.32/bin/apache-tomcat-8.5.32.tar.gz.asc dev/tomcat/tomcat-8/v8.5.32/bin/apache-tomcat-8.5.32.zip.asc Added:

svn commit: r27649 - in /dev/tomcat/tomcat-9/v9.0.10/bin: apache-tomcat-9.0.10.tar.gz.asc apache-tomcat-9.0.10.zip.asc

2018-06-22 Thread markt
Author: markt Date: Fri Jun 22 08:02:02 2018 New Revision: 27649 Log: Add missing sigs Added: dev/tomcat/tomcat-9/v9.0.10/bin/apache-tomcat-9.0.10.tar.gz.asc dev/tomcat/tomcat-9/v9.0.10/bin/apache-tomcat-9.0.10.zip.asc Added:

svn commit: r1834079 [2/3] - in /tomcat/tc7.0.x/trunk: ./ bin/ java/org/apache/catalina/ant/ java/org/apache/catalina/ant/jmx/ java/org/apache/catalina/core/ java/org/apache/catalina/filters/ java/org

2018-06-22 Thread ebourg
Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/filters/RemoteIpFilter.java URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/filters/RemoteIpFilter.java?rev=1834079=1834078=1834079=diff

svn commit: r1834079 [1/3] - in /tomcat/tc7.0.x/trunk: ./ bin/ java/org/apache/catalina/ant/ java/org/apache/catalina/ant/jmx/ java/org/apache/catalina/core/ java/org/apache/catalina/filters/ java/org

2018-06-22 Thread ebourg
Author: ebourg Date: Fri Jun 22 07:57:00 2018 New Revision: 1834079 URL: http://svn.apache.org/viewvc?rev=1834079=rev Log: Use https URLs in the documentation when possible Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/BUILDING.txt

svn commit: r1834079 [3/3] - in /tomcat/tc7.0.x/trunk: ./ bin/ java/org/apache/catalina/ant/ java/org/apache/catalina/ant/jmx/ java/org/apache/catalina/core/ java/org/apache/catalina/filters/ java/org

2018-06-22 Thread ebourg
Modified: tomcat/tc7.0.x/trunk/res/welcome.bin.html URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/res/welcome.bin.html?rev=1834079=1834078=1834079=diff == --- tomcat/tc7.0.x/trunk/res/welcome.bin.html (original)

Re: JDK 11 EA 18

2018-06-22 Thread Mark Thomas
On 21/06/18 02:21, William L. Thomson Jr. wrote: > Turns out my issues were due to resources ending up in a sub-directory, > prefixed with java/org, like find out in sources. One aspect I would > like to see done if possible. Tomcat mixes a lot of stuff into the same > directories. Its layout and

[Bug 62479] TLS Mutual Authentication use case: Using pkcs12 format truststore on connector yields exception "the trustAnchors parameter must be non-empty"

2018-06-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62479 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

svn commit: r1834077 [1/3] - in /tomcat/tc8.0.x/trunk: ./ bin/ java/org/apache/catalina/ant/ java/org/apache/catalina/ant/jmx/ java/org/apache/catalina/core/ java/org/apache/catalina/filters/ java/org

2018-06-22 Thread ebourg
Author: ebourg Date: Fri Jun 22 07:18:43 2018 New Revision: 1834077 URL: http://svn.apache.org/viewvc?rev=1834077=rev Log: Use https URLs in the documentation when possible Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/BUILDING.txt

svn commit: r1834077 [3/3] - in /tomcat/tc8.0.x/trunk: ./ bin/ java/org/apache/catalina/ant/ java/org/apache/catalina/ant/jmx/ java/org/apache/catalina/core/ java/org/apache/catalina/filters/ java/org

2018-06-22 Thread ebourg
Modified: tomcat/tc8.0.x/trunk/webapps/docs/jndi-resources-howto.xml URL: http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/webapps/docs/jndi-resources-howto.xml?rev=1834077=1834076=1834077=diff == ---

svn commit: r1834077 [2/3] - in /tomcat/tc8.0.x/trunk: ./ bin/ java/org/apache/catalina/ant/ java/org/apache/catalina/ant/jmx/ java/org/apache/catalina/core/ java/org/apache/catalina/filters/ java/org

2018-06-22 Thread ebourg
Modified: tomcat/tc8.0.x/trunk/modules/jdbc-pool/doc/jdbc-pool.xml URL: http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/modules/jdbc-pool/doc/jdbc-pool.xml?rev=1834077=1834076=1834077=diff == ---

svn commit: r1834075 [1/3] - in /tomcat/tc8.5.x/trunk: ./ bin/ java/org/apache/catalina/ant/ java/org/apache/catalina/ant/jmx/ java/org/apache/catalina/core/ java/org/apache/catalina/filters/ java/org

2018-06-22 Thread ebourg
Author: ebourg Date: Fri Jun 22 06:53:29 2018 New Revision: 1834075 URL: http://svn.apache.org/viewvc?rev=1834075=rev Log: Use https URLs in the documentation when possible Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/BUILDING.txt

svn commit: r1834075 [3/3] - in /tomcat/tc8.5.x/trunk: ./ bin/ java/org/apache/catalina/ant/ java/org/apache/catalina/ant/jmx/ java/org/apache/catalina/core/ java/org/apache/catalina/filters/ java/org

2018-06-22 Thread ebourg
Modified: tomcat/tc8.5.x/trunk/webapps/docs/jndi-resources-howto.xml URL: http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/webapps/docs/jndi-resources-howto.xml?rev=1834075=1834074=1834075=diff == ---

svn commit: r1834075 [2/3] - in /tomcat/tc8.5.x/trunk: ./ bin/ java/org/apache/catalina/ant/ java/org/apache/catalina/ant/jmx/ java/org/apache/catalina/core/ java/org/apache/catalina/filters/ java/org

2018-06-22 Thread ebourg
Modified: tomcat/tc8.5.x/trunk/modules/jdbc-pool/doc/package.xsl URL: http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/modules/jdbc-pool/doc/package.xsl?rev=1834075=1834074=1834075=diff == ---

svn commit: r1834074 - in /tomcat/tc8.0.x/trunk: ./ BUILDING.txt

2018-06-22 Thread ebourg
Author: ebourg Date: Fri Jun 22 06:42:18 2018 New Revision: 1834074 URL: http://svn.apache.org/viewvc?rev=1834074=rev Log: Updated the Cobertura URL Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/BUILDING.txt Propchange: tomcat/tc8.0.x/trunk/

svn commit: r1834073 - in /tomcat/tc8.5.x/trunk: ./ BUILDING.txt

2018-06-22 Thread ebourg
Author: ebourg Date: Fri Jun 22 06:40:47 2018 New Revision: 1834073 URL: http://svn.apache.org/viewvc?rev=1834073=rev Log: Updated the Cobertura URL Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/BUILDING.txt Propchange: tomcat/tc8.5.x/trunk/