Re: [PROPOSAL] Manager behaviour clarification for 9.0.x

2016-01-08 Thread Konstantin Kolinko
2016-01-08 20:26 GMT+03:00 Mark Thomas : > On 08/01/2016 16:56, Konstantin Kolinko wrote: >> 2016-01-08 15:33 GMT+03:00 Mark Thomas : >>> I've been looking at the relationship between a Context and its Manager >>> and I have identified some inconsistencies in

[PROPOSAL] Manager behaviour clarification for 9.0.x

2016-01-08 Thread Mark Thomas
I've been looking at the relationship between a Context and its Manager and I have identified some inconsistencies in the underlying assumptions on which the code is based. A. Context is always set In some places the code carefully checks to see if the Context is null. In other places (often in

Re: [PROPOSAL] Manager behaviour clarification for 9.0.x

2016-01-08 Thread Konstantin Kolinko
2016-01-08 15:33 GMT+03:00 Mark Thomas : > I've been looking at the relationship between a Context and its Manager > and I have identified some inconsistencies in the underlying assumptions > on which the code is based. > > A. Context is always set > In some places the code

Re: [PROPOSAL] Manager behaviour clarification for 9.0.x

2016-01-08 Thread Mark Thomas
On 08/01/2016 16:56, Konstantin Kolinko wrote: > 2016-01-08 15:33 GMT+03:00 Mark Thomas : >> I've been looking at the relationship between a Context and its Manager >> and I have identified some inconsistencies in the underlying assumptions >> on which the code is based. >> >> A.

Re: [PROPOSAL] Manager behaviour clarification for 9.0.x

2016-01-08 Thread Christopher Schultz
Mark, On 1/8/16 7:33 AM, Mark Thomas wrote: > I've been looking at the relationship between a Context and its Manager > and I have identified some inconsistencies in the underlying assumptions > on which the code is based. > > A. Context is always set > In some places the code carefully checks

Re: [PROPOSAL] Manager behaviour clarification for 9.0.x

2016-01-08 Thread Rémy Maucherat
2016-01-08 13:33 GMT+01:00 Mark Thomas : > My preference is for 1. It is less work, Tomcat currently never changes > the Context and I can't see a viable use case for wanting to do so. > No problem, that's the best solution. Rémy