svn commit: r1459031 - in /tomcat/trunk/java/org/apache/catalina: authenticator/BasicAuthenticator.java authenticator/SpnegoAuthenticator.java realm/JNDIRealm.java util/Base64.java

2013-03-20 Thread markt
Author: markt Date: Wed Mar 20 20:22:42 2013 New Revision: 1459031 URL: http://svn.apache.org/r1459031 Log: Deprecate Base64 and switch to DatatypeConverter Modified: tomcat/trunk/java/org/apache/catalina/authenticator/BasicAuthenticator.java

Re: svn commit: r1459031 - in /tomcat/trunk/java/org/apache/catalina: authenticator/BasicAuthenticator.java authenticator/SpnegoAuthenticator.java realm/JNDIRealm.java util/Base64.java

2013-03-20 Thread Konstantin Kolinko
1. I do not like that you need to convert chunks to Strings to call that API. Though in this particular case the strings should be short enough for it to do not matter. 2. I think we should not blindly cache authentication strings, even if it costs some performance. I think such things should