Re: svn commit: r1703866 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/websocket/WsFrameBase.java java/org/apache/tomcat/websocket/WsFrameClient.java java/org/apache/tomcat/websocket/WsSession

2015-09-18 Thread Yilong Li
Hi Mark, I think these are false positives because the completion handler is only called after the IO operation completes. There is an implicit happens-before order here. I have fixed these false positives recently. That's why I didn't report them in BZ. Could you try the latest version of

Re: svn commit: r1703866 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/websocket/WsFrameBase.java java/org/apache/tomcat/websocket/WsFrameClient.java java/org/apache/tomcat/websocket/WsSession

2015-09-18 Thread Yilong Li
Are you using the 1.7-SNAPSHOT downloaded recently? It's frequently updated. If that's the case, then it's probably a real race and I have to take a closer look. Thanks, Yilong On Fri, Sep 18, 2015 at 7:43 AM, Mark Thomas wrote: > On 18/09/2015 15:27, Yilong Li wrote: > > Hi

Re: svn commit: r1703866 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/websocket/WsFrameBase.java java/org/apache/tomcat/websocket/WsFrameClient.java java/org/apache/tomcat/websocket/WsSession

2015-09-18 Thread Mark Thomas
On 18/09/2015 15:51, Yilong Li wrote: > Are you using the 1.7-SNAPSHOT downloaded recently? It's frequently > updated. If that's the case, then it's probably a real race and I have to > take a closer look. Downloaded at around 10.30 UTC today. The races looked plausible. There was an obvious

Re: svn commit: r1703866 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/websocket/WsFrameBase.java java/org/apache/tomcat/websocket/WsFrameClient.java java/org/apache/tomcat/websocket/WsSession

2015-09-18 Thread Mark Thomas
On 18/09/2015 15:27, Yilong Li wrote: > Hi Mark, > > I think these are false positives because the completion handler is only > called after the IO operation completes. There is an implicit > happens-before order here. I have fixed these false positives recently. > That's why I didn't report them

Re: svn commit: r1703866 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/websocket/WsFrameBase.java java/org/apache/tomcat/websocket/WsFrameClient.java java/org/apache/tomcat/websocket/WsSession

2015-09-18 Thread Yilong Li
Yes, you are right. These are real. I didn't rerun the entire test suite after fixing the obvious false positives. Yilong On Fri, Sep 18, 2015 at 7:58 AM, Mark Thomas wrote: > On 18/09/2015 15:51, Yilong Li wrote: > > Are you using the 1.7-SNAPSHOT downloaded recently? It's