Author: kfujino Date: Mon Oct 19 04:39:05 2015 New Revision: 1709345 URL: http://svn.apache.org/viewvc?rev=1709345&view=rev Log: Because already holding a lock of session objects, remove unnecessary synchronize block of DeltaRequest.
Modified: tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java Modified: tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java?rev=1709345&r1=1709344&r2=1709345&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java (original) +++ tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java Mon Oct 19 04:39:05 2015 @@ -993,17 +993,15 @@ public class DeltaManager extends Cluste } DeltaRequest deltaRequest = session.getDeltaRequest(); session.lock(); - synchronized(deltaRequest) { - if (deltaRequest.getSize() > 0) { - counterSend_EVT_SESSION_DELTA++; - byte[] data = serializeDeltaRequest(session,deltaRequest); - msg = new SessionMessageImpl(getName(), - SessionMessage.EVT_SESSION_DELTA, - data, - sessionId, - sessionId + "-" + System.currentTimeMillis()); - session.resetDeltaRequest(); - } + if (deltaRequest.getSize() > 0) { + counterSend_EVT_SESSION_DELTA++; + byte[] data = serializeDeltaRequest(session,deltaRequest); + msg = new SessionMessageImpl(getName(), + SessionMessage.EVT_SESSION_DELTA, + data, + sessionId, + sessionId + "-" + System.currentTimeMillis()); + session.resetDeltaRequest(); } } catch (IOException x) { log.error(sm.getString("deltaManager.createMessage.unableCreateDeltaRequest", --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org