[Bug 60035] java.io.IOException: Too many open files

2016-08-26 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60035 --- Comment #5 from Mark Thomas --- I think I have been able to reproduce this: - Run Tomcat on machine 1 - Run abs test on machine 2 - Disable network on machine 1 Often, but not always, this leaves sockets open. I've

Re: svn commit: r1757813 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AprEndpoint.java Nio2Endpoint.java NioEndpoint.java SocketWrapperBase.java

2016-08-26 Thread Violeta Georgieva
Hi Remy, 2016-08-26 15:06 GMT+03:00 Rémy Maucherat : > > 2016-08-26 12:23 GMT+02:00 : > > > Author: violetagg > > Date: Fri Aug 26 10:23:15 2016 > > New Revision: 1757813 > > > > URL: http://svn.apache.org/viewvc?rev=1757813=rev > > Log: > > Introduce a new

svn commit: r1757790 - /tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapperBase.java

2016-08-26 Thread violetagg
Author: violetagg Date: Fri Aug 26 08:12:23 2016 New Revision: 1757790 URL: http://svn.apache.org/viewvc?rev=1757790=rev Log: Format the code. No functional changes. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapperBase.java Modified:

svn commit: r1757853 - in /tomcat/trunk: java/org/apache/tomcat/util/net/Nio2Endpoint.java webapps/docs/changelog.xml

2016-08-26 Thread remm
Author: remm Date: Fri Aug 26 13:58:33 2016 New Revision: 1757853 URL: http://svn.apache.org/viewvc?rev=1757853=rev Log: Looking at things after reading the comment in BZ60035. The status should be ERROR, it was probably a cut and paste error. Modified:

svn commit: r1757854 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/Nio2Endpoint.java webapps/docs/changelog.xml

2016-08-26 Thread remm
Author: remm Date: Fri Aug 26 14:00:33 2016 New Revision: 1757854 URL: http://svn.apache.org/viewvc?rev=1757854=rev Log: The status should be ERROR, it was probably a cut and paste error. Modified: tomcat/tc8.5.x/trunk/ (props changed)

[Bug 60033] Jar scanning not handling properly Manifest class-path attribute

2016-08-26 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60033 Olivier Peyrusse changed: What|Removed |Added Status|RESOLVED|REOPENED

svn commit: r1757799 - /tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapperBase.java

2016-08-26 Thread violetagg
Author: violetagg Date: Fri Aug 26 09:10:46 2016 New Revision: 1757799 URL: http://svn.apache.org/viewvc?rev=1757799=rev Log: Introduce a new method SocketWrapperBase.addToBuffers(ByteBuffer) Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapperBase.java Modified:

[Bug 60033] Jar scanning not handling properly Manifest class-path attribute

2016-08-26 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60033 Mark Thomas changed: What|Removed |Added Resolution|--- |INVALID

svn commit: r1757813 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AprEndpoint.java Nio2Endpoint.java NioEndpoint.java SocketWrapperBase.java

2016-08-26 Thread violetagg
Author: violetagg Date: Fri Aug 26 10:23:15 2016 New Revision: 1757813 URL: http://svn.apache.org/viewvc?rev=1757813=rev Log: Introduce a new method SocketWrapperBase.doWrite(boolean, ByteBuffer) Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

[Bug 60035] java.io.IOException: Too many open files

2016-08-26 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60035 --- Comment #4 from Mark Thomas --- I've reviewed the changes and I don't see anything problematic yet. There is what looks like a single fd leak on first use that I want to track down but that is unlikely to be related to

Re: svn commit: r1757813 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AprEndpoint.java Nio2Endpoint.java NioEndpoint.java SocketWrapperBase.java

2016-08-26 Thread Rémy Maucherat
2016-08-26 12:23 GMT+02:00 : > Author: violetagg > Date: Fri Aug 26 10:23:15 2016 > New Revision: 1757813 > > URL: http://svn.apache.org/viewvc?rev=1757813=rev > Log: > Introduce a new method SocketWrapperBase.doWrite(boolean, ByteBuffer) > > Modified: >

[Bug 60035] java.io.IOException: Too many open files

2016-08-26 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60035 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r1757904 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/Nio2Endpoint.java java/org/apache/tomcat/util/net/NioEndpoint.java webapps/docs/changelog.xml

2016-08-26 Thread markt
Author: markt Date: Fri Aug 26 18:20:05 2016 New Revision: 1757904 URL: http://svn.apache.org/viewvc?rev=1757904=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60035 Fix a potential connection leak if the client drops a TLS connection before the handshake completes. Modified:

svn commit: r1757903 - in /tomcat/trunk: java/org/apache/tomcat/util/net/Nio2Endpoint.java java/org/apache/tomcat/util/net/NioEndpoint.java webapps/docs/changelog.xml

2016-08-26 Thread markt
Author: markt Date: Fri Aug 26 18:18:39 2016 New Revision: 1757903 URL: http://svn.apache.org/viewvc?rev=1757903=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60035 Fix a potential connection leak if the client drops a TLS connection before the handshake completes. Modified:

[Bug 60035] java.io.IOException: Too many open files

2016-08-26 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60035 --- Comment #6 from Mark Thomas --- Good news. I've figured out the root cause and there will be a fix in the next release. Indirectly, r1746551 was the issue. The problem occurs for TLS connections when the connection is

svn commit: r1757883 - in /tomcat/trunk/java/org/apache/tomcat/util/net: Nio2Endpoint.java SocketWrapperBase.java

2016-08-26 Thread violetagg
Author: violetagg Date: Fri Aug 26 15:35:40 2016 New Revision: 1757883 URL: http://svn.apache.org/viewvc?rev=1757883=rev Log: Introduce a new method SocketWrapperBase.write(boolean, ByteBuffer) Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java