Re: svn commit: r1780569 - in /tomcat/site/trunk: docs/conference.html xdocs/conference.xml

Mark, On 1/27/17 10:18 AM, Mark Thomas wrote: > On 27/01/2017 15:13, ma...@apache.org wrote: >> Author: markt >> Date: Fri Jan 27 15:13:26 2017 >> New Revision: 1780569 >> >> URL: http://svn.apache.org/viewvc?rev=1780569=rev >> Log: >> Add a page for TomcatCon > > Improvements welcome. I put

[Bug 60362] Missing reason phrase in response

https://bz.apache.org/bugzilla/show_bug.cgi?id=60362 Ken DeLong changed: What|Removed |Added CC|

[Bug 60594] RFC 7230/3986 url requirement that prevents unencoded curly braces should be optional, since it breaks existing sites

https://bz.apache.org/bugzilla/show_bug.cgi?id=60594 --- Comment #3 from Coty Sutherland --- Created attachment 34684 --> https://bz.apache.org/bugzilla/attachment.cgi?id=34684=edit patch proposal In response to the numerous complaints on the users list I decided to give

[Bug 60645] StatementFinalizer is not thread-safe

https://bz.apache.org/bugzilla/show_bug.cgi?id=60645 Christopher Schultz changed: What|Removed |Added Keywords|

svn commit: r1780601 - in /tomcat/trunk: java/org/apache/jasper/compiler/Generator.java test/webapp/WEB-INF/tags/bug42390.tag test/webapp/bug48nnn/bug48616b.jsp webapps/docs/changelog.xml

Author: remm Date: Fri Jan 27 18:35:02 2017 New Revision: 1780601 URL: http://svn.apache.org/viewvc?rev=1780601=rev Log: Improve the error handling for simple tags to ensure that the tag is released and destroyed once used (v2 with Violeta). Modified:

[Bug 60362] Missing reason phrase in response

https://bz.apache.org/bugzilla/show_bug.cgi?id=60362 --- Comment #12 from Ken DeLong --- Our software interfaces with IoT devices which contain firmware (beyond our control) that expects the "OK" (they parse for "200 OK"; just "200" is parsed as an error). I'm sympathetic

[Bug 60594] RFC 7230/3986 url requirement that prevents unencoded curly braces should be optional, since it breaks existing sites

https://bz.apache.org/bugzilla/show_bug.cgi?id=60594 --- Comment #4 from Mark Thomas --- Allowing some of those (e.g. space) is extremely dangerous and should not be allowed under any circumstances. I generally dislike configuration via system property. That said, making this

[Bug 60594] RFC 7230/3986 url requirement that prevents unencoded curly braces should be optional, since it breaks existing sites

https://bz.apache.org/bugzilla/show_bug.cgi?id=60594 --- Comment #5 from Coty Sutherland --- (In reply to Mark Thomas from comment #4) > I generally dislike configuration via system property. That said, making > this per Connector will be significantly more invasive. I

svn commit: r1780606 - in /tomcat/trunk: java/org/apache/tomcat/util/http/parser/Cookie.java test/org/apache/tomcat/util/http/TestCookieParsing.java webapps/docs/changelog.xml

Author: markt Date: Fri Jan 27 20:14:21 2017 New Revision: 1780606 URL: http://svn.apache.org/viewvc?rev=1780606=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60627 Modify the Rfc6265CookieProcessor so that in addition to cookie headers that start with an explicit RFC 2109

[Bug 60627] Wrong cookie makes Rfc6265CookieProcessor ommit all following cookies

https://bz.apache.org/bugzilla/show_bug.cgi?id=60627 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED

buildbot failure in on tomcat-trunk

The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/2073 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

[Bug 59797] Per thread error hash grows indefinitely

https://bz.apache.org/bugzilla/show_bug.cgi?id=59797 NateC changed: What|Removed |Added Attachment #34597|0 |1 is obsolete|

[Bug 60362] Missing reason phrase in response

https://bz.apache.org/bugzilla/show_bug.cgi?id=60362 --- Comment #13 from Mark Thomas --- Is running on 7.0.x or 8.0.x not an option? -- You are receiving this mail because: You are the assignee for the bug.

Re: svn commit: r1780569 - in /tomcat/site/trunk: docs/conference.html xdocs/conference.xml

On 27/01/2017 18:54, Christopher Schultz wrote: > Mark, > > On 1/27/17 10:18 AM, Mark Thomas wrote: >> On 27/01/2017 15:13, ma...@apache.org wrote: >>> Author: markt >>> Date: Fri Jan 27 15:13:26 2017 >>> New Revision: 1780569 >>> >>> URL: http://svn.apache.org/viewvc?rev=1780569=rev >>> Log: >>>

svn commit: r1780607 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/http/parser/Cookie.java test/org/apache/tomcat/util/http/TestCookieParsing.java webapps/docs/changelog.xml

Author: markt Date: Fri Jan 27 20:14:59 2017 New Revision: 1780607 URL: http://svn.apache.org/viewvc?rev=1780607=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60627 Modify the Rfc6265CookieProcessor so that in addition to cookie headers that start with an explicit RFC 2109

[Bug 60362] Missing reason phrase in response

https://bz.apache.org/bugzilla/show_bug.cgi?id=60362 --- Comment #16 from Michael Osipov <1983-01...@gmx.net> --- (In reply to Remy Maucherat from comment #15) > The only good place to put all these non upgradeable IoT devices is the > trash. Therefore, IoT = Internet of Trash -- You are

[Bug 60362] Missing reason phrase in response

https://bz.apache.org/bugzilla/show_bug.cgi?id=60362 --- Comment #14 from Ken DeLong --- For a short time, I'm happy to run on 8.0.x (that's what I'm doing now). But that's unsustainable; eventually the rest of my tech stack (Spring Boot) will outpace me and I'll be in a

buildbot success in on tomcat-trunk

The Buildbot has detected a restored build on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/2074 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

[Bug 60362] Missing reason phrase in response

https://bz.apache.org/bugzilla/show_bug.cgi?id=60362 --- Comment #15 from Remy Maucherat --- The only good place to put all these non upgradeable IoT devices is the trash. -- You are receiving this mail because: You are the assignee for the bug.

Re: [POLL] Will you be at ApacheCon NA 2017?

Provide my answers: On 24/01/2017 15:46, Mark Thomas wrote: > I will be attending ApacheCon NA: > [ X ] Yes > > If attending, I would be willing to present a session at TomcatCon: > [ X ] Yes Mark - To unsubscribe, e-mail:

svn commit: r1780514 - in /tomcat/trunk/java/org/apache/jasper: compiler/Generator.java runtime/JspRuntimeLibrary.java

Author: markt Date: Fri Jan 27 08:21:17 2017 New Revision: 1780514 URL: http://svn.apache.org/viewvc?rev=1780514=rev Log: More refactoring of generated code so tags require less code Modified: tomcat/trunk/java/org/apache/jasper/compiler/Generator.java

svn commit: r1780515 - /tomcat/trunk/java/org/apache/jasper/compiler/Generator.java

Author: markt Date: Fri Jan 27 08:22:43 2017 New Revision: 1780515 URL: http://svn.apache.org/viewvc?rev=1780515=rev Log: Reduce duplicated generation code. No functional change. Modified: tomcat/trunk/java/org/apache/jasper/compiler/Generator.java Modified:

svn commit: r1780516 - /tomcat/trunk/java/org/apache/jasper/compiler/Generator.java

Author: markt Date: Fri Jan 27 08:31:35 2017 New Revision: 1780516 URL: http://svn.apache.org/viewvc?rev=1780516=rev Log: Reduce duplicated generation code. No functional change. Modified: tomcat/trunk/java/org/apache/jasper/compiler/Generator.java Modified:

Re: [POLL] Will you be at ApacheCon NA 2017?

On 01/24/2017 04:46 PM, Mark Thomas wrote: > Hi, > > I'm sure you have all seen the TomcatCon discussion I started on the > users@ list. We are getting enthusiastic support from the ApacheCon > organisers at both the ASF and the Linux Foundation. > > I am starting to think about the overall

svn commit: r1780528 - in /tomcat/site/trunk: docs/security-6.html docs/security-7.html docs/security-8.html xdocs/security-6.xml xdocs/security-7.xml xdocs/security-8.xml

Author: markt Date: Fri Jan 27 09:48:50 2017 New Revision: 1780528 URL: http://svn.apache.org/viewvc?rev=1780528=rev Log: Update the fix versions and release dates now the votes for 8.0.x and 7..x have passed. Add the usual text regarding fixes in releases where the release vote did not pass.

svn commit: r1780530 - /tomcat/trunk/java/org/apache/jasper/compiler/Generator.java

Author: markt Date: Fri Jan 27 09:55:04 2017 New Revision: 1780530 URL: http://svn.apache.org/viewvc?rev=1780530=rev Log: More refactoring of generated code so tags require less code Extract setters into a separate method when tag handling is in-lined in _jspService() Modified:

[Bug 60613] getting Maximum code footprint error after upgrade to Tomcat 8.5.11

https://bz.apache.org/bugzilla/show_bug.cgi?id=60613 --- Comment #7 from Mark Thomas --- While the long term advice is still try to restructure the JSP, I've spent time looking more closely at the generated code. I found several potential changes that might reduce the overall

[Bug 60653] remove or make optional output of comment

https://bz.apache.org/bugzilla/show_bug.cgi?id=60653 Mark Thomas changed: What|Removed |Added Resolution|--- |DUPLICATE

[Bug 60613] getting Maximum code footprint error after upgrade to Tomcat 8.5.11

https://bz.apache.org/bugzilla/show_bug.cgi?id=60613 Mark Thomas changed: What|Removed |Added CC|

[Bug 60659] New: Eclipse WTP "Serve modules without publishing" broken with tomcat8

https://bz.apache.org/bugzilla/show_bug.cgi?id=60659 Bug ID: 60659 Summary: Eclipse WTP "Serve modules without publishing" broken with tomcat8 Product: Tomcat 8 Version: 8.5.x-trunk Hardware: All OS: All

[Bug 60659] Eclipse WTP "Serve modules without publishing" broken with tomcat8

https://bz.apache.org/bugzilla/show_bug.cgi?id=60659 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED

[Bug 60615] 20% CPU use while check for modified resource

https://bz.apache.org/bugzilla/show_bug.cgi?id=60615 --- Comment #4 from Mark Thomas --- I've put together a possible patch for this: http://home.apache.org/~markt/patches/2017-01-27-bug60615-tc9-v1.patch It does require a change to the WebResource interface as well as to a

[Bug 60597] Add ability to set cipher suites for websocket client connections

https://bz.apache.org/bugzilla/show_bug.cgi?id=60597 --- Comment #8 from Mark Thomas --- I think an SSLEngine is required rather than a socket factory but apart from that I think that is the way to go. The code already started down that route with SSLContext but I think

Re: svn commit: r1780530 - /tomcat/trunk/java/org/apache/jasper/compiler/Generator.java

2017-01-27 10:55 GMT+01:00 : > Author: markt > Date: Fri Jan 27 09:55:04 2017 > New Revision: 1780530 > > URL: http://svn.apache.org/viewvc?rev=1780530=rev > Log: > More refactoring of generated code so tags require less code > Extract setters into a separate method when tag

Re: [VOTE] Release Apache Tomcat 6.0.50

2017-01-26 22:13 GMT+01:00 Mark Thomas : > On 26/01/2017 14:38, Rémy Maucherat wrote: > > 2017-01-26 15:29 GMT+01:00 Mark Thomas : > >> On 26 January 2017 13:53:22 GMT+00:00, Konstantin Kolinko < > >> knst.koli...@gmail.com> wrote: > > > > >>> It needs some

Re: svn commit: r1780530 - /tomcat/trunk/java/org/apache/jasper/compiler/Generator.java

On 27/01/2017 14:08, Rémy Maucherat wrote: > 2017-01-27 10:55 GMT+01:00 : > >> Author: markt >> Date: Fri Jan 27 09:55:04 2017 >> New Revision: 1780530 >> >> URL: http://svn.apache.org/viewvc?rev=1780530=rev >> Log: >> More refactoring of generated code so tags require less code

svn commit: r1780563 - /tomcat/trunk/java/org/apache/jasper/compiler/Generator.java

Author: markt Date: Fri Jan 27 14:36:36 2017 New Revision: 1780563 URL: http://svn.apache.org/viewvc?rev=1780563=rev Log: Revert r1780530 Moving setters into a separate method didn't work if attribute values used scriplets. Modified:

[Bug 60613] getting Maximum code footprint error after upgrade to Tomcat 8.5.11

https://bz.apache.org/bugzilla/show_bug.cgi?id=60613 --- Comment #9 from Mark Thomas --- One of the optimisations was buggy. Removing it gives: - after clean-up but with optimisations - 258 Setting mappedFile to false permits another 10 tags to used. -- You are receiving

svn commit: r1780569 - in /tomcat/site/trunk: docs/conference.html xdocs/conference.xml

Author: markt Date: Fri Jan 27 15:13:26 2017 New Revision: 1780569 URL: http://svn.apache.org/viewvc?rev=1780569=rev Log: Add a page for TomcatCon Added: tomcat/site/trunk/docs/conference.html (with props) tomcat/site/trunk/xdocs/conference.xml (with props) Added:

svn commit: r1780571 - in /tomcat/site/trunk: docs/ xdocs/stylesheets/

Author: markt Date: Fri Jan 27 15:17:39 2017 New Revision: 1780571 URL: http://svn.apache.org/viewvc?rev=1780571=rev Log: Add a link to TomcatCon to the menu Modified: tomcat/site/trunk/docs/bugreport.html tomcat/site/trunk/docs/ci.html tomcat/site/trunk/docs/conference.html

Re: svn commit: r1780569 - in /tomcat/site/trunk: docs/conference.html xdocs/conference.xml

On 27/01/2017 15:13, ma...@apache.org wrote: > Author: markt > Date: Fri Jan 27 15:13:26 2017 > New Revision: 1780569 > > URL: http://svn.apache.org/viewvc?rev=1780569=rev > Log: > Add a page for TomcatCon Improvements welcome. I put this up so we had something to start pointing folks towards.

[Bug 60645] StatementFinalizer is not thread-safe

https://bz.apache.org/bugzilla/show_bug.cgi?id=60645 Christopher Schultz changed: What|Removed |Added Attachment #34679|text/x-java-source

[Bug 60645] StatementFinalizer is not thread-safe

https://bz.apache.org/bugzilla/show_bug.cgi?id=60645 --- Comment #3 from Christopher Schultz --- Could this class have been written as a subclass of StatementFinalizer that simply overrides all the methods with synchronized versions and delegates to the superclass?

Re: [POLL] Will you be at ApacheCon NA 2017?

All, For completeness. On 1/24/17 10:46 AM, Mark Thomas wrote: > I will be attending ApacheCon NA: > > [ X ] Yes > > If attending, I would be willing to present a session at TomcatCon: > > [ X ] Yes signature.asc Description: OpenPGP digital signature

[Bug 60645] StatementFinalizer is not thread-safe

https://bz.apache.org/bugzilla/show_bug.cgi?id=60645 --- Comment #4 from ba...@semedy.com --- (In reply to Christopher Schultz from comment #3) > Could this class have been written as a subclass of StatementFinalizer that > simply overrides all the methods with synchronized versions and delegates

[Bug 60594] RFC 7230/3986 url requirement that prevents unencoded curly braces should be optional, since it breaks existing sites

https://bz.apache.org/bugzilla/show_bug.cgi?id=60594 --- Comment #6 from eolivelli --- Hi, for my use cases I would like to have just a whitelist and let Tomcat handle all the RFC blacklisted chars automatically. In my case I had to whitelist curly braces and pipe. -- You

[Bug 60594] RFC 7230/3986 url requirement that prevents unencoded curly braces should be optional, since it breaks existing sites

https://bz.apache.org/bugzilla/show_bug.cgi?id=60594 --- Comment #7 from Coty Sutherland --- Created attachment 34687 --> https://bz.apache.org/bugzilla/attachment.cgi?id=34687=edit whitelist patch proposal For reference, and so I don't accidentally delete it :) -- You

[Bug 60594] RFC 7230/3986 url requirement that prevents unencoded curly braces should be optional, since it breaks existing sites

https://bz.apache.org/bugzilla/show_bug.cgi?id=60594 --- Comment #8 from Mark Thomas --- I think I prefer the whitelist option but I'd like to see it limited to - at this point - '{', '}' and '|'. Other characters can be considered on a case by case basis. Documentation should

svn commit: r1780609 - in /tomcat/trunk: java/org/apache/tomcat/util/http/parser/Cookie.java test/org/apache/tomcat/util/http/TestCookies.java

Author: markt Date: Fri Jan 27 21:02:08 2017 New Revision: 1780609 URL: http://svn.apache.org/viewvc?rev=1780609=rev Log: Follow-up to r1780606 Ensure RFC2109 cookie is created with correct version Modified: tomcat/trunk/java/org/apache/tomcat/util/http/parser/Cookie.java

svn commit: r1780610 - /tomcat/trunk/test/org/apache/tomcat/util/http/TestCookies.java

Author: markt Date: Fri Jan 27 21:03:15 2017 New Revision: 1780610 URL: http://svn.apache.org/viewvc?rev=1780610=rev Log: Update comment Modified: tomcat/trunk/test/org/apache/tomcat/util/http/TestCookies.java Modified: tomcat/trunk/test/org/apache/tomcat/util/http/TestCookies.java URL:

svn commit: r1780611 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/http/parser/Cookie.java test/org/apache/tomcat/util/http/TestCookies.java

Author: markt Date: Fri Jan 27 21:03:41 2017 New Revision: 1780611 URL: http://svn.apache.org/viewvc?rev=1780611=rev Log: Follow-up to r1780607 Ensure RFC2109 cookie is created with correct version Modified: tomcat/tc8.5.x/trunk/ (props changed)