Re: [VOTE] Release Apache Tomcat 8.5.32

2018-06-21 Thread Rémy Maucherat
On Wed, Jun 20, 2018 at 10:27 PM Mark Thomas wrote: > The proposed Apache Tomcat 8.5.32 release is now available for voting. > > The major changes compared to the 8.5.31 release are: > > - Add the RemoteCIDRFilter and RemoteCIDRValve that can be used to > allow/deny requests based on IPv4

Re: svn commit: r1833978 - /tomcat/trunk/build.xml

2018-06-21 Thread Mark Thomas
On 21/06/18 08:18, Rainer Jung wrote: > Noticed the missing ciphers.sh when doing the 9.0.10 check. Looking at > the list of file mode setting in the package-tgz target of build.xml, I > wonder: > > - shouldn't we just use name="bin/*.sh" like we do for *.exe instead of > listing each file

svn commit: r1833989 [2/2] - in /tomcat/trunk: ./ bin/ java/org/apache/catalina/ant/ java/org/apache/catalina/ant/jmx/ java/org/apache/catalina/core/ java/org/apache/catalina/filters/ java/org/apache/

2018-06-21 Thread ebourg
Modified: tomcat/trunk/res/welcome.bin.html URL: http://svn.apache.org/viewvc/tomcat/trunk/res/welcome.bin.html?rev=1833989=1833988=1833989=diff == --- tomcat/trunk/res/welcome.bin.html (original) +++

svn commit: r1833989 [1/2] - in /tomcat/trunk: ./ bin/ java/org/apache/catalina/ant/ java/org/apache/catalina/ant/jmx/ java/org/apache/catalina/core/ java/org/apache/catalina/filters/ java/org/apache/

2018-06-21 Thread ebourg
Author: ebourg Date: Thu Jun 21 09:16:08 2018 New Revision: 1833989 URL: http://svn.apache.org/viewvc?rev=1833989=rev Log: Use https URLs in the documentation when possible Modified: tomcat/trunk/BUILDING.txt tomcat/trunk/CONTRIBUTING.md tomcat/trunk/NOTICE tomcat/trunk/README.md

svn commit: r1833982 - /tomcat/trunk/BUILDING.txt

2018-06-21 Thread ebourg
Author: ebourg Date: Thu Jun 21 08:08:32 2018 New Revision: 1833982 URL: http://svn.apache.org/viewvc?rev=1833982=rev Log: Updated the Cobertura URL Modified: tomcat/trunk/BUILDING.txt Modified: tomcat/trunk/BUILDING.txt URL:

Re: [VOTE] Release Apache Tomcat 9.0.10

2018-06-21 Thread Romain Manni-Bucau
+1 (non-binding), tested on Meecrowave and a few work apps and all was green Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github | LinkedIn

svn commit: r1833978 - /tomcat/trunk/build.xml

2018-06-21 Thread rjung
Author: rjung Date: Thu Jun 21 06:59:29 2018 New Revision: 1833978 URL: http://svn.apache.org/viewvc?rev=1833978=rev Log: Fix permissions for ciphers.sh in binary distribution (750 instead of 640). Modified: tomcat/trunk/build.xml Modified: tomcat/trunk/build.xml URL:

Re: svn commit: r1833978 - /tomcat/trunk/build.xml

2018-06-21 Thread Rainer Jung
Noticed the missing ciphers.sh when doing the 9.0.10 check. Looking at the list of file mode setting in the package-tgz target of build.xml, I wonder: - shouldn't we just use name="bin/*.sh" like we do for *.exe instead of listing each file individually? I don't see any "*.sh" we would not

Re: buildbot failure in on tomcat-trunk

2018-06-21 Thread Emmanuel Bourg
Le 21/06/2018 à 14:00, Mark Thomas a écrit : > Infra ticket. Ok: https://issues.apache.org/jira/browse/INFRA-16673 > And please revert the change until it is updated so the CI system > continues to work. Done in r1834001 Thank you for the guidance. Emmanuel Bourg

Re: buildbot failure in on tomcat-trunk

2018-06-21 Thread Emmanuel Bourg
Le 21/06/2018 à 14:31, Mark Thomas a écrit : > We are going to need to be careful with this. The older Tomcat branches > need to build on old Java versions so we need to look at Ant / Java > version compatibility as well. > > /me heads off to check the Ant docs for minimum Java versions Ant

Re: buildbot failure in on tomcat-trunk

2018-06-21 Thread Gav
I'll add 1.9.11 and ensure previous version remains also. Gav... On Thu, Jun 21, 2018 at 1:31 PM, Mark Thomas wrote: > On 21/06/18 13:14, Gav wrote: > > Wierd, it passed on the same machine only 2 hours earlier:-- > > > > https://ci.apache.org/builders/tomcat-trunk/builds/3378 > > > > as an

[Bug 62479] TLS Mutual Authentication use case: Using pkcs12 format truststore on connector yields exception "the trustAnchors parameter must be non-empty"

2018-06-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62479 --- Comment #6 from Nicolas Therrien --- Created attachment 35982 --> https://bz.apache.org/bugzilla/attachment.cgi?id=35982=edit all logs produced by the server for this use case Adding logs as requested. -- You are receiving this mail

Re: buildbot failure in on tomcat-trunk

2018-06-21 Thread Gav
Wierd, it passed on the same machine only 2 hours earlier:-- https://ci.apache.org/builders/tomcat-trunk/builds/3378 as an FYI gmcdonald@silvanus:~$ /home/buildslave/slave/tools/ant/latest/bin/ant -version Apache Ant(TM) version 1.10.3 compiled on March 24 2018 gmcdonald@silvanus:~$ ant

[Bug 62479] TLS Mutual Authentication use case: Using pkcs12 format truststore on connector yields exception "the trustAnchors parameter must be non-empty"

2018-06-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62479 --- Comment #5 from Remy Maucherat --- Please provide the complete server start log when submitting a bug report like this. -- You are receiving this mail because: You are the assignee for the bug.

Re: buildbot failure in on tomcat-trunk

2018-06-21 Thread Mark Thomas
On 21/06/18 12:46, Emmanuel Bourg wrote: > Le 21/06/2018 à 13:01, build...@apache.org a écrit : >> The Buildbot has detected a new failure on builder tomcat-trunk while >> building . Full details are available at: >> https://ci.apache.org/builders/tomcat-trunk/builds/3379 > > It looks like

svn commit: r1833994 - in /tomcat/trunk: BUILDING.txt build.xml webapps/docs/building.xml

2018-06-21 Thread ebourg
Author: ebourg Date: Thu Jun 21 10:56:16 2018 New Revision: 1833994 URL: http://svn.apache.org/viewvc?rev=1833994=rev Log: Added the new javac release attribute to be able to build Tomcat with recent JDKs without compromising the compatibility with older versions (requires Ant 1.9.8 or later)

[Bug 62479] TLS Mutual Authentication use case: Using pkcs12 format truststore on connector yields exception "the trustAnchors parameter must be non-empty"

2018-06-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62479 --- Comment #4 from Nicolas Therrien --- I didnt know how to edit the description so I'm putting steps to reproduce here: (on windows ) 1) Extract tomcat 9.0.1 to a folder 2) Change the Generate-Certificates script as to output both p12 and

Re: buildbot failure in on tomcat-trunk

2018-06-21 Thread Mark Thomas
On 21/06/18 13:14, Gav wrote: > Wierd, it passed on the same machine only 2 hours earlier:-- > > https://ci.apache.org/builders/tomcat-trunk/builds/3378 > > as an FYI > > gmcdonald@silvanus:~$ /home/buildslave/slave/tools/ant/latest/bin/ant > -version > Apache Ant(TM) version 1.10.3 compiled on

svn commit: r1834003 - in /tomcat/trunk: java/org/apache/catalina/ant/jmx/package.html java/org/apache/catalina/ant/package.html modules/jdbc-pool/build.xml modules/jdbc-pool/doc/jdbc-pool.xml

2018-06-21 Thread ebourg
Author: ebourg Date: Thu Jun 21 12:31:45 2018 New Revision: 1834003 URL: http://svn.apache.org/viewvc?rev=1834003=rev Log: Fixed several links pointing to the documentation of older Tomcat releases Modified: tomcat/trunk/java/org/apache/catalina/ant/jmx/package.html

svn commit: r1834019 - in /tomcat/site/trunk: docs/index.html docs/oldnews-2017.html xdocs/index.xml xdocs/oldnews-2017.xml

2018-06-21 Thread kkolinko
Author: kkolinko Date: Thu Jun 21 14:10:33 2018 New Revision: 1834019 URL: http://svn.apache.org/viewvc?rev=1834019=rev Log: Move announcement for Tomcat Native 1.2.17 to the top of the list (chronologically). Restore lost announcement for 1.2.16 and move it to the news archive. Modified:

buildbot failure in on tomcat-trunk

2018-06-21 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3383 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

[Bug 62479] Using pkcs12 format truststore on connector yields exception "the trustAnchors parameter must be non-empty"

2018-06-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62479 --- Comment #2 from Nicolas Therrien --- Created attachment 35979 --> https://bz.apache.org/bugzilla/attachment.cgi?id=35979=edit server_truststore.p12 -- You are receiving this mail because: You are the assignee for the bug.

[Bug 62479] Using pkcs12 format truststore on connector yields exception "the trustAnchors parameter must be non-empty"

2018-06-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62479 --- Comment #1 from Nicolas Therrien --- Created attachment 35978 --> https://bz.apache.org/bugzilla/attachment.cgi?id=35978=edit server_truststore.jks -- You are receiving this mail because: You are the assignee for the bug.

Re: buildbot failure in on tomcat-trunk

2018-06-21 Thread Emmanuel Bourg
Le 21/06/2018 à 14:14, Gav a écrit : > Wierd, it passed on the same machine only 2 hours earlier:-- > > https://ci.apache.org/builders/tomcat-trunk/builds/3378 This build fetched r1833989, but the issue is with r1833994 which used an Ant feature requiring at least the version 1.9.8. Emmanuel

Re: buildbot failure in on tomcat-trunk

2018-06-21 Thread Mark Thomas
On 21/06/18 13:35, Gav wrote: > I'll add 1.9.11 and ensure previous version remains also. Tx Gav. I'll wait until 1.9.11 is in place and then switch the Tomcat builds to use the latest 1.9.x release (Gav mentioned on HipChat that he'd set up an additional symlink to point to the latest 1.9.x

[Bug 62479] TLS Mutual Authentication use case: Using pkcs12 format truststore on connector yields exception "the trustAnchors parameter must be non-empty"

2018-06-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62479 Nicolas Therrien changed: What|Removed |Added Summary|Using pkcs12 format |TLS Mutual Authentication

buildbot success in on tomcat-trunk

2018-06-21 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3380 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

Re: svn commit: r1833994 - in /tomcat/trunk: BUILDING.txt build.xml webapps/docs/building.xml

2018-06-21 Thread Konstantin Kolinko
You are forgetting to update the docs/changelog.xml. Raising required minimum version of Ant is a visible change, it should be mentioned in changelog. (When this is implemented once again. I saw that this change was reverted because of CI failures at Buildbot.) 2018-06-21 13:56 GMT+03:00 : >

Re: buildbot failure in on tomcat-trunk

2018-06-21 Thread Emmanuel Bourg
Le 21/06/2018 à 13:01, build...@apache.org a écrit : > The Buildbot has detected a new failure on builder tomcat-trunk while > building . Full details are available at: > https://ci.apache.org/builders/tomcat-trunk/builds/3379 It looks like Ant needs an upgrade on the builders. Is there a

svn commit: r1834011 - /tomcat/trunk/webapps/docs/rewrite.xml

2018-06-21 Thread ebourg
Author: ebourg Date: Thu Jun 21 13:21:08 2018 New Revision: 1834011 URL: http://svn.apache.org/viewvc?rev=1834011=rev Log: Fixed a broken perldoc link Modified: tomcat/trunk/webapps/docs/rewrite.xml Modified: tomcat/trunk/webapps/docs/rewrite.xml URL:

svn commit: r1834020 - in /tomcat/trunk: BUILDING.txt build.xml modules/jdbc-pool/build.properties.default modules/jdbc-pool/build.xml webapps/docs/building.xml webapps/docs/changelog.xml

2018-06-21 Thread ebourg
Author: ebourg Date: Thu Jun 21 14:13:46 2018 New Revision: 1834020 URL: http://svn.apache.org/viewvc?rev=1834020=rev Log: Added the new javac release attribute to be able to build Tomcat with recent JDKs without compromising the compatibility with older versions (requires Ant 1.9.8 or later)

buildbot failure in on tomcat-trunk

2018-06-21 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3379 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

[Bug 62479] Using pkcs12 format truststore on connector yields exception "the trustAnchors parameter must be non-empty"

2018-06-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62479 --- Comment #3 from Nicolas Therrien --- Created attachment 35981 --> https://bz.apache.org/bugzilla/attachment.cgi?id=35981=edit server.xml -- You are receiving this mail because: You are the assignee for the bug.

[Bug 62479] New: Using pkcs12 format truststore on connector yields exception "the trustAnchors parameter must be non-empty"

2018-06-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62479 Bug ID: 62479 Summary: Using pkcs12 format truststore on connector yields exception "the trustAnchors parameter must be non-empty" Product: Tomcat 9 Version:

svn commit: r1834001 - in /tomcat/trunk: BUILDING.txt build.xml webapps/docs/building.xml

2018-06-21 Thread ebourg
Author: ebourg Date: Thu Jun 21 12:09:55 2018 New Revision: 1834001 URL: http://svn.apache.org/viewvc?rev=1834001=rev Log: Reverted r1833994 until Ant is upgraded on the builders Modified: tomcat/trunk/BUILDING.txt tomcat/trunk/build.xml tomcat/trunk/webapps/docs/building.xml

Re: buildbot failure in on tomcat-trunk

2018-06-21 Thread Mark Thomas
On 21/06/18 13:31, Mark Thomas wrote: > On 21/06/18 13:14, Gav wrote: >> Wierd, it passed on the same machine only 2 hours earlier:-- >> >> https://ci.apache.org/builders/tomcat-trunk/builds/3378 >> >> as an FYI >> >> gmcdonald@silvanus:~$ /home/buildslave/slave/tools/ant/latest/bin/ant >>

[Bug 62479] TLS Mutual Authentication use case: Using pkcs12 format truststore on connector yields exception "the trustAnchors parameter must be non-empty"

2018-06-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62479 Remy Maucherat changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: buildbot failure in on tomcat-trunk

2018-06-21 Thread Emmanuel Bourg
Le 21/06/2018 à 16:25, Rémy Maucherat a écrit : > Is the Ant of the build platform upgradeable already ? I thought so [1] but it seems there is still an issue. Emmanuel Bourg [1] https://issues.apache.org/jira/browse/INFRA-16673

Re: buildbot failure in on tomcat-trunk

2018-06-21 Thread Gav
done ;) On Thu, Jun 21, 2018 at 4:37 PM, Mark Thomas wrote: > On 21 June 2018 15:31:52 BST, Emmanuel Bourg wrote: > >Le 21/06/2018 à 16:25, Rémy Maucherat a écrit : > > > >> Is the Ant of the build platform upgradeable already ? > > > >I thought so [1] but it seems there is still an issue. > >

Re: buildbot failure in on tomcat-trunk

2018-06-21 Thread Rémy Maucherat
On Thu, Jun 21, 2018 at 4:18 PM wrote: > The Buildbot has detected a new failure on builder tomcat-trunk while > building . Full details are available at: > https://ci.apache.org/builders/tomcat-trunk/builds/3383 > > Buildbot URL: https://ci.apache.org/ > > Buildslave for this Build:

[Bug 62479] TLS Mutual Authentication use case: Using pkcs12 format truststore on connector yields exception "the trustAnchors parameter must be non-empty"

2018-06-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62479 Nicolas Therrien changed: What|Removed |Added Resolution|INVALID |--- Status|RESOLVED

Re: buildbot failure in on tomcat-trunk

2018-06-21 Thread Mark Thomas
On 21 June 2018 16:42:35 BST, Gav wrote: >done ;) Thanks. I appreciate you going that extra mile for the project. Mark > >On Thu, Jun 21, 2018 at 4:37 PM, Mark Thomas wrote: > >> On 21 June 2018 15:31:52 BST, Emmanuel Bourg >wrote: >> >Le 21/06/2018 à 16:25, Rémy Maucherat a écrit : >> > >>

Re: buildbot failure in on tomcat-trunk

2018-06-21 Thread Mark Thomas
On 21 June 2018 15:31:52 BST, Emmanuel Bourg wrote: >Le 21/06/2018 à 16:25, Rémy Maucherat a écrit : > >> Is the Ant of the build platform upgradeable already ? > >I thought so [1] but it seems there is still an issue. > >Emmanuel Bourg > >[1] https://issues.apache.org/jira/browse/INFRA-16673 >

svn commit: r1834060 - in /tomcat/tc8.5.x/trunk: ./ build.xml

2018-06-21 Thread rjung
Author: rjung Date: Thu Jun 21 21:48:48 2018 New Revision: 1834060 URL: http://svn.apache.org/viewvc?rev=1834060=rev Log: - replace outdated list of shell scripts to include in distribution artefacts with *.sh. - replace README.txt with README.md which is currently the name of our README

svn commit: r1834044 - /tomcat/trunk/test/org/apache/tomcat/util/http/TestFastHttpDateFormatPerformance.java

2018-06-21 Thread markt
Author: markt Date: Thu Jun 21 18:59:05 2018 New Revision: 1834044 URL: http://svn.apache.org/viewvc?rev=1834044=rev Log: Add a test to use to check for performance changes during refactoring of data formatting. Added:

buildbot success in on tomcat-trunk

2018-06-21 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3384 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

Re: svn commit: r1834060 - in /tomcat/tc8.5.x/trunk: ./ build.xml

2018-06-21 Thread Konstantin Kolinko
"replace README.txt with README.md which is currently the name of our README file." README.md in Tomcat 8.5 and earlier is broken. It is a blind copy of a Tomcat 9 file (it has Tomcat 9 links instead of correct ones). 2018-06-22 0:48 GMT+03:00 : > Author: rjung > Date: Thu Jun 21 21:48:48

[Bug 62479] TLS Mutual Authentication use case: Using pkcs12 format truststore on connector yields exception "the trustAnchors parameter must be non-empty"

2018-06-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62479 Mark Thomas changed: What|Removed |Added Resolution|INVALID |--- Status|RESOLVED

svn commit: r1834058 - /tomcat/trunk/build.xml

2018-06-21 Thread rjung
Author: rjung Date: Thu Jun 21 21:41:33 2018 New Revision: 1834058 URL: http://svn.apache.org/viewvc?rev=1834058=rev Log: - replace outdated list of shell scripts to include in distribution artefacts with *.sh. - replace README.txt with README.md which is currently the name of our README

[Bug 62479] TLS Mutual Authentication use case: Using pkcs12 format truststore on connector yields exception "the trustAnchors parameter must be non-empty"

2018-06-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62479 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

svn commit: r1834062 - in /tomcat/tc7.0.x/trunk: ./ build.xml

2018-06-21 Thread rjung
Author: rjung Date: Thu Jun 21 21:57:04 2018 New Revision: 1834062 URL: http://svn.apache.org/viewvc?rev=1834062=rev Log: - replace outdated list of shell scripts to include in distribution artefacts with *.sh. - replace README.txt with README.md which is currently the name of our README

[Bug 62479] TLS Mutual Authentication use case: Using pkcs12 format truststore on connector yields exception "the trustAnchors parameter must be non-empty"

2018-06-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62479 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

[Bug 62479] TLS Mutual Authentication use case: Using pkcs12 format truststore on connector yields exception "the trustAnchors parameter must be non-empty"

2018-06-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62479 --- Comment #12 from Nicolas Therrien --- Thanks for looking into it. I understand what you are saying and it could be an explanation. I'm looking at this page:

[Bug 62479] TLS Mutual Authentication use case: Using pkcs12 format truststore on connector yields exception "the trustAnchors parameter must be non-empty"

2018-06-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62479 Nicolas Therrien changed: What|Removed |Added Resolution|INVALID |--- Status|RESOLVED

Re: [VOTE] Release Apache Tomcat 9.0.10

2018-06-21 Thread Huxing Zhang
Hi, The proposed 9.0.10 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 9.0.10 Unit test passed on Java 10. Examples ok. Test web application works fine. On Thu, Jun 21, 2018 at 3:45 AM, Mark Thomas wrote: > The proposed Apache Tomcat 9.0.10 release is now

Re: [VOTE] Release Apache Tomcat 9.0.10

2018-06-21 Thread Konstantin Kolinko
2018-06-20 22:45 GMT+03:00 Mark Thomas : > The proposed Apache Tomcat 9.0.10 release is now available for voting. > I have not tested this version yet (running 8.5 tests now), but I note that the following *.asc files are missing, both in Tomcat 9 and Tomcat 8.5: