(tomcat) branch main updated: Refactor tests to avoid use of @Ignore

2023-12-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 5f6ac4e03e Refactor tests to avoid use of @Ignore

Re: Practical use of CsrfPreventionFilter

2023-12-15 Thread Christopher Schultz
Mark, On 12/15/23 04:53, Mark Thomas wrote: On 13/12/2023 22:05, Christopher Schultz wrote: All, I've been playing with this Filter recently, and I have some concerns for its practical use. I'm considering adding some features to it in order to make it more practical to use, and I'm

(tomcat) branch main updated: Clarifications and consistent wording

2023-12-15 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new fe1787325a Clarifications and consistent wording

Re: [PR] Csrf filter improvements [tomcat]

2023-12-15 Thread via GitHub
ChristopherSchultz commented on PR #681: URL: https://github.com/apache/tomcat/pull/681#issuecomment-1858319793 Commit [e2f78ec](https://github.com/apache/tomcat/pull/681/commits/e2f78eca0c7626303e5e50f1f033770b466f1755) adds nonce-check skipping to the URLs that won't get nonces added to

Re: [PR] Dir redirect use301 [tomcat]

2023-12-15 Thread via GitHub
markt-asf commented on PR #524: URL: https://github.com/apache/tomcat/pull/524#issuecomment-1857955904 A variation of this has been applied to 11.0.x as Servlet 6.1 has added additional methods to allow the status code to be specified in a sendRedirect() call. -- This is an automated

Re: Practical use of CsrfPreventionFilter

2023-12-15 Thread Christopher Schultz
All, I've opened a PR for this: https://github.com/apache/tomcat/pull/681 Comments welcome. -chris On 12/15/23 10:20, Christopher Schultz wrote: Mark, On 12/15/23 04:53, Mark Thomas wrote: On 13/12/2023 22:05, Christopher Schultz wrote: All, I've been playing with this Filter recently,

Re: (tomcat) branch main updated: Make Host header / request line consistency check case insensitive

2023-12-15 Thread Christopher Schultz
Mark, On 12/15/23 04:37, ma...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new

Re: [PR] [WIP] initial implementation of webresource based on path API [tomcat]

2023-12-15 Thread via GitHub
KoteswararaoGundapaneni commented on PR #630: URL: https://github.com/apache/tomcat/pull/630#issuecomment-1858736665 Am ready to take part in this based on the work allocated as per the PR -- This is an automated message from the Apache Git Service. To respond to the message, please log

(tomcat) branch main updated: Add an option to control how the default servlet performs dir redirects

2023-12-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 50cec9655a Add an option to control how the default

(tomcat) branch 9.0.x updated: Clarifications and consistent wording

2023-12-15 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 88ef9e3f32 Clarifications and consistent wording

(tomcat) branch 10.1.x updated: Clarifications and consistent wording

2023-12-15 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new fdb35b98a6 Clarifications and consistent wording

Re: (tomcat) branch main updated: Make Host header / request line consistency check case insensitive

2023-12-15 Thread Mark Thomas
On 15/12/2023 14:51, Christopher Schultz wrote: I replied on users@ about this. Is ASCII-comparison sufficient? I believe so, yes. Could we speed things up dramatically by performing a byte-wise comparison first, and only fall-back to (slower) case-insensitive comparison if that fails?

[PR] Csrf filter improvements [tomcat]

2023-12-15 Thread via GitHub
ChristopherSchultz opened a new pull request, #681: URL: https://github.com/apache/tomcat/pull/681 Please see https://lists.apache.org/thread/47syblyghh3tromyf6bkvl8q14w70f3x for the initial conversation. I see some potential improvements for the CSRF prevention filter that will be

Re: [PR] Csrf filter improvements [tomcat]

2023-12-15 Thread via GitHub
ChristopherSchultz commented on PR #681: URL: https://github.com/apache/tomcat/pull/681#issuecomment-1858296301 My initial testing indicates that caching is working as expected with these changes. -- This is an automated message from the Apache Git Service. To respond to the message,

(tomcat) branch 9.0.x updated: Clarify doc following feedback

2023-12-15 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 6681dcfc7a Clarify doc following feedback

(tomcat) branch 10.1.x updated: Clarify doc following feedback

2023-12-15 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 63076508ff Clarify doc following feedback

(tomcat) branch 10.1.x updated: Allow operations with the same name on introspected mbeans

2023-12-15 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 8aa22054c2 Allow operations with the same name on

(tomcat) branch 9.0.x updated: Allow operations with the same name on introspected mbeans

2023-12-15 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 76aa57fe60 Allow operations with the same name on

(tomcat) branch 9.0.x updated: Make Host header / request line consistency check case insensitive

2023-12-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new ed77f8b8e8 Make Host header / request line

(tomcat) branch 8.5.x updated: Allow operations with the same name on introspected mbeans

2023-12-15 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new c037349147 Allow operations with the same name on

(tomcat) branch 8.5.x updated: Make Host header / request line consistency check case insensitive

2023-12-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new f4a6c16e05 Make Host header / request line

(tomcat) branch main updated: Clarify doc following feedback

2023-12-15 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 1c570df48e Clarify doc following feedback 1c570df48e

(tomcat) branch 9.0.x updated: Use the 10.1 branch in the link since the module is present

2023-12-15 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 9411835458 Use the 10.1 branch in the link since

(tomcat) branch 10.1.x updated: Use the 10.1 branch in the link since the module is present

2023-12-15 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 394336b1d1 Use the 10.1 branch in the link since

(tomcat) branch main updated: Allow operations with the same name on introspected mbeans

2023-12-15 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 4e8b070585 Allow operations with the same name on

(tomcat) branch 10.1.x updated: Make Host header / request line consistency check case insensitive

2023-12-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 7820460330 Make Host header / request line

(tomcat) branch main updated: Make Host header / request line consistency check case insensitive

2023-12-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new a42726c21b Make Host header / request line

(tomcat) branch main updated: Clarify start stop of Tomcat using the trace agent

2023-12-15 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 96de7b5091 Clarify start stop of Tomcat using the

(tomcat) branch 9.0.x updated: Clarify start stop of Tomcat using the trace agent

2023-12-15 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new f17009afaa Clarify start stop of Tomcat using the

(tomcat) branch 10.1.x updated: Clarify start stop of Tomcat using the trace agent

2023-12-15 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 4ea6147002 Clarify start stop of Tomcat using the

Re: Practical use of CsrfPreventionFilter

2023-12-15 Thread Mark Thomas
On 13/12/2023 22:05, Christopher Schultz wrote: All, I've been playing with this Filter recently, and I have some concerns for its practical use. I'm considering adding some features to it in order to make it more practical to use, and I'm interested to see what others think about these