Re: [PR] Csrf filter improvements [tomcat]

2023-12-21 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1434514917 ## webapps/docs/config/filter.xml: ## @@ -291,6 +291,13 @@ request. The default value is 403. + +A flag to enable or disable

Re: [PR] Csrf filter improvements [tomcat]

2023-12-21 Thread via GitHub
michael-o commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1434524088 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -87,11 +104,170 @@ public void setNonceRequestParameterName(String parameterName) {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-21 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1434511388 ## webapps/docs/config/filter.xml: ## @@ -319,6 +326,34 @@ of java.security.SecureRandom will be used. + +A list of URL

Re: [PR] Csrf filter improvements [tomcat]

2023-12-21 Thread via GitHub
michael-o commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1434513367 ## webapps/docs/config/filter.xml: ## @@ -319,6 +326,34 @@ of java.security.SecureRandom will be used. + +A list of URL patterns that

Re: [PR] Csrf filter improvements [tomcat]

2023-12-21 Thread via GitHub
michael-o commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1434512783 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -198,15 +416,27 @@ protected boolean skipNonceCheck(HttpServletRequest request) {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-21 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1434521612 ## webapps/docs/config/filter.xml: ## @@ -319,6 +326,34 @@ of java.security.SecureRandom will be used. + +A list of URL

Re: [PR] Csrf filter improvements [tomcat]

2023-12-21 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1434510673 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -198,15 +416,27 @@ protected boolean skipNonceCheck(HttpServletRequest request) {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-21 Thread via GitHub
michael-o commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1434518590 ## webapps/docs/config/filter.xml: ## @@ -291,6 +291,13 @@ request. The default value is 403. + +A flag to enable or disable

(tomcat) branch main updated: Add warnings and details about webapp classes

2023-12-21 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 681eb77dd3 Add warnings and details about webapp

(tomcat) branch 9.0.x updated: Add warnings and details about webapp classes

2023-12-21 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new e9a7b3c6d1 Add warnings and details about webapp

(tomcat) branch 10.1.x updated: Remove trailing space

2023-12-21 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 3a788920d6 Remove trailing space 3a788920d6 is

(tomcat) branch main updated: Remove trailing space

2023-12-21 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 11fb662af9 Remove trailing space 11fb662af9 is

(tomcat) branch 9.0.x updated: Remove trailing space

2023-12-21 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 387357b0b6 Remove trailing space 387357b0b6 is

(tomcat) branch 10.1.x updated: Add warnings and details about webapp classes

2023-12-21 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new cab798421d Add warnings and details about webapp