[Bug 60940] New: "unpackWARs=false" causes different behavior of classloader

https://bz.apache.org/bugzilla/show_bug.cgi?id=60940 Bug ID: 60940 Summary: "unpackWARs=false" causes different behavior of classloader Product: Tomcat 8 Version: 8.0.42 Hardware: PC Status: NEW

svn commit: r1789435 - in /tomcat/tc7.0.x/trunk: modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/ webapps/docs/

Author: kfujino Date: Thu Mar 30 05:31:22 2017 New Revision: 1789435 URL: http://svn.apache.org/viewvc?rev=1789435=rev Log: Refactor the creating a constructor for a proxy class to reduce duplicate code. Modified:

svn commit: r1789434 - in /tomcat/tc8.0.x/trunk: modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/ webapps/docs/

Author: kfujino Date: Thu Mar 30 05:30:03 2017 New Revision: 1789434 URL: http://svn.apache.org/viewvc?rev=1789434=rev Log: Refactor the creating a constructor for a proxy class to reduce duplicate code. Modified:

svn commit: r1789433 - in /tomcat/tc8.5.x/trunk: modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/ webapps/docs/

Author: kfujino Date: Thu Mar 30 05:28:21 2017 New Revision: 1789433 URL: http://svn.apache.org/viewvc?rev=1789433=rev Log: Refactor the creating a constructor for a proxy class to reduce duplicate code. Modified:

svn commit: r1789432 - in /tomcat/trunk: modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/ webapps/docs/

Author: kfujino Date: Thu Mar 30 05:26:42 2017 New Revision: 1789432 URL: http://svn.apache.org/viewvc?rev=1789432=rev Log: Refactor the creating a constructor for a proxy class to reduce duplicate code. Modified:

[GUMP@vmgump-vm3]: Project tomcat-tc8.0.x-test-nio2 (in module tomcat-8.0.x) failed

To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.0.x-test-nio2 has an issue affecting its community

[GitHub] tomcat pull request #:

Github user michael-o commented on the pull request: https://github.com/apache/tomcat/commit/d46012cb159c3384303eeceffc54eb78e6a62671#commitcomment-21548024 In java/org/apache/el/Messages.properties: In java/org/apache/el/Messages.properties on line 32: Shall it really output

[Bug 60932] Invalid or incomplete escaping of apostrophe (') in messages passed to MessageFormat

https://bz.apache.org/bugzilla/show_bug.cgi?id=60932 --- Comment #1 from Mark Thomas --- Thanks for the patch. I've applied it to 9.0.x along with a bunch of similar issues I found. I will back-port it but probably tomorrow. -- You are receiving this mail because: You are the

svn commit: r1789415 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/catalina/ha/deploy/ java/org/apache/catalina/ha/session/ java/org/apache/cat

Author: markt Date: Wed Mar 29 21:34:18 2017 New Revision: 1789415 URL: http://svn.apache.org/viewvc?rev=1789415=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60932 Correctly escape single quotes when used in i18n messages. Based on a patch by Michael Osipov. Modified:

[Bug 60750] A response that uses Transfer-Encoding: chunked is missing the last zero-length chunk

https://bz.apache.org/bugzilla/show_bug.cgi?id=60750 --- Comment #26 from Mark Thomas --- This is what I was thinking of from 2014 http://markmail.org/thread/znillhttbmvsl5e5 and the change to close the connection without the final chunk was back-ported to 8.0.x and 7.0.x.

[Bug 60750] A response that uses Transfer-Encoding: chunked is missing the last zero-length chunk

https://bz.apache.org/bugzilla/show_bug.cgi?id=60750 --- Comment #25 from Mark Thomas --- I'm leaning towards fixing it but... I do recall we had a discussion around this topic or one similar in the past. Let me see if I can find a reference to it. -- You are receiving this

Re: Read events suspend/resume logic in websocket impl to achieve backpressure

On 29/03/17 08:02, Violeta Georgieva wrote: >> 2017-02-27 16:50 GMT+02:00 Mark Thomas : >>> Overall, I like the approach and would support apply a patch along these >>> lines once the timing issues are resolved. > > Any feedback about the new changes? First of all, kudos for

[Bug 60750] A response that uses Transfer-Encoding: chunked is missing the last zero-length chunk

https://bz.apache.org/bugzilla/show_bug.cgi?id=60750 --- Comment #24 from Christopher Schultz --- It sounds like this should really be WONTFIX: Tomcat 7.0.x and 8.0.x will emit a 0-byte final chunk, and changing that in the 7.0.x or 8.0.x branches should probably

[Bug 60925] Running with SecurityManager - Property 'serverInfo' not found on type org.apache.catalina.core.ApplicationContextFacade

https://bz.apache.org/bugzilla/show_bug.cgi?id=60925 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r1789403 - in /tomcat/tc7.0.x/trunk: ./ java/javax/el/BeanELResolver.java webapps/docs/changelog.xml

Author: markt Date: Wed Mar 29 18:20:08 2017 New Revision: 1789403 URL: http://svn.apache.org/viewvc?rev=1789403=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60925 Improve the handling of access to properties defined by interfaces when a BeanELResolver is used under a

svn commit: r1789402 - in /tomcat/tc8.0.x/trunk: ./ java/javax/el/BeanELResolver.java webapps/docs/changelog.xml

Author: markt Date: Wed Mar 29 18:19:21 2017 New Revision: 1789402 URL: http://svn.apache.org/viewvc?rev=1789402=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60925 Improve the handling of access to properties defined by interfaces when a BeanELResolver is used under a

svn commit: r1789401 - in /tomcat/tc8.5.x/trunk: ./ java/javax/el/BeanELResolver.java webapps/docs/changelog.xml

Author: markt Date: Wed Mar 29 18:18:07 2017 New Revision: 1789401 URL: http://svn.apache.org/viewvc?rev=1789401=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60925 Improve the handling of access to properties defined by interfaces when a BeanELResolver is used under a

svn commit: r1789400 - in /tomcat/trunk: java/javax/el/BeanELResolver.java webapps/docs/changelog.xml

Author: markt Date: Wed Mar 29 18:16:50 2017 New Revision: 1789400 URL: http://svn.apache.org/viewvc?rev=1789400=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60925 Improve the handling of access to properties defined by interfaces when a BeanELResolver is used under a

Re: [VOTE] Release Apache Tomcat 8.0.43

Am 28. März 2017 17:28:30 MESZ schrieb Violeta Georgieva : >The proposed Apache Tomcat 8.0.43 release is now available for voting. > >It can be obtained from: >https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.43/ >The Maven staging repo is:

Re: Building tomcat with maven

On Wed, Mar 29, 2017 at 1:31 PM, Mark Thomas wrote: > On 29/03/17 18:09, Coty Sutherland wrote: >> Hi, >> >> In order to improve my build process I'm looking at utilizing maven to >> build tomcat rather than ant (maven works with an existing toolset, >> whereas ant doesn't).

Re: [VOTE] Release Apache Tomcat 8.5.13

On 27/03/17 16:13, Mark Thomas wrote: > The proposed 8.5.13 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 8.5.13 Unit tests pass for NIO, NIO2 and APR/native (1.2.12) on Windows, Linux and OSX. Mark

Re: [VOTE] Release Apache Tomcat 9.0.0.M19

On 27/03/17 13:56, Mark Thomas wrote: > The proposed 9.0.0.M19 release is: > [ ] Broken - do not release > [X] Alpha - go ahead and release as 9.0.0.M19 Unit tests pass for NIO, NIo2 and APR/native (1.2.12) on Windows, Linux and OSX. Mark

Re: Building tomcat with maven

On 29/03/17 18:09, Coty Sutherland wrote: > Hi, > > In order to improve my build process I'm looking at utilizing maven to > build tomcat rather than ant (maven works with an existing toolset, > whereas ant doesn't). Does anyone know of any groups that have tried > to do or are doing this, or any

Building tomcat with maven

Hi, In order to improve my build process I'm looking at utilizing maven to build tomcat rather than ant (maven works with an existing toolset, whereas ant doesn't). Does anyone know of any groups that have tried to do or are doing this, or any projects that I could look into? If not, would anyone

Re: Tomcat 8.5 Java 9 compatibilty

On Wed, Mar 29, 2017 at 12:10 PM, Mark Thomas wrote: > On 29/03/17 16:56, Coty Sutherland wrote: >> Hi all, >> >> I see a good bit of discussion regarding testing trunk with java 9, >> are we planning to test 8.5 with java 9 also? I've executed the unit >> tests for both and see

Re: Tomcat 8.5 Java 9 compatibilty

On 29/03/17 16:56, Coty Sutherland wrote: > Hi all, > > I see a good bit of discussion regarding testing trunk with java 9, > are we planning to test 8.5 with java 9 also? I've executed the unit > tests for both and see that there are quite a few more failures on 8.5 > than there are for trunk,

Re: Host header validation

On 29/03/17 15:16, Katya Todorova wrote: >> >> I recommend using the code coverage reports as a guide. >> >> https://ci.apache.org/projects/tomcat/tomcat9/coverage/ > > >> >> and add test cases if they increase code coverage. Hmm. It looks like >> there is some low hanging fruit in the parsing

Tomcat 8.5 Java 9 compatibilty

Hi all, I see a good bit of discussion regarding testing trunk with java 9, are we planning to test 8.5 with java 9 also? I've executed the unit tests for both and see that there are quite a few more failures on 8.5 than there are for trunk, so it seems that we've been fixing trunk but not 8.5.

buildbot success in on tomcat-trunk

The Buildbot has detected a restored build on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/2233 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

Re: Host header validation

> > I recommend using the code coverage reports as a guide. > > https://ci.apache.org/projects/tomcat/tomcat9/coverage/ > > and add test cases if they increase code coverage. Hmm. It looks like > there is some low hanging fruit in the parsing code to improve coverage. > > You can run the tests

buildbot failure in on tomcat-trunk

The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/2232 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

svn commit: r1789371 - in /tomcat/trunk: java/org/apache/coyote/http2/HpackDecoder.java webapps/docs/changelog.xml

Author: remm Date: Wed Mar 29 14:09:30 2017 New Revision: 1789371 URL: http://svn.apache.org/viewvc?rev=1789371=rev Log: Revert due to test failures, maybe it's good to identify the issue with a specific exception. Modified: tomcat/trunk/java/org/apache/coyote/http2/HpackDecoder.java

svn commit: r1789369 - in /tomcat/trunk: java/org/apache/coyote/http2/HpackDecoder.java webapps/docs/changelog.xml

Author: remm Date: Wed Mar 29 14:03:11 2017 New Revision: 1789369 URL: http://svn.apache.org/viewvc?rev=1789369=rev Log: Cleanup HPACK decoding exception. Modified: tomcat/trunk/java/org/apache/coyote/http2/HpackDecoder.java tomcat/trunk/webapps/docs/changelog.xml Modified:

[Bug 60932] New: Invalid or incomplete escaping of apostrophe (') in messages passed to MessageFormat

https://bz.apache.org/bugzilla/show_bug.cgi?id=60932 Bug ID: 60932 Summary: Invalid or incomplete escaping of apostrophe (') in messages passed to MessageFormat Product: Tomcat 8 Version: 8.5.x-trunk Hardware: All

svn commit: r1789367 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java webapps/docs/changelog.xml

Author: violetagg Date: Wed Mar 29 13:57:55 2017 New Revision: 1789367 URL: http://svn.apache.org/viewvc?rev=1789367=rev Log: Fix Java8 detection by testing for class java.util.Optional (Java8+) instead of class javax.net.ssl.SSLParameters (Java6+). Patch provided by fibbers via Github. This

svn commit: r1789365 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/compat/ java/org/apache/tomcat/util/compat/Jre8Compat.java webapps/docs/changelog.xml

Author: violetagg Date: Wed Mar 29 13:45:46 2017 New Revision: 1789365 URL: http://svn.apache.org/viewvc?rev=1789365=rev Log: javax.net.ssl.SSLParameters exists since Java 6, but the method setUseCipherSuitesOrder exists since Java 8. Make this clear in the comments. Patch provided by fibbers via

[Bug 60925] Running with SecurityManager - Property 'serverInfo' not found on type org.apache.catalina.core.ApplicationContextFacade

https://bz.apache.org/bugzilla/show_bug.cgi?id=60925 --- Comment #3 from Konstantin Kolinko --- For a record: There exists a working temporary workaround for this issue: grant permission to access the "core" package. E.g. for this test scenario (the ROOT web

Re: [VOTE] Release Apache Tomcat 8.5.13

On Mon, Mar 27, 2017 at 11:13 AM, Mark Thomas wrote: > The proposed Apache Tomcat 8.5.13 release is now available for voting. > > The major changes compared to the 8.5.12 release are: > > - Various HTTP/2 improvements > > - Fixes for sendfile related issues that could cause

Re: [VOTE] Release Apache Tomcat 8.0.43

On Tue, Mar 28, 2017 at 5:28 PM, Violeta Georgieva wrote: > The proposed Apache Tomcat 8.0.43 release is now available for voting. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.43/ > The Maven staging repo is: >

svn commit: r1789338 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/util/compat/Jre8Compat.java webapps/docs/changelog.xml

Author: violetagg Date: Wed Mar 29 11:21:40 2017 New Revision: 1789338 URL: http://svn.apache.org/viewvc?rev=1789338=rev Log: javax.net.ssl.SSLParameters exists since Java 6, but the method setUseCipherSuitesOrder exists since Java 8. Make this clear in the comments. This closes

svn commit: r1789335 - in /tomcat/tc8.5.x/trunk: java/org/apache/tomcat/util/compat/Jre8Compat.java webapps/docs/changelog.xml

Author: violetagg Date: Wed Mar 29 11:12:33 2017 New Revision: 1789335 URL: http://svn.apache.org/viewvc?rev=1789335=rev Log: javax.net.ssl.SSLParameters exists since Java 6, but the method setUseCipherSuitesOrder exists since Java 8. Make this clear in the comments. This closes

Re: Host header validation

On 29/03/17 07:06, Katya Todorova wrote: > On Tue, Mar 28, 2017 at 5:45 PM, Mark Thomas wrote: > >> On 28/03/17 15:23, Katya Todorova wrote: >>> Hi, r1787662 adds Host header validation along with a fair number of unit >> tests. It includes a performance test which

Re: [VOTE] Release Apache Tomcat 8.5.13

2017-03-28 0:13 GMT+09:00 Mark Thomas : > The proposed Apache Tomcat 8.5.13 release is now available for voting. > > The major changes compared to the 8.5.12 release are: > > - Various HTTP/2 improvements > > - Fixes for sendfile related issues that could cause subsequent

Re: [VOTE] Release Apache Tomcat 9.0.0.M19

2017-03-27 21:56 GMT+09:00 Mark Thomas : > The proposed Apache Tomcat 9.0.0.M19 release is now available for voting. > > This is a milestone release for the 9.0.x branch. It should be > noted that, as a milestone release: > - Servlet 4.0 is not finalised > - The EGs have not

Re: [VOTE] Release Apache Tomcat 9.0.0.M19

Am 27. März 2017 14:56:41 MESZ schrieb Mark Thomas : >The proposed Apache Tomcat 9.0.0.M19 release is now available for >voting. > >This is a milestone release for the 9.0.x branch. It should be >noted that, as a milestone release: >- Servlet 4.0 is not finalised >- The EGs

Re: [VOTE] Release Apache Tomcat 8.5.13

Am 27. März 2017 17:13:51 MESZ schrieb Mark Thomas : >The proposed Apache Tomcat 8.5.13 release is now available for voting. > >The major changes compared to the 8.5.12 release are: > >- Various HTTP/2 improvements > >- Fixes for sendfile related issues that could cause

Re: [VOTE] Release Apache Tomcat 8.5.13

2017-03-27 17:13 GMT+02:00 Mark Thomas : > The proposed Apache Tomcat 8.5.13 release is now available for voting. > > The major changes compared to the 8.5.12 release are: > > - Various HTTP/2 improvements > > - Fixes for sendfile related issues that could cause subsequent

Re: [VOTE] Release Apache Tomcat 9.0.0.M19

On Mon, Mar 27, 2017 at 2:56 PM, Mark Thomas wrote: > The proposed Apache Tomcat 9.0.0.M19 release is now available for voting. > > This is a milestone release for the 9.0.x branch. It should be > noted that, as a milestone release: > - Servlet 4.0 is not finalised > - The EGs

Re: Read events suspend/resume logic in websocket impl to achieve backpressure

Hi, 2017-03-20 16:41 GMT+02:00 Violeta Georgieva : > > Hi, > > 2017-02-27 16:50 GMT+02:00 Mark Thomas : > > > > On 27/02/17 11:55, Violeta Georgieva wrote: > > > > > > > > >> A new patch is available based on the provided comments. > > >> Can you please

Re: [VOTE] Release Apache Tomcat 8.5.13

On Mon, Mar 27, 2017 at 5:13 PM, Mark Thomas wrote: > The proposed Apache Tomcat 8.5.13 release is now available for voting. > > The major changes compared to the 8.5.12 release are: > > - Various HTTP/2 improvements > > - Fixes for sendfile related issues that could cause

Re: Host header validation

On Tue, Mar 28, 2017 at 5:45 PM, Mark Thomas wrote: > On 28/03/17 15:23, Katya Todorova wrote: > > Hi, > >> r1787662 adds Host header validation along with a fair number of unit > tests. > >> It includes a performance test which indicates - on my machine at least > >> - that