[Bug 61164] Add %X option to access log for connection status

https://bz.apache.org/bugzilla/show_bug.cgi?id=61164 --- Comment #8 from Zemian Deng --- I have added the isIoAllowed with action code check to the PR now. Please review. -- You are receiving this mail because: You are the assignee for the bug.

[Bug 61164] Add %X option to access log for connection status

https://bz.apache.org/bugzilla/show_bug.cgi?id=61164 --- Comment #7 from Zemian Deng --- Mark, thanks for all the tips. No problem, I can re-fix the imports for better merge experience. Yes, I agree that we should support just '%X' for now until users demands the finer

Re: [VOTE] Release Apache Tomcat 9.0.0.M25

The proposed 9.0.0.M25 release is: [ ] Broken - do not release [ X ] Alpha - go ahead and release as 9.0.0.M25 Unit test passed. Our test web application runs fine. -- From:Mark Thomas Time:2017 Jul 25 (Tue) 07:19

[GUMP@vmgump-vm3]: Project tomcat-tc8.0.x-test-nio2 (in module tomcat-8.0.x) failed

/objenesis/main/target/objenesis-2.7-SNAPSHOT.jar -Dexamples.sources.skip=true -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20170725.jar -Dtest.openssl.path=/srv/gump/public/workspace/openssl-1.0.2/dest-20170725/bin/openssl -Dexecute.test.nio=false

Re: Opportunities for cohesion improvement and refatoring

Hi Mark, tanks for the comment. Let me take the DataSourceProxy as example. This class has 142 methods of which 112 are get () and set () methods. We could mark these methods as deprecated and copy them to a new class: DataSourceProxyConfig, but we would leave them in the DataSourceProxy class,

Re: Bad tags in 8.5's github repo

On Tue, Jul 25, 2017 at 10:00 AM, Mark Thomas wrote: > On 25/07/17 12:34, Coty Sutherland wrote: >> Hi, >> >> This was noted yesterday in #tomcat: >> >> the tomcat85 repo has a tag TOMCAT_8_0_14 which has a >> message "Tag 8.5.14" ... >> but git diff TOMCAT_8_5_14

Re: Bad tags in 8.5's github repo

On 25/07/17 12:34, Coty Sutherland wrote: > Hi, > > This was noted yesterday in #tomcat: > > the tomcat85 repo has a tag TOMCAT_8_0_14 which has a > message "Tag 8.5.14" ... > but git diff TOMCAT_8_5_14 TOMCAT_8_0_14 shows no output > > I took a look at SVN and the tags seem right, but

Re: Opportunities for cohesion improvement and refatoring

On 25/07/17 13:55, João Paulo Lemes Machado wrote: > Hello everyone. > > My name is João Paulo, I am a graduate student the Federal University of > Uberlandia, Brazil. > > I was analyzing the modularization of some classes of Tomcat, and I > identified some opportunities for cohesion

Re: [VOTE] Release Apache Tomcat 8.5.19

On 25/07/17 12:49, Konstantin Kolinko wrote: > 2017-07-25 2:22 GMT+03:00 Mark Thomas : >> The proposed Apache Tomcat 8.5.19 release is now available for voting. >> >> The major changes compared to the 8.5.16 release are: >> >> - Enable TLS connectors to use Java key stores that

Opportunities for cohesion improvement and refatoring

Hello everyone. My name is João Paulo, I am a graduate student the Federal University of Uberlandia, Brazil. I was analyzing the modularization of some classes of Tomcat, and I identified some opportunities for cohesion improvement in the following classes: DataSourceProxy ConnectionPool

Re: [VOTE] Release Apache Tomcat 8.5.19

2017-07-25 2:22 GMT+03:00 Mark Thomas : > The proposed Apache Tomcat 8.5.19 release is now available for voting. > > The major changes compared to the 8.5.16 release are: > > - Enable TLS connectors to use Java key stores that contain multiple > keys where each key has a

Bad tags in 8.5's github repo

Hi, This was noted yesterday in #tomcat: the tomcat85 repo has a tag TOMCAT_8_0_14 which has a message "Tag 8.5.14" ... but git diff TOMCAT_8_5_14 TOMCAT_8_0_14 shows no output I took a look at SVN and the tags seem right, but maybe they were broken and later fixed post replication? The

[Bug 61164] Add %X option to access log for connection status

https://bz.apache.org/bugzilla/show_bug.cgi?id=61164 --- Comment #6 from Mark Thomas --- The updated patch looks good. Thanks. I noticed that the import order has changed. If you could undo that it would be good but it isn't a big deal to fix when the patch is applied.