Responsive Website

2017-12-19 Thread Igal Sapir
Hi everyone, The Tomcat website at http://tomcat.apache.org/ is not using responsive design, and therefore is not very mobile-friendly. I have a lot of experience with Front End development and can fix that if given the approval. Any thoughts? Igal

Fwd: Language for lists archives on Tomcat website

2018-05-25 Thread Igal Sapir
Hi all, The text for Archives currently reads: > at Apache, at MARC (searchable) , at MarkMail, at Nabble and at Mail Archive Which suggests that only MARC is searchable, but in fact MarkMail, at Nabble and Mail Archive are also searchable, and some provide a better search experience, so I want

Re: Fwd: Language for lists archives on Tomcat website

2018-05-25 Thread Igal Sapir
On Fri, May 25, 2018 at 12:36 PM, Mark Thomas <ma...@apache.org> wrote: > On 25/05/18 20:31, Igal Sapir wrote: > > > > > I can either: > > > > 1) Add a [magnifying glass icon] next to each > > > > 2) Change the text to something like: &g

SVN on Windows and new line characters

2018-05-25 Thread Igal Sapir
Hello, Commit r1832279 created a much larger diff than I expected. I am using TortoiseSVN on Windows and it looks like it recorded the NEW_LINE character changes. Does anyone know if there are settings to change that? Or can recommend a different SVN client? Another thing is that I couldn't

Re: Fwd: Language for lists archives on Tomcat website

2018-05-25 Thread Igal Sapir
Chris, On 5/25/2018 4:48 PM, Christopher Schultz wrote: > > > All of the list archives are searchable. It's ironic that MARC has the > > worst interface of all of them, but 15 years ago when that page > waswritten, it was probably the only searchable one available. Looks like > MARC hasn't

Re: Thoughts on suggestions for new contributors

2018-05-31 Thread Igal Sapir
On 5/31/2018 3:28 AM, Mark Thomas wrote: As you may have noticed I have been working on the HttpParser unit tests over the last few days. This was prompted, as a result of the recent fqdn parsing issues, to ensure that the unit tests were covering all of the edge cases. While the fqdn parsing

Re: [Git migration] Developer process

2018-05-31 Thread Igal Sapir
On 5/31/2018 3:00 AM, Mark Thomas wrote: Hi, The next issue to resolve for the Git migration is developer process. Note that this does not cover branch names, merge strategy etc. This is issue is about the options available for developers to organise their local development environment. The

Re: Plans for AJP

2018-06-27 Thread Igal Sapir
On 6/27/2018 11:28 AM, Rémy Maucherat wrote: On Wed, Jun 27, 2018 at 7:09 PM Mark Thomas wrote: On 27/06/18 17:50, Rainer Jung wrote: Since encryption would be most of the most useful features and IMHO we won't get there, I suggest we discuss deprecation and EOL dates for AJP - meaning

Re: Plans for AJP

2018-06-27 Thread Igal Sapir
On 6/27/2018 1:02 PM, Rainer Jung wrote: Not trying to deviate, but any header set with mod_headers RequestHeader directive should automatically be forwarded (I use it often eg. for request IDs). Alternatively one can use JkEnvVar to forward httpd request environment variables as request

File Permissions in SVN/Git

2018-07-02 Thread Igal Sapir
The new files bin/makebase.bat and makebase.sh do not have the same permissions as the other files in bin, possibly because I committed them from a Windows machine. Specifically, the file bin/makebase.sh is missing the eXecute permission. Any idea how to fix that? drwxrwxr-x. 2 ux ux 4096 Jul

Re: svn commit: r1834798 - in /tomcat/trunk/bin: makebase.bat makebase.sh

2018-07-01 Thread Igal Sapir
On 7/1/2018 12:18 PM, Michael Osipov wrote: Am 2018-07-01 um 20:44 schrieb isa...@apache.org: Author: isapir Date: Sun Jul  1 18:44:38 2018 New Revision: 1834798 URL: http://svn.apache.org/viewvc?rev=1834798=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62500 Added scripts to

Re: makebase script and webapps

2018-07-03 Thread Igal Sapir
On 7/3/2018 1:15 PM, Michael Osipov wrote: Am 2018-07-03 um 22:12 schrieb Mark Thomas: On 03/07/18 21:10, Michael Osipov wrote: Am 2018-07-03 um 22:07 schrieb Mark Thomas: On 03/07/18 21:02, Michael Osipov wrote: Am 2018-07-03 um 18:27 schrieb Mark Thomas: Hi, I've been looking at the

Re: makebase script and webapps

2018-07-03 Thread Igal Sapir
On 7/3/2018 1:48 PM, Michael Osipov wrote: Am 2018-07-03 um 22:37 schrieb Igal Sapir: On 7/3/2018 1:15 PM, Michael Osipov wrote: Am 2018-07-03 um 22:12 schrieb Mark Thomas: On 03/07/18 21:10, Michael Osipov wrote: Am 2018-07-03 um 22:07 schrieb Mark Thomas: On 03/07/18 21:02, Michael Osipov

Re: Responsive Website for tomcat.apache.org

2018-01-18 Thread Igal Sapir
Hello, I have moved the static resources to a common directory at /res and I would like to push that as the first step of updating the website since that clean up makes the website's code easier to maintain. That will also get the process of updating the website started with a relatively

Re: Responsive Website for tomcat.apache.org

2018-01-19 Thread Igal Sapir
questions. Best, Igal On Fri, Jan 19, 2018 at 2:49 AM, Mark Thomas <ma...@apache.org> wrote: > On 19/01/18 08:34, Mark Thomas wrote: > > On 18/01/18 22:38, Igal Sapir wrote: > >> Hello, > >> > >> I have moved the static resources to a common directo

Re: Responsive Website for tomcat.apache.org

2018-01-19 Thread Igal Sapir
To clarify, On Fri, Jan 19, 2018 at 4:24 PM, Igal Sapir <i...@lucee.org> wrote: > I have updated the site and it is now responsive. On browsers where the > width is 960px or smaller, the menu on the left is hidden and an hamburger > toggler button appears on the top left. Image

Re: Responsive Website for tomcat.apache.org

2018-01-25 Thread Igal Sapir
Please see patch at https://github.com/isapir/tomcat-site/commit/5e4d642 which adjusts the search box alignment and adds a keyboard toggle with the Enter key when the hamburger menu icon has focus. Best, Igal On Thu, Jan 25, 2018 at 1:34 PM, Igal @ Lucee.org wrote: > On

Re: JK release

2018-08-21 Thread Igal Sapir
On 8/21/2018 8:54 AM, Igal Sapir wrote: On 8/21/2018 2:42 AM, Mark Thomas wrote: There are quite a few open issues and enhancements and I very much doubt I'll be able to get to all of them so if any C coders have some spare cycles to help out that would be great (no JK experience necessary

Re: JK release

2018-08-21 Thread Igal Sapir
On 8/21/2018 2:42 AM, Mark Thomas wrote: Hi all, It is getting on for 6 months since the last JK release so I am planning on making a sweep of the open bugs, fixing what I can, tagging and calling a release vote. I'm hoping to be able to tag by the end of the week but, as always, circumstances

Re: Download Link on the Tomcat website

2018-09-01 Thread Igal Sapir
On 9/1/2018 7:33 AM, Konstantin Kolinko wrote: пт, 31 авг. 2018 г. в 20:49, Igal Sapir : Currently links to the Download pages can be either to the whichversion [1] page or the version-specific pages, e.g. "Tomcat 9" [2] etc. It will be very useful to have a generic dow

Re: makebase script and webapps

2018-07-03 Thread Igal Sapir
On 7/3/2018 9:27 AM, Mark Thomas wrote: Currently, we copy conf recursively but create an empty webapps. This is inconsistent as any directories under conf will (nearly always) be web application specific config. I think we should either copy web applications and config or not copy both. My

Re: Responsive Website for tomcat.apache.org

2018-01-19 Thread Igal Sapir
UPDATE: On Fri, Jan 19, 2018 at 4:30 PM, Igal Sapir <i...@lucee.org> wrote: > To clarify, > > I have updated the code for the site. I have not updated the site itself > since I'm not a committer (my previous statement seemed unclear). > > A committer needs to patch the

Re: JDBC drivers in WEB-INF/lib

2018-09-11 Thread Igal Sapir
On 9/11/2018 2:53 PM, Christopher Schultz wrote: On 9/11/18 3:33 PM, Michael Osipov wrote: ... plus numerous SO questions have been asked about this. ... Most of those questions haven't been answered by anyone who actually knows the answers. Sad but true. Igal

Re: svn commit: r1842849 - in /tomcat/trunk: java/org/apache/tomcat/jni/Library.java test/org/apache/tomcat/util/net/TesterSupport.java test/org/apache/tomcat/util/net/openssl/TestOpenSSLConf.java

2018-10-05 Thread Igal Sapir
On 10/5/2018 2:40 AM, Mark Thomas wrote: On 04/10/18 22:07, isa...@apache.org wrote: Author: isapir Date: Thu Oct 4 21:07:54 2018 New Revision: 1842849 URL: http://svn.apache.org/viewvc?rev=1842849=rev Log: System.load() expects absolute path. Remember to consider whether or not any changes

Re: SSL Unit Tests Failing

2018-10-05 Thread Igal Sapir
On 10/4/2018 11:34 PM, Rainer Jung wrote: Am 05.10.2018 um 00:03 schrieb Igal Sapir:> And with tcnative I get: 04-Oct-2018 14:52:14.231 INFO [main] org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case [testOpenSSLConfCmdCipher] 04-Oct-2018 14:52:14.434 INFO [m

Re: svn commit: r1842849 - in /tomcat/trunk: java/org/apache/tomcat/jni/Library.java test/org/apache/tomcat/util/net/TesterSupport.java test/org/apache/tomcat/util/net/openssl/TestOpenSSLConf.java

2018-10-05 Thread Igal Sapir
On 10/5/2018 3:22 AM, Mark Thomas wrote: On 05/10/18 10:42, Rémy Maucherat wrote: On Fri, Oct 5, 2018 at 11:40 AM Mark Thomas wrote: The Tomcat style is to always use { and } even for one line for clarity. Due to the age of the code base, there are a mix of styles. Generally, we try and move

Re: svn commit: r1842849 - in /tomcat/trunk: java/org/apache/tomcat/jni/Library.java test/org/apache/tomcat/util/net/TesterSupport.java test/org/apache/tomcat/util/net/openssl/TestOpenSSLConf.java

2018-10-08 Thread Igal Sapir
On 10/8/2018 2:52 AM, Mark Thomas wrote: On 05/10/18 19:46, Christopher Schultz wrote: Mark, On 10/5/18 06:22, Mark Thomas wrote: On 05/10/18 10:42, Rémy Maucherat wrote: On Fri, Oct 5, 2018 at 11:40 AM Mark Thomas wrote: On 04/10/18 22:07, isa...@apache.org wrote: Author: isapir Date:

Re: svn commit: r1844066 - in /tomcat/tc8.5.x/trunk: ./ build.xml java/org/apache/tomcat/jni/Library.java res/ide-support/idea/inspections.xml res/ide-support/idea/misc.xml res/ide-support/idea/module

2018-10-17 Thread Igal Sapir
it the > message, not the original one you merged, thus I have chosen 1844066. > Thank you very much for that useful information! Best, Igal > > Editing old log messages can also be useful to fix a typo or add a > security info (eg. CVE number) after a release was done. > &g

Re: svn propchange: r1844066 - svn:log

2018-10-17 Thread Igal Sapir
On Wed, Oct 17, 2018 at 11:20 AM Mark Thomas wrote: > On 17/10/18 18:58, isa...@apache.org wrote: > > Author: isapir > > Revision: 1844066 > > Modified property: svn:log > > > > Modified: svn:log at Wed Oct 17 17:58:39 2018 > > >

Re: svn commit: r1844065 - /tomcat/trunk/java/org/apache/tomcat/jni/Library.java

2018-10-17 Thread Igal Sapir
RE this: On Tue, Oct 16, 2018 at 10:39 PM wrote: > Author: isapir > Date: Wed Oct 17 05:39:01 2018 > New Revision: 1844065 > > URL: http://svn.apache.org/viewvc?rev=1844065=rev > Log: > Added util methods load and loadLibrary per BZ 62830 > > Modified: >

Re: svn commit: r1844066 - in /tomcat/tc8.5.x/trunk: ./ build.xml java/org/apache/tomcat/jni/Library.java res/ide-support/idea/inspections.xml res/ide-support/idea/misc.xml res/ide-support/idea/module

2018-10-17 Thread Igal Sapir
OK, so I ran `svn commit` (I thought before that `svn merge` takes care of that), and I hope that it turned out fine, though it looks like the log message was left empty. #cantwaitforgit Igal On Tue, Oct 16, 2018 at 11:12 PM wrote: > Author: isapir > Date: Wed Oct 17 06:12:38 2018 > New

Enabling HTTP/2 for tomcat.apache.org

2018-10-22 Thread Igal Sapir
I just checked https://tomcat.apache.org/ and it does not support HTTP/2. Who can fix that? Igal

Re: buildbot failure in on tomcat-trunk

2018-10-22 Thread Igal Sapir
I am able to build locally on that same revision. Any ideas? Igal On Mon, Oct 22, 2018 at 9:51 PM wrote: > The Buildbot has detected a new failure on builder tomcat-trunk while > building . Full details are available at: > https://ci.apache.org/builders/tomcat-trunk/builds/3677 > >

Re: [VOTE] Release Apache Tomcat Native 1.2.18

2018-10-17 Thread Igal Sapir
On 10/17/2018 3:19 PM, Mark Thomas wrote: Version 1.2.18 includes the following changes compared to 1.2.17: - Windows binaries built with OpenSSL 1.0.2p and APR 1.6.5 - Windows binaries built with OpenSSL 1.1.1 and APR 1.6.5 - TLSv1.3 support when built with OpenSSL 1.1.1 Various other fixes

Re: svn commit: r1844723 - in /tomcat/trunk/bin: makebase.bat makebase.sh

2018-10-24 Thread Igal Sapir
On Wed, Oct 24, 2018 at 9:01 AM Mark Thomas wrote: > On October 24, 2018 3:44:23 PM UTC, Igal Sapir wrote: > >On Wed, Oct 24, 2018 at 1:55 AM Mark Thomas wrote: > > >> >New Revision: 1844723 > >> > > >> >URL: http://svn.apache.org/viewvc?rev=1

Re: svn commit: r1844723 - in /tomcat/trunk/bin: makebase.bat makebase.sh

2018-10-24 Thread Igal Sapir
On Wed, Oct 24, 2018 at 1:55 AM Mark Thomas wrote: > On October 24, 2018 5:12:00 AM UTC, isa...@apache.org wrote: > >Author: isapir > >Date: Wed Oct 24 05:12:00 2018 > >New Revision: 1844723 > > > >URL: http://svn.apache.org/viewvc?rev=1844723=rev > >Log: > >Added empty ROOT dir > > What is the

Re: "Embedded" improvements

2018-10-24 Thread Igal Sapir
On Wed, Oct 24, 2018 at 2:55 AM Rémy Maucherat wrote: > Hi, > > I'm starting to review embedded. Maybe I won't make many changes in the end > and won't need a separate API. > > However, I have another post 9.0.13 refactoring with a redoing of > ConfigFileLoader and various places which try to

Re: buildbot failure in on tomcat-trunk

2018-10-23 Thread Igal Sapir
Rainer, On Tue, Oct 23, 2018 at 1:03 AM Rainer Jung wrote: > Am 23.10.2018 um 07:08 schrieb Igal Sapir: > > I am able to build locally on that same revision. > > > > Any ideas? > > You can see the reason by looking at the link included in the mail: > > http

Re: Mime types

2018-10-31 Thread Igal Sapir
On 10/31/2018 12:50 PM, Rémy Maucherat wrote: On Wed, Oct 31, 2018 at 8:16 PM Konstantin Kolinko wrote: ср, 31 окт. 2018 г. в 19:38, Rémy Maucherat : Hi, There are two main contraptions in Tomcat that do (badly ...) extension tomime type mapping: the shared web.xml and some hardcoded stuff

Re: [VOTE] Release Apache Tomcat 9.0.13

2018-11-02 Thread Igal Sapir
On Fri, Nov 2, 2018 at 9:11 AM Mark Thomas wrote: > The proposed Apache Tomcat 9.0.13 release is now available for voting. > > The major changes compared to the 9.0.13 release are: > > - support for TLSv1.3 when used with a JRE or OPenSSl version that > supports it > > - added support for

Re: [VOTE] Release Apache Tomcat 9.0.13

2018-11-03 Thread Igal Sapir
On Sat, Nov 3, 2018 at 9:28 AM Mark Thomas wrote: > On 03/11/2018 16:20, Igal Sapir wrote: > > On Sat, Nov 3, 2018 at 3:50 AM Mark Thomas wrote: > > > >> On 02/11/2018 22:39, Igal Sapir wrote: > >> > >> > >> > >>> I am getting the

Re: [VOTE] Release Apache Tomcat 9.0.13

2018-11-03 Thread Igal Sapir
On Sat, Nov 3, 2018 at 3:50 AM Mark Thomas wrote: > On 02/11/2018 22:39, Igal Sapir wrote: > > > > > I am getting the same test case failures as before, so it doesn't look > like > > a regression to me: > >[concat] Testsuites with faile

Re: [VOTE] Release Apache Tomcat 9.0.13

2018-11-03 Thread Igal Sapir
Mark, On Sat, Nov 3, 2018 at 10:37 AM Mark Thomas wrote: > On 03/11/2018 16:54, Igal Sapir wrote: > > On Sat, Nov 3, 2018 at 9:28 AM Mark Thomas wrote: > >> On 03/11/2018 16:20, Igal Sapir wrote: > >>> On Sat, Nov 3, 2018 at 3:50 AM Mark Thomas wrote: > >

Re: [VOTE] Release Apache Tomcat 8.5.35

2018-11-03 Thread Igal Sapir
On Sat, Nov 3, 2018 at 10:55 AM Mark Thomas wrote: > The proposed Apache Tomcat 8.5.35 release is now available for voting. > > The major changes compared to the 8.5.34 release are: > > - support for TLSv1.3 when used with a JRE or OpenSSl version that > supports it > > - multiple improvements

Re: buildbot failure in on tomcat-trunk

2018-10-24 Thread Igal Sapir
It's the same test case that failed yesterday: [concat] Testsuites with failed tests: [concat] TEST-org.apache.catalina.connector.TestCoyoteOutputStream.NIO2.txt Igal On Tue, Oct 23, 2018 at 10:37 PM wrote: > The Buildbot has detected a new failure on builder tomcat-trunk while >

Re: SSL Unit Tests Failing

2018-10-04 Thread Igal Sapir
On 10/4/2018 2:21 PM, Igal Sapir wrote: On 10/3/2018 2:29 AM, Mark Thomas wrote: On 02/10/18 20:40, Igal Sapir wrote: On 02/10/18 06:58, Igal Sapir wrote: When trying to run the unit test cases with `ant clean test` on the current trunk [1] I am getting two (per connector) failures

Re: SSL Unit Tests Failing

2018-10-04 Thread Igal Sapir
On 10/3/2018 2:29 AM, Mark Thomas wrote: On 02/10/18 20:40, Igal Sapir wrote: On 02/10/18 06:58, Igal Sapir wrote: When trying to run the unit test cases with `ant clean test` on the current trunk [1] I am getting two (per connector) failures

Re: svn commit: r1842657 - in /tomcat/trunk/test/org/apache: catalina/startup/TomcatBaseTest.java catalina/webresources/TestAbstractArchiveResource.java catalina/webresources/TestFileResource.java coy

2018-10-03 Thread Igal Sapir
Chris, Thank you for the feedback: On 10/3/2018 10:01 AM, Christopher Schultz wrote: On 10/2/18 17:39, isa...@apache.org wrote: Author: isapir Date: Tue Oct 2 21:39:57 2018 New Revision: 1842657 URL: http://svn.apache.org/viewvc?rev=1842657=rev Log: Fixed test cases that errored due to path

Re: Refactoring and Cleanup of OS Name property usage

2018-10-03 Thread Igal Sapir
On 10/3/2018 4:41 AM, Mark Thomas wrote: On 03/10/18 00:48, Igal Sapir wrote: Regarding this: On 10/2/2018 3:54 PM, Igal Sapir wrote: Rainer pointed out to me the class JrePlatform [1], which has a helper field called IS_WINDOWS. I think that it would make sense to add a constant field

Re: Refactoring and Cleanup of OS Name property usage

2018-10-03 Thread Igal Sapir
On 10/3/2018 12:05 PM, Mark Thomas wrote: [4] https://github.com/apache/tomcat/blob/trunk/test/org/apache/tomcat/util/net/TesterSupport.java#L196 That one I do think makes sense to pull into JrePlatform. I have moved [4] above in r1842748.  I used the existing convention in the file of

Re: svn commit: r1842849 - in /tomcat/trunk: java/org/apache/tomcat/jni/Library.java test/org/apache/tomcat/util/net/TesterSupport.java test/org/apache/tomcat/util/net/openssl/TestOpenSSLConf.java

2018-10-09 Thread Igal Sapir
Mark, On Mon, Oct 8, 2018 at 2:52 AM Mark Thomas wrote: > On 05/10/18 19:46, Christopher Schultz wrote: > > >>> +1 a lack of { } is too big a possible bug source to ignore. > > > >> I just tried enabling the CheckStyle test for this. There were > >> just under three thousand errors. > > > >>

Re: SVN Workflow and Backporting

2018-10-08 Thread Igal Sapir
On Mon, Oct 8, 2018 at 3:04 AM Mark Thomas wrote: > On 06/10/18 23:08, Igal Sapir wrote: > > I am rather new to SVN, and actually use it mostly via GIT, i.e. `git svn > > rebase` and `git svn dcommit`. > > > > What is the best way to backport specific patches from

Re: SVN Workflow and Backporting

2018-10-09 Thread Igal Sapir
On Tue, Oct 9, 2018 at 2:31 AM Mark Thomas wrote: > On 09/10/18 05:55, Igal Sapir wrote: > > On Mon, Oct 8, 2018 at 3:04 AM Mark Thomas wrote: > > > >> On 06/10/18 23:08, Igal Sapir wrote: > >>> I am rather new to SVN, and actually use it mostly via GIT, i.

Re: SSL Unit Tests Failing

2018-10-02 Thread Igal Sapir
Chris, On 10/2/2018 7:25 AM, Christopher Schultz wrote: On 10/2/18 01:58, Igal Sapir wrote: When trying to run the unit test cases with `ant clean test` on the current trunk [1] I am getting two (per connector) failures: org.apache.tomcat.util.net.openssl.ciphers.TestCipher FAILED [2

Re: SSL Unit Tests Failing

2018-10-02 Thread Igal Sapir
Mark / Chris, On 10/2/2018 6:36 AM, Mark Thomas wrote: On 02/10/18 06:58, Igal Sapir wrote: When trying to run the unit test cases with `ant clean test` on the current trunk [1] I am getting two (per connector) failures: org.apache.tomcat.util.net.openssl.ciphers.TestCipher FAILED [2

Refactoring and Cleanup of OS Name property usage

2018-10-02 Thread Igal Sapir
Rainer pointed out to me the class JrePlatform [1], which has a helper field called IS_WINDOWS. I think that it would make sense to add a constant field OS_NAME, as well as IS_LINUX and IS_MACOS, and use these fields instead of calling System.getProperty("os.name") in multiple places - some

Re: svn commit: r1842657 - in /tomcat/trunk/test/org/apache: catalina/startup/TomcatBaseTest.java catalina/webresources/TestAbstractArchiveResource.java catalina/webresources/TestFileResource.java coy

2018-10-02 Thread Igal Sapir
Rainer, On 10/2/2018 3:03 PM, Igal Sapir wrote: Hi Rainer, On 10/2/2018 2:54 PM, Rainer Jung wrote: Hi Igal, Am 02.10.2018 um 23:39 schrieb isa...@apache.org: Author: isapir Date: Tue Oct  2 21:39:57 2018 New Revision: 1842657 URL: http://svn.apache.org/viewvc?rev=1842657=rev Log: Fixed

Re: svn commit: r1842657 - in /tomcat/trunk/test/org/apache: catalina/startup/TomcatBaseTest.java catalina/webresources/TestAbstractArchiveResource.java catalina/webresources/TestFileResource.java coy

2018-10-02 Thread Igal Sapir
Hi Rainer, On 10/2/2018 2:54 PM, Rainer Jung wrote: Hi Igal, Am 02.10.2018 um 23:39 schrieb isa...@apache.org: Author: isapir Date: Tue Oct  2 21:39:57 2018 New Revision: 1842657 URL: http://svn.apache.org/viewvc?rev=1842657=rev Log: Fixed test cases that errored due to path case

Re: Refactoring and Cleanup of OS Name property usage

2018-10-02 Thread Igal Sapir
Regarding this: On 10/2/2018 3:54 PM, Igal Sapir wrote: Rainer pointed out to me the class JrePlatform [1], which has a helper field called IS_WINDOWS. I think that it would make sense to add a constant field OS_NAME, as well as IS_LINUX and IS_MACOS, and use these fields instead of calling

SSL Unit Tests Failing

2018-10-01 Thread Igal Sapir
When trying to run the unit test cases with `ant clean test` on the current trunk [1] I am getting two (per connector) failures: org.apache.tomcat.util.net.openssl.ciphers.TestCipher FAILED [2] org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfigurationParser FAILED [3]

Re: svn commit: r1842811 - /tomcat/trunk/webapps/docs/changelog.xml

2018-10-04 Thread Igal Sapir
RE r1842809: On Thu, Oct 4, 2018 at 6:41 AM wrote: > Author: isapir > Date: Thu Oct 4 13:41:31 2018 > New Revision: 1842811 > > URL: http://svn.apache.org/viewvc?rev=1842811=rev > Log: > Added changelog entry for r1842809 > > Modified: > tomcat/trunk/webapps/docs/changelog.xml > >

SVN Workflow and Backporting

2018-10-06 Thread Igal Sapir
I am rather new to SVN, and actually use it mostly via GIT, i.e. `git svn rebase` and `git svn dcommit`. What is the best way to backport specific patches from trunk to 8.5, 7.0, etc.? Patch utility? SVN Merge? GIT cherry-pick (though the git mirrors have a separate repos which adds some

Re: Proposed patch for o.a.c.users.MemoryUserDatabase

2018-10-01 Thread Igal Sapir
On 10/1/2018 12:08 PM, Mark Thomas wrote: On 27/09/18 16:57, Christopher Schultz wrote: All, I have a proposed patch to MemoryUserDatabase that changes the behavior when a triggered-reload fails. Recently, markt added code to allow database reloads, but if there is an error reloading the

Download Link on the Tomcat website

2018-08-31 Thread Igal Sapir
Currently links to the Download pages can be either to the whichversion [1] page or the version-specific pages, e.g. "Tomcat 9" [2] etc.  It will be very useful to have a generic download.html that is future-proof.  For example, I am writing a blog post ATM and I want to link to a download

Re: New design for the Tomcat website

2019-01-04 Thread Igal Sapir
On Fri, Jan 4, 2019 at 1:39 AM Rémy Maucherat wrote: > On Fri, Jan 4, 2019 at 10:24 AM Mark Thomas wrote: > > > On 03/01/2019 23:47, Igal Sapir wrote: > > > On 1/3/2019 12:09 PM, Mark Thomas wrote: > > >> On 03/01/2019 17:38, Igal Sapir wrote: > > >>

New design for the Tomcat website

2019-01-02 Thread Igal Sapir
Hi Tomcat team, I am working on a new design for the Tomcat website and wanted some preliminary feedback. You can see the first mockup at http://people.apache.org/~isapir/mockups/tomcat-site-1/ Please let me know your thoughts. Best, Igal

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-21 Thread Igal Sapir
On Mon, Jan 21, 2019 at 6:49 AM Mark Thomas wrote: > Version 1.2.20 includes the following changes compared to 1.2.19: > > - Fixed memory leak associated with the use of OpenSSL BIO (used when > OpenSSL provides the TLS functionality for the NIO and NIO2 > connectors) > > Various other fixes

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-22 Thread Igal Sapir
On Tue, Jan 22, 2019 at 5:19 AM Mark Thomas wrote: > On 22/01/2019 04:13, Igal Sapir wrote: > > On Mon, Jan 21, 2019 at 6:49 AM Mark Thomas wrote: > > > > >> > >> The Apache Tomcat Native 1.2.20 release is > >> [X] Stable, go ahead and release

Re: Links to other websites in the documentation?

2019-01-22 Thread Igal Sapir
Chris, On Tue, Jan 22, 2019 at 7:16 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Igal, > > On 1/22/19 14:31, Igal Sapir wrote: > > On Tue, Jan 22, 2019 at 11:09 AM Mark Thomas > >

Re: [Bug 62912] Tomcat adds a space character in the Content-Type header if this one has a ; character right after

2019-01-23 Thread Igal Sapir
On 1/23/2019 1:56 PM, Mark Thomas wrote: On 23/01/2019 21:48, bugzi...@apache.org wrote: https://bz.apache.org/bugzilla/show_bug.cgi?id=62912 --- Comment #14 from Mark Thomas --- Created attachment 36389 --> https://bz.apache.org/bugzilla/attachment.cgi?id=36389=edit Tomcat 9 patch to

Re: [VOTE] Release Apache Tomcat 8.5.37

2018-12-12 Thread Igal Sapir
On Wed, Dec 12, 2018 at 5:23 AM Mark Thomas wrote: > The proposed Apache Tomcat 8.5.37 release is now available for voting. > > The major changes compared to the 8.5.35 release are: > > - Implement the requirements of section 8.2.2 2.c of the Servlet > specification and prevent a web

Re: [ANN] New committer: Woonsan Ko

2018-12-24 Thread Igal Sapir
W00t w00t!  Congrats Woonsan :) Igal On 12/19/2018 6:05 PM, Woonsan Ko wrote: Thank you very much for the warm welcomes! I have watched many volunteering hearts here, helping each other in this community, for years. This community has been my biggest input source from which I have learned how

Re: [VOTE] Release Apache Tomcat 9.0.14

2018-12-06 Thread Igal Sapir
On 12/6/2018 1:37 PM, Mark Thomas wrote: The proposed Apache Tomcat 9.0.14 release is now available for voting. The major changes compared to the 9.0.13 release are: - Significant expansion of localisation support with the addition of Brazilian Portuguese, Korean and Chinese (simplified) as

Re: New design for the Tomcat website

2019-01-03 Thread Igal Sapir
On 1/3/2019 3:47 PM, Igal Sapir wrote: I added a dropdown to the menu with an icon "A" that opens up a slider that lets you choose a font size (12px, 16, 20). I actually changed it so it's more granular ATM - 12 through 20px with step 1. Opening the Console tab in the browser's

Re: New design for the Tomcat website

2019-01-03 Thread Igal Sapir
On 1/3/2019 4:29 AM, Leon Rosenberg wrote: Hi Igal, looks good! Two small things though: Quick tested the mobile (responsive) version on an iphone, latest safari, the text seems too far on the left side (no margin between screenend and text). Can send you screenshots if required. Also I find

Re: New design for the Tomcat website

2019-01-03 Thread Igal Sapir
On 1/3/2019 5:10 AM, Tim Funk wrote: I noticed that too ... but since the "integrity" attribute is present, it doesn't seem as much a concern. I did notice a few inline "p style="text-align: center;" which seems to be better suited to a class element. But since they seem to be downloads -

Re: New design for the Tomcat website

2019-01-03 Thread Igal Sapir
On 1/3/2019 8:18 AM, Emmanuel Bourg wrote: I miss the left menu, I know it isn't the current trend but it allows quick access to the main resources of the site (and since the last redesign it folds into a hamburger button when there isn't enough space). That's a design decision that we need to

Re: New design for the Tomcat website

2019-01-03 Thread Igal Sapir
On 1/3/2019 8:23 AM, Rémy Maucherat wrote: On Thu, Jan 3, 2019 at 2:59 AM Igal Sapir wrote: I am working on a new design for the Tomcat website and wanted some preliminary feedback. You can see the first mockup at http://people.apache.org/~isapir/mockups/tomcat-site-1/ It's a start

Re: New design for the Tomcat website

2019-01-03 Thread Igal Sapir
Rainer, On Thu, Jan 3, 2019 at 3:13 AM Rainer Jung wrote: > I like the modern design but there are at least 5 objects loaded from 5 > non-apache.org-domains (jquery, cloudflare, bootstrapcdn, googleapis, > gstatic). Personally I would prefer if we wouldn't trigger requests to >

Re: New design for the Tomcat website

2019-01-11 Thread Igal Sapir
On 1/10/2019 7:20 AM, Mark Thomas wrote: On 05/01/2019 01:23, Igal Sapir wrote: I made changes according to your feedback. You can see them at http://people.apache.org/~isapir/mockups/tomcat-site-2/ To make room for the nav items, I moved the logos above the nav bar. That also allowed

Re: System properties: JVM launch versus catalina.properties

2018-12-28 Thread Igal Sapir
Chris, On 12/28/2018 7:07 AM, Christopher Schultz wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, Someone asked this question on SO recently: https://stackoverflow.com/questions/53921375/tomcat-overriding-catalina- properties-from-commandline/53952396#53952396 TLDR: this person

Re: New design for the Tomcat website

2019-01-03 Thread Igal Sapir
On 1/3/2019 12:09 PM, Mark Thomas wrote: On 03/01/2019 17:38, Igal Sapir wrote: Looking at other ASF sites like Kafka, Pulsar, and Spark I don't see the ASF logo at the top - is that really a requirement? Tomcat is popular and its brand is recognizable.  ASF logo and trademark notice

Re: svn commit: r1840784 - in /tomcat/trunk: build.properties.default build.xml

2018-09-13 Thread Igal Sapir
On 9/13/2018 12:54 AM, Konstantin Kolinko wrote: 1. The version of Ant is already available as ${ant.version}. There is no need to call antversion task explicitly to get it. See built-in properties in Ant Manual http://ant.apache.org/manual-1.9.x/properties.html 2. This change can be mentioned

Re: Links to other websites in the documentation?

2019-01-22 Thread Igal Sapir
On Tue, Jan 22, 2019 at 11:09 AM Mark Thomas wrote: > On 22/01/2019 18:13, Christopher Schultz wrote: > > All, > > > > Would it be okay to link to another web site -- specifically, > > Wikipedia -- in the Tomcat documentation? > > > > I'd like to link to the page on "block cipher modes" from the

Re: Tomcat Site Redesign

2019-03-27 Thread Igal Sapir
standable. > > сб, 9 мар. 2019 г. в 00:15, Igal @ Lucee.org : > > > > All, > > > > On 3/7/2019 3:22 AM, Konstantin Kolinko wrote: > > > > > пн, 4 мар. 2019 г. в 09:02, Igal Sapir : > > >> I have uploaded the Tomcat site redesign to a temporary loca

Re: Tomcat Site Redesign

2019-03-27 Thread Igal Sapir
On Tue, Mar 26, 2019 at 6:12 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Konstantin, > > On 3/25/19 17:41, Konstantin Kolinko wrote: > > My main concern is that the documentation is printable and is easy > > to use as a

Re: Test Case Ciphers (was: Release Apache Tomcat 8.5.38)

2019-03-23 Thread Igal Sapir
Emmanuel, On Tue, Feb 5, 2019 at 11:45 AM Igal Sapir wrote: > On Tue, Feb 5, 2019 at 11:12 AM Emmanuel Bourg wrote: > >> Le 05/02/2019 à 19:02, Igal Sapir a écrit : >> >> > Do you get any "missing ciphers" errors or not even that? I always get >>

Re: Is it possible to modify the commit email template?

2019-03-23 Thread Igal Sapir
ion email. Thanks, Igal [1] https://github.com/apache/infrastructure-puppet/pull/1489/files https://ci.apache.org/builders/infrastructure-puppet-deployment/builds/4228 > > Mark > > > On 22/03/2019 16:40, Igal Sapir wrote: > > Is it possible to add a URL to the commit email tem

Tomcat Site Redesign

2019-03-03 Thread Igal Sapir
I have uploaded the Tomcat site redesign to a temporary location for review: http://people.apache.org/~isapir/mockups/tomcat-site/ The source can be seen at https://github.com/isapir/tomcat-website This includes all of the pages for the website, but not the documentation for the different

Re: Building and Testing Tomcat 7

2019-03-02 Thread Igal Sapir
Fix typo: On Sat, Mar 2, 2019 at 2:08 PM Igal Sapir wrote: > > > To use the new update, you can now download all of the dependencies using > the new "download-deps" target using Java 8+: > > $ export JAVA_HOME=/path-to-jdk8 > $ ant download-deps > > T

Re: Git migration read for testing

2019-03-02 Thread Igal Sapir
On Wed, Feb 27, 2019 at 2:09 AM Mark Thomas wrote: > On 27/02/2019 09:44, Rémy Maucherat wrote: > > On Tue, Feb 26, 2019 at 1:33 PM Mark Thomas wrote: > > > >> All, > >> > >> https://github.com/apache/tomcat > > > > Trying my test commit, I can't push to the github repo. I probably missed > >

Re: Git migration read for testing

2019-03-02 Thread Igal Sapir
Using an SSH remote URL has resolved the issue for me. Thank you. On Sat, Mar 2, 2019 at 1:35 PM Igal Sapir wrote: > On Wed, Feb 27, 2019 at 2:09 AM Mark Thomas wrote: > >> On 27/02/2019 09:44, Rémy Maucherat wrote: >> > On Tue, Feb 26, 2019 at 1:33 PM Mark Thomas

Building and Testing Tomcat 7

2019-03-02 Thread Igal Sapir
Rainer, On Sat, Feb 16, 2019 at 2:42 PM Rainer Jung wrote: > Hi Igal, > > Am 16.02.2019 um 22:10 schrieb Igal Sapir: > > Violeta, > > > > On Sat, Feb 16, 2019 at 9:41 AM Violeta Georgieva > > wrote: > > > >> The proposed Apache Tomcat 7.0.93 rele

Re: [VOTE] Migrate to git

2019-02-21 Thread Igal Sapir
On 2/21/2019 8:13 AM, Mark Thomas wrote: This is a VOTE to migrate the primary source code repository for Apache Tomcat 9.0.x, 8.5.x and 7.0.x from svn to git. The migration will be performed as per: https://cwiki.apache.org/confluence/display/TOMCAT/Git+migration with the following changes: -

Re: Git migration: new branch/tag naming scheme

2019-02-20 Thread Igal Sapir
Michael, On Mon, Feb 18, 2019 at 11:53 AM Michael Osipov wrote: > Am 2019-02-18 um 15:19 schrieb Igal Sapir: > > > > > > I actually prefer "tc8.5" and "tc7.0" for the branches (over "8.5.x" and > > "7.0.x"). If tags

Re: Git migration: new branch/tag naming scheme

2019-02-20 Thread Igal Sapir
Mark, On 2/20/2019 8:44 AM, Mark Thomas wrote: On 20/02/2019 16:14, Igal Sapir wrote: Michael, On Mon, Feb 18, 2019 at 11:53 AM Michael Osipov wrote: Am 2019-02-18 um 15:19 schrieb Igal Sapir: I actually prefer "tc8.5" and "tc7.0" for the branches (over "8.5.

Re: Git migration read for testing

2019-02-26 Thread Igal Sapir
Konstantin, On Tue, Feb 26, 2019 at 4:23 PM Konstantin Kolinko wrote: > вт, 26 февр. 2019 г. в 21:24, Igal Sapir : > > > > Mark, > > > > On Tue, Feb 26, 2019 at 4:33 AM Mark Thomas wrote: > > > > > > > > branches > > > - master (9

Re: Git Migration: What is the svn:eol-style equilvalent?

2019-03-05 Thread Igal Sapir
Coty, On Tue, Mar 5, 2019 at 6:23 AM Coty Sutherland wrote: > Hi, > > I updated the BUILDING and CONTRIBUTING documents so that GitHub users no > longer see instructions for SVN after our migration, however I had a few > questions. Does anyone know of a git equivalent to svn:eol-style that we >

Re: Tomcat Site Redesign

2019-03-05 Thread Igal Sapir
Chris, Thank you for the feedback: On Tue, Mar 5, 2019 at 11:49 AM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Igal, > > On 3/4/19 01:02, Igal Sapir wrote: > > I have uploaded the Tomcat site re

Re: Git migration read for testing

2019-02-26 Thread Igal Sapir
On Tue, Feb 26, 2019 at 6:45 AM Mark Thomas wrote: > On 26/02/2019 13:54, Rémy Maucherat wrote: > > On Tue, Feb 26, 2019 at 1:33 PM Mark Thomas wrote: > > > >> All, > >> > >> https://github.com/apache/tomcat > >> > >> is now ready for testing. > >> > > > > That looks quite good :) > +1. Looks

  1   2   3   4   >