Re: Plans for 8.0.6
On 12/05/2014 21:00, Rémy Maucherat wrote: 2014-05-12 16:39 GMT+02:00 Mark Thomas ma...@apache.org: I just got to that. I've answered your immediate question but I want to do a little more digging of my own. I'll respond in more detail on that thread. That said, I'm not expecting NIO2 to be declared stable in this release so I don't see this as a release blocker. Ok. I looked at it more, and I think the comment you made is correct: on shutdown it would simply try to read data (but the read for the keepalive is pending, so it gets an exception). So I'm not reverting anything, the code as is won't do anything that would cause real issues even if it's not perfect. The main idea was to avoid ignoring read pending exceptions. I'm running the unit tests now. I want to look at BZ 56516 some more and I don't want to hold up a 8.0.x release any longer. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Plans for 8.0.6
2014-05-13 9:37 GMT+02:00 Mark Thomas ma...@apache.org:
I'm running the unit tests now. I want to look at BZ 56516 some more and
I don't want to hold up a 8.0.x release any longer.
There's nothing to look at IMO, the guy is using scriptlets and expects
things to work with the tag variable. Jasper has no idea to know there's
flow control in his Java code fragments.
Rémy
From his test case (with a message variable info):
%
try {
%
hello:helloWorld id=message/
%
} catch (Exception e) {
//String message = null;
%
hello:helloWorld id=message/
%
}
%
Re: Plans for 8.0.6
On 13/05/2014 11:43, Rémy Maucherat wrote:
2014-05-13 9:37 GMT+02:00 Mark Thomas ma...@apache.org:
I'm running the unit tests now. I want to look at BZ 56516 some more and
I don't want to hold up a 8.0.x release any longer.
There's nothing to look at IMO, the guy is using scriptlets and expects
things to work with the tag variable. Jasper has no idea to know there's
flow control in his Java code fragments.
Rémy
From his test case (with a message variable info):
%
try {
%
hello:helloWorld id=message/
%
} catch (Exception e) {
//String message = null;
%
hello:helloWorld id=message/
%
}
%
Indeed. So do we:
a) do nothing
b) declare variables just after the implicit variables so they are
always in scope
c) add some { } blocks and declare the variable once each time the tag
is used?
I've been looking through the specification but haven't found anything
yet that would suggest a preferred approach. Equally, I haven't found
anything to suggest that a) is valid in this case.
Mark
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Plans for 8.0.6
Over the weekend I ran the unit tests for BIO, NIO and APR on OSX, Win64 and Linux64 and they all passed. My plans for 8.0.6 are therefore: - work through the backlog of messages that built up during the mail server outage; - fix any new issues that might emerge from the backlog - re-run the unit tests - tag 8.0.6 and start the release Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Plans for 8.0.6
2014-05-12 14:33 GMT+02:00 Mark Thomas ma...@apache.org: Over the weekend I ran the unit tests for BIO, NIO and APR on OSX, Win64 and Linux64 and they all passed. My plans for 8.0.6 are therefore: - work through the backlog of messages that built up during the mail server outage; - fix any new issues that might emerge from the backlog - re-run the unit tests - tag 8.0.6 and start the release +1 (the changelog is now significant, but there doesn't seem to be any testsuite regression - I did run it often during the time buildbot was down) In the backlog, I had a question about read pending. Rémy
Re: Plans for 8.0.6
On 12/05/2014 15:01, Rémy Maucherat wrote: 2014-05-12 14:33 GMT+02:00 Mark Thomas ma...@apache.org: Over the weekend I ran the unit tests for BIO, NIO and APR on OSX, Win64 and Linux64 and they all passed. My plans for 8.0.6 are therefore: - work through the backlog of messages that built up during the mail server outage; - fix any new issues that might emerge from the backlog - re-run the unit tests - tag 8.0.6 and start the release +1 (the changelog is now significant, but there doesn't seem to be any testsuite regression - I did run it often during the time buildbot was down) In the backlog, I had a question about read pending. I just got to that. I've answered your immediate question but I want to do a little more digging of my own. I'll respond in more detail on that thread. That said, I'm not expecting NIO2 to be declared stable in this release so I don't see this as a release blocker. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Plans for 8.0.6
2014-05-12 16:39 GMT+02:00 Mark Thomas ma...@apache.org: I just got to that. I've answered your immediate question but I want to do a little more digging of my own. I'll respond in more detail on that thread. That said, I'm not expecting NIO2 to be declared stable in this release so I don't see this as a release blocker. Ok. I looked at it more, and I think the comment you made is correct: on shutdown it would simply try to read data (but the read for the keepalive is pending, so it gets an exception). So I'm not reverting anything, the code as is won't do anything that would cause real issues even if it's not perfect. The main idea was to avoid ignoring read pending exceptions. Rémy
