[Bug 57665] support x-forwarded-host

https://bz.apache.org/bugzilla/show_bug.cgi?id=57665 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 57665] support x-forwarded-host

https://bz.apache.org/bugzilla/show_bug.cgi?id=57665 --- Comment #23 from Alexander Veit --- Same problem here. Our reverse proxy is IIS with ARR (Application Request Routing). In our case we can not send the original Host header via a Host header to the backend (embedded Tomcat). The strange

[Bug 57665] support x-forwarded-host

https://bz.apache.org/bugzilla/show_bug.cgi?id=57665 --- Comment #22 from Michael Osipov --- Here is possible use case: > > maxHttpHeaderSize="24576" redirectPort="8444" maxThreads="250" > /> > > maxHttpHeaderSize="24576" maxThreads="250" >

[Bug 57665] support x-forwarded-host

https://bz.apache.org/bugzilla/show_bug.cgi?id=57665 --- Comment #21 from Michael Osipov --- (In reply to Christopher Schultz from comment #20) > Nobody has merged this patch, yet. I don't see any objections, here. I > didn't do it because I don't have a convenient setup to test it's efficacy.

[Bug 57665] support x-forwarded-host

https://bz.apache.org/bugzilla/show_bug.cgi?id=57665 --- Comment #20 from Christopher Schultz --- Nobody has merged this patch, yet. I don't see any objections, here. I didn't do it because I don't have a convenient setup to test it's efficacy. -- You are receiving this mail because: You are

[Bug 57665] support x-forwarded-host

https://bz.apache.org/bugzilla/show_bug.cgi?id=57665 Michael Osipov changed: What|Removed |Added CC||micha...@apache.org --- Comment #19

[Bug 57665] support x-forwarded-host

https://bz.apache.org/bugzilla/show_bug.cgi?id=57665 frank.michael.busin...@gmail.com changed: What|Removed |Added CC|

[Bug 57665] support x-forwarded-host

https://bz.apache.org/bugzilla/show_bug.cgi?id=57665 --- Comment #18 from Sergey Ponomarev --- Can we set more prio and finally merge the patch? I tried to use this filter as a workaround https://github.com/qaware/x-forwarded-filter which looks quite good and working according to all

[Bug 57665] support x-forwarded-host

https://bz.apache.org/bugzilla/show_bug.cgi?id=57665 --- Comment #17 from Christopher Schultz --- (In reply to Robert from comment #16) > What is the release target for this patch? There is none; it hasn't been merged. -- You are receiving this mail because: You

[Bug 57665] support x-forwarded-host

https://bz.apache.org/bugzilla/show_bug.cgi?id=57665 --- Comment #16 from Robert --- What is the release target for this patch? -- You are receiving this mail because: You are the assignee for the bug.

[Bug 57665] support x-forwarded-host

https://bz.apache.org/bugzilla/show_bug.cgi?id=57665 --- Comment #15 from Stefan Fussenegger --- (In reply to Richard Swart from comment #14) > Note that proxies like Apache with mod_proxy will create a comma separate > list of the X-Forwarded-Host if the incoming request

[Bug 57665] support x-forwarded-host

https://bz.apache.org/bugzilla/show_bug.cgi?id=57665 --- Comment #14 from Richard Swart --- Note that proxies like Apache with mod_proxy will create a comma separate list of the X-Forwarded-Host if the incoming request already contains a X-Forwarded-Host header

[Bug 57665] support x-forwarded-host

https://bz.apache.org/bugzilla/show_bug.cgi?id=57665 Stefan Fussenegger changed: What|Removed |Added Attachment #33985|0 |1 is

[Bug 57665] support x-forwarded-host

https://bz.apache.org/bugzilla/show_bug.cgi?id=57665 --- Comment #12 from Christopher Schultz --- I think there are reasonable use-cases for X-Forwarded-Host. Stefan, if you wouldn't mind augmenting the patch to include similar changes to the Filter and the

[Bug 57665] support x-forwarded-host

https://bz.apache.org/bugzilla/show_bug.cgi?id=57665 --- Comment #11 from Mark Thomas --- The proposed patch adds this to the Valve. The Filter also needs to be updated as does the documentation. Generally, I don't like adding features in Tomcat to work around 3rd party

[Bug 57665] support x-forwarded-host

https://bz.apache.org/bugzilla/show_bug.cgi?id=57665 --- Comment #10 from Christopher Schultz --- Okay. I have no particular objection to this patch.. I just wanted to understand the use-cases a little more. -- You are receiving this mail because: You are the

[Bug 57665] support x-forwarded-host

https://bz.apache.org/bugzilla/show_bug.cgi?id=57665 Christopher Schultz changed: What|Removed |Added Attachment #33985|0 |1

[Bug 57665] support x-forwarded-host

https://bz.apache.org/bugzilla/show_bug.cgi?id=57665 --- Comment #9 from Stefan Fussenegger --- There are other scenarios than "an intervening reverse-proxy". One example would be a CDN that use the Host header of the backend and adds the original value as X-Forwarded-Host.

[Bug 57665] support x-forwarded-host

https://bz.apache.org/bugzilla/show_bug.cgi?id=57665 --- Comment #8 from Mike Youngstrom --- We modify the Host header mostly to work around limitations in application platforms our apps are hosted on. For example, Cloud Foundry only recently added support for path based

[Bug 57665] support x-forwarded-host

https://bz.apache.org/bugzilla/show_bug.cgi?id=57665 --- Comment #7 from Christopher Schultz --- I'm curious why this enhancement has even been requested. My understanding of the HTTP spec is that the "Host" header should not be modified by an intervening

[Bug 57665] support x-forwarded-host

https://bz.apache.org/bugzilla/show_bug.cgi?id=57665 --- Comment #6 from Christopher Schultz --- (In reply to Balasubramanian from comment #5) > In which version of tomcat, this fix is available? I did not see this fix in > tomcat 9 and 8. What led you to believe

[Bug 57665] support x-forwarded-host

https://bz.apache.org/bugzilla/show_bug.cgi?id=57665 Balasubramanian changed: What|Removed |Added CC|

[Bug 57665] support x-forwarded-host

https://bz.apache.org/bugzilla/show_bug.cgi?id=57665 Christopher Schultz changed: What|Removed |Added Keywords|

[Bug 57665] support x-forwarded-host

https://bz.apache.org/bugzilla/show_bug.cgi?id=57665 gonzalad changed: What|Removed |Added CC|

[Bug 57665] support x-forwarded-host

https://bz.apache.org/bugzilla/show_bug.cgi?id=57665 --- Comment #4 from Stefan Fussenegger --- The patch adds support for a hostHeader that works analogue to the existing portHeader. It's disabled by default, keeping backward compatibility. Setting it to a value like

[Bug 57665] support x-forwarded-host

https://bz.apache.org/bugzilla/show_bug.cgi?id=57665 Stefan Fussenegger changed: What|Removed |Added CC||s...@molindo.at

[Bug 57665] support x-forwarded-host

https://bz.apache.org/bugzilla/show_bug.cgi?id=57665 --- Comment #2 from Robert --- The best workaround so far (which is really just a hack) is to extend Http11NioProtocol as shown below: /** * Custom Tomcat Protocol based off of Http11NioProtocol that looks for an

[Bug 57665] support x-forwarded-host

https://bz.apache.org/bugzilla/show_bug.cgi?id=57665 Mark Thomas ma...@apache.org changed: What|Removed |Added CC||slaur...@apache.org ---

[Bug 57665] support x-forwarded-host

https://bz.apache.org/bugzilla/show_bug.cgi?id=57665 Mark Thomas ma...@apache.org changed: What|Removed |Added Severity|normal |enhancement -- You are