Re: svn commit: r1758580 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AprEndpoint.java SocketWrapperBase.java

2016-09-01 Thread Violeta Georgieva
2016-09-01 9:16 GMT+03:00 Rémy Maucherat : > > 2016-08-31 19:55 GMT+02:00 Violeta Georgieva : > > > Do you mean the APR case or also NIO and NIO2? With the new API > > CoyoteOutputStream.write(ByteBuffer) the application layer may provide > > direct ByteBuffers

Re: svn commit: r1758580 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AprEndpoint.java SocketWrapperBase.java

2016-09-01 Thread Rémy Maucherat
2016-08-31 19:55 GMT+02:00 Violeta Georgieva : > Do you mean the APR case or also NIO and NIO2? With the new API > CoyoteOutputStream.write(ByteBuffer) the application layer may provide > direct ByteBuffers so why should we copy them to the socket write buffer > and not use

Re: svn commit: r1758580 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AprEndpoint.java SocketWrapperBase.java

2016-08-31 Thread Violeta Georgieva
2016-08-31 14:03 GMT+03:00 Rémy Maucherat : > > 2016-08-31 12:49 GMT+02:00 : > > > Author: violetagg > > Date: Wed Aug 31 10:49:10 2016 > > New Revision: 1758580 > > > > URL: http://svn.apache.org/viewvc?rev=1758580=rev > > Log: > > When

Re: svn commit: r1758580 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AprEndpoint.java SocketWrapperBase.java

2016-08-31 Thread Violeta Georgieva
2016-08-31 14:08 GMT+03:00 Rémy Maucherat : > > 2016-08-31 12:49 GMT+02:00 : > > > Author: violetagg > > Date: Wed Aug 31 10:49:10 2016 > > New Revision: 1758580 > > > > URL: http://svn.apache.org/viewvc?rev=1758580=rev > > Log: > > When

Re: svn commit: r1758580 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AprEndpoint.java SocketWrapperBase.java

2016-08-31 Thread Rémy Maucherat
2016-08-31 12:49 GMT+02:00 : > Author: violetagg > Date: Wed Aug 31 10:49:10 2016 > New Revision: 1758580 > > URL: http://svn.apache.org/viewvc?rev=1758580=rev > Log: > When AprEndpoint.write(boolean, ByteBuffer) is invoked with a non direct > ByteBuffer then copy that

Re: svn commit: r1758580 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AprEndpoint.java SocketWrapperBase.java

2016-08-31 Thread Rémy Maucherat
2016-08-31 12:49 GMT+02:00 : > Author: violetagg > Date: Wed Aug 31 10:49:10 2016 > New Revision: 1758580 > > URL: http://svn.apache.org/viewvc?rev=1758580=rev > Log: > When AprEndpoint.write(boolean, ByteBuffer) is invoked with a non direct > ByteBuffer then copy that

svn commit: r1758580 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AprEndpoint.java SocketWrapperBase.java

2016-08-31 Thread violetagg
Author: violetagg Date: Wed Aug 31 10:49:10 2016 New Revision: 1758580 URL: http://svn.apache.org/viewvc?rev=1758580=rev Log: When AprEndpoint.write(boolean, ByteBuffer) is invoked with a non direct ByteBuffer then copy that ByteBuffer to the socket write buffer before transferring the data to